[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/uiconfig
cui/uiconfig/ui/hyperlinkdialog.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 85089547c0fa6a8e9f9073f89e1b1abf0f43550f Author: Caolán McNamara AuthorDate: Fri Jun 14 12:52:08 2019 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Fri Jun 14 16:56:27 2019 +0200 Resolves: tdf#125875 allow keyboard traversal into icon control Change-Id: I001a5ec63aa998917f30b47f37e7db995bf55f0f Reviewed-on: https://gerrit.libreoffice.org/74041 Reviewed-by: Adolfo Jayme Barrientos Tested-by: Adolfo Jayme Barrientos diff --git a/cui/uiconfig/ui/hyperlinkdialog.ui b/cui/uiconfig/ui/hyperlinkdialog.ui index edc2dc11682b..dfa0b47d7922 100644 --- a/cui/uiconfig/ui/hyperlinkdialog.ui +++ b/cui/uiconfig/ui/hyperlinkdialog.ui @@ -112,7 +112,7 @@ 110 400 True -False +True True ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/uiconfig
cui/uiconfig/ui/acorreplacepage.ui |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit eaa01effbcf34d2984f1bd1a8002479c717d82a2 Author: Caolán McNamara AuthorDate: Fri May 17 17:14:07 2019 +0100 Commit: Miklos Vajna CommitDate: Tue May 21 11:32:17 2019 +0200 Related: tdf#125241 for gtk use fixed height and width in huge list case Change-Id: I8fd0ebc336c222184485f72eb7c9d97922ab1386 Reviewed-on: https://gerrit.libreoffice.org/72497 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/cui/uiconfig/ui/acorreplacepage.ui b/cui/uiconfig/ui/acorreplacepage.ui index 3d293cc458d1..326152eb2ca8 100644 --- a/cui/uiconfig/ui/acorreplacepage.ui +++ b/cui/uiconfig/ui/acorreplacepage.ui @@ -93,9 +93,10 @@ True True True -False liststore1 +False 0 +True False @@ -104,6 +105,7 @@ True 6 +fixed @@ -116,6 +118,7 @@ True 6 +fixed ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/uiconfig
cui/uiconfig/ui/customizedialog.ui |2 +- cui/uiconfig/ui/menuassignpage.ui |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit f68925bf241092ae6701d72efdb298e5b86701b2 Author: Caolán McNamara AuthorDate: Thu Apr 25 09:04:06 2019 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Sat Apr 27 11:31:32 2019 +0200 Resolves: tdf#124932 fix Shortcut Keys etc tab traversal Change-Id: I9d0204161a0efe91ebcddaf5b2931ab156221b79 Reviewed-on: https://gerrit.libreoffice.org/71308 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/cui/uiconfig/ui/customizedialog.ui b/cui/uiconfig/ui/customizedialog.ui index 30ecea9db44f..e8ba127afd28 100644 --- a/cui/uiconfig/ui/customizedialog.ui +++ b/cui/uiconfig/ui/customizedialog.ui @@ -86,7 +86,7 @@ True -False +True True True True diff --git a/cui/uiconfig/ui/menuassignpage.ui b/cui/uiconfig/ui/menuassignpage.ui index 2ff9c0f465a0..3e831d883e42 100644 --- a/cui/uiconfig/ui/menuassignpage.ui +++ b/cui/uiconfig/ui/menuassignpage.ui @@ -199,7 +199,7 @@ True -True +False 4 True @@ -243,7 +243,7 @@ True -True +False 5 True @@ -280,7 +280,7 @@ True -True +False True ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/uiconfig include/svx svx/source vcl/source
cui/uiconfig/ui/colorpage.ui |1 +
include/svx/hexcolorcontrol.hxx |7 ++-
svx/source/dialog/hexcolorcontrol.cxx | 29 -
vcl/source/control/edit.cxx | 14 --
4 files changed, 47 insertions(+), 4 deletions(-)
New commits:
commit 0198259e4301a45c339fcdda688892e1e6a3ad9f
Author: Caolán McNamara
AuthorDate: Tue Mar 26 15:39:32 2019 +
Commit: Caolán McNamara
CommitDate: Fri Mar 29 22:24:18 2019 +0100
Resolves: tdf#123291 set hex input to overwrite by default
and ensure the modify arrives after the input text has been
filtered
Change-Id: I16c0bd095700e7d9858e3e74884b5a1ad3eb7e4c
Reviewed-on: https://gerrit.libreoffice.org/69764
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
(cherry picked from commit f1e52cbdd4a9753a9b9d562ef280a00e52db1dae)
support overwrite-mode
Change-Id: I6133aedbebd3ca358e2b916469873c38fc7453cb
Reviewed-on: https://gerrit.libreoffice.org/69761
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
(cherry picked from commit 2f70e6111b61d52bbdfa753257370cb82bfd30eb)
Related: tdf#123291 treat overwrite like a selection of 1
for input into ImplTruncateToMaxLen like we do for the
following erase
Change-Id: I8cd02ff1ba76f61ddc614922068cbe2bc9bc4cb8
Reviewed-on: https://gerrit.libreoffice.org/69763
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
(cherry picked from commit 8622dc09954a1a26661e3524c99e7ed0f456cf6e)
Reviewed-on: https://gerrit.libreoffice.org/69800
Tested-by: Xisco Faulí
diff --git a/cui/uiconfig/ui/colorpage.ui b/cui/uiconfig/ui/colorpage.ui
index b801bc787b66..c35cfd4babef 100644
--- a/cui/uiconfig/ui/colorpage.ui
+++ b/cui/uiconfig/ui/colorpage.ui
@@ -788,6 +788,7 @@
True
True
True
+True
1
diff --git a/include/svx/hexcolorcontrol.hxx b/include/svx/hexcolorcontrol.hxx
index 91960d9f7f9b..f47f50fb1e82 100644
--- a/include/svx/hexcolorcontrol.hxx
+++ b/include/svx/hexcolorcontrol.hxx
@@ -34,12 +34,17 @@ class SVX_DLLPUBLIC HexColorControl
{
private:
std::unique_ptr m_xEntry;
+Link m_aModifyHdl;
+ImplSVEvent* m_nAsyncModifyEvent;
DECL_STATIC_LINK(HexColorControl, ImplProcessInputHdl, OUString&, bool);
+DECL_LINK(ImplProcessModifyHdl, weld::Entry&, void);
+DECL_LINK(OnAsyncModifyHdl, void*, void);
public:
HexColorControl(std::unique_ptr pEdit);
+~HexColorControl();
-void connect_changed(const Link& rLink) {
m_xEntry->connect_changed(rLink); }
+void connect_changed(const Link& rLink) { m_aModifyHdl
= rLink; }
void SetColor( ::Color nColor );
::Color GetColor();
diff --git a/svx/source/dialog/hexcolorcontrol.cxx
b/svx/source/dialog/hexcolorcontrol.cxx
index e9ddfb553a43..70e32e540827 100644
--- a/svx/source/dialog/hexcolorcontrol.cxx
+++ b/svx/source/dialog/hexcolorcontrol.cxx
@@ -19,22 +19,49 @@
#include
#include
+#include
namespace weld {
HexColorControl::HexColorControl(std::unique_ptr pEntry)
: m_xEntry(std::move(pEntry))
+, m_nAsyncModifyEvent(nullptr)
{
m_xEntry->set_max_length(6);
m_xEntry->set_width_chars(6);
m_xEntry->connect_insert_text(LINK(this, HexColorControl,
ImplProcessInputHdl));
+m_xEntry->connect_changed(LINK(this, HexColorControl,
ImplProcessModifyHdl));
+}
+
+HexColorControl::~HexColorControl()
+{
+if (m_nAsyncModifyEvent)
+Application::RemoveUserEvent(m_nAsyncModifyEvent);
+}
+
+IMPL_LINK_NOARG(HexColorControl, OnAsyncModifyHdl, void*, void)
+{
+m_nAsyncModifyEvent = nullptr;
+m_aModifyHdl.Call(*m_xEntry);
+}
+
+// tdf#123291 resend it async so it arrives after ImplProcessInputHdl has been
+// processed
+IMPL_LINK_NOARG(HexColorControl, ImplProcessModifyHdl, weld::Entry&, void)
+{
+if (m_nAsyncModifyEvent)
+Application::RemoveUserEvent(m_nAsyncModifyEvent);
+m_nAsyncModifyEvent = Application::PostUserEvent(LINK(this,
HexColorControl, OnAsyncModifyHdl));
}
void HexColorControl::SetColor(Color nColor)
{
OUStringBuffer aBuffer;
sax::Converter::convertColor(aBuffer, nColor);
-m_xEntry->set_text(aBuffer.makeStringAndClear().copy(1));
+OUString sColor = aBuffer.makeStringAndClear().copy(1);
+if (sColor == m_xEntry->get_text())
+return;
+m_xEntry->set_text(sColor);
}
Color HexColorControl::GetColor()
diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index 00e44a98e39c..547f9464186d 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -194,6 +194,10 @@ bool Edit::set_property(const OString , const
OUString )
{
SetReadOnly(!toBool(rValue));
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/uiconfig
cui/uiconfig/ui/newlibdialog.ui | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) New commits: commit 0b7f9a512b36bc409f8e1f66b07afb74b42f0561 Author: Caolán McNamara AuthorDate: Thu Feb 21 17:26:48 2019 + Commit: Eike Rathke CommitDate: Tue Feb 26 17:18:57 2019 +0100 these are dialog titles, so no use_underline for mnemonics wanted Change-Id: I88c684c88df391beb62415240580064e97fe87f0 Reviewed-on: https://gerrit.libreoffice.org/68174 Tested-by: Jenkins Reviewed-by: Eike Rathke diff --git a/cui/uiconfig/ui/newlibdialog.ui b/cui/uiconfig/ui/newlibdialog.ui index 6e61593a3a0d..c4d6fc2e7f14 100644 --- a/cui/uiconfig/ui/newlibdialog.ui +++ b/cui/uiconfig/ui/newlibdialog.ui @@ -1,5 +1,5 @@ - + @@ -10,6 +10,9 @@ 0 0 dialog + + + False @@ -123,7 +126,6 @@ False True Create Macro -True 0 @@ -135,7 +137,6 @@ False True Rename -True 0 @@ -155,8 +156,5 @@ ok cancel - - - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/uiconfig
cui/uiconfig/ui/formatcellsdialog.ui |1 - 1 file changed, 1 deletion(-) New commits: commit 3b2e876f52ab3ae4ec778d2d5dc3adee0b75aca0 Author: Caolán McNamara AuthorDate: Sat Feb 2 17:06:56 2019 + Commit: Adolfo Jayme Barrientos CommitDate: Sat Feb 2 21:16:08 2019 +0100 Resolves: tdf#123128 impress format->table dialog too tall it needs to be resizable if it has the modifiable western vs ctl+cjk font page Change-Id: I0498baaf566328549a365e57ac440161b7199ad9 Reviewed-on: https://gerrit.libreoffice.org/67293 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/cui/uiconfig/ui/formatcellsdialog.ui b/cui/uiconfig/ui/formatcellsdialog.ui index a7f3488e3fcf..dde69f6862ba 100644 --- a/cui/uiconfig/ui/formatcellsdialog.ui +++ b/cui/uiconfig/ui/formatcellsdialog.ui @@ -6,7 +6,6 @@ False 6 Table Properties -False True 0 0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/uiconfig
cui/uiconfig/ui/movemenu.ui |1 + 1 file changed, 1 insertion(+) New commits: commit 6cb50965f80fc36388e8dc5dfbc1e6205f69cb92 Author: Xisco Fauli AuthorDate: Thu Jan 31 16:10:23 2019 +0100 Commit: Xisco Faulí CommitDate: Fri Feb 1 07:18:25 2019 +0100 tdf#123089: expand menulist horizontally Change-Id: I578883c9eaf02b919fe2a7128d4255ab2a1cd2b8 Reviewed-on: https://gerrit.libreoffice.org/67225 Tested-by: Jenkins Reviewed-by: Xisco Faulí diff --git a/cui/uiconfig/ui/movemenu.ui b/cui/uiconfig/ui/movemenu.ui index 0dc7c58f6ac6..7bb5be63309c 100644 --- a/cui/uiconfig/ui/movemenu.ui +++ b/cui/uiconfig/ui/movemenu.ui @@ -181,6 +181,7 @@ True True True +True liststore1 False False ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/uiconfig
cui/uiconfig/ui/numberingformatpage.ui |1 + 1 file changed, 1 insertion(+) New commits: commit e89129196e71366ec7fee1b6200599475f62783c Author: Caolán McNamara AuthorDate: Tue Jan 22 11:30:35 2019 + Commit: Eike Rathke CommitDate: Tue Jan 22 19:50:50 2019 +0100 let return in format->cells: format-code entry widget activate ok Change-Id: Ibeb51624a12a62d9f93d1b1f712cbdde83cce2c7 Reviewed-on: https://gerrit.libreoffice.org/66734 Tested-by: Jenkins Reviewed-by: Eike Rathke diff --git a/cui/uiconfig/ui/numberingformatpage.ui b/cui/uiconfig/ui/numberingformatpage.ui index def161ea9b31..2238af9ae0cc 100644 --- a/cui/uiconfig/ui/numberingformatpage.ui +++ b/cui/uiconfig/ui/numberingformatpage.ui @@ -82,6 +82,7 @@ True center True +True 0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/uiconfig
cui/uiconfig/ui/searchformatdialog.ui |1 + 1 file changed, 1 insertion(+) New commits: commit 706fc56e0cdfbdcca6374ead83685577afd276ff Author: Caolán McNamara AuthorDate: Mon Jan 21 11:33:02 2019 + Commit: Adolfo Jayme Barrientos CommitDate: Mon Jan 21 14:09:48 2019 +0100 tdf#122808 search formatting dialog should be modal Change-Id: I8b33fcbbf538660703f6cdb9818e8fae2c623be9 Reviewed-on: https://gerrit.libreoffice.org/66675 Reviewed-by: Adolfo Jayme Barrientos Tested-by: Adolfo Jayme Barrientos diff --git a/cui/uiconfig/ui/searchformatdialog.ui b/cui/uiconfig/ui/searchformatdialog.ui index 42a437a32661..a2e586d799e2 100644 --- a/cui/uiconfig/ui/searchformatdialog.ui +++ b/cui/uiconfig/ui/searchformatdialog.ui @@ -6,6 +6,7 @@ False 6 Text Format +True dialog ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/uiconfig
cui/uiconfig/ui/select_persona_dialog.ui | 201 ++- 1 file changed, 67 insertions(+), 134 deletions(-) New commits: commit c13f4d0a2ff503cdebbc789e1711f90e7b5fe379 Author: Adolfo Jayme Barrientos AuthorDate: Tue Oct 23 09:58:18 2018 -0500 Commit: Adolfo Jayme Barrientos CommitDate: Tue Nov 20 03:37:13 2018 +0100 Make Persona selection dialog look less busy • No need for a horizontal line to be randomly there. • Get rid of GtkFrames that enclose only one element. Seriously, they are cancer. Use them properly! • … and while I’m here, use a stock label for the Search button. I noticed the associated help page not using the “Go” name. Change-Id: Id196d8d970a219285c5cc606ab9b4327cdce2e91 Reviewed-on: https://gerrit.libreoffice.org/62238 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos (cherry picked from commit 8b011be70b92552932e5d74d862008ab06a064fc) Reviewed-on: https://gerrit.libreoffice.org/63618 diff --git a/cui/uiconfig/ui/select_persona_dialog.ui b/cui/uiconfig/ui/select_persona_dialog.ui index ca746046f3df..36d80658a5d2 100644 --- a/cui/uiconfig/ui/select_persona_dialog.ui +++ b/cui/uiconfig/ui/select_persona_dialog.ui @@ -85,83 +85,46 @@ False True end -4 +0 - + True False -0 -none +6 - + True -False -6 -12 - - -True -False -vertical -6 - - -True -False -6 - - -True -True -True -False -False - - -False -True -0 - - - - -_Go -85 -True -True -True -True -True -True - - -False -True -1 - - - - -False -True -1 - - - - +True +True +False +False +Search term or address + +False +True +0 + - - + + +gtk-find +85 True -False -Search Term or Firefox Theme URL - - - +True +True +True +True +True +True + +False +True +1 + @@ -171,71 +134,52 @@ - + True False -0 -none +6 - + True False -6 -12 - - -True -False -vertical -6 - - -True -False - - Abstract - Causes - Fashion - Film and TV - Firefox - https://addons.mozilla.org/en-US/firefox/themes/; context="select_persona_dialog|categoriesCB">Foxkeh - Holiday - Music - Nature - Other - Scenery - Seasonal -
