[Libreoffice-commits] core.git: bin/gla11y solenv/sanitizers

[Samuel Thibault (via logerrit)]

 bin/gla11y   |4 ++--
 solenv/sanitizers/ui/modules/scalc.suppr |8 
 2 files changed, 2 insertions(+), 10 deletions(-)

New commits:
commit 4c483204edc5ab5da4b40eb92fd69c6d87d11505
Author: Samuel Thibault 
AuthorDate: Sat Feb 29 23:07:11 2020 +0100
Commit: Caolán McNamara 
CommitDate: Sun Mar 1 16:42:14 2020 +0100

gla11y: Fix checking orphan labels

Change-Id: Icd43014f40a655b512b6328f4800906325d9b164
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89767
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/bin/gla11y b/bin/gla11y
index aff0a13172c6..1ae67b173959 100755
--- a/bin/gla11y
+++ b/bin/gla11y
@@ -10,7 +10,7 @@
 # This file incorporates work covered by the following license notice:
 #
 #   Copyright (c) 2018 Martin Pieuchot
-#   Copyright (c) 2018-2019 Samuel Thibault 
+#   Copyright (c) 2018-2020 Samuel Thibault 
 #
 #   Permission to use, copy, modify, and distribute this software for any
 #   purpose with or without fee is hereby granted, provided that the above
@@ -677,7 +677,7 @@ def is_orphan_label(filename, tree, root, obj, orphan_root, 
doprint = False):
 # This label is part of a button
 return False
 
-oid = obj.attrib.get('oid')
+oid = obj.attrib.get('id')
 if oid is not None:
 if oid in labelled_by_elm:
 # Some widget is labelled by us, we are not orphan.
diff --git a/solenv/sanitizers/ui/modules/scalc.suppr 
b/solenv/sanitizers/ui/modules/scalc.suppr
index ebb2152b0ec2..8de4823a7f67 100644
--- a/solenv/sanitizers/ui/modules/scalc.suppr
+++ b/solenv/sanitizers/ui/modules/scalc.suppr
@@ -117,10 +117,6 @@ 
sc/uiconfig/scalc/ui/pivotfielddialog.ui://GtkLabel[@id='label2'] orphan-label
 sc/uiconfig/scalc/ui/pivotfielddialog.ui://GtkLabel[@id='name'] orphan-label
 sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='connect1'] 
missing-label-for
 sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='connect2'] 
no-labelled-by
-sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkLabel[@id='label2'] orphan-label
-sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkLabel[@id='label3'] orphan-label
-sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkLabel[@id='label4'] orphan-label
-sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkLabel[@id='label5'] orphan-label
 sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field1'] 
missing-label-for
 sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field2'] 
missing-label-for
 sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field3'] 
missing-label-for
@@ -150,10 +146,6 @@ 
sc/uiconfig/scalc/ui/retypepassdialog.ui://GtkLabel[@id='docStatusLabel'] orphan
 
sc/uiconfig/scalc/ui/sorttransformationentry.ui:GtkGrid[@id='grid']/GtkBox/GtkLabel
 orphan-label
 sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='connect1'] 
missing-label-for
 sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='connect2'] 
missing-label-for
-sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkLabel[@id='label2'] 
orphan-label
-sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkLabel[@id='label3'] 
orphan-label
-sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkLabel[@id='label4'] 
orphan-label
-sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkLabel[@id='label5'] 
orphan-label
 sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='field1'] 
missing-label-for
 sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='field2'] 
missing-label-for
 sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='field3'] 
missing-label-for
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: bin/gla11y solenv/sanitizers

[Samuel Thibault (via logerrit)]

 bin/gla11y   |4 ++--
 solenv/sanitizers/ui/cui.suppr   |5 -
 solenv/sanitizers/ui/filter.suppr|2 --
 solenv/sanitizers/ui/modules/scalc.suppr |2 --
 solenv/sanitizers/ui/sfx.suppr   |2 --
 solenv/sanitizers/ui/svx.false   |4 
 solenv/sanitizers/ui/uui.suppr   |1 -
 solenv/sanitizers/ui/xmlsec.suppr|1 -
 8 files changed, 2 insertions(+), 19 deletions(-)

New commits:
commit 7073d17fe5565589bdd3e6438cfa8b4d932acf8b
Author: Samuel Thibault 
AuthorDate: Fri May 10 23:19:08 2019 +0200
Commit: Katarina Behrens 
CommitDate: Mon May 13 16:06:50 2019 +0200

gla11y: whitelist GtkTreeViewColumn as not needing labelling

and remove corresponding suppressions.

Change-Id: I0dd88082ee0af4c5ee82590e894305fa53574c6b
Reviewed-on: https://gerrit.libreoffice.org/72133
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 

diff --git a/bin/gla11y b/bin/gla11y
index 3fed400de699..f93121484648 100755
--- a/bin/gla11y
+++ b/bin/gla11y
@@ -10,7 +10,7 @@
 # This file incorporates work covered by the following license notice:
 #
 #   Copyright (c) 2018 Martin Pieuchot
-#   Copyright (c) 2018 Samuel Thibault 
+#   Copyright (c) 2018-2019 Samuel Thibault 
 #
 #   Permission to use, copy, modify, and distribute this software for any
 #   purpose with or without fee is hereby granted, provided that the above
@@ -145,6 +145,7 @@ widgets_ignored = widgets_toplevel + [
 'GtkTreeSelection',
 
 'GtkListBoxRow',
+'GtkTreeViewColumn',
 
 # Useless to label
 'GtkScrollbar',
@@ -216,7 +217,6 @@ widgets_labels = [
 
 # GtkCellView
 # GtkTreeView
-# GtkTreeViewColumn
 # GtkTextView
 # GtkIconView
 
diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr
index 1fce68321a1c..4279ed553003 100644
--- a/solenv/sanitizers/ui/cui.suppr
+++ b/solenv/sanitizers/ui/cui.suppr
@@ -256,7 +256,6 @@ 
cui/uiconfig/ui/insertfloatingframe.ui://GtkLabel[@id='heightlabel'] orphan-labe
 cui/uiconfig/ui/insertfloatingframe.ui://GtkSpinButton[@id='width'] 
no-labelled-by
 cui/uiconfig/ui/insertfloatingframe.ui://GtkSpinButton[@id='height'] 
no-labelled-by
 cui/uiconfig/ui/insertoleobject.ui://GtkEntry[@id='urled'] no-labelled-by
-cui/uiconfig/ui/javastartparametersdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn1']
 no-labelled-by
 cui/uiconfig/ui/javastartparametersdialog.ui://GtkLabel[@id='label6'] 
orphan-label
 cui/uiconfig/ui/lineendstabpage.ui://GtkLabel[@id='FT_LINE_END_STYLE'] 
orphan-label
 cui/uiconfig/ui/lineendstabpage.ui://GtkComboBox[@id='LB_LINEENDS'] 
no-labelled-by
@@ -281,7 +280,6 @@ 
cui/uiconfig/ui/menuassignpage.ui://GtkLabel[@id='rightfunctionlabel'] orphan-la
 cui/uiconfig/ui/menuassignpage.ui://GtkLabel[@id='customizelabel'] orphan-label
 cui/uiconfig/ui/movemenu.ui://GtkLabel[@id='label1'] orphan-label
 cui/uiconfig/ui/movemenu.ui://GtkTreeView[@id='menulist'] no-labelled-by
-cui/uiconfig/ui/movemenu.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] 
no-labelled-by
 cui/uiconfig/ui/multipathdialog.ui://svtlo-SvSimpleTableContainer[@id='paths'] 
no-labelled-by
 cui/uiconfig/ui/multipathdialog.ui://GtkLabel[@id='pathlist'] orphan-label
 cui/uiconfig/ui/newlibdialog.ui://GtkEntry[@id='entry'] duplicate-mnemonic
@@ -464,10 +462,7 @@ 
cui/uiconfig/ui/tsaurldialog.ui://GtkLabel[@id='enteraurl'] orphan-label
 cui/uiconfig/ui/twolinespage.ui://GtkLabel[@id='label29'] orphan-label
 cui/uiconfig/ui/twolinespage.ui://GtkLabel[@id='label30'] orphan-label
 cui/uiconfig/ui/twolinespage.ui://GtkTreeView[@id='startbracket'] 
no-labelled-by
-cui/uiconfig/ui/twolinespage.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] 
no-labelled-by
 cui/uiconfig/ui/twolinespage.ui://GtkTreeView[@id='endbracket'] no-labelled-by
-cui/uiconfig/ui/twolinespage.ui://GtkTreeViewColumn[@id='treeviewcolumn2'] 
no-labelled-by
 cui/uiconfig/ui/wordcompletionpage.ui://GtkTreeView[@id='entries'] 
no-labelled-by
 cui/uiconfig/ui/wordcompletionpage.ui://GtkSpinButton[@id='maxentries'] 
duplicate-mnemonic
 cui/uiconfig/ui/wordcompletionpage.ui://GtkSpinButton[@id='minwordlen'] 
no-labelled-by
-cui/uiconfig/ui/wordcompletionpage.ui://GtkTreeViewColumn[@id='treeviewcolumn2']
 no-labelled-by
diff --git a/solenv/sanitizers/ui/filter.suppr 
b/solenv/sanitizers/ui/filter.suppr
index de80972e87e5..c0199933cfb6 100644
--- a/solenv/sanitizers/ui/filter.suppr
+++ b/solenv/sanitizers/ui/filter.suppr
@@ -23,5 +23,3 @@ 
filter/uiconfig/ui/testxmlfilter.ui://GtkLabel[@id='importxslttemplate'] orphan-
 filter/uiconfig/ui/testxmlfilter.ui://GtkLabel[@id='recentfilename'] 
orphan-label
 filter/uiconfig/ui/warnpdfdialog.ui://GtkLabel[@id='message'] orphan-label
 filter/uiconfig/ui/warnpdfdialog.ui://GtkTreeView[@id='errors'] no-labelled-by
-filter/uiconfig/ui/warnpdfdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] 
no-labelled-by
-filter/uiconfig/ui/warnpdfdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn2']