[Libreoffice-commits] core.git: canvas/source chart2/source

2022-10-17 Thread OmkarAcharekar (via logerrit) 
 canvas/source/opengl/ogl_canvastools.cxx |4 ++--
 chart2/source/tools/ThreeDHelper.cxx |5 ++---
 2 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 7b63242ea72885d05faa5f0879395fa93a3446d1
Author: OmkarAcharekar 
AuthorDate: Mon Oct 17 00:27:06 2022 +0530
Commit: Hossein 
CommitDate: Mon Oct 17 22:16:12 2022 +0200

tdf#145538 - Use range based for loops

Change-Id: Ia4f795dc9bb59b6d1ee54daae49ac195bbc92a0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141434
Tested-by: Jenkins
Reviewed-by: Hossein 

diff --git a/canvas/source/opengl/ogl_canvastools.cxx 
b/canvas/source/opengl/ogl_canvastools.cxx
index c5fbe0255760..97e7377c0a60 100644
--- a/canvas/source/opengl/ogl_canvastools.cxx
+++ b/canvas/source/opengl/ogl_canvastools.cxx
@@ -35,9 +35,9 @@ namespace oglcanvas
 const ::basegfx::triangulator::B2DTriangleVector rTriangulatedPolygon(
 ::basegfx::triangulator::triangulate(aPolyPoly));
 
-for( size_t i=0; i > aSeriesList =
 DiagramHelper::getDataSeriesFromDiagram( xDiagram );
-sal_Int32 nSeriesCount = static_cast( aSeriesList.size() );
-for( sal_Int32 nS = 0; nS < nSeriesCount; ++nS )
+for( auto const&  aSeriesListItem : aSeriesList)
 {
-rtl::Reference< DataSeries > xSeries( aSeriesList[nS] );
+rtl::Reference< DataSeries > xSeries( aSeriesListItem );
 
 if( nRoundedEdges>=0 && nRoundedEdges<=100 )
 DataSeriesHelper::setPropertyAlsoToAllAttributedDataPoints( 
xSeries, "PercentDiagonal", aARoundedEdges );

[Libreoffice-commits] core.git: canvas/source chart2/source cppcanvas/source drawinglayer/source editeng/source filter/source include/basegfx include/svx include/tools libreofficekit/source oox/source

2021-11-19 Thread Mike Kaganski (via logerrit) 
 canvas/source/cairo/cairo_canvashelper_text.cxx|2 -
 canvas/source/vcl/canvashelper.cxx |2 -
 canvas/source/vcl/canvashelper_texturefill.cxx |2 -
 canvas/source/vcl/impltools.cxx|2 -
 chart2/source/view/main/ShapeFactory.cxx   |4 +-
 chart2/source/view/main/VTitle.cxx |2 -
 cppcanvas/source/mtfrenderer/implrenderer.cxx  |6 +--
 drawinglayer/source/primitive2d/textlayoutdevice.cxx   |2 -
 drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx |4 +-
 drawinglayer/source/processor2d/vclpixelprocessor2d.cxx|6 +--
 drawinglayer/source/tools/wmfemfhelper.cxx |8 ++--
 editeng/source/editeng/impedit3.cxx|4 +-
 editeng/source/outliner/outliner.cxx   |2 -
 filter/source/msfilter/eschesdo.cxx|   10 ++---
 filter/source/msfilter/msdffimp.cxx|6 +--
 filter/source/msfilter/svdfppt.cxx |3 -
 include/basegfx/numeric/ftools.hxx |   16 ++--
 include/svx/svdtrans.hxx   |   13 ---
 include/tools/degree.hxx   |7 ++-
 libreofficekit/source/gtk/lokdocview.cxx   |4 +-
 oox/source/export/drawingml.cxx|4 +-
 sc/qa/unit/ucalc.cxx   |4 +-
 sc/source/core/data/column2.cxx|4 +-
 sc/source/core/data/table2.cxx |2 -
 sc/source/filter/excel/xichart.cxx |2 -
 sd/source/filter/eppt/epptso.cxx   |   12 +++---
 svx/source/customshapes/EnhancedCustomShape3d.cxx  |2 -
 svx/source/sdr/contact/viewcontactofe3dlathe.cxx   |2 -
 svx/source/sdr/contact/viewcontactofgraphic.cxx|2 -
 svx/source/sdr/contact/viewcontactofsdrcaptionobj.cxx  |2 -
 svx/source/sdr/contact/viewcontactofsdrcircobj.cxx |   10 ++---
 svx/source/sdr/contact/viewcontactofsdrobjcustomshape.cxx  |4 +-
 svx/source/sdr/contact/viewcontactofsdrole2obj.cxx |2 -
 svx/source/sdr/contact/viewcontactofsdrpathobj.cxx |2 -
 svx/source/sdr/contact/viewcontactofsdrrectobj.cxx |2 -
 svx/source/sdr/primitive2d/sdrattributecreator.cxx |6 +--
 svx/source/svdraw/svddrgmt.cxx |8 ++--
 svx/source/svdraw/svdedtv1.cxx |   14 +++
 svx/source/svdraw/svdglev.cxx  |4 +-
 svx/source/svdraw/svdhdl.cxx   |2 -
 svx/source/svdraw/svdoashp.cxx |   22 +--
 svx/source/svdraw/svdobj.cxx   |8 ++--
 svx/source/svdraw/svdocirc.cxx |   14 +++
 svx/source/svdraw/svdomeas.cxx |4 +-
 svx/source/svdraw/svdopath.cxx |   24 ++---
 svx/source/svdraw/svdotext.cxx |6 +--
 svx/source/svdraw/svdotextdecomposition.cxx|2 -
 svx/source/svdraw/svdotextpathdecomposition.cxx|2 -
 svx/source/svdraw/svdpoev.cxx  |4 +-
 svx/source/svdraw/svdtrans.cxx |9 ++--
 svx/source/table/viewcontactoftableobj.cxx |4 +-
 svx/source/unodraw/unoshape.cxx|6 +--
 svx/source/xoutdev/xtabgrdt.cxx|2 -
 svx/source/xoutdev/xtabhtch.cxx|2 -
 sw/source/filter/ww8/docxsdrexport.cxx |   19 --
 tools/source/generic/point.cxx |2 -
 tools/source/generic/poly.cxx  |2 -
 tools/source/generic/poly2.cxx |2 -
 vcl/quartz/ctfonts.cxx |9 +---
 vcl/skia/gdiimpl.cxx   |2 -
 vcl/source/bitmap/bitmappaint.cxx  |4 +-
 vcl/source/gdi/gdimtf.cxx  |2 -
 vcl/source/gdi/gradient.cxx|4 +-
 vcl/source/gdi/pdfwriter_impl.cxx  |2 -
 vcl/source/outdev/hatch.cxx|4 +-
 vcl/source/outdev/textline.cxx |4 +-
 vcl/unx/generic/gdi/cairotextrender.cxx|2 -
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx |2 -
 xmloff/source/text/XMLTextFrameContext.cxx |2 -
 xmloff/source/text/txtparae.cxx|2 -
 70 files changed, 170 insertions(+), 198 deletions(-)

[Libreoffice-commits] core.git: canvas/source chart2/source cppcanvas/source cui/source drawinglayer/source editeng/source filter/source include/tools include/vcl oox/source sc/source sd/source svx/so

2021-01-12 Thread Noel (via logerrit) 
 canvas/source/cairo/cairo_canvashelper_text.cxx |4 -
 canvas/source/directx/dx_textlayout_drawhelper.cxx  |2 
 canvas/source/vcl/canvasbitmaphelper.cxx|2 
 canvas/source/vcl/canvashelper.cxx  |   16 +++---
 canvas/source/vcl/canvashelper.hxx  |2 
 chart2/source/view/main/VDataSeries.cxx |2 
 cppcanvas/source/mtfrenderer/implrenderer.cxx   |8 +--
 cui/source/tabpages/chardlg.cxx |6 +-
 cui/source/tabpages/tpcolor.cxx |   10 +--
 drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |8 +--
 drawinglayer/source/tools/emfphelperdata.cxx|   32 ++--
 drawinglayer/source/tools/emfpimageattributes.cxx   |2 
 editeng/source/accessibility/AccessibleEditableTextPara.cxx |2 
 editeng/source/accessibility/AccessibleImageBullet.cxx  |2 
 editeng/source/items/frmitems.cxx   |   14 ++---
 editeng/source/items/legacyitem.cxx |2 
 editeng/source/items/textitem.cxx   |   16 +++---
 filter/source/svg/svgwriter.cxx |   14 ++---
 include/tools/color.hxx |   18 +++---
 include/vcl/RawBitmap.hxx   |2 
 oox/source/export/drawingml.cxx |2 
 sc/source/filter/excel/xestream.cxx |2 
 sc/source/filter/html/htmlexp.cxx   |2 
 sc/source/ui/view/output.cxx|6 +-
 sd/source/filter/eppt/pptx-stylesheet.cxx   |2 
 sd/source/filter/pdf/sdpdffilter.cxx|4 -
 svx/source/accessibility/AccessibleShape.cxx|4 -
 svx/source/sdr/contact/viewobjectcontactofsdrpage.cxx   |2 
 svx/source/sdr/overlay/overlaypolypolygon.cxx   |4 -
 svx/source/sdr/primitive2d/sdrattributecreator.cxx  |2 
 svx/source/sidebar/nbdtmg.cxx   |2 
 svx/source/svdraw/svdotextdecomposition.cxx |2 
 svx/source/unodraw/unobrushitemhelper.cxx   |   10 +--
 sw/qa/inc/swmodeltestbase.hxx   |2 
 sw/source/core/layout/paintfrm.cxx  |6 +-
 sw/source/core/text/inftxt.cxx  |2 
 sw/source/filter/ww8/docxattributeoutput.cxx|4 -
 sw/source/filter/ww8/docxsdrexport.cxx  |2 
 sw/source/filter/ww8/wrtw8esh.cxx   |2 
 sw/source/filter/ww8/ww8graf.cxx|6 +-
 sw/source/filter/ww8/ww8par6.cxx|2 
 sw/source/filter/xml/xmlimpit.cxx   |4 -
 tools/qa/cppunit/test_color.cxx |2 
 vcl/headless/svpgdi.cxx |2 
 vcl/inc/bitmap/ScanlineTools.hxx|2 
 vcl/inc/qt5/Qt5Tools.hxx|3 -
 vcl/qa/cppunit/BackendTest.cxx  |6 +-
 vcl/qa/cppunit/BitmapScaleTest.cxx  |2 
 vcl/qa/cppunit/BitmapTest.cxx   |2 
 vcl/qa/cppunit/bitmapcolor.cxx  |   32 ++--
 vcl/qa/cppunit/pdfexport/pdfexport.cxx  |2 
 vcl/skia/gdiimpl.cxx|5 -
 vcl/skia/salbmp.cxx |5 -
 vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx   |2 
 vcl/source/bitmap/BitmapDisabledImageFilter.cxx |2 
 vcl/source/bitmap/BitmapEx.cxx  |8 +--
 vcl/source/bitmap/BitmapReadAccess.cxx  |8 +--
 vcl/source/bitmap/BitmapTools.cxx   |2 
 vcl/source/bitmap/BitmapWriteAccess.cxx |4 -
 vcl/source/edit/texteng.cxx |4 -
 vcl/source/edit/textview.cxx|2 
 vcl/source/gdi/FileDefinitionWidgetDraw.cxx |3 -
 vcl/source/gdi/gdimtf.cxx   |4 -
 vcl/source/helper/canvastools.cxx   |9 +--
 vcl/source/outdev/outdevstate.cxx   |2 
 vcl/source/outdev/pixel.cxx |4 -
 vcl/source/window/menubarwindow.cxx |2 
 67 files changed, 176 insertions(+), 181 deletions(-)

New commits:
commit d765ec2295d12ccde1fb25aa92c5d821de748add
Author: Noel 
AuthorDate: Mon Jan 11 08:54:37 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 12 17:38:53 2021 +0100

transparency->alpha in

[Libreoffice-commits] core.git: canvas/source chart2/source

2020-10-01 Thread Noel (via logerrit) 
 canvas/source/vcl/spritehelper.cxx  |2 +-
 chart2/source/controller/dialogs/DataBrowser.cxx|2 +-
 chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx  |4 ++--
 chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx |6 
++
 chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx  |4 ++--
 chart2/source/controller/sidebar/ChartAreaPanel.cxx |3 +--
 chart2/source/view/charttypes/CandleStickChart.cxx  |3 +--
 chart2/source/view/main/ChartView.cxx   |2 +-
 chart2/source/view/main/VDataSeries.cxx |4 ++--
 chart2/source/view/main/VLegend.cxx |2 +-
 10 files changed, 14 insertions(+), 18 deletions(-)

New commits:
commit 18d4e89fdd63479e20d096c3a578153aa4328aee
Author: Noel 
AuthorDate: Thu Oct 1 14:02:05 2020 +0200
Commit: Noel Grandin 
CommitDate: Thu Oct 1 15:00:52 2020 +0200

loplugin:reducevarscope in canvas,chart2

Change-Id: I6c73e609cc8ce0ed9cf0f5a6b68c6e299bf26a44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103761
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/vcl/spritehelper.cxx 
b/canvas/source/vcl/spritehelper.cxx
index e52bb211020c..14be26c2aa6c 100644
--- a/canvas/source/vcl/spritehelper.cxx
+++ b/canvas/source/vcl/spritehelper.cxx
@@ -101,7 +101,6 @@ namespace vclcanvas
 if( !isActive() || ::basegfx::fTools::equalZero( fAlpha ) )
 return;
 
-const Point aEmptyPoint;
 const ::basegfx::B2DVector& rOrigOutputSize( getSizePixel() );
 
 // might get changed below (e.g. adapted for
@@ -128,6 +127,7 @@ namespace vclcanvas
 
 if( bNeedBitmapUpdate )
 {
+const Point aEmptyPoint;
 BitmapEx aBmp( mpBackBuffer->getOutDev().GetBitmapEx( aEmptyPoint,
   aOutputSize ) );
 
diff --git a/chart2/source/controller/dialogs/DataBrowser.cxx 
b/chart2/source/controller/dialogs/DataBrowser.cxx
index 6f7ada12cbec..89036649c500 100644
--- a/chart2/source/controller/dialogs/DataBrowser.cxx
+++ b/chart2/source/controller/dialogs/DataBrowser.cxx
@@ -699,12 +699,12 @@ OUString DataBrowser::GetCellText( long nRow, sal_uInt16 
nColumnId ) const
 if( m_apDataBrowserModel->getCellType( nColIndex ) == 
DataBrowserModel::NUMBER )
 {
 double fData( m_apDataBrowserModel->getCellNumber( nColIndex, nRow 
));
-Color nLabelColor;
 
 if( ! std::isnan( fData ) &&
 m_spNumberFormatterWrapper )
 {
 bool bColorChanged = false;
+Color nLabelColor;
 aResult = m_spNumberFormatterWrapper->getFormattedString(
   GetNumberFormatKey( nColumnId ),
   fData, nLabelColor, bColorChanged );
diff --git a/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx 
b/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx
index 302c56280fa0..9703f9dd398d 100644
--- a/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx
@@ -368,9 +368,9 @@ bool DataPointItemConverter::ApplySpecialItem(
 case SCHATTR_DATADESCR_SEPARATOR:
 {
 OUString aNewValue = static_cast< const SfxStringItem & >( 
rItemSet.Get( nWhichId )).GetValue();
-OUString aOldValue;
 try
 {
+OUString aOldValue;
 GetPropertySet()->getPropertyValue( "LabelSeparator" ) >>= 
aOldValue;
 if( m_bOverwriteLabelsForAttributedDataPointsAlso )
 {
@@ -689,9 +689,9 @@ void DataPointItemConverter::FillSpecialItem(
 
 case SCHATTR_DATADESCR_SEPARATOR:
 {
-OUString aValue;
 try
 {
+OUString aValue;
 GetPropertySet()->getPropertyValue( "LabelSeparator" ) >>= 
aValue;
 rOutItemSet.Put( SfxStringItem( nWhichId, aValue ));
 }
diff --git 
a/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx 
b/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx
index b4c4405ff88b..c0691daf24cf 100644
--- a/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx
@@ -107,11 +107,10 @@ uno::Reference< beans::XPropertySet > 
lcl_getEquationProperties(
 // ensure that a trendline is on
 if( pItemSet )
 {
-SvxChartRegress eRegress = SvxChartRegress::NONE;
 const SfxPoolItem *pPoolItem = nullptr;
 if( pItemSet->GetItemState( SCHATTR_REGRESSION_TYPE, true,  
) == SfxItemState::SET )

[Libreoffice-commits] core.git: canvas/source chart2/source cui/source drawinglayer/source include/vcl sd/source svtools/source svx/source sw/source vcl/backendtest vcl/headless vcl/inc vcl/opengl vcl

2020-09-28 Thread Luboš Luňák (via logerrit) 
 canvas/source/vcl/backbuffer.cxx|4 -
 canvas/source/vcl/bitmapbackbuffer.cxx  |   10 ++--
 canvas/source/vcl/canvashelper.cxx  |   14 ++---
 canvas/source/vcl/impltools.hxx |2 
 canvas/source/vcl/spritecanvashelper.cxx|8 +--
 canvas/source/vcl/spritedevicehelper.cxx|6 +-
 chart2/source/controller/main/ChartWindow.cxx   |2 
 cui/source/dialogs/screenshotannotationdlg.cxx  |2 
 cui/source/tabpages/grfpage.cxx |2 
 drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |   15 ++
 include/vcl/outdev.hxx  |2 
 include/vcl/outdev/ScopedStates.hxx |4 -
 sd/source/ui/slidesorter/view/SlsPageObjectPainter.cxx  |2 
 svtools/source/control/ctrlbox.cxx  |2 
 svtools/source/filter/DocumentToGraphicRenderer.cxx |2 
 svx/source/sdr/overlay/overlaymanager.cxx   |4 -
 sw/source/core/doc/notxtfrm.cxx |4 -
 vcl/backendtest/VisualBackendTest.cxx   |2 
 vcl/backendtest/outputdevice/common.cxx |2 
 vcl/backendtest/outputdevice/line.cxx   |2 
 vcl/backendtest/outputdevice/polygon.cxx|2 
 vcl/backendtest/outputdevice/polyline.cxx   |2 
 vcl/headless/CustomWidgetDraw.cxx   |6 +-
 vcl/headless/svpgdi.cxx |   40 
 vcl/inc/headless/svpgdi.hxx |2 
 vcl/inc/salgdi.hxx  |6 +-
 vcl/opengl/gdiimpl.cxx  |   12 ++--
 vcl/qa/cppunit/BackendTest.cxx  |2 
 vcl/qa/cppunit/gen/gen.cxx  |2 
 vcl/qt5/Qt5Graphics_GDI.cxx |7 +-
 vcl/quartz/salgdicommon.cxx |6 +-
 vcl/skia/gdiimpl.cxx|   16 +++---
 vcl/source/gdi/FileDefinitionWidgetDraw.cxx |6 +-
 vcl/source/gdi/gdimtf.cxx   |4 -
 vcl/source/gdi/impgraph.cxx |2 
 vcl/source/gdi/print.cxx|2 
 vcl/source/gdi/salgdilayout.cxx |2 
 vcl/source/gdi/virdev.cxx   |2 
 vcl/source/outdev/line.cxx  |4 -
 vcl/source/outdev/outdevstate.cxx   |2 
 vcl/source/outdev/polygon.cxx   |6 +-
 vcl/source/outdev/polyline.cxx  |6 +-
 vcl/source/outdev/transparent.cxx   |2 
 vcl/source/window/printdlg.cxx  |2 
 vcl/source/window/splitwin.cxx  |2 
 vcl/source/window/toolbox.cxx   |2 
 vcl/source/window/window.cxx|2 
 vcl/unx/generic/gdi/cairotextrender.cxx |2 
 vcl/unx/generic/gdi/gdiimpl.cxx |2 
 vcl/unx/generic/gdi/salgdi.cxx  |4 -
 vcl/win/gdi/gdiimpl.cxx |4 -
 vcl/workben/vcldemo.cxx |4 -
 52 files changed, 126 insertions(+), 130 deletions(-)

New commits:
commit 76597aa62a09997beb794669008ce880327bda39
Author: Luboš Luňák 
AuthorDate: Fri Sep 25 12:50:46 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Mon Sep 28 13:35:42 2020 +0200

rename for disentangling AA and B2D use in VCL drawing

This renames AntialiasingFlags::EnableB2dDraw to just Enable,
and the AntiAliasB2DDraw names to just AntiAlias. This is
in preparation for a second commit that will actually separate
the AA and B2D functionality of these flags.

Change-Id: I9cc215c5752dfabce41e00e19d9074fc8dc3d4de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103416
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/canvas/source/vcl/backbuffer.cxx b/canvas/source/vcl/backbuffer.cxx
index 427f77f12d53..0ddf0344ea73 100644
--- a/canvas/source/vcl/backbuffer.cxx
+++ b/canvas/source/vcl/backbuffer.cxx
@@ -37,12 +37,12 @@ namespace vclcanvas
 // #i95645#
 #if defined( MACOSX )
 // use AA on VCLCanvas for Mac
-maVDev->SetAntialiasing( AntialiasingFlags::EnableB2dDraw | 
maVDev->GetAntialiasing() );
+maVDev->SetAntialiasing( AntialiasingFlags::Enable | 
maVDev->GetAntialiasing() );
 #else
 // switch off AA for WIN32 and UNIX, the VCLCanvas does not look good 
with it and
 // is not required to do AA. It would need to be adapted to use it 
correctly
 // (especially gradient painting). This will need extra work.
-

[Libreoffice-commits] core.git: canvas/source chart2/source comphelper/source cui/source

2020-05-28 Thread Noel Grandin (via logerrit) 
 canvas/source/tools/verifyinput.cxx|   16 
+-
 chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx   |2 -
 chart2/source/controller/sidebar/ChartElementsPanel.cxx|4 +-
 chart2/source/view/charttypes/Splines.cxx  |4 +-
 comphelper/source/container/IndexedPropertyValuesContainer.cxx |2 -
 cui/source/customize/SvxMenuConfigPage.cxx |6 +--
 cui/source/customize/SvxToolbarConfigPage.cxx  |4 +-
 cui/source/customize/cfg.cxx   |2 -
 cui/source/options/optlingu.cxx|2 -
 cui/source/tabpages/page.cxx   |2 -
 cui/source/tabpages/tpcolor.cxx|2 -
 11 files changed, 23 insertions(+), 23 deletions(-)

New commits:
commit e871c9cb7ce4f3df2ba6780be62ed46b5ee7a410
Author: Noel Grandin 
AuthorDate: Wed May 27 14:50:01 2020 +0200
Commit: Noel Grandin 
CommitDate: Thu May 28 09:04:51 2020 +0200

loplugin:simplifybool in canvas..cui

Change-Id: Ib7c3b381ce4456e3d48538ee6f762ceaf2784fe1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94973
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/tools/verifyinput.cxx 
b/canvas/source/tools/verifyinput.cxx
index de69da5e744a..9d0020c12da9 100644
--- a/canvas/source/tools/verifyinput.cxx
+++ b/canvas/source/tools/verifyinput.cxx
@@ -295,8 +295,8 @@ namespace canvas::tools
 #endif
 }
 
-if( !(renderState.CompositeOperation < 
rendering::CompositeOperation::CLEAR ||
-renderState.CompositeOperation > 
rendering::CompositeOperation::SATURATE) )
+if( renderState.CompositeOperation >= 
rendering::CompositeOperation::CLEAR &&
+renderState.CompositeOperation <= 
rendering::CompositeOperation::SATURATE )
 return;
 
 #if OSL_DEBUG_LEVEL > 0
@@ -361,8 +361,8 @@ namespace canvas::tools
 #endif
 }
 
-if( !(texture.RepeatModeY < rendering::TexturingMode::NONE ||
-texture.RepeatModeY > rendering::TexturingMode::REPEAT) )
+if( texture.RepeatModeY >= rendering::TexturingMode::NONE &&
+texture.RepeatModeY <= rendering::TexturingMode::REPEAT )
 return;
 
 #if OSL_DEBUG_LEVEL > 0
@@ -483,8 +483,8 @@ namespace canvas::tools
 #endif
 }
 
-if( !(strokeAttributes.JoinType < rendering::PathJoinType::NONE ||
-strokeAttributes.JoinType > rendering::PathJoinType::BEVEL) )
+if( strokeAttributes.JoinType >= rendering::PathJoinType::NONE &&
+strokeAttributes.JoinType <= rendering::PathJoinType::BEVEL )
 return;
 
 #if OSL_DEBUG_LEVEL > 0
@@ -552,8 +552,8 @@ namespace canvas::tools
 #endif
 }
 
-if( !(bitmapLayout.ColorSpace->getEndianness() < 
util::Endianness::LITTLE ||
-bitmapLayout.ColorSpace->getEndianness() > 
util::Endianness::BIG) )
+if( bitmapLayout.ColorSpace->getEndianness() >= 
util::Endianness::LITTLE &&
+bitmapLayout.ColorSpace->getEndianness() <= 
util::Endianness::BIG )
 return;
 
 #if OSL_DEBUG_LEVEL > 0
diff --git a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx 
b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
index e656ef206499..27566a2a1251 100644
--- a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
+++ b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
@@ -131,7 +131,7 @@ namespace
 const ::chart::LightSource & rLightSource,
 sal_Int32 nIndex )
 {
-if( !(0 <= nIndex && nIndex < 8) )
+if( 0 > nIndex || nIndex >= 8 )
 return;
 
 OUString aIndex( OUString::number( nIndex + 1 ));
diff --git a/chart2/source/controller/sidebar/ChartElementsPanel.cxx 
b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
index c15572717d50..346672c2bb2a 100644
--- a/chart2/source/controller/sidebar/ChartElementsPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
@@ -203,7 +203,7 @@ bool isAxisVisible(const 
css::uno::Reference& xModel, AxisTy
 else if (eType == AxisType::Z_MAIN)
 nDimensionIndex = 2;
 
-bool bMajor = !(eType == AxisType::X_SECOND || eType == 
AxisType::Y_SECOND);
+bool bMajor = (eType != AxisType::X_SECOND && eType != 
AxisType::Y_SECOND);
 
 bool bHasAxis = AxisHelper::isAxisShown(nDimensionIndex, bMajor, 
xDiagram);
 return bHasAxis;
@@ -223,7 +223,7 @@ void setAxisVisible(const 
css::uno::Reference& xModel, AxisT
 else if (eType == AxisType::Z_MAIN)
 nDimensionIndex = 2;
 
-bool bMajor = !(eType == AxisType::X_SECOND || eType == 
AxisType::Y_SECOND);
+bool bMajor = (eType != AxisType::X_SECOND && eType != AxisType::Y_SECOND);
 
 if

[Libreoffice-commits] core.git: canvas/source chart2/source comphelper/source compilerplugins/clang connectivity/source cppcanvas/source cppuhelper/source cppu/source cui/source

2020-04-14 Thread Noel Grandin (via logerrit) 
 canvas/source/factory/cf_service.cxx   
|   24 
 canvas/source/tools/canvastools.cxx
|5 
 
chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
 |4 
 chart2/source/tools/ObjectIdentifier.cxx   
|3 
 comphelper/source/misc/threadpool.cxx  
|9 
 compilerplugins/clang/buriedassign.cxx 
|  558 --
 compilerplugins/clang/test/buriedassign.cxx
|   43 
 connectivity/source/commontools/FDatabaseMetaDataResultSetMetaData.cxx 
|   26 
 connectivity/source/commontools/dbtools2.cxx   
|7 
 connectivity/source/commontools/parameters.cxx 
|2 
 connectivity/source/drivers/dbase/DIndexIter.cxx   
|   29 
 connectivity/source/drivers/dbase/dindexnode.cxx   
|7 
 connectivity/source/drivers/firebird/Util.cxx  
|   10 
 connectivity/source/drivers/mysql_jdbc/YTable.cxx  
|   14 
 connectivity/source/drivers/odbc/OFunctions.cxx
|3 
 connectivity/source/drivers/odbc/OResultSetMetaData.cxx
|3 
 connectivity/source/drivers/postgresql/pq_tools.cxx
|   14 
 cppcanvas/source/mtfrenderer/implrenderer.cxx  
|6 
 cppu/source/typelib/static_types.cxx   
|9 
 cppu/source/typelib/typelib.cxx
|   59 -
 cppu/source/uno/copy.hxx   
|8 
 cppu/source/uno/lbenv.cxx  
|7 
 cppu/source/uno/sequence.cxx   
|4 
 cppuhelper/source/tdmgr.cxx
|   16 
 cui/source/dialogs/insdlg.cxx  
|6 
 cui/source/tabpages/backgrnd.cxx   
|   15 
 26 files changed, 654 insertions(+), 237 deletions(-)

New commits:
commit 11785217594d863efb518aa8b8f2910cdcb9c59d
Author: Noel Grandin 
AuthorDate: Tue Apr 14 14:55:22 2020 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 14 16:35:38 2020 +0200

loplugin:buriedassign in c*

Change-Id: Id14fed7e5c0f588ad3c927f12251432d12c1a7c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92190
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/factory/cf_service.cxx 
b/canvas/source/factory/cf_service.cxx
index 86dbc2f12aeb..936c99885f20 100644
--- a/canvas/source/factory/cf_service.cxx
+++ b/canvas/source/factory/cf_service.cxx
@@ -321,13 +321,13 @@ Reference CanvasFactory::lookupAndUse(
 
 // try to reuse last working implementation for given service name
 const CacheVector::iterator aEnd(m_aCachedImplementations.end());
-CacheVector::iterator aMatch;
-if( (aMatch=std::find_if(
+auto aMatch = std::find_if(
 m_aCachedImplementations.begin(),
 aEnd,
 [](CachePair const& cp)
 { return serviceName == cp.first; }
-)) != aEnd) {
+);
+if( aMatch != aEnd ) {
 Reference xCanvas( use( aMatch->second, args, xContext ) );
 if(xCanvas.is())
 return xCanvas;
@@ -335,35 +335,35 @@ Reference CanvasFactory::lookupAndUse(
 
 // lookup in available service list
 const AvailVector::const_iterator 
aAvailEnd(m_aAvailableImplementations.end());
-AvailVector::const_iterator aAvailImplsMatch;
-if( (aAvailImplsMatch=std::find_if(
+auto aAvailImplsMatch = std::find_if(
 m_aAvailableImplementations.begin(),
 aAvailEnd,
 [](AvailPair const& ap)
 { return serviceName == ap.first; }
-)) == aAvailEnd ) {
+);
+if( aAvailImplsMatch == aAvailEnd ) {
 return Reference();
 }
 
 const AvailVector::const_iterator aAAEnd(m_aAAImplementations.end());
-AvailVector::const_iterator aAAImplsMatch;
-if( (aAAImplsMatch=std::find_if(
+auto aAAImplsMatch = std::find_if(
 m_aAAImplementations.begin(),
 aAAEnd,
 [](AvailPair const& ap)
 { return serviceName == ap.first; }
-)) == aAAEnd) {
+);
+if( aAAImplsMatch == aAAEnd ) {
 return Reference();
 }

[Libreoffice-commits] core.git: canvas/source chart2/source chart2/workbench codemaker/source

2019-12-18 Thread Noel Grandin (via logerrit) 
 canvas/source/cairo/cairo_services.cxx   |2 -
 canvas/source/directx/dx_canvas.cxx  |2 -
 canvas/source/directx/dx_spritecanvas.cxx|2 -
 canvas/source/opengl/ogl_spritecanvas.cxx|2 -
 canvas/source/simplecanvas/simplecanvasimpl.cxx  |2 -
 canvas/source/vcl/services.cxx   |2 -
 chart2/source/controller/main/ChartDropTargetHelper.cxx  |2 -
 chart2/source/controller/main/FeatureCommandDispatchBase.cxx |2 -
 chart2/source/controller/main/FeatureCommandDispatchBase.hxx |2 -
 chart2/source/inc/CommonFunctors.hxx |4 +-
 chart2/workbench/addin/sampleaddin.cxx   |2 -
 codemaker/source/codemaker/global.cxx|   20 +--
 12 files changed, 22 insertions(+), 22 deletions(-)

New commits:
commit f0106e19303a3806a375833e2100538506ccbc0a
Author: Noel Grandin 
AuthorDate: Wed Dec 18 11:54:43 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 18 14:18:55 2019 +0100

sal_Char->char in canvas..codemaker

Change-Id: Iaf46b42a17bc00da0f86daeafea7b5346c4a6360
Reviewed-on: https://gerrit.libreoffice.org/85372
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/cairo/cairo_services.cxx 
b/canvas/source/cairo/cairo_services.cxx
index d9e2a4318816..c90ed7cfc7df 100644
--- a/canvas/source/cairo/cairo_services.cxx
+++ b/canvas/source/cairo/cairo_services.cxx
@@ -65,7 +65,7 @@ namespace cairocanvas
 
 // The C shared lib entry points
 extern "C"
-SAL_DLLPUBLIC_EXPORT void* cairocanvas_component_getFactory( sal_Char const* 
pImplName,
+SAL_DLLPUBLIC_EXPORT void* cairocanvas_component_getFactory( char const* 
pImplName,
  void*, void* )
 {
 return sdecl::component_getFactoryHelper( pImplName, 
{::cairoCanvasDecl, ::cairoSpriteCanvasDecl} );
diff --git a/canvas/source/directx/dx_canvas.cxx 
b/canvas/source/directx/dx_canvas.cxx
index 39a319f31cff..3aace1190f08 100644
--- a/canvas/source/directx/dx_canvas.cxx
+++ b/canvas/source/directx/dx_canvas.cxx
@@ -246,7 +246,7 @@ namespace dxcanvas
 
 // The C shared lib entry points
 extern "C"
-SAL_DLLPUBLIC_EXPORT void* gdipluscanvas_component_getFactory( sal_Char const* 
pImplName,
+SAL_DLLPUBLIC_EXPORT void* gdipluscanvas_component_getFactory( char const* 
pImplName,
  void*, void* )
 {
 return sdecl::component_getFactoryHelper( pImplName, 
{::dxCanvasDecl, ::dxBitmapCanvasDecl} );
diff --git a/canvas/source/directx/dx_spritecanvas.cxx 
b/canvas/source/directx/dx_spritecanvas.cxx
index 5d8243bc121d..e4ef8a5764d6 100644
--- a/canvas/source/directx/dx_spritecanvas.cxx
+++ b/canvas/source/directx/dx_spritecanvas.cxx
@@ -189,7 +189,7 @@ namespace dxcanvas
 
 // The C shared lib entry points
 extern "C"
-SAL_DLLPUBLIC_EXPORT void* directx9canvas_component_getFactory( sal_Char 
const* pImplName,
+SAL_DLLPUBLIC_EXPORT void* directx9canvas_component_getFactory( char const* 
pImplName,
  void*, void* )
 {
 return sdecl::component_getFactoryHelper( pImplName, 
{::dxSpriteCanvasDecl} );
diff --git a/canvas/source/opengl/ogl_spritecanvas.cxx 
b/canvas/source/opengl/ogl_spritecanvas.cxx
index 954ecf03bcf6..1c48812463f3 100644
--- a/canvas/source/opengl/ogl_spritecanvas.cxx
+++ b/canvas/source/opengl/ogl_spritecanvas.cxx
@@ -170,7 +170,7 @@ namespace oglcanvas
 
 // The C shared lib entry points
 extern "C"
-SAL_DLLPUBLIC_EXPORT void* oglcanvas_component_getFactory( sal_Char const* 
pImplName,
+SAL_DLLPUBLIC_EXPORT void* oglcanvas_component_getFactory( char const* 
pImplName,
  void*, void* )
 {
 return sdecl::component_getFactoryHelper( pImplName, 
{::oglSpriteCanvasDecl} );
diff --git a/canvas/source/simplecanvas/simplecanvasimpl.cxx 
b/canvas/source/simplecanvas/simplecanvasimpl.cxx
index cf5c426812fa..902c2c6a03d2 100644
--- a/canvas/source/simplecanvas/simplecanvasimpl.cxx
+++ b/canvas/source/simplecanvas/simplecanvasimpl.cxx
@@ -373,7 +373,7 @@ namespace
 }
 
 // The C shared lib entry points
-extern "C" SAL_DLLPUBLIC_EXPORT void* simplecanvas_component_getFactory( 
sal_Char const* pImplName,
+extern "C" SAL_DLLPUBLIC_EXPORT void* simplecanvas_component_getFactory( char 
const* pImplName,
  void*, void* )
 {
 return sdecl::component_getFactoryHelper( pImplName, {} );
diff --git a/canvas/source/vcl/services.cxx b/canvas/source/vcl/services.cxx
index e5167fbef49d..7b130c6fda32 100644
--- a/canvas/source/vcl/services.cxx
+++ b/canvas/source/vcl/services.cxx
@@ -60,7 +60,7 @@ namespace vclcanvas
 
 // The C shared lib entry points
 extern "C"
-SAL_DLLPUBLIC_EXPORT void* vclcanvas_component_getFactory( sal_Char const* 
pImplName,
+SAL_DLLPUBLIC_EXPORT void* vclcanvas_component_getFactory( char

[Libreoffice-commits] core.git: canvas/source chart2/source compilerplugins/clang connectivity/source cppuhelper/source cui/source dbaccess/source hwpfilter/source include/canvas include/comphelper in

2019-03-03 Thread Libreoffice Gerrit user 
 canvas/source/opengl/ogl_canvastools.hxx |4 
 canvas/source/tools/surface.hxx  |2 
 chart2/source/tools/InternalData.cxx |4 
 compilerplugins/clang/test/typedefparam.cxx  |   80 --
 compilerplugins/clang/typedefparam.cxx   |  291 
--
 connectivity/source/drivers/mysqlc/mysqlc_connection.hxx |6 
 connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.hxx |3 
 connectivity/source/drivers/mysqlc/mysqlc_resultset.hxx  |3 
 cppuhelper/source/implementationentry.cxx|6 
 cui/source/dialogs/hangulhanjadlg.cxx|2 
 dbaccess/source/filter/hsqldb/hsqlbinarynode.cxx |2 
 dbaccess/source/filter/hsqldb/hsqlimport.cxx |   21 
 dbaccess/source/filter/hsqldb/parseschema.cxx|2 
 dbaccess/source/filter/hsqldb/rowinputbinary.cxx |4 
 dbaccess/source/ui/misc/charsets.cxx |2 
 hwpfilter/source/hcode.cxx   |2 
 include/canvas/spriteredrawmanager.hxx   |9 
 include/comphelper/listenernotification.hxx  |6 
 include/oox/ppt/slidepersist.hxx |2 
 include/sfx2/sfxbasecontroller.hxx   |2 
 include/svtools/brwbox.hxx   |2 
 include/svtools/editbrowsebox.hxx|2 
 include/svtools/table/tablerenderer.hxx  |   13 
 include/svx/charmap.hxx  |2 
 include/svx/galctrl.hxx  |2 
 include/svx/sdrpagewindow.hxx|3 
 include/svx/svdpagv.hxx  |3 
 include/vcl/fontcharmap.hxx  |6 
 oox/source/mathml/import.cxx |2 
 sal/osl/unx/mutex.cxx|8 
 sal/textenc/tencinfo.cxx |8 
 sal/textenc/textcvt.cxx  |4 
 sc/source/core/data/segmenttree.cxx  |2 
 sc/source/filter/excel/xeescher.cxx  |2 
 sc/source/filter/inc/lotrange.hxx|6 
 sc/source/filter/inc/workbookhelper.hxx  |2 
 sc/source/filter/inc/worksheethelper.hxx |2 
 sc/source/filter/inc/xeescher.hxx|7 
 sc/source/ui/inc/AccessibleCsvControl.hxx|5 
 sc/source/ui/inc/colrowba.hxx|2 
 sc/source/ui/inc/dbfunc.hxx  |2 
 sc/source/ui/view/colrowba.cxx   |2 
 scaddins/source/analysis/analysishelper.hxx  |2 
 sd/source/core/sdpage_animations.cxx |2 
 sd/source/ui/sidebar/MasterPagesSelector.hxx |2 
 sfx2/source/dialog/filedlghelper.cxx |2 
 sfx2/source/dialog/filedlgimpl.hxx   |2 
 sfx2/source/dialog/templdlg.cxx  |2 
 sfx2/source/inc/macroloader.hxx  |2 
 sfx2/source/inc/templdgi.hxx |2 
 slideshow/source/engine/transitions/slidechangebase.hxx  |2 
 slideshow/source/inc/hslcoloranimation.hxx   |4 
 slideshow/source/inc/numberanimation.hxx |4 
 solenv/CompilerTest_compilerplugins_clang.mk |1 
 svtools/inc/table/gridtablerenderer.hxx  |   10 
 svtools/source/brwbox/editbrowsebox.cxx  |2 
 svtools/source/table/gridtablerenderer.cxx   |2 
 svtools/source/table/tablecontrol.cxx|2 
 svtools/source/table/tablecontrol_impl.cxx   |2 
 svx/inc/svdibrow.hxx |2 
 svx/source/fmcomp/gridcell.cxx   |6 
 svx/source/form/navigatortree.cxx|2 
 svx/source/svdraw/svdcrtv.cxx|2 
 svx/source/svdraw/svdibrow.cxx   |2 
 svx/source/tbxctrls/tbcontrl.cxx |4 
 sw/inc/crsrsh.hxx|2 
 sw/inc/doc.hxx   |4 
 sw/inc/swatrset.hxx

[Libreoffice-commits] core.git: canvas/source chart2/source compilerplugins/clang connectivity/source cppuhelper/source cui/source dbaccess/source hwpfilter/source include/canvas include/comphelper in

2019-03-03 Thread Libreoffice Gerrit user 
 canvas/source/opengl/ogl_canvastools.hxx |4 
 canvas/source/tools/surface.hxx  |2 
 chart2/source/tools/InternalData.cxx |4 
 compilerplugins/clang/test/typedefparam.cxx  |   80 ++
 compilerplugins/clang/typedefparam.cxx   |  291 
++
 connectivity/source/drivers/mysqlc/mysqlc_connection.hxx |6 
 connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.hxx |3 
 connectivity/source/drivers/mysqlc/mysqlc_resultset.hxx  |3 
 cppuhelper/source/implementationentry.cxx|6 
 cui/source/dialogs/hangulhanjadlg.cxx|2 
 dbaccess/source/filter/hsqldb/hsqlbinarynode.cxx |2 
 dbaccess/source/filter/hsqldb/hsqlimport.cxx |   21 
 dbaccess/source/filter/hsqldb/parseschema.cxx|2 
 dbaccess/source/filter/hsqldb/rowinputbinary.cxx |4 
 dbaccess/source/ui/misc/charsets.cxx |2 
 hwpfilter/source/hcode.cxx   |2 
 include/canvas/spriteredrawmanager.hxx   |9 
 include/comphelper/listenernotification.hxx  |6 
 include/oox/ppt/slidepersist.hxx |2 
 include/sfx2/sfxbasecontroller.hxx   |2 
 include/svtools/brwbox.hxx   |2 
 include/svtools/editbrowsebox.hxx|2 
 include/svtools/table/tablerenderer.hxx  |   13 
 include/svx/charmap.hxx  |2 
 include/svx/galctrl.hxx  |2 
 include/svx/sdrpagewindow.hxx|3 
 include/svx/svdpagv.hxx  |3 
 include/vcl/fontcharmap.hxx  |6 
 oox/source/mathml/import.cxx |2 
 sal/osl/unx/mutex.cxx|8 
 sal/textenc/tencinfo.cxx |8 
 sal/textenc/textcvt.cxx  |4 
 sc/source/core/data/segmenttree.cxx  |2 
 sc/source/filter/excel/xeescher.cxx  |2 
 sc/source/filter/inc/lotrange.hxx|6 
 sc/source/filter/inc/workbookhelper.hxx  |2 
 sc/source/filter/inc/worksheethelper.hxx |2 
 sc/source/filter/inc/xeescher.hxx|7 
 sc/source/ui/inc/AccessibleCsvControl.hxx|5 
 sc/source/ui/inc/colrowba.hxx|2 
 sc/source/ui/inc/dbfunc.hxx  |2 
 sc/source/ui/view/colrowba.cxx   |2 
 scaddins/source/analysis/analysishelper.hxx  |2 
 sd/source/core/sdpage_animations.cxx |2 
 sd/source/ui/sidebar/MasterPagesSelector.hxx |2 
 sfx2/source/dialog/filedlghelper.cxx |2 
 sfx2/source/dialog/filedlgimpl.hxx   |2 
 sfx2/source/dialog/templdlg.cxx  |2 
 sfx2/source/inc/macroloader.hxx  |2 
 sfx2/source/inc/templdgi.hxx |2 
 slideshow/source/engine/transitions/slidechangebase.hxx  |2 
 slideshow/source/inc/hslcoloranimation.hxx   |4 
 slideshow/source/inc/numberanimation.hxx |4 
 solenv/CompilerTest_compilerplugins_clang.mk |1 
 svtools/inc/table/gridtablerenderer.hxx  |   10 
 svtools/source/brwbox/editbrowsebox.cxx  |2 
 svtools/source/table/gridtablerenderer.cxx   |2 
 svtools/source/table/tablecontrol.cxx|2 
 svtools/source/table/tablecontrol_impl.cxx   |2 
 svx/inc/svdibrow.hxx |2 
 svx/source/fmcomp/gridcell.cxx   |6 
 svx/source/form/navigatortree.cxx|2 
 svx/source/svdraw/svdcrtv.cxx|2 
 svx/source/svdraw/svdibrow.cxx   |2 
 svx/source/tbxctrls/tbcontrl.cxx |4 
 sw/inc/crsrsh.hxx|2 
 sw/inc/doc.hxx   |4 
 sw/inc/swatrset.hxx

[Libreoffice-commits] core.git: canvas/source chart2/source compilerplugins/clang framework/inc framework/source include/canvas lotuswordpro/inc lotuswordpro/source sd/source slideshow/source solenv/C

2018-11-13 Thread Libreoffice Gerrit user 
 canvas/source/tools/canvascustomspritehelper.cxx|   18 
 chart2/source/controller/dialogs/dlg_ObjectProperties.cxx   |7 
 chart2/source/controller/inc/dlg_ObjectProperties.hxx   |2 
 compilerplugins/clang/singlevalfields.could-be-bool.results |   42 +
 compilerplugins/clang/singlevalfields.cxx   |  115 ---
 compilerplugins/clang/singlevalfields.results   |  430 ++--
 compilerplugins/clang/test/singlevalfields.cxx  |   26 
 framework/inc/uielement/toolbarsmenucontroller.hxx  |2 
 framework/source/uielement/toolbarsmenucontroller.cxx   |9 
 include/canvas/base/canvascustomspritehelper.hxx|   15 
 lotuswordpro/inc/xfilter/xffontdecl.hxx |3 
 lotuswordpro/source/filter/xfilter/xffontdecl.cxx   |1 
 lotuswordpro/source/filter/xfilter/xfstylemanager.cxx   |5 
 sd/source/ui/inc/Window.hxx |1 
 sd/source/ui/slideshow/slideshowimpl.cxx|5 
 sd/source/ui/slideshow/slideshowimpl.hxx|1 
 sd/source/ui/view/sdwindow.cxx  |   43 -
 slideshow/source/engine/shapes/viewmediashape.cxx   |   13 
 slideshow/source/engine/shapes/viewmediashape.hxx   |1 
 solenv/CompilerTest_compilerplugins_clang.mk|1 
 xmloff/source/draw/animexp.cxx  |9 
 21 files changed, 484 insertions(+), 265 deletions(-)

New commits:
commit e3290499009492e39e5ddd870d314bb5df494199
Author: Noel Grandin 
AuthorDate: Fri Nov 9 07:44:45 2018 +0200
Commit: Noel Grandin 
CommitDate: Tue Nov 13 12:27:08 2018 +0100

loplugin singlevalfields improvement

checking for casting to void* turns out to mask useful stuff, so
remove that and just deal with a few extra false+

Change-Id: Id9700d7ceda90ba8fdb38aa870f13a7ca3acb668
Reviewed-on: https://gerrit.libreoffice.org/63145
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/tools/canvascustomspritehelper.cxx 
b/canvas/source/tools/canvascustomspritehelper.cxx
index 1d39107c9d00..90a9506d0b84 100644
--- a/canvas/source/tools/canvascustomspritehelper.cxx
+++ b/canvas/source/tools/canvascustomspritehelper.cxx
@@ -154,12 +154,7 @@ namespace canvas
 mbActive(false),
 mbIsCurrClipRectangle(true),
 mbIsContentFullyOpaque( false ),
-mbAlphaDirty( true ),
-mbPositionDirty( true ),
-mbTransformDirty( true ),
-mbClipDirty( true ),
-mbPrioDirty( true ),
-mbVisibilityDirty( true )
+mbTransformDirty( true )
 {
 }
 
@@ -238,8 +233,6 @@ namespace canvas
   maPosition,
   getUpdateArea() );
 }
-
-mbAlphaDirty = true;
 }
 }
 
@@ -277,7 +270,6 @@ namespace canvas
 }
 
 maPosition = aPoint;
-mbPositionDirty = true;
 }
 }
 
@@ -330,8 +322,6 @@ namespace canvas
   maPosition,
   getUpdateArea() );
 }
-
-mbClipDirty = true;
 }
 
 void CanvasCustomSpriteHelper::setPriority( const Sprite::Reference&
rSprite,
@@ -350,8 +340,6 @@ namespace canvas
   maPosition,
   getUpdateArea() );
 }
-
-mbPrioDirty = true;
 }
 }
 
@@ -374,8 +362,6 @@ namespace canvas
   maPosition,
   getUpdateArea() );
 }
-
-mbVisibilityDirty = true;
 }
 }
 
@@ -398,8 +384,6 @@ namespace canvas
   maPosition,
   getUpdateArea() );
 }
-
-mbVisibilityDirty = true;
 }
 }
 
diff --git a/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx 
b/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
index 1a074b29f9d4..13f0419a05ca 100644
--- a/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
+++ b/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
@@ -324,7 +324,6 @@ SchAttribTabDlg::SchAttribTabDlg(weld::Window* pParent,
  const ViewElementListProvider* 
pViewElementListProvider,
  const uno::Reference< 
util::XNumberFormatsSupplier >& xNumberFormatsSupplier)
 : SfxTabDialogController(pParent, "modules/schart/ui/attributedialog.ui", 
"AttributeDialog", pAttr)
-, nDlgType(nNoArrowNoShadowDlg)
 , m_pParameter( pDialogParameter )
 , m_pViewElementListProvider( pViewElementListProvider )
 , m_pNumberFormatter(nullptr)
@@ -488,7 +487,7 @@ void

[Libreoffice-commits] core.git: canvas/source chart2/source connectivity/source cui/source

2018-10-23 Thread Libreoffice Gerrit user 
 canvas/source/cairo/cairo_canvashelper.cxx   |4 ++--
 canvas/source/cairo/cairo_textlayout.cxx |2 +-
 chart2/source/controller/main/ChartController_Tools.cxx  |2 +-
 chart2/source/controller/main/ChartController_Window.cxx |2 +-
 chart2/source/controller/main/SelectionHelper.cxx|2 +-
 chart2/source/controller/sidebar/ChartAreaPanel.cxx  |4 ++--
 chart2/source/tools/DiagramHelper.cxx|3 +--
 chart2/source/view/charttypes/VSeriesPlotter.cxx |2 +-
 chart2/source/view/main/ChartView.cxx|2 +-
 connectivity/source/commontools/dbtools.cxx  |2 +-
 connectivity/source/commontools/parameters.cxx   |2 +-
 connectivity/source/drivers/calc/CDatabaseMetaData.cxx   |2 +-
 connectivity/source/drivers/dbase/DColumns.cxx   |2 +-
 connectivity/source/drivers/dbase/DIndexColumns.cxx  |2 +-
 connectivity/source/drivers/file/fcode.cxx   |8 
 connectivity/source/drivers/flat/EColumns.cxx|2 +-
 connectivity/source/drivers/mork/MQueryHelper.cxx|2 +-
 connectivity/source/parse/sqliterator.cxx|3 +--
 connectivity/source/parse/sqlnode.cxx|2 +-
 cui/source/customize/cfg.cxx |2 +-
 cui/source/dialogs/cuicharmap.cxx|2 +-
 cui/source/dialogs/insdlg.cxx|2 +-
 cui/source/dialogs/scriptdlg.cxx |3 +--
 cui/source/options/optaccessibility.cxx  |2 +-
 cui/source/options/optasian.cxx  |2 +-
 cui/source/tabpages/autocdlg.cxx |4 ++--
 cui/source/tabpages/macroass.cxx |2 +-
 cui/source/tabpages/numpages.cxx |2 +-
 28 files changed, 34 insertions(+), 37 deletions(-)

New commits:
commit a8a461b2fba27f1a729e2b9b28426286617892a9
Author: Noel Grandin 
AuthorDate: Tue Oct 23 07:46:34 2018 +0200
Commit: Noel Grandin 
CommitDate: Tue Oct 23 09:44:09 2018 +0200

clang-tidy performance-unnecessary-copy-init in canvas..cui

Change-Id: I08c137d852b5f1f817c171ee4f1cee7971417dc4
Reviewed-on: https://gerrit.libreoffice.org/62214
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/cairo/cairo_canvashelper.cxx 
b/canvas/source/cairo/cairo_canvashelper.cxx
index 8a80912886a5..dcd752cf6a52 100644
--- a/canvas/source/cairo/cairo_canvashelper.cxx
+++ b/canvas/source/cairo/cairo_canvashelper.cxx
@@ -694,7 +694,7 @@ namespace cairocanvas
 
 for( sal_uInt32 nPolygonIndex = 0; nPolygonIndex < 
aPolyPolygon.count(); nPolygonIndex++ )
 {
-::basegfx::B2DPolygon aPolygon( aPolyPolygon.getB2DPolygon( 
nPolygonIndex ) );
+const ::basegfx::B2DPolygon& aPolygon( aPolyPolygon.getB2DPolygon( 
nPolygonIndex ) );
 const sal_uInt32 nPointCount( aPolygon.count() );
 // to correctly render closed curves, need to output first
 // point twice (so output one additional point)
@@ -831,7 +831,7 @@ namespace cairocanvas
 // emulate rendering::PathJoinType::NONE by painting single edges
 for(sal_uInt32 a(0); a < rPolyPoly.count(); a++)
 {
-const basegfx::B2DPolygon 
aCandidate(rPolyPoly.getB2DPolygon(a));
+const basegfx::B2DPolygon& 
aCandidate(rPolyPoly.getB2DPolygon(a));
 const sal_uInt32 nPointCount(aCandidate.count());
 
 if(nPointCount)
diff --git a/canvas/source/cairo/cairo_textlayout.cxx 
b/canvas/source/cairo/cairo_textlayout.cxx
index bce2469d6b9d..087f0479bf05 100644
--- a/canvas/source/cairo/cairo_textlayout.cxx
+++ b/canvas/source/cairo/cairo_textlayout.cxx
@@ -399,7 +399,7 @@ namespace cairocanvas
 if (cairo_glyphs.empty())
 continue;
 
-vcl::Font aFont = rOutDev.GetFont();
+const vcl::Font& aFont = rOutDev.GetFont();
 long nWidth = aFont.GetAverageFontWidth();
 long nHeight = aFont.GetFontHeight();
 if (nWidth == 0)
diff --git a/chart2/source/controller/main/ChartController_Tools.cxx 
b/chart2/source/controller/main/ChartController_Tools.cxx
index d59ae46fb52e..5cd5da3edf05 100644
--- a/chart2/source/controller/main/ChartController_Tools.cxx
+++ b/chart2/source/controller/main/ChartController_Tools.cxx
@@ -538,7 +538,7 @@ bool ChartController::isObjectDeleteable( const uno::Any& 
rSelection )
 ObjectIdentifier aSelOID( rSelection );
 if ( aSelOID.isAutoGeneratedObject() )
 {
-OUString aSelObjCID( aSelOID.getObjectCID() );
+const OUString& aSelObjCID( aSelOID.getObjectCID() );
 ObjectType aObjectType(ObjectIdentifier::getObjectType( aSelObjCID ));
 
 switch(aObjectType)
diff --git

[Libreoffice-commits] core.git: canvas/source chart2/source comphelper/source connectivity/source cppcanvas/source cppu/source cui/source

2018-09-06 Thread Libreoffice Gerrit user 
 canvas/source/cairo/cairo_canvashelper.cxx  |2 -
 chart2/source/controller/accessibility/AccessibleChartView.cxx  |3 -
 chart2/source/controller/accessibility/AccessibleTextHelper.cxx |1 
 chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx |3 -
 chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx   |2 -
 chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx |2 -
 chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx |2 -
 chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx  |4 +-
 chart2/source/controller/chartapiwrapper/UpDownBarWrapper.cxx   |4 +-
 chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx |4 +-
 chart2/source/controller/dialogs/ChartTypeDialogController.cxx  |2 -
 chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx |2 -
 chart2/source/controller/dialogs/dlg_ObjectProperties.cxx   |3 -
 chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx|1 
 chart2/source/controller/dialogs/tp_PointGeometry.cxx   |1 
 chart2/source/controller/dialogs/tp_RangeChooser.cxx|1 
 chart2/source/controller/drawinglayer/ViewElementListProvider.cxx   |3 -
 chart2/source/controller/itemsetwrapper/ItemConverter.cxx   |1 
 chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx |2 -
 chart2/source/controller/main/ChartController.cxx   |4 --
 chart2/source/controller/main/ChartFrameloader.cxx  |4 +-
 chart2/source/model/main/ChartModel.cxx |7 +---
 chart2/source/tools/LifeTime.cxx|2 -
 chart2/source/tools/ObjectIdentifier.cxx|7 +---
 chart2/source/tools/WrappedPropertySet.cxx  |3 -
 chart2/source/view/axes/Tickmarks.cxx   |2 -
 chart2/source/view/axes/Tickmarks_Dates.cxx |1 
 chart2/source/view/axes/Tickmarks_Equidistant.cxx   |8 
+
 chart2/source/view/axes/VAxisBase.cxx   |2 -
 chart2/source/view/axes/VAxisProperties.cxx |1 
 chart2/source/view/axes/VCartesianAxis.cxx  |4 +-
 chart2/source/view/axes/VCoordinateSystem.cxx   |5 ---
 chart2/source/view/axes/VPolarGrid.cxx  |4 +-
 chart2/source/view/axes/VPolarRadiusAxis.cxx|2 -
 chart2/source/view/charttypes/AreaChart.cxx |8 
+
 chart2/source/view/charttypes/BarChart.cxx  |2 -
 chart2/source/view/charttypes/CandleStickChart.cxx  |6 +--
 chart2/source/view/charttypes/NetChart.cxx  |4 --
 chart2/source/view/charttypes/PieChart.cxx  |8 
++---
 chart2/source/view/diagram/VDiagram.cxx |   11 
+-
 chart2/source/view/main/ChartItemPool.cxx   |2 -
 chart2/source/view/main/ChartView.cxx   |8 
++---
 chart2/source/view/main/DrawModelWrapper.cxx|2 -
 chart2/source/view/main/PlotterBase.cxx |5 ---
 chart2/source/view/main/PlottingPositionHelper.cxx  |3 -
 chart2/source/view/main/VButton.cxx |5 ---
 chart2/source/view/main/VDataSeries.cxx |   16 
--
 chart2/source/view/main/VTitle.cxx  |5 ---
 comphelper/source/container/container.cxx   |1 
 comphelper/source/misc/instancelocker.cxx   |3 -
 comphelper/source/officeinstdir/officeinstallationdirectories.cxx   |4 --
 connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx  |2 -
 connectivity/source/commontools/TKeys.cxx   |2 -
 connectivity/source/commontools/parameters.cxx  |1 
 connectivity/source/drivers/dbase/DIndex.cxx|2 -
 connectivity/source/drivers/dbase/DTable.cxx|2 -
 connectivity/source/drivers/dbase/dindexnode.cxx|1 
 connectivity/source/drivers/evoab2/NColumns.cxx |2 -
 connectivity/source/drivers/evoab2/NConnection.cxx  |1 
 connectivity/source/drivers/evoab2/NTables.cxx  |2 -
 connectivity/source/drivers/file/FColumns.cxx   |2 -
 connectivity/source/drivers/file/FDriver.cxx|2 -
 connectivity/source/drivers/file/FResultSet.cxx |4 --

[Libreoffice-commits] core.git: canvas/source chart2/source cui/source

2018-02-14 Thread Noel Grandin 
 canvas/source/cairo/cairo_canvashelper_text.cxx |4 -
 canvas/source/vcl/canvashelper_texturefill.cxx  |8 +--
 canvas/source/vcl/impltools.cxx |4 -
 canvas/source/vcl/spritehelper.cxx  |8 +--
 chart2/source/controller/dialogs/DataBrowser.cxx|2 
 chart2/source/controller/dialogs/dlg_CreationWizard.cxx |2 
 chart2/source/controller/main/ChartWindow.cxx   |   20 
 chart2/source/controller/main/DrawCommandDispatch.cxx   |4 -
 cui/source/customize/macropg.cxx|   10 ++--
 cui/source/dialogs/colorpicker.cxx  |   24 -
 cui/source/dialogs/cuicharmap.cxx   |   14 ++---
 cui/source/dialogs/cuigrfflt.cxx|8 +--
 cui/source/dialogs/cuihyperdlg.cxx  |   12 ++--
 cui/source/dialogs/thesdlg.cxx  |6 +-
 cui/source/options/dbregister.cxx   |2 
 cui/source/options/optcolor.cxx |2 
 cui/source/options/optdict.cxx  |4 -
 cui/source/options/optlingu.cxx |8 +--
 cui/source/options/optpath.cxx  |2 
 cui/source/tabpages/autocdlg.cxx|4 -
 cui/source/tabpages/backgrnd.cxx|   22 
 cui/source/tabpages/chardlg.cxx |   16 +++---
 cui/source/tabpages/grfpage.cxx |   12 ++--
 cui/source/tabpages/macroass.cxx|2 
 cui/source/tabpages/numpages.cxx|   18 +++
 cui/source/tabpages/page.cxx|6 +-
 cui/source/tabpages/tabstpge.cxx|4 -
 cui/source/tabpages/tparea.cxx  |4 -
 cui/source/tabpages/tpbitmap.cxx|   40 
 cui/source/tabpages/tpline.cxx  |   12 ++--
 30 files changed, 142 insertions(+), 142 deletions(-)

New commits:
commit f841dada1a5018897cce29ccf972da33ece4738c
Author: Noel Grandin 
Date:   Tue Feb 13 14:21:50 2018 +0200

loplugin:changetoolsgen in canvas..cui

Change-Id: I4e320055a3dbe4159c2aa2714e1ee98182e1e80a
Reviewed-on: https://gerrit.libreoffice.org/49642
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/cairo/cairo_canvashelper_text.cxx 
b/canvas/source/cairo/cairo_canvashelper_text.cxx
index 806bc415e7b1..b0d07f87cdbe 100644
--- a/canvas/source/cairo/cairo_canvashelper_text.cxx
+++ b/canvas/source/cairo/cairo_canvashelper_text.cxx
@@ -99,8 +99,8 @@ namespace cairocanvas
 io_rVCLFont.SetOrientation( static_cast< short >( 
::basegfx::fround(-fmod(nRotate, 2*M_PI)*(1800.0/M_PI)) ) );
 
 // TODO(F2): Missing functionality in VCL: shearing
-o_rPoint.X() = ::basegfx::fround(aTranslate.getX());
-o_rPoint.Y() = ::basegfx::fround(aTranslate.getY());
+o_rPoint.setX( ::basegfx::fround(aTranslate.getX()) );
+o_rPoint.setY( ::basegfx::fround(aTranslate.getY()) );
 
 return true;
 }
diff --git a/canvas/source/vcl/canvashelper_texturefill.cxx 
b/canvas/source/vcl/canvashelper_texturefill.cxx
index 9d7aaa502a88..892d6d781e8f 100644
--- a/canvas/source/vcl/canvashelper_texturefill.cxx
+++ b/canvas/source/vcl/canvashelper_texturefill.cxx
@@ -78,8 +78,8 @@ namespace vclcanvas
 
 for( nY=0; nY < nTilesY; ++nY )
 {
-aCurrPos.X() = rPosPixel.X() + nY*rNextTileY.Width();
-aCurrPos.Y() = rPosPixel.Y() + nY*rNextTileY.Height();
+aCurrPos.setX( rPosPixel.X() + nY*rNextTileY.Width() );
+aCurrPos.setY( rPosPixel.Y() + nY*rNextTileY.Height() );
 
 for( nX=0; nX < nTilesX; ++nX )
 {
@@ -90,8 +90,8 @@ namespace vclcanvas
rTileSize,
 );
 
-aCurrPos.X() += rNextTileX.Width();
-aCurrPos.Y() += rNextTileX.Height();
+aCurrPos.setX( aCurrPos.X() + rNextTileX.Width() );
+aCurrPos.setY( aCurrPos.Y() + rNextTileX.Height() );
 }
 }
 
diff --git a/canvas/source/vcl/impltools.cxx b/canvas/source/vcl/impltools.cxx
index 055eb061930e..dd0ca8a0714b 100644
--- a/canvas/source/vcl/impltools.cxx
+++ b/canvas/source/vcl/impltools.cxx
@@ -140,8 +140,8 @@ namespace vclcanvas
 io_rVCLFont.SetOrientation( static_cast< short >( 
::basegfx::fround(-fmod(nRotate, 2*M_PI)*(1800.0/M_PI)) ) );
 
 // TODO(F2): Missing functionality in VCL: shearing
-o_rPoint.X() = ::basegfx::fround(aTranslate.getX());
-o_rPoint.Y() =

[Libreoffice-commits] core.git: canvas/source chart2/source svtools/source svx/source sw/source vcl/source

2017-11-14 Thread Andrea Gelmini 
 canvas/source/vcl/canvashelper_texturefill.cxx |2 +-
 chart2/source/view/axes/ScaleAutomatism.cxx|2 +-
 svtools/source/contnr/fileview.cxx |2 +-
 svx/source/table/svdotable.cxx |2 +-
 sw/source/core/layout/tabfrm.cxx   |2 +-
 vcl/source/window/legacyaccessibility.cxx  |2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 6b56336e2378c150a34bd8de4ed7521493d8a8ff
Author: Andrea Gelmini 
Date:   Tue Nov 14 10:36:53 2017 +0100

Fix typos

Change-Id: I53b47cab5cbc603bf11adcda8ac2a8373eef26a8
Reviewed-on: https://gerrit.libreoffice.org/44695
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/canvas/source/vcl/canvashelper_texturefill.cxx 
b/canvas/source/vcl/canvashelper_texturefill.cxx
index 631f0f154458..c2735a5ce46d 100644
--- a/canvas/source/vcl/canvashelper_texturefill.cxx
+++ b/canvas/source/vcl/canvashelper_texturefill.cxx
@@ -868,7 +868,7 @@ namespace vclcanvas
 // =
 
 // calc device space direction vectors. We employ
-// the followin approach for tiled output: the
+// the following approach for tiled output: the
 // texture bitmap is output in texture space
 // x-major order, i.e. tile neighbors in texture
 // space x direction are rendered back-to-back in
diff --git a/chart2/source/view/axes/ScaleAutomatism.cxx 
b/chart2/source/view/axes/ScaleAutomatism.cxx
index 468d21003292..6e99df1b9c6a 100644
--- a/chart2/source/view/axes/ScaleAutomatism.cxx
+++ b/chart2/source/view/axes/ScaleAutomatism.cxx
@@ -115,7 +115,7 @@ void ScaleAutomatism::expandValueRange( double fMinimum, 
double fMaximum )
 {
 // if m_fValueMinimum and m_fValueMaximum == 0, it means that they were 
not determined.
 // m_fValueMinimum == 0 makes impossible to determine real minimum,
-// so they need to be reseted tdf#96807
+// so they need to be reset tdf#96807
 if( (m_fValueMinimum == 0.0) && (m_fValueMaximum == 0.0) )
 resetValueRange();
 if( (fMinimum < m_fValueMinimum) || ::rtl::math::isNan( m_fValueMinimum ) )
diff --git a/svtools/source/contnr/fileview.cxx 
b/svtools/source/contnr/fileview.cxx
index 24853fa6f268..7d6eeecd440e 100644
--- a/svtools/source/contnr/fileview.cxx
+++ b/svtools/source/contnr/fileview.cxx
@@ -1542,7 +1542,7 @@ FileViewResult SvtFileView_Impl::GetFolderContent_Impl(
 m_aAsyncActionFinished.reset();
 
 // don't (yet) set m_aCurrentAsyncActionHandler to 
pTimeout->aFinishHandler.
-// By definition, this handler *only* get's called when the result cannot 
be obtained
+// By definition, this handler *only* gets called when the result cannot 
be obtained
 // during the minimum wait time, so it is only set below, when needed.
 m_aCurrentAsyncActionHandler = Link();
 
diff --git a/svx/source/table/svdotable.cxx b/svx/source/table/svdotable.cxx
index 78f6261c43a2..441b4a01fbbb 100644
--- a/svx/source/table/svdotable.cxx
+++ b/svx/source/table/svdotable.cxx
@@ -2120,7 +2120,7 @@ SdrHdl* SdrTableObj::GetHdl(sal_uInt32 nHdlNum) const
 }
 
 
-// Draging
+// Dragging
 
 bool SdrTableObj::hasSpecialDrag() const
 {
diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index 245d636b4552..491c3f3b2e52 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -3601,7 +3601,7 @@ void SwTabFrame::Paste( SwFrame* pParent, SwFrame* 
pSibling )
 }
 }
 else if ( GetNext() )
-//Take the marging into account when dealing with ContentFrame's. 
There are
+//Take the margin into account when dealing with ContentFrame's. There 
are
 //two situations (both always happen at once):
 //a) The Content becomes the first in a chain
 //b) The new follower was the first in a chain before
diff --git a/vcl/source/window/legacyaccessibility.cxx 
b/vcl/source/window/legacyaccessibility.cxx
index ece1de64d6dd..b2b3e0634c6e 100644
--- a/vcl/source/window/legacyaccessibility.cxx
+++ b/vcl/source/window/legacyaccessibility.cxx
@@ -166,7 +166,7 @@ static Window* ImplGetLabeledBy( Window* pFrameWindow, 
WindowType nMyType, Windo
  nType == WindowType::FIXEDLINE ||
  nType == WindowType::GROUPBOX )
 {
-// a fixed text can't be labeld by a fixed text.
+// a fixed text can't be labelled by a fixed text.
 if ( ( nMyType != WindowType::FIXEDTEXT ) || ( nType 
!= WindowType::FIXEDTEXT ) )
 pWindow = pSWindow;
 break;
___
Libreoffice-commits mailing list

[Libreoffice-commits] core.git: canvas/source chart2/source codemaker/source include/codemaker

2017-11-01 Thread Noel Grandin 
 canvas/source/opengl/ogl_spritedevicehelper.cxx |8 ++--
 canvas/source/vcl/canvashelper_texturefill.cxx  |   13 +++-
 chart2/source/controller/dialogs/DialogModel.cxx|   26 +++-
 chart2/source/controller/sidebar/ChartElementsPanel.cxx |2 -
 chart2/source/inc/TitleHelper.hxx   |3 -
 chart2/source/tools/StatisticsHelper.cxx|   12 ++-
 chart2/source/tools/TitleHelper.cxx |5 +--
 chart2/source/view/charttypes/VSeriesPlotter.cxx|   11 +++---
 codemaker/source/codemaker/global.cxx   |8 
 include/codemaker/global.hxx|3 -
 10 files changed, 29 insertions(+), 62 deletions(-)

New commits:
commit 1a284d1f98069f55d5211882431f516691c2a6f0
Author: Noel Grandin 
Date:   Tue Oct 31 15:26:23 2017 +0200

loplugin:constantparam in c*

Change-Id: I10c7b62e6458062324367b94b207f776af79f598
Reviewed-on: https://gerrit.libreoffice.org/44129
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/canvas/source/opengl/ogl_spritedevicehelper.cxx 
b/canvas/source/opengl/ogl_spritedevicehelper.cxx
index 1c2a0525c9f4..46535fc9a409 100644
--- a/canvas/source/opengl/ogl_spritedevicehelper.cxx
+++ b/canvas/source/opengl/ogl_spritedevicehelper.cxx
@@ -52,7 +52,7 @@ static void initContext()
 glShadeModel(GL_FLAT);
 }
 
-static void initTransformation(const ::Size& rSize, bool bMirror)
+static void initTransformation(const ::Size& rSize)
 {
 // use whole window
 glViewport( 0,0,
@@ -62,9 +62,9 @@ static void initTransformation(const ::Size& rSize, bool 
bMirror)
 // model coordinate system is already in device pixel
 glMatrixMode(GL_MODELVIEW);
 glLoadIdentity();
-glTranslated(-1.0, (bMirror ? -1.0 : 1.0), 0.0);
+glTranslated(-1.0, 1.0, 0.0);
 glScaled( 2.0  / rSize.Width(),
-  (bMirror ? 2.0 : -2.0) / rSize.Height(),
+  -2.0 / rSize.Height(),
   1.0 );
 
 // clear to black
@@ -281,7 +281,7 @@ namespace oglcanvas
 
 SystemChildWindow* pChildWindow = mxContext->getChildWindow();
 const ::Size& rOutputSize = pChildWindow->GetSizePixel();
-initTransformation(rOutputSize, false);
+initTransformation(rOutputSize);
 
 // render the actual spritecanvas content
 mpSpriteCanvas->renderRecordedActions();
diff --git a/canvas/source/vcl/canvashelper_texturefill.cxx 
b/canvas/source/vcl/canvashelper_texturefill.cxx
index 0452aca5fcd9..631f0f154458 100644
--- a/canvas/source/vcl/canvashelper_texturefill.cxx
+++ b/canvas/source/vcl/canvashelper_texturefill.cxx
@@ -488,9 +488,8 @@ namespace vclcanvas
  const ::canvas::ParametricPolyPolygon::Values& 
rValues,
  const std::vector< ::Color >&  
rColors,
  const ::basegfx::B2DHomMatrix& 
rTextureTransform,
- const ::tools::Rectangle& 
rBounds,
- unsigned int   
nStepCount,
- bool   
bFillNonOverlapping )
+ const ::tools::Rectangle&  
rBounds,
+ unsigned int   
nStepCount )
 {
 switch( rValues.meType )
 {
@@ -510,7 +509,7 @@ namespace vclcanvas
rTextureTransform,
rBounds,
nStepCount,
-   bFillNonOverlapping,
+   false/*bFillNonOverlapping*/,
rValues,
rColors );
 break;
@@ -585,8 +584,7 @@ namespace vclcanvas
 rColors,
 aTotalTransform,
 aPolygonDeviceRectOrig,
-nStepCount,
-false );
+nStepCount );
 rOutDev.Pop();
 
 if( p2ndOutDev && nTransparency < 253 )
@@ -611,8 +609,7 @@ namespace vclcanvas
 rColors,
 aTotalTransform,
 aPolygonDeviceRectOrig,
-nStepCount,
-false );
+nStepCount );
 rOutDev.Pop();
 
 if( p2ndOutDev && nTransparency < 253 )
diff --git a/chart2/source/controller/dialogs/DialogModel.cxx

[Libreoffice-commits] core.git: canvas/source chart2/source compilerplugins/clang cui/source dbaccess/source filter/source framework/source lotuswordpro/source sc/source sdext/source sd/source sfx2/so

2017-10-26 Thread Stephan Bergmann 
 canvas/source/factory/cf_service.cxx |6 -
 chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx |4 -
 chart2/source/controller/main/ChartController_Position.cxx   |2 
 chart2/source/model/template/PieChartTypeTemplate.cxx|2 
 chart2/source/tools/DataSeriesHelper.cxx |8 +-
 chart2/source/view/main/VLegend.cxx  |2 
 compilerplugins/clang/unnecessaryparen.cxx   |   40 
+++---
 cui/source/options/optgdlg.cxx   |4 -
 dbaccess/source/ui/dlg/ConnectionPage.cxx|2 
 dbaccess/source/ui/querydesign/TableWindowListBox.cxx|2 
 filter/source/svg/impsvgdialog.cxx   |2 
 filter/source/svg/svgexport.cxx  |2 
 framework/source/uiconfiguration/uicategorydescription.cxx   |2 
 framework/source/uiconfiguration/windowstateconfiguration.cxx|4 -
 framework/source/uielement/uicommanddescription.cxx  |4 -
 lotuswordpro/source/filter/lwpfont.cxx   |2 
 sc/source/ui/unoobj/dapiuno.cxx  |2 
 sc/source/ui/vba/vbaformat.cxx   |2 
 sd/source/filter/ppt/pptinanimations.cxx |2 
 sdext/source/presenter/PresenterAccessibility.cxx|4 -
 sfx2/source/appl/sfxhelp.cxx |2 
 slideshow/source/engine/animationnodes/animationbasenode.cxx |4 -
 slideshow/source/engine/animationnodes/basenode.cxx  |2 
 slideshow/source/engine/effectrewinder.cxx   |2 
 slideshow/source/engine/slide/targetpropertiescreator.cxx|2 
 svx/source/xml/xmlgrhlp.cxx  |2 
 sw/qa/extras/ooxmlexport/ooxmlencryption.cxx |2 
 sw/qa/extras/ooxmlexport/ooxmlexport10.cxx   |2 
 sw/qa/extras/ooxmlexport/ooxmlexport6.cxx|2 
 sw/qa/extras/ooxmlexport/ooxmlexport7.cxx|2 
 sw/qa/extras/ooxmlexport/ooxmlexport8.cxx|2 
 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx|2 
 sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx|2 
 sw/qa/extras/ooxmlexport/ooxmlw14export.cxx  |2 
 vbahelper/source/vbahelper/vbafontbase.cxx   |4 -
 xmloff/source/chart/SchXMLExport.cxx |2 
 36 files changed, 77 insertions(+), 57 deletions(-)

New commits:
commit 084f454e8caa2d9e43f7bdea098538bfb87423d8
Author: Stephan Bergmann 
Date:   Thu Oct 26 10:27:48 2017 +0200

More loplugin:unnecessaryparen

81892b2037453108b9bde1512a500cf3b2ce438a "loplugin:unnecessaryparen when
compiling as C++17, so the ParenExpr is no longer hidden behind
ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave 
me
the idea to generally look though IgnoreImplicit instead of IngoreImpCasts 
in
loplugin:unnecessaryparen.  However, that would still not look through 
implicit
CXXConstructExpr, so would still not have found the occurrences in
81892b2037453108b9bde1512a500cf3b2ce438a when compiling in pre-C++17 mode.
Therefore, let ignoreAllImplicit also look through CXXConstructExpr.  (I am 
not
entirely sure in which situations non-implicit CXXConstructExpr---that 
should
thus not be ignored---would occur, but assume they would be underneath 
something
like a CXXFunctionalCastExpr, which is not ignored.)

Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843

diff --git a/canvas/source/factory/cf_service.cxx 
b/canvas/source/factory/cf_service.cxx
index 5a846aef7bb3..ed49bcfa1474 100644
--- a/canvas/source/factory/cf_service.cxx
+++ b/canvas/source/factory/cf_service.cxx
@@ -166,15 +166,15 @@ CanvasFactory::CanvasFactory( 
Reference const & xContext ) :
 if( xEntryNameAccess.is() )
 {
 Sequence implementationList;
-if( 
(xEntryNameAccess->getByName("PreferredImplementations") >>= 
implementationList) )
+if( 
xEntryNameAccess->getByName("PreferredImplementations") >>= implementationList )
 {
 
m_aAvailableImplementations.emplace_back(*pCurr,implementationList );
 }
-if( 
(xEntryNameAccess->getByName("AcceleratedImplementations") >>= 
implementationList) )
+if( 
xEntryNameAccess->getByName("AcceleratedImplementations") >>= 
implementationList )

[Libreoffice-commits] core.git: canvas/source chart2/source compilerplugins/clang cpputools/source desktop/source embeddedobj/source forms/source framework/source io/source linguistic/source package/s

2017-09-29 Thread Noel Grandin 
 canvas/source/tools/verifyinput.cxx   |   37 -
 chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx |3 
 chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx   |3 
 compilerplugins/clang/flatten.cxx |  198 
++-
 compilerplugins/clang/test/flatten.cxx|   40 +
 cpputools/source/unoexe/unoexe.cxx|9 
 desktop/source/app/officeipcthread.cxx|3 
 embeddedobj/source/commonembedding/persistence.cxx|7 
 forms/source/xforms/NameContainer.hxx |3 
 framework/source/fwe/xml/xmlnamespaces.cxx|   24 
 framework/source/services/substitutepathvars.cxx  |6 
 framework/source/tabwin/tabwindow.cxx |   92 +--
 framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx |   88 +--
 framework/source/uiconfiguration/uiconfigurationmanager.cxx   |   35 -
 framework/source/uiconfiguration/windowstateconfiguration.cxx |   76 +-
 framework/source/uifactory/uielementfactorymanager.cxx|6 
 io/source/stm/omark.cxx   |   21 
 linguistic/source/convdiclist.cxx |8 
 package/source/zipapi/ZipFile.cxx |   12 
 package/source/zippackage/ZipPackageFolder.cxx|   47 -
 sc/source/core/opencl/op_logical.cxx  |   77 +-
 sc/source/ui/unoobj/docuno.cxx|   15 
 sd/source/core/stlfamily.cxx  |5 
 sd/source/core/stlsheet.cxx   |  260 
--
 sd/source/ui/unoidl/unopback.cxx  |  114 ++--
 sdext/source/presenter/PresenterPaneFactory.cxx   |9 
 sdext/source/presenter/PresenterViewFactory.cxx   |   15 
 sfx2/source/doc/printhelper.cxx   |5 
 sfx2/source/sidebar/TabBar.cxx|   31 -
 starmath/source/accessibility.cxx |  131 ++---
 svx/source/unodraw/unoshap3.cxx   |   38 -
 svx/source/unogallery/unogaltheme.cxx |   12 
 svx/source/unogallery/unogalthemeprovider.cxx |   12 
 sw/source/core/access/accpara.cxx |4 
 sw/source/core/unocore/unochart.cxx   |   13 
 sw/source/core/unocore/unodraw.cxx|   87 +--
 sw/source/core/unocore/unosett.cxx|3 
 sw/source/core/unocore/unotext.cxx|   24 
 sw/source/uibase/uno/unomailmerge.cxx |   72 +-
 sw/source/uibase/uno/unotxvw.cxx  |   60 +-
 ucb/source/ucp/file/filglob.cxx   |8 
 ucb/source/ucp/file/filinpstr.cxx |3 
 ucb/source/ucp/file/filstr.cxx|9 
 unodevtools/source/skeletonmaker/skeletoncommon.cxx   |3 
 unodevtools/source/unodevtools/options.cxx|7 
 vbahelper/source/vbahelper/vbadocumentbase.cxx|9 
 vbahelper/source/vbahelper/vbahelper.cxx  |5 
 xmlhelp/source/cxxhelp/provider/inputstream.cxx   |4 
 xmlhelp/source/cxxhelp/provider/urlparameter.cxx  |4 
 xmlsecurity/source/xmlsec/saxhelper.cxx   |   36 -
 50 files changed, 909 insertions(+), 884 deletions(-)

New commits:
commit 1ffba0e356608fb6dbf568248e2a953b4d7fb5d6
Author: Noel Grandin 
Date:   Thu Sep 28 10:33:09 2017 +0200

loplugin:flatten check for throw in then clause

also make the plugin ignore the case where we have var decl's in the
clause we want to flatten, which could lead to problematic extension of
variable lifetime

Change-Id: I3061f7104e8c6a460bf74f5eac325a516ec50c59
Reviewed-on: https://gerrit.libreoffice.org/42889
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/tools/verifyinput.cxx 
b/canvas/source/tools/verifyinput.cxx
index c5764b38f7aa..9e15738302b4 100644
--- a/canvas/source/tools/verifyinput.cxx
+++ b/canvas/source/tools/verifyinput.cxx
@@ -550,34 +550,31 @@ namespace canvas
 throw lang::IllegalArgumentException();
 #endif
 }
-else
+if( bitmapLayout.ColorSpace->getBitsPerPixel() < 0 )
 {
-if( bitmapLayout.ColorSpace->getBitsPerPixel() < 0 )
-{
 #if

[Libreoffice-commits] core.git: canvas/source chart2/source

2017-05-23 Thread Noel Grandin 
 canvas/source/cairo/cairo_canvashelper.cxx  |2 
 chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx |4 
 chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx   |2 
 chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx |6 
-
 chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx   |   10 
+-
 chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx |   16 
+--
 chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx|4 
 chart2/source/controller/dialogs/ChartTypeDialogController.cxx  |8 
-
 chart2/source/controller/dialogs/ObjectNameProvider.cxx |   20 
++--
 chart2/source/controller/dialogs/dlg_ObjectProperties.cxx   |   22 
++--
 chart2/source/controller/dialogs/res_DataLabel.cxx  |2 
 chart2/source/controller/dialogs/tp_AxisPositions.cxx   |8 
-
 chart2/source/controller/dialogs/tp_ChartType.cxx   |   24 
++---
 chart2/source/controller/dialogs/tp_Scale.cxx   |   18 
+--
 chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx   |   10 
+-
 chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx  |   26 
++---
 chart2/source/controller/itemsetwrapper/ItemConverter.cxx   |2 
 chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx  |4 
 chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx  |   26 
++---
 chart2/source/controller/main/ChartController_Position.cxx  |   10 
+-
 chart2/source/controller/main/ChartController_Properties.cxx|   10 
+-
 chart2/source/controller/main/ChartController_Window.cxx|   46 
+-
 chart2/source/controller/main/ControllerCommandDispatch.cxx |   14 
+--
 chart2/source/controller/main/DrawCommandDispatch.cxx   |2 
 chart2/source/controller/main/ElementSelector.cxx   |4 
 chart2/source/controller/main/PositionAndSizeHelper.cxx |   10 
+-
 chart2/source/controller/main/SelectionHelper.cxx   |   10 
+-
 chart2/source/model/main/ChartModel.cxx |4 
 chart2/source/model/main/Diagram.cxx|   14 
+--
 chart2/source/model/template/ChartTypeTemplate.cxx  |2 
 chart2/source/tools/AxisHelper.cxx  |6 
-
 chart2/source/tools/ChartModelHelper.cxx|2 
 chart2/source/tools/ChartTypeHelper.cxx |   10 
+-
 chart2/source/tools/LinePropertiesHelper.cxx|4 
 chart2/source/tools/ObjectIdentifier.cxx|4 
 chart2/source/tools/RangeHighlighter.cxx|   22 
++--
 chart2/source/tools/ThreeDHelper.cxx|2 
 chart2/source/view/axes/DateScaling.cxx |4 
 chart2/source/view/axes/ScaleAutomatism.cxx |4 
 chart2/source/view/axes/Tickmarks.cxx   |6 
-
 chart2/source/view/axes/VAxisBase.cxx   |8 
-
 chart2/source/view/axes/VAxisProperties.cxx |   16 
+--
 chart2/source/view/axes/VCartesianAxis.cxx  |   44 
-
 chart2/source/view/axes/VCartesianCoordinateSystem.cxx  |8 
-
 chart2/source/view/axes/VCartesianGrid.cxx  |   26 
++---
 chart2/source/view/axes/VCoordinateSystem.cxx   |   22 
++--
 chart2/source/view/axes/VPolarAxis.cxx  |4 
 chart2/source/view/axes/VPolarCoordinateSystem.cxx  |6 
-
 chart2/source/view/axes/VPolarGrid.cxx  |2 
 chart2/source/view/charttypes/AreaChart.cxx |   18 
+--
 chart2/source/view/charttypes/BarChart.cxx  |   20 
++--
 chart2/source/view/charttypes/BubbleChart.cxx   |2 
 chart2/source/view/charttypes/NetChart.cxx  |2 
 chart2/source/view/charttypes/PieChart.cxx  |4 
 chart2/source/view/charttypes/VSeriesPlotter.cxx|   34 
+++
 chart2/source/view/diagram/VDiagram.cxx |   14 
+--
 chart2/source/view/main/ChartView.cxx   |   22 
++--
 chart2/source/view/main/DummyXShape.cxx |4 
 chart2/source/view/main/GL3DRenderer.cxx|4 
 chart2/source/view/main/LabelPositionHelper.cxx

[Libreoffice-commits] core.git: canvas/source chart2/source cli_ure/source comphelper/source compilerplugins/clang connectivity/source

2017-03-02 Thread Andrea Gelmini 
 canvas/source/tools/surfaceproxy.cxx  |2 +-
 chart2/source/view/charttypes/VSeriesPlotter.cxx  |2 +-
 cli_ure/source/scripts/increment_version.pl   |2 +-
 comphelper/source/misc/backupfilehelper.cxx   |6 +++---
 compilerplugins/clang/overrideparam.cxx   |2 +-
 compilerplugins/clang/passstuffbyref.cxx  |2 +-
 compilerplugins/clang/refcounting.cxx |2 +-
 compilerplugins/clang/unusedmethods.py|2 +-
 connectivity/source/drivers/evoab2/NDriver.cxx|2 +-
 connectivity/source/drivers/kab/KConnection.cxx   |2 +-
 connectivity/source/drivers/kab/KDriver.cxx   |2 +-
 connectivity/source/drivers/macab/MacabConnection.cxx |2 +-
 connectivity/source/drivers/macab/MacabDriver.cxx |2 +-
 connectivity/source/drivers/mork/MConnection.cxx  |2 +-
 connectivity/source/inc/hsqldb/HDriver.hxx|2 +-
 connectivity/source/inc/mysql/YDriver.hxx |2 +-
 connectivity/source/inc/odbc/OConnection.hxx  |2 +-
 connectivity/source/parse/sqliterator.cxx |2 +-
 18 files changed, 20 insertions(+), 20 deletions(-)

New commits:
commit 6fab286b2a213575e3b1ccd0eddb00c8b242af00
Author: Andrea Gelmini 
Date:   Thu Mar 2 17:56:40 2017 +0100

Fix typos

Change-Id: I4f16ba5fc32cbfd6a5b01e495f3ad905da193524
Reviewed-on: https://gerrit.libreoffice.org/34808
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/canvas/source/tools/surfaceproxy.cxx 
b/canvas/source/tools/surfaceproxy.cxx
index 2699820..4f17d239 100644
--- a/canvas/source/tools/surfaceproxy.cxx
+++ b/canvas/source/tools/surfaceproxy.cxx
@@ -114,7 +114,7 @@ namespace canvas
 ::basegfx::triangulator::triangulate(rClipPoly));
 
 // dump polygons
-SAL_INFO("canvas", "Orignal clip polygon: " <<  
basegfx::tools::exportToSvgD( rClipPoly, true, true, false ));
+SAL_INFO("canvas", "Original clip polygon: " <<  
basegfx::tools::exportToSvgD( rClipPoly, true, true, false ));
 SAL_INFO("canvas", "Triangulated polygon: " <<  
basegfx::tools::exportToSvgD(basegfx::B2DPolyPolygon(rTriangulatedPolygon), 
true, true, false ));
 
 for( const auto& rSurfacePtr : maSurfaceList )
diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx 
b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index bd17a54..0d98ead 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -1697,7 +1697,7 @@ namespace {
  * For each X value, we calculate separate Y value ranges for each data
  * series in the first pass.  In the second pass, we calculate the minimum Y
  * value by taking the absolute minimum value of all data series, whereas
- * the maxium Y value is the sum of all the series maximum Y values.
+ * the maximum Y value is the sum of all the series maximum Y values.
  *
  * Once that's done for all X values, the final min / max Y values get
  * calculated by taking the absolute min / max Y values across all the X
diff --git a/cli_ure/source/scripts/increment_version.pl 
b/cli_ure/source/scripts/increment_version.pl
index d8606d6..ad371e4 100644
--- a/cli_ure/source/scripts/increment_version.pl
+++ b/cli_ure/source/scripts/increment_version.pl
@@ -30,7 +30,7 @@ sub incrementPolicyVersion($);
 my $usage =
 "The tool increments the minor version of assemblies and the major version of 
".
 "the respective policy files. This is only done if new uno types have been 
added since".
-"the last product upate. This information is obtained from the file which is 
passed as ".
+"the last product update. This information is obtained from the file which is 
passed as ".
 "argument changedTypes. The names in the version file must have a particular 
form. ".
 "They must end on one of folling terms: NEW_VERSION, OLD_VERSION, 
POLICY_VERSION\n".
 "If no new published types have been added then no output, argument  
newVersions, is written".
diff --git a/comphelper/source/misc/backupfilehelper.cxx 
b/comphelper/source/misc/backupfilehelper.cxx
index face14f..5c65dde 100644
--- a/comphelper/source/misc/backupfilehelper.cxx
+++ b/comphelper/source/misc/backupfilehelper.cxx
@@ -1763,7 +1763,7 @@ namespace comphelper
 
 if (mbActive)
 {
-// ensure existance
+// ensure existence
 getInitialBaseURL();
 
 // if not found, we are out of business (maExt may be empty)
@@ -1809,7 +1809,7 @@ namespace comphelper
 
 void BackupFileHelper::reactOnSafeMode(bool bSafeMode)
 {
-// ensure existance of needed paths
+// ensure existence of needed paths
 getInitialBaseURL();
 
 if (!maUserConfigBaseURL.isEmpty())
@@ -2719,7 +2719,7 @@ namespace comphelper
 case 2:
 {

[Libreoffice-commits] core.git: canvas/source chart2/source comphelper/source configmgr/source connectivity/source cui/source dbaccess/source include/canvas include/comphelper include/connectivity

2016-09-14 Thread Noel Grandin 
 canvas/source/cairo/cairo_cachedbitmap.cxx  |2 
 canvas/source/tools/cachedprimitivebase.cxx |9 --
 canvas/source/vcl/cachedbitmap.cxx  |2 
 chart2/source/controller/dialogs/TextDirectionListBox.cxx   |4 -
 chart2/source/controller/inc/MultipleChartConverters.hxx|6 -
 chart2/source/controller/inc/TextDirectionListBox.hxx   |3 
 chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx |   10 +-
 comphelper/source/misc/servicedecl.cxx  |6 +
 configmgr/source/access.cxx |2 
 configmgr/source/components.cxx |5 -
 configmgr/source/components.hxx |3 
 connectivity/source/commontools/TIndexColumns.cxx   |2 
 connectivity/source/commontools/TKeyColumns.cxx |3 
 connectivity/source/drivers/dbase/DIndex.cxx|2 
 connectivity/source/drivers/dbase/DIndexColumns.cxx |3 
 connectivity/source/drivers/dbase/dindexnode.cxx|4 -
 connectivity/source/drivers/hsqldb/HUser.cxx|2 
 connectivity/source/drivers/hsqldb/HView.cxx|2 
 connectivity/source/drivers/mork/MorkParser.cxx |4 -
 connectivity/source/drivers/mork/MorkParser.hxx |2 
 connectivity/source/drivers/mysql/YUser.cxx |2 
 connectivity/source/drivers/mysql/YViews.cxx|1 
 connectivity/source/inc/OColumn.hxx |   37 
+++---
 connectivity/source/inc/dbase/DIndexIter.hxx|8 --
 connectivity/source/inc/dbase/dindexnode.hxx|4 -
 connectivity/source/sdbcx/VIndex.cxx|4 -
 connectivity/source/sdbcx/VIndexColumn.cxx  |9 --
 connectivity/source/sdbcx/VKey.cxx  |2 
 connectivity/source/sdbcx/VKeyColumn.cxx|9 --
 connectivity/source/sdbcx/VView.cxx |3 
 cui/source/dialogs/hangulhanjadlg.cxx   |   14 +--
 cui/source/dialogs/iconcdlg.cxx |   24 
--
 cui/source/dialogs/newtabledlg.cxx  |4 -
 cui/source/dialogs/scriptdlg.cxx|5 -
 cui/source/factory/dlgfact.cxx  |4 -
 cui/source/inc/autocdlg.hxx |4 -
 cui/source/inc/iconcdlg.hxx |8 --
 cui/source/inc/newtabledlg.hxx  |2 
 cui/source/inc/numfmt.hxx   |2 
 cui/source/inc/scriptdlg.hxx|2 
 cui/source/options/connpoolconfig.cxx   |4 -
 cui/source/options/connpoolsettings.cxx |4 -
 cui/source/options/connpoolsettings.hxx |2 
 cui/source/tabpages/numfmt.cxx  |4 -
 dbaccess/source/core/api/View.cxx   |2 
 include/canvas/base/cachedprimitivebase.hxx |   11 --
 include/comphelper/servicedecl.hxx  |6 -
 include/connectivity/sdbcx/VIndexColumn.hxx |3 
 include/connectivity/sdbcx/VKeyColumn.hxx   |3 
 include/connectivity/sdbcx/VView.hxx|1 
 50 files changed, 89 insertions(+), 175 deletions(-)

New commits:
commit 1e49e33c26950b606714c0dafb26cbcb2aeb3877
Author: Noel Grandin 
Date:   Mon Sep 12 13:10:16 2016 +0200

loplugin:constantparam in chart2..connectivity

Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d
Reviewed-on: https://gerrit.libreoffice.org/28834
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/canvas/source/cairo/cairo_cachedbitmap.cxx 
b/canvas/source/cairo/cairo_cachedbitmap.cxx
index 2528a68..13e88f1 100644
--- a/canvas/source/cairo/cairo_cachedbitmap.cxx
+++ b/canvas/source/cairo/cairo_cachedbitmap.cxx
@@ -38,7 +38,7 @@ namespace cairocanvas
 const rendering::ViewState& 
rUsedViewState,
 const rendering::RenderState&   
rUsedRenderState,
 const uno::Reference< rendering::XCanvas >& 
rTarget ) :
-CachedPrimitiveBase( rUsedViewState,

[Libreoffice-commits] core.git: canvas/source chart2/source

2016-08-05 Thread Noel Grandin 
 canvas/source/cairo/cairo_canvas.hxx   |2 +-
 canvas/source/cairo/cairo_canvasbitmap.hxx |2 +-
 canvas/source/cairo/cairo_canvascustomsprite.cxx   |2 +-
 canvas/source/cairo/cairo_canvascustomsprite.hxx   |2 +-
 canvas/source/cairo/cairo_canvashelper.cxx |4 ++--
 canvas/source/cairo/cairo_devicehelper.hxx |2 +-
 canvas/source/cairo/cairo_spritecanvas.hxx |2 +-
 canvas/source/cairo/cairo_spritedevicehelper.hxx   |2 +-
 canvas/source/cairo/cairo_surfaceprovider.hxx  |2 +-
 canvas/source/opengl/ogl_spritedevicehelper.cxx|4 ++--
 chart2/source/controller/dialogs/ChartTypeDialogController.hxx |4 ++--
 chart2/source/controller/dialogs/DataBrowser.cxx   |2 +-
 chart2/source/controller/dialogs/tp_Scale.hxx  |2 +-
 chart2/source/controller/inc/ChartController.hxx   |2 +-
 chart2/source/controller/main/CommandDispatch.hxx  |3 +--
 chart2/source/controller/main/FeatureCommandDispatchBase.hxx   |2 +-
 chart2/source/controller/sidebar/ChartElementsPanel.cxx|2 +-
 chart2/source/inc/AxisHelper.hxx   |4 ++--
 chart2/source/inc/CommonConverters.hxx |2 +-
 chart2/source/inc/DataSeriesHelper.hxx |2 +-
 chart2/source/inc/DiagramHelper.hxx|5 ++---
 chart2/source/inc/RegressionCurveCalculator.hxx|2 +-
 chart2/source/inc/RegressionCurveHelper.hxx|2 +-
 chart2/source/inc/TitleHelper.hxx  |2 +-
 chart2/source/tools/RangeHighlighter.cxx   |5 +++--
 chart2/source/view/axes/Tickmarks_Equidistant.cxx  |2 +-
 chart2/source/view/axes/Tickmarks_Equidistant.hxx  |2 +-
 chart2/source/view/charttypes/AreaChart.cxx|2 +-
 chart2/source/view/charttypes/AreaChart.hxx|2 +-
 chart2/source/view/charttypes/GL3DBarChart.cxx |2 +-
 chart2/source/view/charttypes/NetChart.hxx |2 +-
 chart2/source/view/charttypes/PieChart.cxx |2 +-
 chart2/source/view/charttypes/VSeriesPlotter.cxx   |2 +-
 chart2/source/view/inc/3DChartObjects.hxx  |2 +-
 chart2/source/view/inc/AbstractShapeFactory.hxx|   10 
+-
 chart2/source/view/inc/GL3DBarChart.hxx|2 +-
 chart2/source/view/inc/GL3DRenderer.hxx|2 +-
 chart2/source/view/inc/OpenglShapeFactory.hxx  |8 
 chart2/source/view/inc/PolarLabelPositionHelper.hxx|4 ++--
 chart2/source/view/inc/ShapeFactory.hxx|8 
 chart2/source/view/inc/VSeriesPlotter.hxx  |8 
 chart2/source/view/main/DataPointSymbolSupplier.cxx|2 +-
 chart2/source/view/main/ShapeFactory.cxx   |4 ++--
 chart2/source/view/main/VLegendSymbolFactory.cxx   |8 
 44 files changed, 69 insertions(+), 70 deletions(-)

New commits:
commit f22fa994603311a36f467a6afea19bc4fad03814
Author: Noel Grandin 
Date:   Thu Aug 4 11:35:36 2016 +0200

loplugin:countusersofdefaultparams in canvas,chart2

Change-Id: Id66a706171b73affeb508812744028d9f30133af
Reviewed-on: https://gerrit.libreoffice.org/27868
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/cairo/cairo_canvas.hxx 
b/canvas/source/cairo/cairo_canvas.hxx
index fe712e3..920b37a 100644
--- a/canvas/source/cairo/cairo_canvas.hxx
+++ b/canvas/source/cairo/cairo_canvas.hxx
@@ -133,7 +133,7 @@ namespace cairocanvas
 
 // SurfaceProvider
 virtual ::cairo::SurfaceSharedPtr getSurface() override;
-virtual ::cairo::SurfaceSharedPtr createSurface( const 
::basegfx::B2ISize& rSize, int aContent = CAIRO_CONTENT_COLOR_ALPHA ) override;
+virtual ::cairo::SurfaceSharedPtr createSurface( const 
::basegfx::B2ISize& rSize, int aContent ) override;
 virtual ::cairo::SurfaceSharedPtr createSurface( ::Bitmap& rBitmap ) 
override;
 virtual ::cairo::SurfaceSharedPtr changeSurface() override;
 virtual OutputDevice* getOutputDevice() override;
diff --git a/canvas/source/cairo/cairo_canvasbitmap.hxx 
b/canvas/source/cairo/cairo_canvasbitmap.hxx
index e6c9f0c..d795418 100644
--- a/canvas/source/cairo/cairo_canvasbitmap.hxx
+++ b/canvas/source/cairo/cairo_canvasbitmap.hxx
@@ -93,7 +93,7 @@ namespace cairocanvas
 
 // SurfaceProvider
 virtual ::cairo::SurfaceSharedPtr getSurface() override;
-virtual

[Libreoffice-commits] core.git: canvas/source chart2/source chart2/workbench comphelper/source connectivity/source cppu/source

2016-08-01 Thread nadith 
 canvas/source/cairo/cairo_devicehelper.cxx  |4 --
 chart2/source/controller/dialogs/ObjectNameProvider.cxx |   29 
 chart2/source/tools/ObjectIdentifier.cxx|3 -
 chart2/workbench/addin/sampleaddin.cxx  |4 --
 comphelper/source/container/embeddedobjectcontainer.cxx |3 -
 comphelper/source/misc/mimeconfighelper.cxx |3 -
 comphelper/source/xml/ofopxmlhelper.cxx |3 -
 connectivity/source/commontools/dbtools.cxx |3 -
 connectivity/source/drivers/ado/APreparedStatement.cxx  |6 +--
 connectivity/source/drivers/file/fcomp.cxx  |3 -
 connectivity/source/drivers/hsqldb/HDriver.cxx  |5 --
 connectivity/source/drivers/hsqldb/HTable.cxx   |4 --
 cppu/source/uno/lbenv.cxx   |4 --
 13 files changed, 22 insertions(+), 52 deletions(-)

New commits:
commit efef273e2c61b19a63572a71b103e3b1490f15af
Author: nadith 
Date:   Fri Jul 29 12:22:18 2016 +0530

tdf#100726: Improve readability of OUString concatenation

this bug fixed in the modules between canvas - cppu

Change-Id: I2022b022897dafde20251352376e3facdb9b8d75
Reviewed-on: https://gerrit.libreoffice.org/27663
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/cairo/cairo_devicehelper.cxx 
b/canvas/source/cairo/cairo_devicehelper.cxx
index 2f214ad..0400c2c 100644
--- a/canvas/source/cairo/cairo_devicehelper.cxx
+++ b/canvas/source/cairo/cairo_devicehelper.cxx
@@ -236,9 +236,7 @@ namespace cairocanvas
 
 if( mpRefDevice )
 {
-OUString aFilename("dbg_frontbuffer");
-aFilename += OUString::number(nFilePostfixCount);
-aFilename += ".bmp";
+OUString aFilename = "dbg_frontbuffer" + 
OUString::number(nFilePostfixCount) + ".bmp";
 
 SvFileStream aStream( aFilename, STREAM_STD_READWRITE );
 
diff --git a/chart2/source/controller/dialogs/ObjectNameProvider.cxx 
b/chart2/source/controller/dialogs/ObjectNameProvider.cxx
index a70894b..3eccea9 100644
--- a/chart2/source/controller/dialogs/ObjectNameProvider.cxx
+++ b/chart2/source/controller/dialogs/ObjectNameProvider.cxx
@@ -489,11 +489,9 @@ OUString ObjectNameProvider::getHelpText( const OUString& 
rObjectCID, const Refe
 {
 OUString aNewLine( "\n" );
 
-aRet=SCH_RESSTR(STR_TIP_DATAPOINT_INDEX);
-aRet+=aNewLine;
-aRet+=SCH_RESSTR(STR_TIP_DATASERIES);
-aRet+=aNewLine;
-aRet+=SCH_RESSTR(STR_TIP_DATAPOINT_VALUES);
+aRet= SCH_RESSTR(STR_TIP_DATAPOINT_INDEX) + aNewLine
++ SCH_RESSTR(STR_TIP_DATASERIES) + aNewLine
++ SCH_RESSTR(STR_TIP_DATAPOINT_VALUES);
 }
 else
 aRet=SCH_RESSTR(STR_TIP_DATAPOINT);
@@ -637,9 +635,7 @@ OUString ObjectNameProvider::getHelpText( const OUString& 
rObjectCID, const Refe
 Reference< chart2::XRegressionCurve > xCurve( 
RegressionCurveHelper::getRegressionCurveAtIndex(xCurveCnt, nCurveIndex) );
 if( xCurve.is())
 {
-aRet += " (";
-aRet += 
RegressionCurveHelper::getRegressionCurveName(xCurve);
-aRet += " )";
+aRet += " (" + 
RegressionCurveHelper::getRegressionCurveName(xCurve) + " )";
 }
 }
 }
@@ -790,19 +786,15 @@ OUString ObjectNameProvider::getNameForCID(
 case OBJECTTYPE_DATA_CURVE:
 case OBJECTTYPE_DATA_CURVE_EQUATION:
 {
-OUString aRet = lcl_getFullSeriesName( rObjectCID, xModel );
-aRet += " ";
+OUString aRet = lcl_getFullSeriesName( rObjectCID, xModel ) + 
" ";
 if( eType == OBJECTTYPE_DATA_POINT || eType == 
OBJECTTYPE_DATA_LABEL )
 {
 aRet += getName( OBJECTTYPE_DATA_POINT  );
 sal_Int32 nPointIndex = 
ObjectIdentifier::getIndexFromParticleOrCID( rObjectCID );
-aRet += " ";
-aRet += OUString::number(nPointIndex+1);
-
+aRet += " " + OUString::number(nPointIndex+1);
 if( eType == OBJECTTYPE_DATA_LABEL )
 {
-aRet += " ";
-aRet += getName( OBJECTTYPE_DATA_LABEL  );
+aRet += " " + getName( OBJECTTYPE_DATA_LABEL  );
 }
 }
 else if (eType == OBJECTTYPE_DATA_CURVE || eType == 
OBJECTTYPE_DATA_CURVE_EQUATION)
@@ -810,8 +802,7 @@ OUString ObjectNameProvider::getNameForCID(
 Reference< chart2::XDataSeries > xSeries( 
ObjectIdentifier::getDataSeriesForCID( rObjectCID , xModel ));
 Reference<

[Libreoffice-commits] core.git: canvas/source chart2/source dbaccess/source framework/inc framework/source include/uno scp2/inc sc/source sd/source svtools/source UnoControls/inc xmloff/source

2016-04-22 Thread Andrea Gelmini 
 UnoControls/inc/basecontrol.hxx  |2 +-
 canvas/source/directx/dx_surfacebitmap.cxx   |2 +-
 chart2/source/view/main/VDataSeries.cxx  |2 +-
 dbaccess/source/core/dataaccess/ModelImpl.hxx|2 +-
 framework/inc/jobs/jobresult.hxx |2 +-
 framework/source/inc/loadenv/loadenvexception.hxx|2 +-
 include/uno/threadpool.h |2 +-
 sc/source/filter/inc/xehelper.hxx|2 +-
 sc/source/ui/vba/vbahyperlinks.cxx   |2 +-
 scp2/inc/macros.inc  |2 +-
 sd/source/ui/slidesorter/inc/model/SlsPageDescriptor.hxx |2 +-
 svtools/source/svhtml/htmlkywd.cxx   |2 +-
 xmloff/source/chart/SchXMLChartContext.cxx   |2 +-
 xmloff/source/chart/SchXMLExport.cxx |2 +-
 xmloff/source/draw/ximpbody.cxx  |2 +-
 15 files changed, 15 insertions(+), 15 deletions(-)

New commits:
commit b2e86d2e26a7675b925b50b26e0ed4b3a946e9b9
Author: Andrea Gelmini 
Date:   Thu Apr 21 23:21:13 2016 +0200

Fix typos

Change-Id: Iea2a1bf1ff934de0e355b9e81979aa1966a3
Reviewed-on: https://gerrit.libreoffice.org/24286
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/UnoControls/inc/basecontrol.hxx b/UnoControls/inc/basecontrol.hxx
index 6ea4bd1..3970e75 100644
--- a/UnoControls/inc/basecontrol.hxx
+++ b/UnoControls/inc/basecontrol.hxx
@@ -101,7 +101,7 @@ namespace unocontrols{
 
 struct IMPL_MutexContainer
 {
-// Is necassery to initialize "BaseControl" and make this class 
thread-safe.
+// Is necessary to initialize "BaseControl" and make this class 
thread-safe.
 ::osl::Mutex m_aMutex;
 };
 
diff --git a/canvas/source/directx/dx_surfacebitmap.cxx 
b/canvas/source/directx/dx_surfacebitmap.cxx
index f7a3dde..fac6d9e 100644
--- a/canvas/source/directx/dx_surfacebitmap.cxx
+++ b/canvas/source/directx/dx_surfacebitmap.cxx
@@ -292,7 +292,7 @@ namespace dxcanvas
 {
 // since clients will most probably draw directly
 // to the GDI+ bitmap, we need to mark it as dirty
-// to ensure that the corrosponding dxsurface will
+// to ensure that the corresponding dxsurface will
 // be updated.
 mbIsSurfaceDirty = true;
 
diff --git a/chart2/source/view/main/VDataSeries.cxx 
b/chart2/source/view/main/VDataSeries.cxx
index 1b4748f..83c58e4 100644
--- a/chart2/source/view/main/VDataSeries.cxx
+++ b/chart2/source/view/main/VDataSeries.cxx
@@ -117,7 +117,7 @@ void lcl_clearIfNoValuesButTextIsContained( VDataSequence& 
rData, const uno::Ref
 if( !::rtl::math::isNan( rData.Doubles[i] ) )
 return;
 }
-//no double value is countained
+//no double value is contained
 //is there any text?
 uno::Sequence< OUString > aStrings( DataSequenceToStringSequence( 
xDataSequence ) );
 sal_Int32 nTextCount = aStrings.getLength();
diff --git a/dbaccess/source/core/dataaccess/ModelImpl.hxx 
b/dbaccess/source/core/dataaccess/ModelImpl.hxx
index ca3003e..aca2f56 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.hxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.hxx
@@ -484,7 +484,7 @@ private:
 css::uno::Reference< css::embed::XStorage >
 impl_switchToStorage_throw( const css::uno::Reference< 
css::embed::XStorage >& _rxNewRootStorage );
 
-/** switches to the given document URL, which denotes the logical URL of 
the document, not necessariy the
+/** switches to the given document URL, which denotes the logical URL of 
the document, not necessarily the
 URL where the doc was loaded/recovered from
 */
 voidimpl_switchToLogicalURL(
diff --git a/framework/inc/jobs/jobresult.hxx b/framework/inc/jobs/jobresult.hxx
index c4d515b..ef4c7cf 100644
--- a/framework/inc/jobs/jobresult.hxx
+++ b/framework/inc/jobs/jobresult.hxx
@@ -32,7 +32,7 @@ namespace framework{
 
 /**
 @short  represent a result of a finished job execution
-@descr  Such result instance transport all neccessarry
+@descr  Such result instance transport all necessary
 data from the code place where the job was finished
 to the outside code, where e.g. listener must be notified.
  */
diff --git a/framework/source/inc/loadenv/loadenvexception.hxx 
b/framework/source/inc/loadenv/loadenvexception.hxx
index ed7dda9..81dba45 100644
--- a/framework/source/inc/loadenv/loadenvexception.hxx
+++ b/framework/source/inc/loadenv/loadenvexception.hxx
@@ -46,7 +46,7 @@ class LoadEnvException
 ID_UNSUPPORTED_CONTENT,
 
 /** @short  It was not possible to get access to global filter 
configuration.
-@descr  Might som neccsessary services could not be created. */
+@descr  Might

[Libreoffice-commits] core.git: canvas/source chart2/source cui/source dbaccess/source drawinglayer/source editeng/source extensions/source reportdesign/source toolkit/source

2016-02-17 Thread David Ostrovsky 
 canvas/source/opengl/ogl_spritedevicehelper.cxx   |2 ++
 chart2/source/controller/accessibility/AccessibleBase.cxx |1 +
 chart2/source/controller/main/ObjectHierarchy.cxx |1 +
 cui/source/customize/macropg.cxx  |1 +
 dbaccess/source/ui/app/AppControllerDnD.cxx   |1 +
 dbaccess/source/ui/dlg/DbAdminImpl.cxx|1 +
 dbaccess/source/ui/relationdesign/RelationController.cxx  |1 +
 drawinglayer/source/primitive2d/baseprimitive2d.cxx   |1 +
 editeng/source/outliner/paralist.cxx  |2 ++
 extensions/source/propctrlr/eventhandler.cxx  |1 +
 extensions/source/propctrlr/propertycomposer.cxx  |1 +
 reportdesign/source/filter/xml/xmlExport.cxx  |1 +
 reportdesign/source/ui/inspection/GeometryHandler.cxx |1 +
 toolkit/source/helper/formpdfexport.cxx   |1 +
 14 files changed, 16 insertions(+)

New commits:
commit a3c70e760fa4203b7e6692f82d1d8a14214af3da
Author: David Ostrovsky 
Date:   Wed Feb 17 23:28:26 2016 +0100

Fix missing iterator include on MSVC 14.0

Change-Id: I55de612aef52038fd9979426950d4ae4131ca586
Reviewed-on: https://gerrit.libreoffice.org/22448
Tested-by: Jenkins 
Reviewed-by: David Ostrovsky 

diff --git a/canvas/source/opengl/ogl_spritedevicehelper.cxx 
b/canvas/source/opengl/ogl_spritedevicehelper.cxx
index 80812a0..50a4499 100644
--- a/canvas/source/opengl/ogl_spritedevicehelper.cxx
+++ b/canvas/source/opengl/ogl_spritedevicehelper.cxx
@@ -30,6 +30,8 @@
 #include "ogl_canvascustomsprite.hxx"
 #include "ogl_texturecache.hxx"
 
+#include 
+
 using namespace ::com::sun::star;
 
 static void initContext()
diff --git a/chart2/source/controller/accessibility/AccessibleBase.cxx 
b/chart2/source/controller/accessibility/AccessibleBase.cxx
index ad2da37..350a593 100644
--- a/chart2/source/controller/accessibility/AccessibleBase.cxx
+++ b/chart2/source/controller/accessibility/AccessibleBase.cxx
@@ -51,6 +51,7 @@
 #include 
 
 #include 
+#include 
 
 #include "ChartElementFactory.hxx"
 
diff --git a/chart2/source/controller/main/ObjectHierarchy.cxx 
b/chart2/source/controller/main/ObjectHierarchy.cxx
index fb2f37e..d9c82de 100644
--- a/chart2/source/controller/main/ObjectHierarchy.cxx
+++ b/chart2/source/controller/main/ObjectHierarchy.cxx
@@ -34,6 +34,7 @@
 
 #include 
 #include 
+#include 
 
 #include 
 #include 
diff --git a/cui/source/customize/macropg.cxx b/cui/source/customize/macropg.cxx
index 927a2dd..778b513 100644
--- a/cui/source/customize/macropg.cxx
+++ b/cui/source/customize/macropg.cxx
@@ -43,6 +43,7 @@
 #include 
 
 #include 
+#include 
 #include 
 
 using namespace ::com::sun::star;
diff --git a/dbaccess/source/ui/app/AppControllerDnD.cxx 
b/dbaccess/source/ui/app/AppControllerDnD.cxx
index cc71d6b..151ad46 100644
--- a/dbaccess/source/ui/app/AppControllerDnD.cxx
+++ b/dbaccess/source/ui/app/AppControllerDnD.cxx
@@ -68,6 +68,7 @@
 #include "dbexchange.hxx"
 #include "UITools.hxx"
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/dbaccess/source/ui/dlg/DbAdminImpl.cxx 
b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
index 91ae318..7d9a004 100644
--- a/dbaccess/source/ui/dlg/DbAdminImpl.cxx
+++ b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
@@ -69,6 +69,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 
diff --git a/dbaccess/source/ui/relationdesign/RelationController.cxx 
b/dbaccess/source/ui/relationdesign/RelationController.cxx
index 29a71be..c5e17da 100644
--- a/dbaccess/source/ui/relationdesign/RelationController.cxx
+++ b/dbaccess/source/ui/relationdesign/RelationController.cxx
@@ -19,6 +19,7 @@
 
 #include 
 
+#include 
 #include 
 
 #include "dbu_reghelper.hxx"
diff --git a/drawinglayer/source/primitive2d/baseprimitive2d.cxx 
b/drawinglayer/source/primitive2d/baseprimitive2d.cxx
index 382cdbb..6f89cf3 100644
--- a/drawinglayer/source/primitive2d/baseprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/baseprimitive2d.cxx
@@ -19,6 +19,7 @@
 
 #include 
 
+#include 
 #include 
 
 #include 
diff --git a/editeng/source/outliner/paralist.cxx 
b/editeng/source/outliner/paralist.cxx
index 5c0a2c2..3912f58 100644
--- a/editeng/source/outliner/paralist.cxx
+++ b/editeng/source/outliner/paralist.cxx
@@ -26,6 +26,8 @@
 #include 
 #include 
 
+#include 
+
 ParagraphData::ParagraphData()
 : nDepth( -1 )
 , mnNumberingStartValue( -1 )
diff --git a/extensions/source/propctrlr/eventhandler.cxx 
b/extensions/source/propctrlr/eventhandler.cxx
index d2ac643..496ccd0 100644
--- a/extensions/source/propctrlr/eventhandler.cxx
+++ b/extensions/source/propctrlr/eventhandler.cxx
@@ -69,6 +69,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 extern "C" void SAL_CALL createRegistryInfo_EventHandler()
diff --git a/extensions/source/propctrlr/propertycomposer.cxx

[Libreoffice-commits] core.git: canvas/source chart2/source dbaccess/source extensions/source forms/source

2015-08-11 Thread Daniel Robertson 
 canvas/source/factory/cf_service.cxx  |   20 
+-
 chart2/source/controller/accessibility/AccessibleBase.cxx |4 +-
 chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx |4 +-
 chart2/source/controller/dialogs/DialogModel.cxx  |2 -
 chart2/source/inc/CommonFunctors.hxx  |2 -
 chart2/source/inc/ContainerHelper.hxx |7 +--
 chart2/source/model/template/ChartTypeManager.cxx |4 +-
 dbaccess/source/core/dataaccess/documentevents.cxx|4 +-
 dbaccess/source/ui/browser/genericcontroller.cxx  |4 +-
 dbaccess/source/ui/dlg/DbAdminImpl.cxx|4 +-
 extensions/source/propctrlr/eformshelper.cxx  |3 +
 extensions/source/propctrlr/eventhandler.cxx  |3 +
 extensions/source/propctrlr/genericpropertyhandler.cxx|4 +-
 forms/source/xforms/convert.cxx   |6 +--
 forms/source/xforms/datatyperepository.cxx|4 +-
 15 files changed, 38 insertions(+), 37 deletions(-)

New commits:
commit 87130a4e18347d055331ff53da3b1a79548ff24a
Author: Daniel Robertson danlrobertso...@gmail.com
Date:   Tue Aug 11 14:51:35 2015 -0400

tdf#92459 Cleanup unclear lambdas

Replace lambdas used to select the first/second member of a pair with
the new simplified select1st/2nd from o3tl/compat_functional. There
should be no side effects due to this change.

Change-Id: I17f37796e0c4defe96a10aa491d192adb9eebb89
Reviewed-on: https://gerrit.libreoffice.org/17656
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Thorsten Behrens thorsten.behr...@cib.de

diff --git a/canvas/source/factory/cf_service.cxx 
b/canvas/source/factory/cf_service.cxx
index 677cf42..9d1d2b2 100644
--- a/canvas/source/factory/cf_service.cxx
+++ b/canvas/source/factory/cf_service.cxx
@@ -38,7 +38,7 @@
 #include cppuhelper/supportsservice.hxx
 #include osl/mutex.hxx
 #include osl/process.h
-
+#include o3tl/compat_functional.hxx
 
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
@@ -52,8 +52,10 @@ class CanvasFactory
   lang::XMultiComponentFactory,
   lang::XMultiServiceFactory 
 {
-typedef std::vectorstd::pairOUString, SequenceOUString   AvailVector;
-typedef std::vectorstd::pairOUString, OUString CacheVector;
+typedef std::pair OUString, Sequence OUString   AvailPair;
+typedef std::pair OUString, OUString  CachePair;
+typedef std::vector AvailPair AvailVector;
+typedef std::vector CachePair CacheVector;
 
 
 mutable ::osl::Mutex  m_mutex;
@@ -238,9 +240,7 @@ SequenceOUString CanvasFactory::getAvailableServiceNames()
 std::transform(m_aAvailableImplementations.begin(),
m_aAvailableImplementations.end(),
aServiceNames.getArray(),
-   [](std::pairOUString, SequenceOUString  const ap)
-   { return ap.first; }
-);
+   o3tl::select1st AvailPair ());
 return aServiceNames;
 }
 
@@ -326,7 +326,7 @@ ReferenceXInterface CanvasFactory::lookupAndUse(
 if( (aMatch=std::find_if(
 m_aCachedImplementations.begin(),
 aEnd,
-[serviceName](std::pairOUString, OUString const cp)
+[serviceName](CachePair const cp)
 { return serviceName.equals(cp.first); }
 )) != aEnd) {
 ReferenceXInterface xCanvas( use( aMatch-second, args, xContext ) );
@@ -340,7 +340,7 @@ ReferenceXInterface CanvasFactory::lookupAndUse(
 if( (aAvailImplsMatch=std::find_if(
 m_aAvailableImplementations.begin(),
 aAvailEnd,
-[serviceName](std::pairOUString, SequenceOUString  
const ap)
+[serviceName](AvailPair const ap)
 { return serviceName.equals(ap.first); }
 )) == aAvailEnd ) {
 return ReferenceXInterface();
@@ -351,7 +351,7 @@ ReferenceXInterface CanvasFactory::lookupAndUse(
 if( (aAAImplsMatch=std::find_if(
 m_aAAImplementations.begin(),
 aAAEnd,
-[serviceName](std::pairOUString, SequenceOUString  
const ap)
+[serviceName](AvailPair const ap)
 { return serviceName.equals(ap.first); }
 )) == aAAEnd) {
 return ReferenceXInterface();
@@ -362,7 +362,7 @@ ReferenceXInterface CanvasFactory::lookupAndUse(
 if( (aAccelImplsMatch=std::find_if(
 m_aAcceleratedImplementations.begin(),
 aAccelEnd,
-

[Libreoffice-commits] core.git: canvas/source chart2/source cppuhelper/source cppu/source cui/source dbaccess/source desktop/test filter/source framework/inc framework/source include/cppuhelper includ

2015-02-18 Thread Julien Nabet 
 canvas/source/directx/dx_9rm.cxx   
 |2 +-
 canvas/source/directx/dx_vcltools.cxx  
 |6 +++---
 chart2/source/inc/NameContainer.hxx
 |2 +-
 cppu/source/typelib/typelib.cxx
 |8 
 cppuhelper/source/propshlp.cxx 
 |6 +++---
 cui/source/dialogs/cuihyperdlg.cxx 
 |4 ++--
 cui/source/dialogs/hldocntp.cxx
 |2 +-
 cui/source/dialogs/hldoctp.cxx 
 |2 +-
 cui/source/dialogs/hlmailtp.cxx
 |2 +-
 cui/source/dialogs/hlmarkwn.cxx
 |2 +-
 dbaccess/source/ui/inc/RelationDlg.hxx 
 |4 ++--
 dbaccess/source/ui/inc/ScrollHelper.hxx
 |2 +-
 dbaccess/source/ui/inc/UITools.hxx 
 |2 +-
 
desktop/test/deployment/options/handler/com/sun/star/comp/extensionoptions/OptionsEventHandler.java
 |2 +-
 filter/source/pdf/pdfexport.cxx
 |2 +-
 framework/inc/macros/xinterface.hxx
 |   10 +-
 framework/source/fwi/uielement/constitemcontainer.cxx  
 |6 +++---
 include/cppuhelper/propshlp.hxx
 |4 ++--
 include/rtl/strbuf.hxx 
 |2 +-
 include/rtl/ustrbuf.hxx
 |2 +-
 include/sfx2/sfxuno.hxx
 |2 +-
 include/svx/sdr/overlay/overlayobject.hxx  
 |2 +-
 reportbuilder/java/org/libreoffice/report/InputRepository.java 
 |2 +-
 reportbuilder/java/org/libreoffice/report/OutputRepository.java
 |2 +-
 sc/source/ui/view/printfun.cxx 
 |4 ++--
 sd/source/ui/slidesorter/inc/cache/SlsCacheContext.hxx 
 |2 +-
 stoc/source/javaloader/javaloader.cxx  
 |2 +-
 svx/sdi/fmslots.sdi
 |2 +-
 svx/source/fmcomp/gridctrl.cxx 
 |2 +-
 sw/inc/tox.hxx 
 |2 +-
 sw/source/core/inc/ptqueue.hxx 
 |2 +-
 sw/source/uibase/app/docsh2.cxx
 |2 +-
 sw/source/uibase/uiview/view2.cxx  
 |2 +-
 toolkit/source/awt/vclxtoolkit.cxx 
 |2 +-
 unotools/source/config/fontoptions.cxx 
 |2 +-
 unotools/source/config/localisationoptions.cxx 
 |2 +-
 36 files changed, 53 insertions(+), 53 deletions(-)

New commits:
commit 48f0a5ed3501e0b0a55cc71f85b4d1aee5a9f4ed
Author: Julien Nabet serval2...@yahoo.fr
Date:   Wed Feb 18 21:58:05 2015 +0100

Typos

Change-Id: I845a85e1aad4a0708f2b43f7d94606b4b5513ee4

diff --git a/canvas/source/directx/dx_9rm.cxx b/canvas/source/directx/dx_9rm.cxx
index e9fd666..b9ee883 100644
--- a/canvas/source/directx/dx_9rm.cxx
+++ b/canvas/source/directx/dx_9rm.cxx
@@ -153,7 +153,7 @@ namespace dxcanvas
 COMReferenceIDirect3DTexture9 getTexture() const;
 
 private:
-/// Guard local methods against concurrent acces to RenderModule
+/// Guard local methods against concurrent access to RenderModule
 class ImplRenderModuleGuard : private ::boost::noncopyable
 {
 public:
diff --git a/canvas/source/directx/dx_vcltools.cxx

[Libreoffice-commits] core.git: canvas/source chart2/source cui/source dbaccess/source extensions/source reportdesign/source sc/source sd/source svtools/source svx/source sw/source vcl/inc vcl/source

2013-03-13 Thread Michael Stahl 
 canvas/source/vcl/spritecanvashelper.cxx  |2 +-
 chart2/source/controller/dialogs/DataBrowser.cxx  |2 +-
 cui/source/dialogs/about.cxx  |2 +-
 cui/source/options/connpooloptions.cxx|2 +-
 dbaccess/source/ui/control/RelationControl.cxx|4 +++-
 dbaccess/source/ui/control/TableGrantCtrl.cxx |4 +++-
 dbaccess/source/ui/dlg/indexfieldscontrol.cxx |2 +-
 dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx |2 +-
 dbaccess/source/ui/tabledesign/TEditControl.cxx   |2 +-
 extensions/source/scanner/grid.cxx|2 +-
 reportdesign/source/ui/dlg/GroupsSorting.cxx  |2 +-
 sc/source/ui/view/gridwin.cxx |2 +-
 sc/source/ui/view/gridwin4.cxx|6 +++---
 sc/source/ui/view/olinewin.cxx|4 ++--
 sc/source/ui/view/printfun.cxx|5 +++--
 sd/source/ui/docshell/docshel2.cxx|2 +-
 sd/source/ui/view/DocumentRenderer.cxx|3 ++-
 sd/source/ui/view/clview.cxx  |2 +-
 svtools/source/brwbox/editbrowsebox.cxx   |2 +-
 svtools/source/contnr/imivctl1.cxx|8 
 svtools/source/graphic/grfmgr.cxx |4 ++--
 svtools/source/toolpanel/paneltabbar.cxx  |7 +--
 svx/source/dialog/framelink.cxx   |4 ++--
 svx/source/gallery2/galobj.cxx|4 +++-
 svx/source/svdraw/svdibrow.cxx|2 +-
 sw/source/core/doc/notxtfrm.cxx   |2 +-
 sw/source/core/layout/paintfrm.cxx|4 ++--
 sw/source/ui/envelp/labfmt.cxx|2 +-
 vcl/inc/vcl/region.hxx|   12 ++--
 vcl/source/control/spinbtn.cxx|4 ++--
 vcl/source/control/spinfld.cxx|6 +++---
 vcl/source/filter/sgvmain.cxx |8 
 vcl/source/gdi/gdimtf.cxx |4 +++-
 vcl/source/gdi/outdev4.cxx|2 +-
 vcl/source/gdi/outdev6.cxx|2 +-
 vcl/source/gdi/outdevnative.cxx   |2 +-
 vcl/source/gdi/region.cxx |4 ++--
 vcl/source/window/menu.cxx|2 +-
 38 files changed, 74 insertions(+), 61 deletions(-)

New commits:
commit 38d3e115c159f19f22de73ece1abe609d75a041e
Author: Michael Stahl mst...@redhat.com
Date:   Wed Mar 13 22:28:52 2013 +0100

vcl: make Region ctors explicit to prevent overloading desasters

Change-Id: Id36d125b4940418833bec31a4710d6cd545629e0

diff --git a/canvas/source/vcl/spritecanvashelper.cxx 
b/canvas/source/vcl/spritecanvashelper.cxx
index d9a77f2..c627950 100644
--- a/canvas/source/vcl/spritecanvashelper.cxx
+++ b/canvas/source/vcl/spritecanvashelper.cxx
@@ -88,7 +88,7 @@ namespace vclcanvas
 // wouldn't save much render time, and b) will clutter
 // scrolled sprite content outside this area)
 rOutDev.EnableMapMode( sal_False );
-rOutDev.SetClipRegion( rRequestedArea );
+rOutDev.SetClipRegion(Region(rRequestedArea));
 
 // repaint affected sprite directly to output device (at
 // the actual screen output position)
diff --git a/chart2/source/controller/dialogs/DataBrowser.cxx 
b/chart2/source/controller/dialogs/DataBrowser.cxx
index 26eab78..a291c55 100644
--- a/chart2/source/controller/dialogs/DataBrowser.cxx
+++ b/chart2/source/controller/dialogs/DataBrowser.cxx
@@ -1007,7 +1007,7 @@ void DataBrowser::PaintCell(
 // clipping
 if( aPos.X()  rRect.Right() || aPos.X() + TxtSize.Width()  rRect.Right() 
||
 aPos.Y()  rRect.Top() || aPos.Y() + TxtSize.Height()  rRect.Bottom())
-rDev.SetClipRegion( rRect );
+rDev.SetClipRegion(Region(rRect));
 
 // allow for a disabled control ...
 sal_Bool bEnabled = IsEnabled();
diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx
index 9c247d3..e904d0f 100644
--- a/cui/source/dialogs/about.cxx
+++ b/cui/source/dialogs/about.cxx
@@ -429,7 +429,7 @@ void AboutDialog::MoveControl(Control rControl, sal_Int32 
X, sal_Int32 Y)
 
 void AboutDialog::Paint( const Rectangle rRect )
 {
-SetClipRegion( rRect );
+SetClipRegion(Region(rRect));
 Point aPos ( rRect.GetWidth() - aBackgroundBitmap.GetSizePixel().Width(), 
rRect.GetHeight() - aBackgroundBitmap.GetSizePixel().Height() );
 DrawBitmapEx( aPos, aBackgroundBitmap );
 }
diff --git a/cui/source/options/connpooloptions.cxx 
b/cui/source/options/connpooloptions.cxx
index 381a8f4..0745f8f 100644
--- a/cui/source/options/connpooloptions.cxx
+++ b/cui/source/options/connpooloptions.cxx
@@ -294,7 +294,7 @@