[Libreoffice-commits] core.git: dbaccess/source drawinglayer/source editeng/source extensions/source filter/source i18npool/source include/editeng lotuswordpro/source oox/source

[Libreoffice Gerrit user]

 dbaccess/source/core/api/RowSet.cxx   |2 
 dbaccess/source/core/dataaccess/documentcontainer.cxx |3 -
 dbaccess/source/ui/misc/WCopyTable.cxx|   15 ---
 dbaccess/source/ui/querydesign/QueryDesignView.cxx|2 
 drawinglayer/source/tools/emfphelperdata.cxx  |   28 ++---
 editeng/source/misc/svxacorr.cxx  |   17 
 extensions/source/propctrlr/newdatatype.cxx   |2 
 filter/source/graphicfilter/egif/giflzwc.cxx  |3 -
 filter/source/graphicfilter/eps/eps.cxx   |3 -
 filter/source/graphicfilter/etiff/etiff.cxx   |3 -
 filter/source/graphicfilter/icgm/class5.cxx   |   21 +
 filter/source/graphicfilter/idxf/dxf2mtf.cxx  |   12 +++--
 filter/source/msfilter/mstoolbar.cxx  |5 +-
 filter/source/svg/svgfontexport.cxx   |3 -
 filter/source/svg/svgwriter.cxx   |   13 +++---
 i18npool/source/calendar/calendar_gregorian.cxx   |   38 +-
 i18npool/source/collator/collatorImpl.cxx |3 -
 include/editeng/boxitem.hxx   |8 ++-
 lotuswordpro/source/filter/lwptools.cxx   |2 
 oox/source/drawingml/color.cxx|2 
 oox/source/dump/dumperbase.cxx|4 -
 oox/source/vml/vmlformatting.cxx  |2 
 22 files changed, 113 insertions(+), 78 deletions(-)

New commits:
commit 890afecb45bfcd2e53599974fbcf61fffd8f8a7b
Author: Noel Grandin 
AuthorDate: Fri Nov 16 14:05:25 2018 +0200
Commit: Noel Grandin 
CommitDate: Fri Nov 16 14:31:38 2018 +0100

loplugin:buriedassign in dbaccess..oox

Change-Id: Ic0ca695a1d9d05418213475a68e233953136cc8e
Reviewed-on: https://gerrit.libreoffice.org/63468
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/core/api/RowSet.cxx 
b/dbaccess/source/core/api/RowSet.cxx
index 8d6d7c60e798..a8d1a5721274 100644
--- a/dbaccess/source/core/api/RowSet.cxx
+++ b/dbaccess/source/core/api/RowSet.cxx
@@ -1865,7 +1865,7 @@ void 
ORowSet::execute_NoApprove_NoNewConn(ResettableMutexGuard& _rClearForNotifi
 sal_Int32 searchIndex=1;
 while(aColumnMap.find(sAlias) != aColumnMap.end())
 {
-(sAlias = sName) += 
OUString::number(searchIndex++);
+sAlias = sName + 
OUString::number(searchIndex++);
 }
 sName = sAlias;
 }
diff --git a/dbaccess/source/core/dataaccess/documentcontainer.cxx 
b/dbaccess/source/core/dataaccess/documentcontainer.cxx
index d1a40470d067..d422506307fa 100644
--- a/dbaccess/source/core/dataaccess/documentcontainer.cxx
+++ b/dbaccess/source/core/dataaccess/documentcontainer.cxx
@@ -465,7 +465,8 @@ namespace
 bool bRet = _xNameContainer->hasByName(sName);
 if ( bRet )
 {
-_rRet = _xNameContainer->getByName(_sSimpleName = sName);
+_sSimpleName = sName;
+_rRet = _xNameContainer->getByName(_sSimpleName);
 while ( nIndex != -1 && bRet )
 {
 sName = _sName.getToken(0,'/',nIndex);
diff --git a/dbaccess/source/ui/misc/WCopyTable.cxx 
b/dbaccess/source/ui/misc/WCopyTable.cxx
index 0660be262c9b..795e7e6a7eab 100644
--- a/dbaccess/source/ui/misc/WCopyTable.cxx
+++ b/dbaccess/source/ui/misc/WCopyTable.cxx
@@ -628,11 +628,16 @@ void OCopyTableWizard::construct()
 {
 SetSizePixel(Size(700, 350));
 
-AddButton( m_pbHelp = VclPtr::Create(this, WB_TABSTOP) );
-AddButton( m_pbCancel = VclPtr::Create(this, WB_TABSTOP) );
-AddButton( m_pbPrev = VclPtr::Create(this, WB_TABSTOP));
-AddButton( m_pbNext = VclPtr::Create(this, WB_TABSTOP));
-AddButton( m_pbFinish = VclPtr::Create(this, WB_TABSTOP));
+m_pbHelp = VclPtr::Create(this, WB_TABSTOP);
+AddButton(m_pbHelp);
+m_pbCancel = VclPtr::Create(this, WB_TABSTOP);
+AddButton(m_pbCancel);
+m_pbPrev = VclPtr::Create(this, WB_TABSTOP);
+AddButton(m_pbPrev);
+m_pbNext = VclPtr::Create(this, WB_TABSTOP);
+AddButton(m_pbNext);
+m_pbFinish = VclPtr::Create(this, WB_TABSTOP);
+AddButton(m_pbFinish);
 
 m_pbHelp->SetSizePixel( LogicToPixel(Size(50, 14), 
MapMode(MapUnit::MapAppFont)) );
 m_pbCancel->SetSizePixel( LogicToPixel(Size(50, 14), 
MapMode(MapUnit::MapAppFont)) );
diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx 
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 046e851183c0..558cf3ee1315 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -334,7 +334,7 @@ namespace
 bBrace = true;
 _rJoin = _rJoin.replaceAt(_rJoin.getLength()-1,1,OUString(' 

[Libreoffice-commits] core.git: dbaccess/source drawinglayer/source filter/source formula/source idlc/source idl/source l10ntools/source libreofficekit/qa lotuswordpro/source

[Libreoffice Gerrit user]

 dbaccess/source/ui/app/AppView.cxx   |7 -
 dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx|7 -
 drawinglayer/source/dumper/XShapeDumper.cxx  |9 -
 filter/source/graphicfilter/eps/eps.cxx  |7 -
 filter/source/msfilter/escherex.cxx  |   40 +++
 filter/source/msfilter/msdffimp.cxx  |   79 +++
 formula/source/core/api/FormulaCompiler.cxx  |7 -
 idl/source/objects/basobj.cxx|9 -
 idlc/source/astscope.cxx |7 -
 l10ntools/source/xrmmerge.cxx|8 -
 libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx |   13 --
 lotuswordpro/source/filter/lwpfribptr.cxx|   17 +--
 lotuswordpro/source/filter/lwpparastyle.cxx  |   30 ++---
 13 files changed, 98 insertions(+), 142 deletions(-)

New commits:
commit 004cc81168ce4e9f9b2f8fddf3361f8c23323673
Author: Noel Grandin 
AuthorDate: Tue Nov 6 10:19:19 2018 +0200
Commit: Noel Grandin 
CommitDate: Tue Nov 6 11:53:58 2018 +0100

loplugin:collapseif in dbaccess..lotuswordpro

Change-Id: Ia2a0d25c3833dfde0cd28337361f3cbd2aa29662
Reviewed-on: https://gerrit.libreoffice.org/62934
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/ui/app/AppView.cxx 
b/dbaccess/source/ui/app/AppView.cxx
index 8a2e9d1419e3..9ece79f6830a 100644
--- a/dbaccess/source/ui/app/AppView.cxx
+++ b/dbaccess/source/ui/app/AppView.cxx
@@ -114,11 +114,8 @@ void OAppBorderWindow::Resize()
 if ( m_pPanel )
 {
 OApplicationSwapWindow* pSwap = getPanel();
-if ( pSwap )
-{
-if ( pSwap->GetEntryCount() != 0 )
-nX = pSwap->GetBoundingBox( pSwap->GetEntry(0) ).GetWidth() + 
aFLSize.Height();
-}
+if ( pSwap && pSwap->GetEntryCount() != 0 )
+nX = pSwap->GetBoundingBox( pSwap->GetEntry(0) ).GetWidth() + 
aFLSize.Height();
 nX = std::max(m_pPanel->GetWidthPixel() ,nX);
 m_pPanel->SetPosSizePixel(Point(0,0),Size(nX,nOutputHeight));
 }
diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx 
b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
index 0c7e6c1b0d6e..4863cdf46b22 100644
--- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
+++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
@@ -2047,11 +2047,8 @@ long OSelectionBrowseBox::GetRealRow(long nRowId) const
 const long nCount = m_bVisibleRow.size();
 for(i=0;i < nCount; ++i)
 {
-if(m_bVisibleRow[i])
-{
-if(nErg++ == nRowId)
-break;
-}
+if(m_bVisibleRow[i] && nErg++ == nRowId)
+break;
 }
 OSL_ENSURE(nErg <= long(m_bVisibleRow.size()),"nErg cannot be greater than 
BROW_ROW_CNT!");
 return i;
diff --git a/drawinglayer/source/dumper/XShapeDumper.cxx 
b/drawinglayer/source/dumper/XShapeDumper.cxx
index e610d9b2d77d..1a97e57f6642 100644
--- a/drawinglayer/source/dumper/XShapeDumper.cxx
+++ b/drawinglayer/source/dumper/XShapeDumper.cxx
@@ -1812,13 +1812,10 @@ void dumpXShape(const uno::Reference< drawing::XShape 
>& xShape, xmlTextWriterPt
 if(xInfo->hasPropertyByName("Name"))
 {
 uno::Any aAny = xPropSet->getPropertyValue("Name");
-if (aAny >>= aName)
+if ((aAny >>= aName) && !aName.isEmpty())
 {
-if (!aName.isEmpty())
-{
-xmlTextWriterWriteFormatAttribute( xmlWriter, 
BAD_CAST("name"), "%s", OUStringToOString(aName, 
RTL_TEXTENCODING_UTF8).getStr());
-m_bNameDumped = true;
-}
+xmlTextWriterWriteFormatAttribute( xmlWriter, BAD_CAST("name"), 
"%s", OUStringToOString(aName, RTL_TEXTENCODING_UTF8).getStr());
+m_bNameDumped = true;
 }
 }
 
diff --git a/filter/source/graphicfilter/eps/eps.cxx 
b/filter/source/graphicfilter/eps/eps.cxx
index e131091b9ba1..c6a14bfeab0e 100644
--- a/filter/source/graphicfilter/eps/eps.cxx
+++ b/filter/source/graphicfilter/eps/eps.cxx
@@ -1672,11 +1672,8 @@ void PSWriter::ImplBmp( Bitmap const * pBitmap, Bitmap 
const * pMaskBitmap, cons
 bDoTrans = true;
 while (true)
 {
-if ( mnLevel == 1 )
-{
-if ( nHeight > 10 )
-nHeight = 8;
-}
+if ( mnLevel == 1 && nHeight > 10 )
+nHeight = 8;
 aRect = tools::Rectangle( Point( 0, nHeightOrg - nHeightLeft 
), Size( nWidth, nHeight ) );
 aRegion = vcl::Region( pMaskBitmap->CreateRegion( COL_BLACK, 
aRect ) );
 
diff --git a/filter/source/msfilter/escherex.cxx 
b/filter/source/msfilter/escherex.cxx
index c158129fb6a5..ecffc34b4cb0 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ 

[Libreoffice-commits] core.git: dbaccess/source drawinglayer/source filter/qa include/vcl offapi/com sc/source sw/source ucb/source writerfilter/source

[Andrea Gelmini]

 dbaccess/source/ui/dlg/DriverSettings.hxx   |2 +-
 drawinglayer/source/primitive2d/groupprimitive2d.cxx|2 +-
 drawinglayer/source/primitive3d/groupprimitive3d.cxx|2 +-
 filter/qa/complex/filter/detection/typeDetection/TypeDetection.java |2 +-
 include/vcl/pdfextoutdevdata.hxx|2 +-
 include/vcl/pdfwriter.hxx   |2 +-
 offapi/com/sun/star/ucb/Content.idl |4 ++--
 sc/source/ui/view/editsh.cxx|2 +-
 sw/source/core/fields/fldbas.cxx|2 +-
 sw/source/ui/frmdlg/frmpage.cxx |4 ++--
 ucb/source/core/ucb.cxx |4 ++--
 ucb/source/ucp/webdav/ContentProperties.hxx |4 ++--
 writerfilter/source/dmapper/FieldTypes.hxx  |2 +-
 13 files changed, 17 insertions(+), 17 deletions(-)

New commits:
commit eae9bf0d25f34e0ff9d54191ea8732a8bfecb969
Author: Andrea Gelmini 
Date:   Sun Jan 14 23:42:28 2018 +0100

Fix typos

Change-Id: Id3d1a07922d4ca05e3bbf61d4b5797a30fc5b23a
Reviewed-on: https://gerrit.libreoffice.org/47872
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/dbaccess/source/ui/dlg/DriverSettings.hxx 
b/dbaccess/source/ui/dlg/DriverSettings.hxx
index 20aac533816c..1259f3a987f9 100644
--- a/dbaccess/source/ui/dlg/DriverSettings.hxx
+++ b/dbaccess/source/ui/dlg/DriverSettings.hxx
@@ -33,7 +33,7 @@ namespace dbaui
 {
 public:
 
-/** filles the IDs of the settings which are reflected in indirect 
data source properties
+/** fills the IDs of the settings which are reflected in indirect data 
source properties
 (aka properties in the css.sdb.DataSource.Info sequence)
 
 @param  _eType
diff --git a/drawinglayer/source/primitive2d/groupprimitive2d.cxx 
b/drawinglayer/source/primitive2d/groupprimitive2d.cxx
index 5a646ec3ce39..7d7d43d8fe93 100644
--- a/drawinglayer/source/primitive2d/groupprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/groupprimitive2d.cxx
@@ -35,7 +35,7 @@ namespace drawinglayer
 }
 
 /** The compare opertator uses the Sequence::==operator, so only 
checking if
-the rererences are equal. All non-equal references are interpreted 
as
+the references are equal. All non-equal references are interpreted 
as
 non-equal.
  */
 bool GroupPrimitive2D::operator==( const BasePrimitive2D& rPrimitive ) 
const
diff --git a/drawinglayer/source/primitive3d/groupprimitive3d.cxx 
b/drawinglayer/source/primitive3d/groupprimitive3d.cxx
index 710b79c412cd..3339a6b412da 100644
--- a/drawinglayer/source/primitive3d/groupprimitive3d.cxx
+++ b/drawinglayer/source/primitive3d/groupprimitive3d.cxx
@@ -35,7 +35,7 @@ namespace drawinglayer
 }
 
 /** The compare opertator uses the Sequence::==operator, so only 
checking if
-the rererences are equal. All non-equal references are interpreted 
as
+the references are equal. All non-equal references are interpreted 
as
 non-equal.
  */
 bool GroupPrimitive3D::operator==( const BasePrimitive3D& rPrimitive ) 
const
diff --git 
a/filter/qa/complex/filter/detection/typeDetection/TypeDetection.java 
b/filter/qa/complex/filter/detection/typeDetection/TypeDetection.java
index 44a5d2de9ad0..b3e6c914b8af 100644
--- a/filter/qa/complex/filter/detection/typeDetection/TypeDetection.java
+++ b/filter/qa/complex/filter/detection/typeDetection/TypeDetection.java
@@ -299,7 +299,7 @@ public class TypeDetection extends ComplexTestCase {
"'\n\texpected type: '" + fileType + "'",fileTypeOK 
,ContinueWithTest.YES);
 }
 
-/** Filles a MediaDescriptor with a XInputStream of the test
+/** Fills a MediaDescriptor with a XInputStream of the test
  * file given by URL.
  * Then the MediaDescriptor was used as parameter for TypeDetection.
  * The TypeDetection must return expected type
diff --git a/include/vcl/pdfextoutdevdata.hxx b/include/vcl/pdfextoutdevdata.hxx
index 6dc5165d99a5..dad86845a0c8 100644
--- a/include/vcl/pdfextoutdevdata.hxx
+++ b/include/vcl/pdfextoutdevdata.hxx
@@ -374,7 +374,7 @@ public:
 For different purposes it may be useful to paint a structure element's
 content discontinously. In that case an already existing structure element
 can be appended to by using SetCurrentStructureElement. The
-refenrenced structure element becomes the current structure element with
+referenced structure element becomes the current structure element with
 all consequences: all following structure elements are appended as children
 of the current 

[Libreoffice-commits] core.git: dbaccess/source drawinglayer/source dtrans/source framework/source include/basic include/salhelper jurt/com odk/examples sc/source sd/source sfx2/source sw/source UnoCo

[Andrea Gelmini]

 UnoControls/source/controls/progressbar.cxx   
|2 +-
 dbaccess/source/core/api/RowSetBase.cxx   
|4 ++--
 drawinglayer/source/processor2d/vclprocessor2d.cxx
|2 +-
 dtrans/source/win32/dtobj/Fetc.hxx
|2 +-
 dtrans/source/win32/dtobj/XTDataObject.hxx
|2 +-
 dtrans/source/win32/workbench/XTDo.hxx
|2 +-
 framework/source/dispatch/closedispatcher.cxx 
|2 +-
 include/basic/sbuno.hxx   
|2 +-
 include/salhelper/singletonref.hxx
|2 +-
 jurt/com/sun/star/comp/bridgefactory/BridgeFactory.java   
|2 +-
 odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/FunctionHelper.java 
|2 +-
 odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/ViewContainer.java  
|4 ++--
 sc/source/core/data/global.cxx
|2 +-
 sc/source/ui/undo/undocell.cxx
|2 +-
 sd/source/ui/inc/framework/Pane.hxx   
|2 +-
 sfx2/source/dialog/basedlgs.cxx   
|2 +-
 sw/source/core/doc/docbm.cxx  
|2 +-
 sw/source/core/layout/trvlfrm.cxx 
|2 +-
 vcl/source/gdi/gdimtf.cxx 
|2 +-
 vcl/source/gdi/pdfwriter_impl.cxx 
|2 +-
 vcl/win/window/salframe.cxx   
|2 +-
 xmloff/source/text/txtftne.cxx
|2 +-
 22 files changed, 24 insertions(+), 24 deletions(-)

New commits:
commit 8efd39be747c729a7f5b40cbca3e2a93585f9413
Author: Andrea Gelmini 
Date:   Tue Dec 19 00:00:46 2017 +0100

Fix typos

Change-Id: Ibffe19c1dfda9d0f4ba8d2a0761ad1222491007f
Reviewed-on: https://gerrit.libreoffice.org/46599
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/UnoControls/source/controls/progressbar.cxx 
b/UnoControls/source/controls/progressbar.cxx
index d94409e5e337..dc1757a46cf9 100644
--- a/UnoControls/source/controls/progressbar.cxx
+++ b/UnoControls/source/controls/progressbar.cxx
@@ -204,7 +204,7 @@ void SAL_CALL ProgressBar::setRange ( sal_Int32 nMin, 
sal_Int32 nMax )
 
 // save impossible cases
 // This method is only defined for valid values
-// If you ignore this, the release version wil produce an error "division 
by zero" in "ProgressBar::setValue()"!
+// If you ignore this, the release version will produce an error "division 
by zero" in "ProgressBar::setValue()"!
 DBG_ASSERT ( ( nMin != nMax ) , "ProgressBar::setRange()\nValues for MIN 
and MAX are the same. This is not allowed!\n" );
 
 // Ready for multithreading
diff --git a/dbaccess/source/core/api/RowSetBase.cxx 
b/dbaccess/source/core/api/RowSetBase.cxx
index 5d2b11e20a6e..48226e2d61c8 100644
--- a/dbaccess/source/core/api/RowSetBase.cxx
+++ b/dbaccess/source/core/api/RowSetBase.cxx
@@ -1374,7 +1374,7 @@ ORowSetNotifier::ORowSetNotifier( ORowSetBase* _pRowSet )
 ,m_bWasModified( false )
 {
 
-OSL_ENSURE( m_pRowSet, "ORowSetNotifier::ORowSetNotifier: invalid row set. 
This wil crash." );
+OSL_ENSURE( m_pRowSet, "ORowSetNotifier::ORowSetNotifier: invalid row set. 
This will crash." );
 
 // remember the "inserted" and "modified" state for later firing
 m_bWasNew   = m_pRowSet->isNew( ORowSetBase::GrantNotifierAccess() );
@@ -1392,7 +1392,7 @@ ORowSetNotifier::ORowSetNotifier( ORowSetBase* 
_pRowSet,const ORowSetValueVector
 ,m_bWasModified( false )
 {
 
-OSL_ENSURE( m_pRowSet, "ORowSetNotifier::ORowSetNotifier: invalid row set. 
This wil crash." );
+OSL_ENSURE( m_pRowSet, "ORowSetNotifier::ORowSetNotifier: invalid row set. 
This will crash." );
 m_pImpl->aRow = i_aRow; // yes, create a copy to store the old values
 }
 
diff --git a/drawinglayer/source/processor2d/vclprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclprocessor2d.cxx
index e1cf42b0f42c..0240cd988dad 100644
--- a/drawinglayer/source/processor2d/vclprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclprocessor2d.cxx
@@ -650,7 +650,7 @@ namespace drawinglayer
 // tools::PolyPolygon is filled. 
Create the bitmap tile area in object
 // coordinates. For this, the object 
transformation needs to be created
 // from the already scaled 
PolyPolygon. The tile area 

[Libreoffice-commits] core.git: dbaccess/source drawinglayer/source

[Noel Grandin]

 dbaccess/source/core/api/TableDeco.cxx|2 +-
 dbaccess/source/core/api/querydescriptor.cxx  |2 +-
 dbaccess/source/core/api/querydescriptor.hxx  |1 -
 dbaccess/source/core/inc/TableDeco.hxx|2 --
 dbaccess/source/ui/browser/brwctrlr.cxx   |5 ++---
 dbaccess/source/ui/dlg/dbadmin.cxx|4 ++--
 dbaccess/source/ui/inc/TableConnectionData.hxx|2 --
 dbaccess/source/ui/inc/TableWindow.hxx|4 
 dbaccess/source/ui/inc/brwctrlr.hxx   |1 -
 dbaccess/source/ui/inc/dbadmin.hxx|4 
 dbaccess/source/ui/querydesign/TableConnectionData.cxx|2 +-
 dbaccess/source/ui/querydesign/TableWindow.cxx|   11 +--
 dbaccess/source/ui/tabledesign/TableFieldDescWin.cxx  |2 +-
 dbaccess/source/ui/tabledesign/TableFieldDescWin.hxx  |1 -
 dbaccess/source/ui/uno/ColumnModel.cxx|2 +-
 dbaccess/source/ui/uno/ColumnModel.hxx|1 -
 drawinglayer/source/attribute/sdrfillgraphicattribute.cxx |3 +--
 drawinglayer/source/attribute/sdrsceneattribute3d.cxx |3 +--
 18 files changed, 16 insertions(+), 36 deletions(-)

New commits:
commit ef637a1c4e16eb9228b6d5e01fc670c4d24afb9b
Author: Noel Grandin 
Date:   Tue Oct 18 13:27:59 2016 +0200

loplugin:expandablemethodds in dbaccess..drawinglayer

Change-Id: Iee9143999f5c94040dadd378006f2a429ca0edb5
Reviewed-on: https://gerrit.libreoffice.org/30012
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/core/api/TableDeco.cxx 
b/dbaccess/source/core/api/TableDeco.cxx
index f16cfdd..643ed93 100644
--- a/dbaccess/source/core/api/TableDeco.cxx
+++ b/dbaccess/source/core/api/TableDeco.cxx
@@ -511,7 +511,7 @@ void ODBTableDecorator::fillPrivileges() const
 xProp->getPropertyValue(PROPERTY_CATALOGNAME)   >>= sCatalog;
 xProp->getPropertyValue(PROPERTY_SCHEMANAME)>>= sSchema;
 xProp->getPropertyValue(PROPERTY_NAME)  >>= sName;
-m_nPrivileges = 
::dbtools::getTablePrivileges(getMetaData(),sCatalog,sSchema, sName);
+m_nPrivileges = ::dbtools::getTablePrivileges(m_xMetaData, 
sCatalog,sSchema, sName);
 }
 }
 }
diff --git a/dbaccess/source/core/api/querydescriptor.cxx 
b/dbaccess/source/core/api/querydescriptor.cxx
index 1ceea68..ef49745 100644
--- a/dbaccess/source/core/api/querydescriptor.cxx
+++ b/dbaccess/source/core/api/querydescriptor.cxx
@@ -183,7 +183,7 @@ Reference< XNameAccess > SAL_CALL 
OQueryDescriptor_Base::getColumns( ) throw (Ru
 {
 MutexGuard aGuard(m_rMutex);
 
-if ( isColumnsOutOfDate() )
+if ( m_bColumnsOutOfDate )
 {
 // clear the current columns
 clearColumns();
diff --git a/dbaccess/source/core/api/querydescriptor.hxx 
b/dbaccess/source/core/api/querydescriptor.hxx
index c069bde..da985b5 100644
--- a/dbaccess/source/core/api/querydescriptor.hxx
+++ b/dbaccess/source/core/api/querydescriptor.hxx
@@ -60,7 +60,6 @@ protected:
 virtual ~OQueryDescriptor_Base();
 
 voidsetColumnsOutOfDate( bool _bOutOfDate = true );
-boolisColumnsOutOfDate() const { return m_bColumnsOutOfDate; }
 
 sal_Int32   getColumnCount() const { return m_pColumns ? 
m_pColumns->getCount() : 0; }
 voidclearColumns( );
diff --git a/dbaccess/source/core/inc/TableDeco.hxx 
b/dbaccess/source/core/inc/TableDeco.hxx
index 71c45ea..b8b8f50 100644
--- a/dbaccess/source/core/inc/TableDeco.hxx
+++ b/dbaccess/source/core/inc/TableDeco.hxx
@@ -150,8 +150,6 @@ namespace dbaccess
 virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< 
sal_Int8 >& aIdentifier ) throw(css::uno::RuntimeException, std::exception) 
override;
 static css::uno::Sequence< sal_Int8 > getUnoTunnelImplementationId();
 
-const css::uno::Reference< css::sdbc::XDatabaseMetaData>& 
getMetaData() const { return m_xMetaData; }
-
 // XColumnsSupplier
 virtual css::uno::Reference< css::container::XNameAccess > SAL_CALL 
getColumns(  ) throw (css::uno::RuntimeException, std::exception) override;
 // XKeysSupplier
diff --git a/dbaccess/source/ui/browser/brwctrlr.cxx 
b/dbaccess/source/ui/browser/brwctrlr.cxx
index a95e5ec..bf6c989 100644
--- a/dbaccess/source/ui/browser/brwctrlr.cxx
+++ b/dbaccess/source/ui/browser/brwctrlr.cxx
@@ -1754,18 +1754,17 @@ void 
SbaXDataBrowserController::ExecuteFilterSortCrit(bool bFilter)
 Reference< XSingleSelectQueryComposer > xParser = createParser_nothrow();
 try
 {
-Reference< css::sdbcx::XColumnsSupplier> xSup = getColumnsSupplier();
 Reference< XConnection> 

[Libreoffice-commits] core.git: dbaccess/source drawinglayer/source editeng/source include/dbaccess include/drawinglayer include/editeng svx/source

[Noel Grandin]

 dbaccess/source/core/dataaccess/documentdefinition.cxx |4 +-
 dbaccess/source/ext/macromigration/rangeprogressbar.hxx|4 +-
 dbaccess/source/ui/browser/genericcontroller.cxx   |5 +--
 dbaccess/source/ui/browser/sbagrid.cxx |4 +-
 dbaccess/source/ui/control/charsetlistbox.cxx  |4 +-
 dbaccess/source/ui/control/sqledit.cxx |4 +-
 dbaccess/source/ui/dlg/sqlmessage.cxx  |5 +--
 dbaccess/source/ui/inc/HtmlReader.hxx  |4 --
 dbaccess/source/ui/inc/JoinTableView.hxx   |2 -
 dbaccess/source/ui/inc/RtfReader.hxx   |4 --
 dbaccess/source/ui/inc/SqlNameEdit.hxx |6 ++--
 dbaccess/source/ui/inc/WNameMatch.hxx  |2 -
 dbaccess/source/ui/inc/WTypeSelect.hxx |6 ++--
 dbaccess/source/ui/inc/charsetlistbox.hxx  |2 -
 dbaccess/source/ui/inc/querycontainerwindow.hxx|2 -
 dbaccess/source/ui/inc/sbagrid.hxx |2 -
 dbaccess/source/ui/inc/sqledit.hxx |2 -
 dbaccess/source/ui/inc/sqlmessage.hxx  |4 --
 dbaccess/source/ui/misc/HtmlReader.cxx |6 +---
 dbaccess/source/ui/misc/RtfReader.cxx  |6 +---
 dbaccess/source/ui/misc/WNameMatch.cxx |6 ++--
 dbaccess/source/ui/misc/WTypeSelect.cxx|4 +-
 dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx   |2 -
 dbaccess/source/ui/querydesign/JoinTableView.cxx   |   19 ++---
 dbaccess/source/ui/querydesign/QTableWindow.cxx|7 +---
 dbaccess/source/ui/querydesign/QTableWindow.hxx|4 +-
 dbaccess/source/ui/querydesign/querycontroller.cxx |2 -
 dbaccess/source/ui/tabledesign/TEditControl.cxx|6 ++--
 dbaccess/source/ui/tabledesign/TEditControl.hxx|2 -
 drawinglayer/source/primitive3d/sdrextrudeprimitive3d.cxx  |3 --
 drawinglayer/source/primitive3d/sdrlatheprimitive3d.cxx|3 --
 editeng/source/editeng/editeng.cxx |4 +-
 editeng/source/editeng/editundo.cxx|4 +-
 editeng/source/items/borderline.cxx|4 --
 editeng/source/uno/unoedhlp.cxx|2 -
 include/dbaccess/genericcontroller.hxx |3 --
 include/drawinglayer/primitive3d/sdrextrudeprimitive3d.hxx |1 
 include/drawinglayer/primitive3d/sdrlatheprimitive3d.hxx   |1 
 include/editeng/borderline.hxx |3 --
 include/editeng/editeng.hxx|2 -
 include/editeng/unoedhlp.hxx   |3 --
 svx/source/sdr/contact/viewcontactofe3dextrude.cxx |2 -
 svx/source/sdr/contact/viewcontactofe3dlathe.cxx   |2 -
 43 files changed, 65 insertions(+), 102 deletions(-)

New commits:
commit 6dd4905a7ac93a48dc87358da3ba0a8078bbb6cf
Author: Noel Grandin 
Date:   Mon Sep 12 12:56:25 2016 +0200

loplugin:constantparam in dbaccess..editeng

Change-Id: I1d0dc3d89933d86cd229e503b350fccc1523dedc
Reviewed-on: https://gerrit.libreoffice.org/28833
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/core/dataaccess/documentdefinition.cxx 
b/dbaccess/source/core/dataaccess/documentdefinition.cxx
index 6af9365..0dbfdaf 100644
--- a/dbaccess/source/core/dataaccess/documentdefinition.cxx
+++ b/dbaccess/source/core/dataaccess/documentdefinition.cxx
@@ -241,7 +241,7 @@ namespace dbaccess
 virtual void SAL_CALL visibilityChanged( sal_Bool /*bVisible*/ ) throw 
(WrongStateException, RuntimeException, std::exception) override
 {
 }
-inline void resetClient(ODocumentDefinition* _pClient) { m_pClient = 
_pClient; }
+inline void resetClient() { m_pClient = nullptr; }
 };
 
 // LockModifiable
@@ -457,7 +457,7 @@ void ODocumentDefinition::closeObject()
 m_xEmbeddedObject = nullptr;
 if ( m_pClientHelper.is() )
 {
-m_pClientHelper->resetClient(nullptr);
+m_pClientHelper->resetClient();
 m_pClientHelper.clear();
 }
 }
diff --git a/dbaccess/source/ext/macromigration/rangeprogressbar.hxx 
b/dbaccess/source/ext/macromigration/rangeprogressbar.hxx
index efa4339..b0c4d49 100644
--- a/dbaccess/source/ext/macromigration/rangeprogressbar.hxx
+++ b/dbaccess/source/ext/macromigration/rangeprogressbar.hxx
@@ -31,8 +31,8 @@ namespace dbmm
 class RangeProgressBar
 {
 public:
-explicit RangeProgressBar(ProgressBar *pBar = nullptr)
-: m_pBar(pBar)
+explicit RangeProgressBar()
+: m_pBar(nullptr)
 , 

[Libreoffice-commits] core.git: dbaccess/source drawinglayer/source extensions/source filter/source fpicker/source framework/source include/svx sc/source sd/source sfx2/source slideshow/source svl/sou

[Andrea Gelmini]

 dbaccess/source/ui/misc/UITools.cxx|2 +-
 drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx |2 +-
 extensions/source/bibliography/datman.cxx  |2 +-
 filter/source/config/cache/typedetection.hxx   |2 +-
 fpicker/source/office/iodlg.cxx|4 ++--
 framework/source/dispatch/closedispatcher.cxx  |2 +-
 include/svx/svdhdl.hxx |2 +-
 sc/source/ui/dbgui/validate.cxx|2 +-
 sc/source/ui/docshell/docsh2.cxx   |2 +-
 sd/source/ui/dlg/animobjs.cxx  |2 +-
 sd/source/ui/func/fudraw.cxx   |2 +-
 sfx2/source/dialog/templdlg.cxx|2 +-
 slideshow/source/inc/animationnodefactory.hxx  |2 +-
 svl/source/numbers/zforfind.hxx|2 +-
 svtools/source/uno/contextmenuhelper.cxx   |2 +-
 svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx   |2 +-
 vcl/source/outdev/transparent.cxx  |2 +-
 xmlsecurity/source/xmlsec/nss/ciphercontext.cxx|2 +-
 18 files changed, 19 insertions(+), 19 deletions(-)

New commits:
commit 814af9f1e59d1a76473b2c72cae4ba8afe1c52d4
Author: Andrea Gelmini andrea.gelm...@gelma.net
Date:   Tue Jun 16 12:20:56 2015 +0200

Fix typos

Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f
Reviewed-on: https://gerrit.libreoffice.org/16309
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com

diff --git a/dbaccess/source/ui/misc/UITools.cxx 
b/dbaccess/source/ui/misc/UITools.cxx
index 2b15eae..37c57f6 100644
--- a/dbaccess/source/ui/misc/UITools.cxx
+++ b/dbaccess/source/ui/misc/UITools.cxx
@@ -1136,7 +1136,7 @@ namespace
 
 return bRet;
 }
-} // annonymous
+} // anonymous
 
 ::com::sun::star::util::URL createHelpAgentURL(const OUString _sModuleName, 
const OString sHelpId)
 {
diff --git a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
index dd200ab..6a4da36 100644
--- a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
@@ -691,7 +691,7 @@ namespace drawinglayer
 the rectangle data is added directly by the GraphicsExporter as 
comment. Does not need
 to be adapted at once.
 When adapting later, the only user - the diashow - should directly 
use the provided
-Anination infos in the appropriate primitives (e.g. 
AnimatedSwitchPrimitive2D)
+Animation infos in the appropriate primitives (e.g. 
AnimatedSwitchPrimitive2D)
 
 PRNSPOOL_TRANSPARENTBITMAP_BEGIN, PRNSPOOL_TRANSPARENTBITMAP_END
 VCL usage when printing PL - THB. Okay, THB confirms that it is 
only used as
diff --git a/extensions/source/bibliography/datman.cxx 
b/extensions/source/bibliography/datman.cxx
index a1fc5b8..44c8c9a 100644
--- a/extensions/source/bibliography/datman.cxx
+++ b/extensions/source/bibliography/datman.cxx
@@ -1392,7 +1392,7 @@ Reference awt::XControlModel  
BibDataManager::loadControlModel(
 // in the current scenario, we insert a control model into a form. 
This results in the control model
 // adding itself as load listener to the form. Now, the form 
should realize that it's already loaded
 // and notify the model (which it knows as XLoadListener only) 
immediately. This seems to make sense.
-// (as an anologon to the XStatusListener semantics).
+// (as an analogon to the XStatusListener semantics).
 //
 // But this would be way too risky for this last-day fix here.
 Reference XLoadable  xLoad( m_xForm, UNO_QUERY );
diff --git a/filter/source/config/cache/typedetection.hxx 
b/filter/source/config/cache/typedetection.hxx
index b06d151..d9c6a63b 100644
--- a/filter/source/config/cache/typedetection.hxx
+++ b/filter/source/config/cache/typedetection.hxx
@@ -271,7 +271,7 @@ private:
 
 
 
-/** @short  remove anythimng related to a TYPE/FILTER entry from the
+/** @short  remove anything related to a TYPE/FILTER entry from the
 specified MediaDescriptor.
 
 @descr  This method works together with 
impl_validateAndSetTypeOnDescriptor()/
diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx
index 451d5ba..9f43429 100644
--- a/fpicker/source/office/iodlg.cxx
+++ b/fpicker/source/office/iodlg.cxx
@@ -946,11 +946,11 @@ IMPL_LINK( SvtFileDialog, OpenHdl_Impl, void*, pVoid )
 // check if it is a folder
 bool bIsFolder = false;
 
-// first thing before doing anyhing with the content: Reset it. When the 
user presses open (or save or export,
+//