package/inc/ZipEnumeration.hxx | 1 - package/source/zipapi/ZipEnumeration.cxx | 1 - sw/inc/IDocumentMarkAccess.hxx | 1 - sw/source/core/doc/docbm.cxx | 4 ---- 4 files changed, 7 deletions(-)
New commits: commit 83dd8deed7b5013fa0f0592140e136770fbda4d6 Author: Stephan Bergmann <sberg...@redhat.com> AuthorDate: Mon Mar 14 20:14:41 2022 +0100 Commit: Stephan Bergmann <sberg...@redhat.com> CommitDate: Mon Mar 14 22:30:44 2022 +0100 loplugin:trivialdestructor (-stdlib=libc++) That these are only flagged when building against libc++ and not against libstdc++ is a consequence of the plugin's dependence on implementation details of the relevant classes, but so be it. Change-Id: I6b96f81939edab2b8e618aa53c9fe23492edfbbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131562 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sberg...@redhat.com> diff --git a/package/inc/ZipEnumeration.hxx b/package/inc/ZipEnumeration.hxx index f0a810ea29cd..50533cc28920 100644 --- a/package/inc/ZipEnumeration.hxx +++ b/package/inc/ZipEnumeration.hxx @@ -30,7 +30,6 @@ public: bool hasMoreElements(); const ZipEntry* nextElement(); ZipEnumeration(EntryHash& rNewEntryHash); - ~ZipEnumeration(); }; /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/package/source/zipapi/ZipEnumeration.cxx b/package/source/zipapi/ZipEnumeration.cxx index 9849c6854f61..0c036882f079 100644 --- a/package/source/zipapi/ZipEnumeration.cxx +++ b/package/source/zipapi/ZipEnumeration.cxx @@ -26,7 +26,6 @@ ZipEnumeration::ZipEnumeration(EntryHash& rNewEntryHash) , aIterator(rEntryHash.begin()) { } -ZipEnumeration::~ZipEnumeration() {} bool ZipEnumeration::hasMoreElements() { return (aIterator != rEntryHash.end()); } const ZipEntry* ZipEnumeration::nextElement() diff --git a/sw/inc/IDocumentMarkAccess.hxx b/sw/inc/IDocumentMarkAccess.hxx index 1d11734e46e9..5596665453e3 100644 --- a/sw/inc/IDocumentMarkAccess.hxx +++ b/sw/inc/IDocumentMarkAccess.hxx @@ -79,7 +79,6 @@ class IDocumentMarkAccess iterator& operator=(iterator const& rOther); iterator(iterator && rOther) noexcept; iterator& operator=(iterator && rOther) noexcept; - ~iterator(); // FIXME unfortunately there's a requirement on input iterator // and forward iterator to return reference, which isn't diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx index c15c1dd3fcea..371111c33edc 100644 --- a/sw/source/core/doc/docbm.cxx +++ b/sw/source/core/doc/docbm.cxx @@ -86,10 +86,6 @@ auto IDocumentMarkAccess::iterator::operator=(iterator && rOther) noexcept -> it return *this; } -IDocumentMarkAccess::iterator::~iterator() -{ -} - // ARGH why does it *need* to return const& ? ::sw::mark::IMark* /*const&*/ IDocumentMarkAccess::iterator::operator*() const