[Libreoffice-commits] core.git: sdext/source sd/inc sd/source

[Noel Grandin]

 sd/inc/sdiocmpt.hxx |3 --
 sd/source/core/sdiocmpt.cxx |8 +++---
 sd/source/ui/animations/CustomAnimationList.cxx |4 ---
 sd/source/ui/dlg/animobjs.cxx   |3 --
 sd/source/ui/dlg/dlgsnap.cxx|2 -
 sd/source/ui/dlg/headerfooterdlg.cxx|4 +--
 sd/source/ui/dlg/layeroptionsdlg.cxx|   13 --
 sd/source/ui/inc/OutlineView.hxx|3 --
 sd/source/ui/inc/animobjs.hxx   |1 
 sd/source/ui/inc/dlgsnap.hxx|1 
 sd/source/ui/inc/headerfooterdlg.hxx|1 
 sd/source/ui/inc/layeroptionsdlg.hxx|2 -
 sd/source/ui/sidebar/SlideBackground.cxx|   11 
 sd/source/ui/sidebar/SlideBackground.hxx|1 
 sd/source/ui/slidesorter/inc/view/SlsPageObjectLayouter.hxx |1 
 sd/source/ui/slidesorter/view/SlsPageObjectLayouter.cxx |   10 
 sd/source/ui/view/outlview.cxx  |   15 
 sdext/source/minimizer/configurationaccess.cxx  |1 
 sdext/source/minimizer/configurationaccess.hxx  |1 
 19 files changed, 20 insertions(+), 65 deletions(-)

New commits:
commit 59f398e934541e05dc9b77c1191227f8c68ea037
Author: Noel Grandin 
Date:   Wed May 16 12:58:05 2018 +0200

loplugin:unusedfields in sd

Change-Id: I01e6431279b71d0cff8f44614b3cad17f0f89460
Reviewed-on: https://gerrit.libreoffice.org/54452
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sd/inc/sdiocmpt.hxx b/sd/inc/sdiocmpt.hxx
index b3582a85c58f..fb1872f16832 100644
--- a/sd/inc/sdiocmpt.hxx
+++ b/sd/inc/sdiocmpt.hxx
@@ -47,9 +47,6 @@ public:
 
 class SD_DLLPUBLIC SdIOCompat : public old_SdrDownCompat
 {
-private:
-sal_uInt16 nVersion;
-
 public:
 // nNewMode: StreamMode::READ or StreamMode::WRITE
 // nVer: specify only when writing
diff --git a/sd/source/core/sdiocmpt.cxx b/sd/source/core/sdiocmpt.cxx
index 7cdd36a05139..67de6a64d71d 100644
--- a/sd/source/core/sdiocmpt.cxx
+++ b/sd/source/core/sdiocmpt.cxx
@@ -93,18 +93,18 @@ void old_SdrDownCompat::CloseSubRecord()
 |*
 \/
 
-SdIOCompat::SdIOCompat(SvStream& rNewStream, StreamMode nNewMode, sal_uInt16 
nVer)
-:   old_SdrDownCompat(rNewStream, nNewMode), nVersion(nVer)
+SdIOCompat::SdIOCompat(SvStream& rNewStream, StreamMode nNewMode, sal_uInt16 
nVersion)
+:   old_SdrDownCompat(rNewStream, nNewMode)
 {
 if (nNewMode == StreamMode::WRITE)
 {
-DBG_ASSERT(nVer != SDIOCOMPAT_VERSIONDONTKNOW,
+DBG_ASSERT(nVersion != SDIOCOMPAT_VERSIONDONTKNOW,
"can't write unknown version");
 rNewStream.WriteUInt16( nVersion );
 }
 else if (nNewMode == StreamMode::READ)
 {
-DBG_ASSERT(nVer == SDIOCOMPAT_VERSIONDONTKNOW,
+DBG_ASSERT(nVersion == SDIOCOMPAT_VERSIONDONTKNOW,
"referring to the version while reading is silly!");
 rNewStream.ReadUInt16( nVersion );
 }
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx 
b/sd/source/ui/animations/CustomAnimationList.cxx
index 59de6e7e1811..4f1b4eef4786 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -211,7 +211,6 @@ private:
 OUStringmsDescription;
 OUStringmsEffectName;
 CustomAnimationEffectPtr mpEffect;
-const CustomAnimationPresets* mpCustomAnimationPresets;
 static const long nIconWidth = 19;
 static const long nItemMinHeight = 38;
 };
@@ -222,7 +221,6 @@ CustomAnimationListEntryItem::CustomAnimationListEntryItem( 
const OUString& aDes
 , msDescription( aDescription )
 , msEffectName( OUString() )
 , mpEffect(pEffect)
-, 
mpCustomAnimationPresets(::getCustomAnimationPresets())
 {
 switch(mpEffect->getPresetClass())
 {
@@ -235,7 +233,7 @@ CustomAnimationListEntryItem::CustomAnimationListEntryItem( 
const OUString& aDes
 case EffectPresetClass::MOTIONPATH:
 msEffectName = SdResId(STR_CUSTOMANIMATION_MOTION_PATHS); break;
 }
-msEffectName = msEffectName.replaceFirst( "%1" , 
mpCustomAnimationPresets->getUINameForPresetId(mpEffect->getPresetId()));
+msEffectName = msEffectName.replaceFirst( "%1" , 
CustomAnimationPresets::getCustomAnimationPresets().getUINameForPresetId(mpEffect->getPresetId()));
 }
 
 void CustomAnimationListEntryItem::InitViewData( SvTreeListBox* pView, 
SvTreeListEntry* pEntry, SvViewDataItem* pViewData )
diff --git a/sd/source/ui/dlg/animobjs.cxx b/sd/source/ui/dlg/animobjs.cxx
index 8f48e7e13b29..50d795504875 

[Libreoffice-commits] core.git: sdext/source sd/inc sd/source

[Jochen Nitschke]

 sd/inc/OutlinerIterator.hxx |7 ---
 sd/inc/drawdoc.hxx  |1 
 sd/source/core/drawdoc.cxx  |   17 ---
 sd/source/ui/sidebar/MasterPageDescriptor.cxx   |   23 
--
 sd/source/ui/sidebar/MasterPageDescriptor.hxx   |2 
 sd/source/ui/slidesorter/inc/controller/SlsTransferableData.hxx |6 --
 sd/source/ui/slidesorter/inc/view/SlsLayouter.hxx   |1 
 sd/source/ui/slidesorter/view/SlsLayouter.cxx   |   17 ---
 sd/source/ui/view/OutlinerIterator.cxx  |9 ---
 sd/source/ui/view/ViewShellManager.cxx  |   22 
-
 sdext/source/pdfimport/sax/saxattrlist.cxx  |   11 
 sdext/source/pdfimport/sax/saxattrlist.hxx  |2 
 12 files changed, 118 deletions(-)

New commits:
commit e641975076db46381f39ebca82bd43c503c3880c
Author: Jochen Nitschke 
Date:   Sun Nov 26 17:27:45 2017 +0100

clang-tidy modernize-use-equals-default in sd

Change-Id: Ib3d3bb1a0484cb8bb6411444254644252e3614cf
Reviewed-on: https://gerrit.libreoffice.org/45293
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sd/inc/OutlinerIterator.hxx b/sd/inc/OutlinerIterator.hxx
index d61448db7c91..0696fbffc265 100644
--- a/sd/inc/OutlinerIterator.hxx
+++ b/sd/inc/OutlinerIterator.hxx
@@ -288,13 +288,6 @@ public:
 it is as a marker in comparisons.
 */
 IteratorPosition();
-/** Create a new object with all data members set from the given
-position.
-@param aPosition
-The position object from which to take the values that are
-assigned to the data members of this object.
-*/
-IteratorPosition (const IteratorPosition& aPosition);
 
 /** Compare two positions for equality.
 @return
diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx
index 2ce8fabb9de4..8a0af1398287 100644
--- a/sd/inc/drawdoc.hxx
+++ b/sd/inc/drawdoc.hxx
@@ -126,7 +126,6 @@ namespace sd
 bool mbShowPauseLogo;
 
 PresentationSettings();
-PresentationSettings( const PresentationSettings& r );
 };
 }
 
diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx
index ff30462fc3c9..620607507790 100644
--- a/sd/source/core/drawdoc.cxx
+++ b/sd/source/core/drawdoc.cxx
@@ -130,23 +130,6 @@ PresentationSettings::PresentationSettings()
 {
 }
 
-PresentationSettings::PresentationSettings( const PresentationSettings& r )
-:   maPresPage( r.maPresPage ),
-mbAll( r.mbAll ),
-mbEndless( r.mbEndless ),
-mbCustomShow( r.mbCustomShow ),
-mbManual( r.mbManual ),
-mbMouseVisible( r.mbMouseVisible ),
-mbMouseAsPen( r.mbMouseAsPen ),
-mbLockedPages( r.mbLockedPages ),
-mbAlwaysOnTop( r.mbAlwaysOnTop ),
-mbFullScreen( r.mbFullScreen ),
-mbAnimationAllowed( r.mbAnimationAllowed ),
-mnPauseTimeout( r.mnPauseTimeout ),
-mbShowPauseLogo( r.mbShowPauseLogo )
-{
-}
-
 SdDrawDocument::SdDrawDocument(DocumentType eType, SfxObjectShell* pDrDocSh)
 : FmFormModel( !utl::ConfigManager::IsFuzzing() ? 
SvtPathOptions().GetPalettePath() : OUString(), nullptr, pDrDocSh )
 , mpOutliner(nullptr)
diff --git a/sd/source/ui/sidebar/MasterPageDescriptor.cxx 
b/sd/source/ui/sidebar/MasterPageDescriptor.cxx
index 26e44eff0f7e..87a27d597870 100644
--- a/sd/source/ui/sidebar/MasterPageDescriptor.cxx
+++ b/sd/source/ui/sidebar/MasterPageDescriptor.cxx
@@ -55,29 +55,6 @@ MasterPageDescriptor::MasterPageDescriptor (
 {
 }
 
-MasterPageDescriptor::MasterPageDescriptor (const MasterPageDescriptor& 
rDescriptor)
-: maToken(rDescriptor.maToken),
-  meOrigin(rDescriptor.meOrigin),
-  msURL(rDescriptor.msURL),
-  msPageName(rDescriptor.msPageName),
-  msStyleName(rDescriptor.msStyleName),
-  mbIsPrecious(rDescriptor.mbIsPrecious),
-  mpMasterPage(rDescriptor.mpMasterPage),
-  mpSlide(rDescriptor.mpSlide),
-  maSmallPreview(rDescriptor.maSmallPreview),
-  maLargePreview(rDescriptor.maLargePreview),
-  mpPreviewProvider(rDescriptor.mpPreviewProvider),
-  mpPageObjectProvider(rDescriptor.mpPageObjectProvider),
-  mnTemplateIndex(rDescriptor.mnTemplateIndex),
-  meURLClassification(rDescriptor.meURLClassification),
-  mnUseCount(rDescriptor.mnUseCount)
-{
-}
-
-MasterPageDescriptor::~MasterPageDescriptor()
-{
-}
-
 void MasterPageDescriptor::SetToken (MasterPageContainer::Token aToken)
 {
 maToken = aToken;
diff --git a/sd/source/ui/sidebar/MasterPageDescriptor.hxx 
b/sd/source/ui/sidebar/MasterPageDescriptor.hxx
index d4bb8cc40def..dfc7795189b5 100644
--- a/sd/source/ui/sidebar/MasterPageDescriptor.hxx
+++ b/sd/source/ui/sidebar/MasterPageDescriptor.hxx
@@ -46,8 +46,6 @@ public:
 const bool bIsPrecious,
 

[Libreoffice-commits] core.git: sdext/source sd/inc sd/source

[Noel Grandin]

 sd/inc/CustomAnimationEffect.hxx  |4 ++--
 sd/inc/CustomAnimationPreset.hxx  |4 ++--
 sd/inc/cusshow.hxx|4 ++--
 sd/source/filter/html/htmlex.hxx  |4 ++--
 sd/source/ui/app/sdmod1.cxx   |3 +--
 sd/source/ui/inc/SlideSorter.hxx  |4 ++--
 sd/source/ui/inc/ViewShell.hxx|2 +-
 sd/source/ui/sidebar/MasterPageContainer.hxx  |4 ++--
 sd/source/ui/sidebar/MasterPageContainerQueue.hxx |4 ++--
 sd/source/ui/slidesorter/cache/SlsQueueProcessor.hxx  |4 ++--
 sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx |4 ++--
 sd/source/ui/slidesorter/inc/controller/SlsSelectionObserver.hxx  |4 ++--
 sd/source/ui/slidesorter/inc/model/SlideSorterModel.hxx   |4 ++--
 sd/source/ui/table/TableDesignPane.hxx|4 ++--
 sdext/source/pdfimport/tree/pdfiprocessor.hxx |3 +--
 sdext/source/presenter/PresenterSprite.hxx|4 ++--
 16 files changed, 29 insertions(+), 31 deletions(-)

New commits:
commit 0a3eaf9f67f5e66ca0ae0c38cc4d85e07795b9f4
Author: Noel Grandin 
Date:   Mon Nov 7 13:33:38 2016 +0200

loplugin:unnecessaryvirtual in sd..sdext

Change-Id: Id0bc82210fadc138b55d1abe4e06b1d2ed564df3
Reviewed-on: https://gerrit.libreoffice.org/30659
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/sd/inc/CustomAnimationEffect.hxx b/sd/inc/CustomAnimationEffect.hxx
index bc6adda..952582b 100644
--- a/sd/inc/CustomAnimationEffect.hxx
+++ b/sd/inc/CustomAnimationEffect.hxx
@@ -51,14 +51,14 @@ typedef std::list< CustomAnimationEffectPtr > 
EffectSequence;
 
 class EffectSequenceHelper;
 
-class SD_DLLPUBLIC CustomAnimationEffect
+class SD_DLLPUBLIC CustomAnimationEffect final
 {
 friend class MainSequence;
 friend class EffectSequenceHelper;
 
 public:
 CustomAnimationEffect( const css::uno::Reference< 
css::animations::XAnimationNode >& xNode );
-virtual ~CustomAnimationEffect();
+~CustomAnimationEffect();
 
 SAL_DLLPRIVATE const css::uno::Reference< css::animations::XAnimationNode 
>& getNode() const { return mxNode; }
 SAL_DLLPRIVATE void setNode( const css::uno::Reference< 
css::animations::XAnimationNode >& xNode );
diff --git a/sd/inc/CustomAnimationPreset.hxx b/sd/inc/CustomAnimationPreset.hxx
index c519d3c..7f8252f 100644
--- a/sd/inc/CustomAnimationPreset.hxx
+++ b/sd/inc/CustomAnimationPreset.hxx
@@ -86,11 +86,11 @@ struct PresetCategory
 typedef std::shared_ptr< PresetCategory > PresetCategoryPtr;
 typedef std::vector< PresetCategoryPtr > PresetCategoryList;
 
-class SD_DLLPUBLIC CustomAnimationPresets
+class SD_DLLPUBLIC CustomAnimationPresets final
 {
 public:
 SAL_DLLPRIVATE CustomAnimationPresets();
-SAL_DLLPRIVATE virtual ~CustomAnimationPresets();
+SAL_DLLPRIVATE ~CustomAnimationPresets();
 
 static const CustomAnimationPresets& getCustomAnimationPresets();
 
diff --git a/sd/inc/cusshow.hxx b/sd/inc/cusshow.hxx
index a6edd30..d0509ad 100644
--- a/sd/inc/cusshow.hxx
+++ b/sd/inc/cusshow.hxx
@@ -27,7 +27,7 @@
 class SdDrawDocument;
 class SdPage;
 
-class SD_DLLPUBLIC SdCustomShow
+class SD_DLLPUBLIC SdCustomShow final
 {
 public:
 typedef ::std::vector PageVec;
@@ -47,7 +47,7 @@ public:
 explicit SdCustomShow(SdDrawDocument* pDrawDoc);
 SdCustomShow(SdDrawDocument* pDrawDoc, css::uno::Reference< 
css::uno::XInterface > const & xShow );
 
-virtual ~SdCustomShow();
+~SdCustomShow();
 
 // @@@ copy ctor, but no copy assignment? @@@
 SdCustomShow( const SdCustomShow& rShow );
diff --git a/sd/source/filter/html/htmlex.hxx b/sd/source/filter/html/htmlex.hxx
index c42f1b8..dc63989 100644
--- a/sd/source/filter/html/htmlex.hxx
+++ b/sd/source/filter/html/htmlex.hxx
@@ -76,7 +76,7 @@ public:
 };
 
 /// this class exports an Impress Document as a HTML Presentation.
-class HtmlExport
+class HtmlExport final
 {
 std::vector< SdPage* > maPages;
 std::vector< SdPage* > maNotesPages;
@@ -229,7 +229,7 @@ class HtmlExport
SdDrawDocument* pExpDoc,
sd::DrawDocShell* pDocShell);
 
-virtual ~HtmlExport();
+~HtmlExport();
 
 static OUString ColorToHTMLString( Color aColor );
 static OUString StringToHTMLString( const OUString& rString );
diff --git a/sd/source/ui/app/sdmod1.cxx b/sd/source/ui/app/sdmod1.cxx
index 1dcaae8..0fb7a27 100644
--- a/sd/source/ui/app/sdmod1.cxx
+++ b/sd/source/ui/app/sdmod1.cxx
@@ -73,14 +73,13 @@ using ::com::sun::star::uno::Sequence;
 
 namespace {
 
-class OutlineToImpressFinalizer
+class OutlineToImpressFinalizer final
 {
 

[Libreoffice-commits] core.git: sdext/source sd/inc sd/source

[Noel Grandin]

 sd/inc/CustomAnimationEffect.hxx  |8 -
 sd/inc/Outliner.hxx   |2 
 sd/inc/OutlinerIterator.hxx   |4 
 sd/inc/drawdoc.hxx|   10 -
 sd/inc/sdabstdlg.hxx  |4 
 sd/inc/sdgrffilter.hxx|2 
 sd/inc/sdpage.hxx |2 
 sd/source/core/CustomAnimationCloner.cxx  |2 
 sd/source/core/EffectMigration.cxx|2 
 sd/source/core/PageListWatcher.hxx|2 
 sd/source/core/annotations/Annotation.cxx |2 
 sd/source/core/drawdoc2.cxx   |2 
 sd/source/core/drawdoc3.cxx   |2 
 sd/source/filter/eppt/eppt.hxx|   16 +-
 sd/source/filter/eppt/epptbase.hxx|2 
 sd/source/filter/eppt/epptso.cxx  |4 
 sd/source/filter/eppt/pptx-epptbase.cxx   |2 
 sd/source/filter/eppt/pptx-stylesheet.cxx |2 
 sd/source/filter/eppt/pptx-text.cxx   |4 
 sd/source/filter/eppt/text.hxx|8 -
 sd/source/ui/animations/CustomAnimationDialog.cxx |2 
 sd/source/ui/animations/CustomAnimationList.cxx   |2 
 sd/source/ui/animations/CustomAnimationList.hxx   |2 
 sd/source/ui/animations/motionpathtag.hxx |2 
 sd/source/ui/annotations/annotationtag.hxx|2 
 sd/source/ui/dlg/navigatr.cxx |6 
 sd/source/ui/dlg/sddlgfact.hxx|4 
 sd/source/ui/dlg/sdtreelb.cxx |2 
 sd/source/ui/docshell/docshel3.cxx|2 
 sd/source/ui/framework/factories/BasicViewFactory.cxx |2 
 sd/source/ui/framework/factories/BasicViewFactory.hxx |2 
 sd/source/ui/func/fucushow.cxx|2 
 sd/source/ui/func/fuinsfil.cxx|2 
 sd/source/ui/inc/DrawDocShell.hxx |2 
 sd/source/ui/inc/DrawViewShell.hxx|   12 -
 sd/source/ui/inc/EventMultiplexer.hxx |2 
 sd/source/ui/inc/FrameView.hxx|8 -
 sd/source/ui/inc/OutlineView.hxx  |6 
 sd/source/ui/inc/OutlineViewShell.hxx |4 
 sd/source/ui/inc/PreviewRenderer.hxx  |2 
 sd/source/ui/inc/ShellFactory.hxx |2 
 sd/source/ui/inc/TemplateScanner.hxx  |2 
 sd/source/ui/inc/View.hxx |4 
 sd/source/ui/inc/ViewShell.hxx|8 -
 sd/source/ui/inc/docprev.hxx  |2 
 sd/source/ui/inc/navigatr.hxx |6 
 sd/source/ui/inc/optsitem.hxx |   80 
+-
 sd/source/ui/inc/sdtreelb.hxx |2 
 sd/source/ui/inc/slideshow.hxx|2 
 sd/source/ui/inc/smarttag.hxx |4 
 sd/source/ui/inc/tools/IdleDetection.hxx  |2 
 sd/source/ui/inc/unomodel.hxx |2 
 sd/source/ui/presenter/SlideRenderer.cxx  |2 
 sd/source/ui/sidebar/MasterPageContainer.hxx  |2 
 sd/source/ui/sidebar/MasterPageContainerQueue.cxx |2 
 sd/source/ui/sidebar/MasterPagesSelector.cxx  |2 
 sd/source/ui/slideshow/showwindow.hxx |2 
 sd/source/ui/slideshow/slideshow.cxx  |2 
 sd/source/ui/slideshow/slideshowimpl.cxx  |2 
 sd/source/ui/slidesorter/cache/SlsGenericPageCache.hxx|2 
 sd/source/ui/slidesorter/cache/SlsPageCache.cxx   |2 
 sd/source/ui/slidesorter/cache/SlsQueueProcessor.hxx  |2 
 sd/source/ui/slidesorter/controller/SlsDragAndDropContext.hxx |4 
 sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx  |4 
 sd/source/ui/slidesorter/controller/SlsVisibleAreaManager.cxx |2 
 sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx |2 
 

[Libreoffice-commits] core.git: sdext/source sd/inc sd/source

[Noel Grandin]

 sd/inc/OutlinerIterator.hxx   |3 -
 sd/inc/cusshow.hxx|3 -
 sd/inc/sdabstdlg.hxx  |1 
 sd/inc/sdattr.hxx |   14 
 sd/source/core/sdattr.cxx |   36 
 sd/source/filter/eppt/epptbase.hxx|6 --
 sd/source/ui/dlg/sddlgfact.cxx|5 -
 sd/source/ui/dlg/sddlgfact.hxx|1 
 sd/source/ui/inc/PaneShells.hxx   |   13 
 sd/source/ui/slideshow/slideshowimpl.cxx  |   42 --
 sd/source/ui/slideshow/slideshowimpl.hxx  |2 
 sd/source/ui/slidesorter/inc/model/SlsPageEnumeration.hxx |2 
 sdext/source/pdfimport/sax/saxattrlist.hxx|1 
 sdext/source/pdfimport/tree/genericelements.cxx   |4 -
 sdext/source/pdfimport/tree/genericelements.hxx   |3 -
 sdext/source/pdfimport/tree/style.hxx |1 
 sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx |   16 -
 sdext/source/presenter/PresenterUIPainter.hxx |3 -
 18 files changed, 4 insertions(+), 152 deletions(-)

New commits:
commit b73f45ef0bf3230275c11fc9c70c22625332b695
Author: Noel Grandin 
Date:   Wed May 18 16:57:21 2016 +0200

loplugin:unusedmethods in sd

Change-Id: I27da3e7afd86217ec9f75958775da9c144d7a0a5
Reviewed-on: https://gerrit.libreoffice.org/25111
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sd/inc/OutlinerIterator.hxx b/sd/inc/OutlinerIterator.hxx
index f4392b0..dc63add 100644
--- a/sd/inc/OutlinerIterator.hxx
+++ b/sd/inc/OutlinerIterator.hxx
@@ -280,8 +280,7 @@ private:
 IteratorLocation aLocation);
 
 // Do not allow default constructor and copying of outliner containers.
-OutlinerContainer (const OutlinerContainer&) {};
-OutlinerContainer() {};
+OutlinerContainer (const OutlinerContainer&) = delete;
 OutlinerContainer& operator= (const OutlinerContainer&) {return *this;};
 };
 
diff --git a/sd/inc/cusshow.hxx b/sd/inc/cusshow.hxx
index 11d1e15..83de986 100644
--- a/sd/inc/cusshow.hxx
+++ b/sd/inc/cusshow.hxx
@@ -40,8 +40,7 @@ private:
 // this is a weak reference to a possible living api wrapper for this 
custom show
 css::uno::WeakReference< css::uno::XInterface > mxUnoCustomShow;
 
-// forbidden and not implemented
-SdCustomShow();
+SdCustomShow() = delete;
 
 public:
 // single argument ctors shall be explicit
diff --git a/sd/inc/sdabstdlg.hxx b/sd/inc/sdabstdlg.hxx
index f673c28..702ba60 100644
--- a/sd/inc/sdabstdlg.hxx
+++ b/sd/inc/sdabstdlg.hxx
@@ -118,7 +118,6 @@ class AbstractSdInsertPasteDlg : public VclAbstractDialog
 class AbstractSdInsertPagesObjsDlg : public VclAbstractDialog
 {
 public:
-virtual vcl::Window*   GetWindow() = 0;  //this method is added for return 
a vcl::Window type pointer
 virtual std::vector GetList ( const sal_uInt16 nType ) = 0;
 virtual boolIsLink() = 0;
 virtual boolIsRemoveUnnessesaryMasterPages() const = 0;
diff --git a/sd/inc/sdattr.hxx b/sd/inc/sdattr.hxx
index 603e322..710a072 100644
--- a/sd/inc/sdattr.hxx
+++ b/sd/inc/sdattr.hxx
@@ -35,8 +35,6 @@
 class SdAttrLayerName : public SfxStringItem
 {
 public:
-SdAttrLayerName() :
-SfxStringItem( ATTR_LAYER_NAME, OUString("neue Ebene") ) {}
 SdAttrLayerName( const OUString& aStr ) :
 SfxStringItem( ATTR_LAYER_NAME, aStr ) {}
 };
@@ -86,7 +84,6 @@ public:
 class DiaEffectItem : public SfxEnumItem
 {
 public:
-DiaEffectItem( css::presentation::FadeEffect eFade = 
css::presentation::FadeEffect_NONE );
 DiaEffectItem( SvStream& rIn );
 
 virtual SfxPoolItem*Clone( SfxItemPool* pPool = nullptr ) const 
override;
@@ -97,7 +94,6 @@ public:
 class DiaSpeedItem : public SfxEnumItem
 {
 public:
-DiaSpeedItem( FadeSpeed = FADE_SPEED_MEDIUM );
 DiaSpeedItem( SvStream& rIn );
 
 virtual SfxPoolItem*Clone( SfxItemPool* pPool = nullptr ) const 
override;
@@ -108,7 +104,6 @@ public:
 class DiaAutoItem : public SfxEnumItem
 {
 public:
-DiaAutoItem( PresChange = PRESCHANGE_MANUAL );
 DiaAutoItem( SvStream& rIn );
 
 virtual SfxPoolItem*Clone( SfxItemPool* pPool = nullptr ) const 
override;
@@ -116,15 +111,6 @@ public:
 sal_uInt16  GetValueCount() const override { return 
PRESCHANGE_COUNT; }
 };
 
-class DiaTimeItem : public SfxUInt32Item
-{
-public:
-DiaTimeItem( sal_uInt32 nValue = 0L );
-
-virtual SfxPoolItem* Clone( SfxItemPool* pPool = nullptr ) const override;
-virtual bool operator==( const SfxPoolItem& ) const override;
-};
-
 #endif // INCLUDED_SD_INC_SDATTR_HXX
 
 /* vim:set