tools/source/inet/inetmime.cxx | 3 +-- ucb/source/ucp/file/filglob.hxx | 4 ++-- ucb/source/ucp/file/filtask.hxx | 2 +- unoidl/source/unoidlprovider.cxx | 2 +- vbahelper/source/msforms/vbacontrols.cxx | 2 +- vbahelper/source/vbahelper/vbacommandbarhelper.hxx | 2 +- vcl/inc/fontsubset.hxx | 4 ++-- vcl/inc/headless/svpgdi.hxx | 2 +- vcl/inc/headless/svpinst.hxx | 2 +- vcl/inc/impgraph.hxx | 8 ++++---- vcl/inc/opengl/program.hxx | 2 +- vcl/inc/opengl/texture.hxx | 2 +- vcl/inc/openglgdiimpl.hxx | 4 ++-- vcl/inc/salgdi.hxx | 2 +- vcl/inc/salinst.hxx | 2 +- vcl/inc/textlayout.hxx | 4 ++-- vcl/inc/unx/genpspgraphics.h | 2 +- vcl/inc/unx/gtk/gtkinst.hxx | 2 +- vcl/inc/unx/printergfx.hxx | 2 +- vcl/inc/unx/printerjob.hxx | 2 +- vcl/inc/unx/salbmp.h | 2 +- vcl/inc/unx/salgdi.h | 2 +- vcl/inc/unx/salinst.h | 2 +- vcl/source/edit/textdoc.hxx | 2 +- vcl/source/gdi/pdfwriter_impl.hxx | 16 ++++++++-------- vcl/source/outdev/font.cxx | 2 +- vcl/unx/generic/dtrans/X11_selection.hxx | 2 +- vcl/unx/generic/printer/ppdparser.cxx | 2 +- xmlhelp/source/cxxhelp/provider/databases.hxx | 2 +- xmloff/source/style/impastpl.hxx | 4 ++-- xmloff/source/style/xmlexppr.cxx | 2 +- xmlsecurity/qa/unit/signing/signing.cxx | 8 ++++---- 32 files changed, 50 insertions(+), 51 deletions(-)
New commits: commit 9870f02b310567c1d50c8e11a49afea5fdc549a0 Author: Noel Grandin <n...@peralex.com> Date: Mon Jul 25 14:04:19 2016 +0200 loplugin:countusersofdefaultparams in tools..xmlsecurity find methods with default params with only zero or one call site Change-Id: Ie5b30f60e9fe00ba1acf0dfc79b005ded46f05a0 Reviewed-on: https://gerrit.libreoffice.org/27512 Tested-by: Jenkins <c...@libreoffice.org> Reviewed-by: Noel Grandin <noelgran...@gmail.com> diff --git a/tools/source/inet/inetmime.cxx b/tools/source/inet/inetmime.cxx index 33bf396..2e4b74a 100644 --- a/tools/source/inet/inetmime.cxx +++ b/tools/source/inet/inetmime.cxx @@ -446,8 +446,7 @@ public: void includes(sal_uInt32 nChar); - rtl_TextEncoding getPreferredEncoding(rtl_TextEncoding eDefault - = RTL_TEXTENCODING_DONTKNOW) + rtl_TextEncoding getPreferredEncoding(rtl_TextEncoding eDefault) const; void reset(); diff --git a/ucb/source/ucp/file/filglob.hxx b/ucb/source/ucp/file/filglob.hxx index 2bbecb3..d1e9a4a 100644 --- a/ucb/source/ucp/file/filglob.hxx +++ b/ucb/source/ucp/file/filglob.hxx @@ -63,7 +63,7 @@ namespace fileaccess { extern osl::FileBase::RC osl_File_copy( const OUString& strPath, const OUString& strDestPath, - bool test = false ); + bool test ); /** * special move: @@ -84,7 +84,7 @@ namespace fileaccess { const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv, const OUString& aUncPath, BaseContent* pContent, - bool isHandled = false); + bool isHandled); // the physical URL of the object } // end namespace fileaccess diff --git a/ucb/source/ucp/file/filtask.hxx b/ucb/source/ucp/file/filtask.hxx index 9af0e04..f2b0d89 100644 --- a/ucb/source/ucp/file/filtask.hxx +++ b/ucb/source/ucp/file/filtask.hxx @@ -94,7 +94,7 @@ namespace fileaccess } void SAL_CALL installError( sal_Int32 nErrorCode, - sal_Int32 nMinorCode = TASKHANDLER_NO_ERROR ) + sal_Int32 nMinorCode ) { m_nErrorCode = nErrorCode; m_nMinorCode = nMinorCode; diff --git a/unoidl/source/unoidlprovider.cxx b/unoidl/source/unoidlprovider.cxx index 800d112..acf443b 100644 --- a/unoidl/source/unoidlprovider.cxx +++ b/unoidl/source/unoidlprovider.cxx @@ -551,7 +551,7 @@ std::vector< OUString > readAnnotations( ConstantValue readConstant( rtl::Reference< MappedFile > const & file, sal_uInt32 offset, - sal_uInt32 * newOffset = nullptr, bool * annotated = nullptr) + sal_uInt32 * newOffset, bool * annotated) { assert(file.is()); int v = file->read8(offset); diff --git a/vbahelper/source/msforms/vbacontrols.cxx b/vbahelper/source/msforms/vbacontrols.cxx index 87241b5..fe62c1b 100644 --- a/vbahelper/source/msforms/vbacontrols.cxx +++ b/vbahelper/source/msforms/vbacontrols.cxx @@ -50,7 +50,7 @@ class ControlArrayWrapper : public ::cppu::WeakImplHelper< container::XNameAcces ControlIndexMap mIndices; private: - void SetArrayElementTo( const uno::Reference< awt::XControl >& xCtrl, sal_Int32 nIndex = -1 ) + void SetArrayElementTo( const uno::Reference< awt::XControl >& xCtrl, sal_Int32 nIndex ) { // initialize the element with specified index to the control if ( xCtrl.is() ) diff --git a/vbahelper/source/vbahelper/vbacommandbarhelper.hxx b/vbahelper/source/vbahelper/vbacommandbarhelper.hxx index 3279fb4..43f2f80 100644 --- a/vbahelper/source/vbahelper/vbacommandbarhelper.hxx +++ b/vbahelper/source/vbahelper/vbacommandbarhelper.hxx @@ -77,7 +77,7 @@ public: const OUString& getModuleId() const { return maModuleId; } OUString findToolbarByName( const css::uno::Reference< css::container::XNameAccess >& xNameAccess, const OUString& sName ) throw (css::uno::RuntimeException); - static sal_Int32 findControlByName( const css::uno::Reference< css::container::XIndexAccess >& xIndexAccess, const OUString& sName, bool bMenu = false ) throw (css::uno::RuntimeException); + static sal_Int32 findControlByName( const css::uno::Reference< css::container::XIndexAccess >& xIndexAccess, const OUString& sName, bool bMenu ) throw (css::uno::RuntimeException); static OUString generateCustomURL(); }; diff --git a/vcl/inc/fontsubset.hxx b/vcl/inc/fontsubset.hxx index 5053442..5c17e86 100644 --- a/vcl/inc/fontsubset.hxx +++ b/vcl/inc/fontsubset.hxx @@ -82,8 +82,8 @@ private: protected: bool CreateFontSubsetFromCff( sal_Int32* pOutGlyphWidths = nullptr ); - bool CreateFontSubsetFromSfnt( sal_Int32* pOutGlyphWidths = nullptr ); - static bool CreateFontSubsetFromType1( sal_Int32* pOutGlyphWidths = nullptr ); + bool CreateFontSubsetFromSfnt( sal_Int32* pOutGlyphWidths ); + static bool CreateFontSubsetFromType1( sal_Int32* pOutGlyphWidths ); }; #endif // INCLUDED_VCL_INC_FONTSUBSET_HXX diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx index e0d2a9d..76e4460 100644 --- a/vcl/inc/headless/svpgdi.hxx +++ b/vcl/inc/headless/svpgdi.hxx @@ -137,7 +137,7 @@ public: virtual void SetTextColor( SalColor nSalColor ) override; virtual void SetFont( FontSelectPattern*, int nFallbackLevel ) override; - virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel = 0 ) override; + virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel ) override; virtual const FontCharMapPtr GetFontCharMap() const override; virtual bool GetFontCapabilities(vcl::FontCapabilities &rFontCapabilities) const override; virtual void GetDevFontList( PhysicalFontCollection* ) override; diff --git a/vcl/inc/headless/svpinst.hxx b/vcl/inc/headless/svpinst.hxx index 932e928..7f24194 100644 --- a/vcl/inc/headless/svpinst.hxx +++ b/vcl/inc/headless/svpinst.hxx @@ -118,7 +118,7 @@ public: virtual void DestroyFrame( SalFrame* pFrame ) override; // Object (System Child Window) - virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow = true ) override; + virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow ) override; virtual void DestroyObject( SalObject* pObject ) override; // VirtualDevice diff --git a/vcl/inc/impgraph.hxx b/vcl/inc/impgraph.hxx index 817b9cf..cafad4e 100644 --- a/vcl/inc/impgraph.hxx +++ b/vcl/inc/impgraph.hxx @@ -102,10 +102,10 @@ private: void ImplStartAnimation( OutputDevice* pOutDev, const Point& rDestPt, const Size& rDestSize, - long nExtraData = 0, - OutputDevice* pFirstFrameOutDev = nullptr ); - void ImplStopAnimation( OutputDevice* pOutputDevice = nullptr, - long nExtraData = 0 ); + long nExtraData, + OutputDevice* pFirstFrameOutDev ); + void ImplStopAnimation( OutputDevice* pOutputDevice, + long nExtraData ); void ImplSetAnimationNotifyHdl( const Link<Animation*,void>& rLink ); Link<Animation*,void> ImplGetAnimationNotifyHdl() const; diff --git a/vcl/inc/opengl/program.hxx b/vcl/inc/opengl/program.hxx index 82f5c2c..73cdb7f 100644 --- a/vcl/inc/opengl/program.hxx +++ b/vcl/inc/opengl/program.hxx @@ -70,7 +70,7 @@ public: GLuint Id() { return mnId; } bool Load( const OUString& rVertexShader, const OUString& rFragmentShader, - const rtl::OString& preamble = "", const rtl::OString& rDigest = "" ); + const rtl::OString& preamble, const rtl::OString& rDigest ); bool Use(); void Reuse(); bool Clean(); diff --git a/vcl/inc/opengl/texture.hxx b/vcl/inc/opengl/texture.hxx index 95126ff..7044119 100644 --- a/vcl/inc/opengl/texture.hxx +++ b/vcl/inc/opengl/texture.hxx @@ -59,7 +59,7 @@ public: return mnRefCount == 1; } - bool InitializeSlotMechanism(int nInitialSlotSize = 0); + bool InitializeSlotMechanism(int nInitialSlotSize); void SetSlotDeallocateCallback(std::function<void(int)> aCallback) { diff --git a/vcl/inc/openglgdiimpl.hxx b/vcl/inc/openglgdiimpl.hxx index cf10036..1bc9ef5 100644 --- a/vcl/inc/openglgdiimpl.hxx +++ b/vcl/inc/openglgdiimpl.hxx @@ -122,7 +122,7 @@ public: void DrawConvexPolygon( sal_uInt32 nPoints, const SalPoint* pPtAry, bool blockAA = false ); void DrawConvexPolygon( const tools::Polygon& rPolygon, bool blockAA = false ); - void DrawTrapezoid( const basegfx::B2DTrapezoid& trapezoid, bool blockAA = false ); + void DrawTrapezoid( const basegfx::B2DTrapezoid& trapezoid, bool blockAA ); void DrawRect( long nX, long nY, long nWidth, long nHeight ); void DrawRect( const Rectangle& rRect ); void DrawPolygon( sal_uInt32 nPoints, const SalPoint* pPtAry ); @@ -132,7 +132,7 @@ public: void DrawTextureRect( OpenGLTexture& rTexture, const SalTwoRect& rPosAry, bool bInverted = false ); void DrawTexture( OpenGLTexture& rTexture, const SalTwoRect& rPosAry, bool bInverted = false ); void DrawTransformedTexture( OpenGLTexture& rTexture, OpenGLTexture& rMask, const basegfx::B2DPoint& rNull, const basegfx::B2DPoint& rX, const basegfx::B2DPoint& rY ); - void DrawAlphaTexture( OpenGLTexture& rTexture, const SalTwoRect& rPosAry, bool bInverted = false, bool pPremultiplied = false ); + void DrawAlphaTexture( OpenGLTexture& rTexture, const SalTwoRect& rPosAry, bool bInverted, bool pPremultiplied ); void DrawTextureDiff( OpenGLTexture& rTexture, OpenGLTexture& rMask, const SalTwoRect& rPosAry, bool bInverted = false ); void DrawTextureWithMask( OpenGLTexture& rTexture, OpenGLTexture& rMask, const SalTwoRect& rPosAry ); void DrawBlendedTexture( OpenGLTexture& rTexture, OpenGLTexture& rMask, OpenGLTexture& rAlpha, const SalTwoRect& rPosAry ); diff --git a/vcl/inc/salgdi.hxx b/vcl/inc/salgdi.hxx index 51b5e3e..c8f9a1c 100644 --- a/vcl/inc/salgdi.hxx +++ b/vcl/inc/salgdi.hxx @@ -131,7 +131,7 @@ public: void ReleaseFonts() { SetFont( nullptr, 0 ); } // get the current font's metrics - virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel = 0 ) = 0; + virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel ) = 0; // get the repertoire of the current font virtual const FontCharMapPtr GetFontCharMap() const = 0; diff --git a/vcl/inc/salinst.hxx b/vcl/inc/salinst.hxx index b6a93fc..bd40723 100644 --- a/vcl/inc/salinst.hxx +++ b/vcl/inc/salinst.hxx @@ -81,7 +81,7 @@ public: virtual void DestroyFrame( SalFrame* pFrame ) = 0; // Object (System Child Window) - virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow = true ) = 0; + virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow ) = 0; virtual void DestroyObject( SalObject* pObject ) = 0; // VirtualDevice diff --git a/vcl/inc/textlayout.hxx b/vcl/inc/textlayout.hxx index f057c5c..7371abd 100644 --- a/vcl/inc/textlayout.hxx +++ b/vcl/inc/textlayout.hxx @@ -91,8 +91,8 @@ namespace vcl virtual ~ControlTextRenderer(); Rectangle DrawText( const Rectangle& _rRect, - const OUString& _rText, DrawTextFlags _nStyle = DrawTextFlags::NONE, - MetricVector* _pVector = nullptr, OUString* _pDisplayText = nullptr ); + const OUString& _rText, DrawTextFlags _nStyle, + MetricVector* _pVector, OUString* _pDisplayText ); private: ControlTextRenderer( const ControlTextRenderer& ) = delete; diff --git a/vcl/inc/unx/genpspgraphics.h b/vcl/inc/unx/genpspgraphics.h index ecafc8ea..f38dc0e 100644 --- a/vcl/inc/unx/genpspgraphics.h +++ b/vcl/inc/unx/genpspgraphics.h @@ -93,7 +93,7 @@ public: virtual void SetTextColor( SalColor nSalColor ) override; virtual void SetFont( FontSelectPattern*, int nFallbackLevel ) override; - virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel = 0 ) override; + virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel ) override; virtual const FontCharMapPtr GetFontCharMap() const override; virtual bool GetFontCapabilities(vcl::FontCapabilities &rFontCapabilities) const override; virtual void GetDevFontList( PhysicalFontCollection* ) override; diff --git a/vcl/inc/unx/gtk/gtkinst.hxx b/vcl/inc/unx/gtk/gtkinst.hxx index 3864084..e29d221 100644 --- a/vcl/inc/unx/gtk/gtkinst.hxx +++ b/vcl/inc/unx/gtk/gtkinst.hxx @@ -204,7 +204,7 @@ public: virtual SalFrame* CreateFrame( SalFrame* pParent, SalFrameStyleFlags nStyle ) override; virtual SalFrame* CreateChildFrame( SystemParentData* pParent, SalFrameStyleFlags nStyle ) override; - virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow = true ) override; + virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow ) override; virtual SalSystem* CreateSalSystem() override; virtual SalInfoPrinter* CreateInfoPrinter(SalPrinterQueueInfo* pPrinterQueueInfo, ImplJobSetup* pJobSetup) override; virtual SalPrinter* CreatePrinter( SalInfoPrinter* pInfoPrinter ) override; diff --git a/vcl/inc/unx/printergfx.hxx b/vcl/inc/unx/printergfx.hxx index ac261d4..f7f1367 100644 --- a/vcl/inc/unx/printergfx.hxx +++ b/vcl/inc/unx/printergfx.hxx @@ -374,7 +374,7 @@ public: { return maVirtualStatus.mbArtBold; } void DrawText (const Point& rPoint, const sal_Unicode* pStr, sal_Int16 nLen, - const sal_Int32* pDeltaArray = nullptr); + const sal_Int32* pDeltaArray); void SetTextColor (PrinterColor& rTextColor) { maTextColor = rTextColor; } sal_Int32 GetCharWidth (sal_uInt16 nFrom, sal_uInt16 nTo, diff --git a/vcl/inc/unx/printerjob.hxx b/vcl/inc/unx/printerjob.hxx index 8f283cda..5ed6abe 100644 --- a/vcl/inc/unx/printerjob.hxx +++ b/vcl/inc/unx/printerjob.hxx @@ -75,7 +75,7 @@ private: bool writeFeatureList( osl::File* pFile, const JobData&, bool bDocumentSetup ); bool writeSetup( osl::File* pFile, const JobData& ); - bool writePageSetup( osl::File* pFile, const JobData&, bool bWriteFeatures = true ); + bool writePageSetup( osl::File* pFile, const JobData&, bool bWriteFeatures ); static void writeJobPatch( osl::File* File, const JobData& ); static bool writeProlog (osl::File* pFile, const JobData& ); diff --git a/vcl/inc/unx/salbmp.h b/vcl/inc/unx/salbmp.h index 761bbb6..88a8668 100644 --- a/vcl/inc/unx/salbmp.h +++ b/vcl/inc/unx/salbmp.h @@ -229,7 +229,7 @@ public: ImplSalBitmapCache(); ~ImplSalBitmapCache(); - void ImplAdd( X11SalBitmap* pBmp, sal_uIntPtr nMemSize = 0UL ); + void ImplAdd( X11SalBitmap* pBmp, sal_uIntPtr nMemSize ); void ImplRemove( X11SalBitmap* pBmp ); void ImplClear(); }; diff --git a/vcl/inc/unx/salgdi.h b/vcl/inc/unx/salgdi.h index 1c48f05..a9c91ed 100644 --- a/vcl/inc/unx/salgdi.h +++ b/vcl/inc/unx/salgdi.h @@ -117,7 +117,7 @@ public: virtual void SetTextColor( SalColor nSalColor ) override; virtual void SetFont( FontSelectPattern*, int nFallbackLevel ) override; - virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel = 0 ) override; + virtual void GetFontMetric( ImplFontMetricDataPtr&, int nFallbackLevel ) override; virtual const FontCharMapPtr GetFontCharMap() const override; virtual bool GetFontCapabilities(vcl::FontCapabilities &rFontCapabilities) const override; virtual void GetDevFontList( PhysicalFontCollection* ) override; diff --git a/vcl/inc/unx/salinst.h b/vcl/inc/unx/salinst.h index d3f5fa7..5bf339b 100644 --- a/vcl/inc/unx/salinst.h +++ b/vcl/inc/unx/salinst.h @@ -51,7 +51,7 @@ public: virtual SalFrame* CreateFrame( SalFrame* pParent, SalFrameStyleFlags nStyle ) override; virtual void DestroyFrame( SalFrame* pFrame ) override; - virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow = true ) override; + virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow ) override; virtual void DestroyObject( SalObject* pObject ) override; /// Gtk vclplug needs to pass GtkSalGraphics to X11SalVirtualDevice, so create it, and pass as pNewGraphics. diff --git a/vcl/source/edit/textdoc.hxx b/vcl/source/edit/textdoc.hxx index 9f8b5fc..9f0929f 100644 --- a/vcl/source/edit/textdoc.hxx +++ b/vcl/source/edit/textdoc.hxx @@ -54,7 +54,7 @@ public: bool& HasEmptyAttribs() { return mbHasEmptyAttribs; } TextCharAttrib* FindAttrib( sal_uInt16 nWhich, sal_Int32 nPos ); - const TextCharAttrib* FindNextAttrib( sal_uInt16 nWhich, sal_Int32 nFromPos, sal_Int32 nMaxPos = SAL_MAX_INT32 ) const; + const TextCharAttrib* FindNextAttrib( sal_uInt16 nWhich, sal_Int32 nFromPos, sal_Int32 nMaxPos ) const; TextCharAttrib* FindEmptyAttrib( sal_uInt16 nWhich, sal_Int32 nPos ); bool HasAttrib( sal_uInt16 nWhich ) const; bool HasBoundingAttrib( sal_Int32 nBound ); diff --git a/vcl/source/gdi/pdfwriter_impl.hxx b/vcl/source/gdi/pdfwriter_impl.hxx index b55c55b..669bd92 100644 --- a/vcl/source/gdi/pdfwriter_impl.hxx +++ b/vcl/source/gdi/pdfwriter_impl.hxx @@ -805,7 +805,7 @@ i12626 /* writes all gradient patterns */ bool emitGradients(); /* writes a builtin font object and returns its objectid (or 0 in case of failure ) */ - sal_Int32 emitBuiltinFont( const PdfBuiltinFontFace*, sal_Int32 nObject = -1 ); + sal_Int32 emitBuiltinFont( const PdfBuiltinFontFace*, sal_Int32 nObject ); /* writes a type1 embedded font object and returns its mapping from font ids to object ids (or 0 in case of failure ) */ std::map< sal_Int32, sal_Int32 > emitEmbeddedFont( const PhysicalFontFace*, EmbedFont& ); /* writes a type1 system font object and returns its mapping from font ids to object ids (or 0 in case of failure ) */ @@ -1165,7 +1165,7 @@ public: void emitComment( const char* pComment ); //--->i56629 named destinations - sal_Int32 createNamedDest( const OUString& sDestName, const Rectangle& rRect, sal_Int32 nPageNr = -1, PDFWriter::DestAreaType eType = PDFWriter::XYZ ); + sal_Int32 createNamedDest( const OUString& sDestName, const Rectangle& rRect, sal_Int32 nPageNr, PDFWriter::DestAreaType eType ); //--->i59651 //emits output intent @@ -1175,21 +1175,21 @@ public: sal_Int32 emitDocumentMetadata(); // links - sal_Int32 createLink( const Rectangle& rRect, sal_Int32 nPageNr = -1 ); + sal_Int32 createLink( const Rectangle& rRect, sal_Int32 nPageNr ); sal_Int32 createDest( const Rectangle& rRect, sal_Int32 nPageNr = -1, PDFWriter::DestAreaType eType = PDFWriter::XYZ ); - sal_Int32 registerDestReference( sal_Int32 nDestId, const Rectangle& rRect, sal_Int32 nPageNr = -1, PDFWriter::DestAreaType eType = PDFWriter::XYZ ); + sal_Int32 registerDestReference( sal_Int32 nDestId, const Rectangle& rRect, sal_Int32 nPageNr, PDFWriter::DestAreaType eType ); void setLinkDest( sal_Int32 nLinkId, sal_Int32 nDestId ); void setLinkURL( sal_Int32 nLinkId, const OUString& rURL ); void setLinkPropertyId( sal_Int32 nLinkId, sal_Int32 nPropertyId ); // outline - sal_Int32 createOutlineItem( sal_Int32 nParent = 0, const OUString& rText = OUString(), sal_Int32 nDestID = -1 ); + sal_Int32 createOutlineItem( sal_Int32 nParent, const OUString& rText, sal_Int32 nDestID ); void setOutlineItemParent( sal_Int32 nItem, sal_Int32 nNewParent ); void setOutlineItemText( sal_Int32 nItem, const OUString& rText ); void setOutlineItemDest( sal_Int32 nItem, sal_Int32 nDestID ); // notes - void createNote( const Rectangle& rRect, const PDFNote& rNote, sal_Int32 nPageNr = -1 ); + void createNote( const Rectangle& rRect, const PDFNote& rNote, sal_Int32 nPageNr ); // structure elements sal_Int32 beginStructureElement( PDFWriter::StructElement eType, const OUString& rAlias ); void endStructureElement(); @@ -1201,8 +1201,8 @@ public: void setAlternateText( const OUString& rText ); // transitional effects - void setAutoAdvanceTime( sal_uInt32 nSeconds, sal_Int32 nPageNr = -1 ); - void setPageTransition( PDFWriter::PageTransition eType, sal_uInt32 nMilliSec, sal_Int32 nPageNr = -1 ); + void setAutoAdvanceTime( sal_uInt32 nSeconds, sal_Int32 nPageNr ); + void setPageTransition( PDFWriter::PageTransition eType, sal_uInt32 nMilliSec, sal_Int32 nPageNr ); // controls sal_Int32 createControl( const PDFWriter::AnyWidget& rControl, sal_Int32 nPageNr = -1 ); diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx index 25a9fad..520999f 100644 --- a/vcl/source/outdev/font.cxx +++ b/vcl/source/outdev/font.cxx @@ -1095,7 +1095,7 @@ bool OutputDevice::ImplNewFont() const pFontInstance->mbInit = true; pFontInstance->mxFontMetric->SetOrientation( sal::static_int_cast<short>(pFontInstance->maFontSelData.mnOrientation) ); - pGraphics->GetFontMetric( pFontInstance->mxFontMetric ); + pGraphics->GetFontMetric( pFontInstance->mxFontMetric, 0 ); pFontInstance->mxFontMetric->ImplInitTextLineSize( this ); pFontInstance->mxFontMetric->ImplInitAboveTextLineSize(); diff --git a/vcl/unx/generic/dtrans/X11_selection.hxx b/vcl/unx/generic/dtrans/X11_selection.hxx index 9a678b2..232a2ad 100644 --- a/vcl/unx/generic/dtrans/X11_selection.hxx +++ b/vcl/unx/generic/dtrans/X11_selection.hxx @@ -418,7 +418,7 @@ namespace x11 { // compound text conversion OString convertToCompound( const OUString& rText ); - OUString convertFromCompound( const char* pText, int nLen = -1 ); + OUString convertFromCompound( const char* pText, int nLen ); sal_Int8 getUserDragAction() const; sal_Int32 getSelectionTimeout(); diff --git a/vcl/unx/generic/printer/ppdparser.cxx b/vcl/unx/generic/printer/ppdparser.cxx index 3024b1e..2a62dcf 100644 --- a/vcl/unx/generic/printer/ppdparser.cxx +++ b/vcl/unx/generic/printer/ppdparser.cxx @@ -122,7 +122,7 @@ namespace psp static css::lang::Locale normalizeInputLocale( const css::lang::Locale& i_rLocale, - bool bInsertDefault = false + bool bInsertDefault ) { css::lang::Locale aLoc( i_rLocale ); diff --git a/xmlhelp/source/cxxhelp/provider/databases.hxx b/xmlhelp/source/cxxhelp/provider/databases.hxx index 432607a..b1e0230 100644 --- a/xmlhelp/source/cxxhelp/provider/databases.hxx +++ b/xmlhelp/source/cxxhelp/provider/databases.hxx @@ -430,7 +430,7 @@ namespace chelp { css::uno::Reference< css::container::XHierarchicalNameAccess > nextJarFile( css::uno::Reference< css::deployment::XPackage >& o_xParentPackageBundle, - OUString* o_pExtensionPath = nullptr, OUString* o_pExtensionRegistryPath = nullptr ); + OUString* o_pExtensionPath, OUString* o_pExtensionRegistryPath ); private: css::uno::Reference< css::container::XHierarchicalNameAccess > diff --git a/xmloff/source/style/impastpl.hxx b/xmloff/source/style/impastpl.hxx index 5e65632..992c188 100644 --- a/xmloff/source/style/impastpl.hxx +++ b/xmloff/source/style/impastpl.hxx @@ -82,7 +82,7 @@ public: ~XMLAutoStylePoolParent(); - bool Add( XMLAutoStyleFamily& rFamilyData, const ::std::vector< XMLPropertyState >& rProperties, OUString& rName, bool bDontSeek = false ); + bool Add( XMLAutoStyleFamily& rFamilyData, const ::std::vector< XMLPropertyState >& rProperties, OUString& rName, bool bDontSeek ); bool AddNamed( XMLAutoStyleFamily& rFamilyData, const ::std::vector< XMLPropertyState >& rProperties, const OUString& rName ); @@ -151,7 +151,7 @@ public: void AddFamily( sal_Int32 nFamily, const OUString& rStrName, const rtl::Reference < SvXMLExportPropertyMapper > & rMapper, - const OUString& rStrPrefix, bool bAsFamily = true ); + const OUString& rStrPrefix, bool bAsFamily ); void SetFamilyPropSetMapper( sal_Int32 nFamily, const rtl::Reference < SvXMLExportPropertyMapper > & rMapper ); void RegisterName( sal_Int32 nFamily, const OUString& rName ); diff --git a/xmloff/source/style/xmlexppr.cxx b/xmloff/source/style/xmlexppr.cxx index 1201dbc..804f788 100644 --- a/xmloff/source/style/xmlexppr.cxx +++ b/xmloff/source/style/xmlexppr.cxx @@ -192,7 +192,7 @@ public: vector< XMLPropertyState >& rPropStates, const Reference< XPropertySet >& xPropSet, const rtl::Reference< XMLPropertySetMapper >& maPropMapper, - const bool bDefault = false); + const bool bDefault); sal_uInt32 GetPropertyCount() const { return nCount; } }; diff --git a/xmlsecurity/qa/unit/signing/signing.cxx b/xmlsecurity/qa/unit/signing/signing.cxx index 767b0fa..7065d0d 100644 --- a/xmlsecurity/qa/unit/signing/signing.cxx +++ b/xmlsecurity/qa/unit/signing/signing.cxx @@ -95,8 +95,8 @@ public: CPPUNIT_TEST_SUITE_END(); private: - void createDoc(const OUString& rURL = OUString()); - void createCalc(const OUString& rURL = OUString()); + void createDoc(const OUString& rURL); + void createCalc(const OUString& rURL); uno::Reference<security::XCertificate> getCertificate(XMLSignatureHelper& rSignatureHelper); }; @@ -161,7 +161,7 @@ uno::Reference<security::XCertificate> SigningTest::getCertificate(XMLSignatureH void SigningTest::testDescription() { // Create an empty document and store it to a tempfile, finally load it as a storage. - createDoc(); + createDoc(""); utl::TempFile aTempFile; aTempFile.EnableKillingFile(); @@ -194,7 +194,7 @@ void SigningTest::testDescription() void SigningTest::testOOXMLDescription() { // Create an empty document and store it to a tempfile, finally load it as a storage. - createDoc(); + createDoc(""); utl::TempFile aTempFile; aTempFile.EnableKillingFile(); _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits