[PATCH] Modified the wording of the Save-on-Exit-Dialog

2012-08-27 Thread Gerrit 
>From Samuel Mehrbrodt :

Samuel Mehrbrodt has uploaded a new change for review.

Change subject: Modified the wording of the Save-on-Exit-Dialog
..

Modified the wording of the Save-on-Exit-Dialog

Change-Id: Ie3a02efc4541754ba553909ad03a115258890351
---
M sfx2/inc/sfx2/sfx.hrc
M sfx2/source/doc/QuerySaveDocument.cxx
M sfx2/source/doc/doc.src
3 files changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/491/1
--
To view, visit https://gerrit.libreoffice.org/491
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3a02efc4541754ba553909ad03a115258890351
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Modified the wording of the Save-on-Exit-Dialog

2012-08-23 Thread Jean-Tiare LE BIGOT 

Wow, Much nicer this way !

Le 2012-08-23 21:47, Samuel Mehrbrodt a écrit :

Hi,

I have a suggestion to change the wording of the Dialog which appears
when you close a document and unsaved changes exist.

See attached images with the difference before/after.

I wrote a mail to the ux-advise list [1] before and asked if this
could be changed, but there was no reply (except one came to me
directly, he was ok with it).

I would also like to change the button order (move the Save button to
the right), but I don't know how it fits with Windows/Mac.

I needed to create a new translation string for the dialog title, is
that ok the way I did it? Did I forget something?

Thanks,
Samuel

[1]

http://nabble.documentfoundation.org/Libreoffice-ux-advise-Exit-Dialog-Button-Order-and-Wording-tp4001483.html

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


--
Jean-Tiare LE BIGOT
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Modified the wording of the Save-on-Exit-Dialog

2012-08-23 Thread Samuel Mehrbrodt 

Hi,

I have a suggestion to change the wording of the Dialog which appears 
when you close a document and unsaved changes exist.


See attached images with the difference before/after.

I wrote a mail to the ux-advise list [1] before and asked if this could 
be changed, but there was no reply (except one came to me directly, he 
was ok with it).


I would also like to change the button order (move the Save button to 
the right), but I don't know how it fits with Windows/Mac.


I needed to create a new translation string for the dialog title, is 
that ok the way I did it? Did I forget something?


Thanks,
Samuel

[1] 
http://nabble.documentfoundation.org/Libreoffice-ux-advise-Exit-Dialog-Button-Order-and-Wording-tp4001483.html
>From 56e70a37ac203f361bb4a493cc1562fc9038f045 Mon Sep 17 00:00:00 2001
From: Samuel Mehrbrodt 
Date: Thu, 23 Aug 2012 21:33:05 +0200
Subject: [PATCH] Modified the wording of the Save-on-Exit-Dialog

Change-Id: I1714f254c4fb279bbb9e67881641566c21b7ec35
---
 sfx2/inc/sfx2/sfx.hrc |1 +
 sfx2/source/doc/QuerySaveDocument.cxx |1 +
 sfx2/source/doc/doc.src   |8 ++--
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/sfx2/inc/sfx2/sfx.hrc b/sfx2/inc/sfx2/sfx.hrc
index 0d44061..c215a18 100644
--- a/sfx2/inc/sfx2/sfx.hrc
+++ b/sfx2/inc/sfx2/sfx.hrc
@@ -162,6 +162,7 @@
 #define STR_KB  (RID_SFX_START+112)
 #define STR_MB  (RID_SFX_START+113)
 #define STR_GB  (RID_SFX_START+114)
+#define STR_QUERY_SAVE_DOCUMENT_TITLE   (RID_SFX_START+115)
 
 #define STR_STANDARD_SHORTCUT   (RID_SFX_START+117)
 #define STR_REPAIREDDOCUMENT(RID_SFX_START+118)
diff --git a/sfx2/source/doc/QuerySaveDocument.cxx b/sfx2/source/doc/QuerySaveDocument.cxx
index 2510e9a..fdcb870 100644
--- a/sfx2/source/doc/QuerySaveDocument.cxx
+++ b/sfx2/source/doc/QuerySaveDocument.cxx
@@ -36,6 +36,7 @@ short ExecuteQuerySaveDocument(Window* _pParent,const String& _rTitle)
 aText.SearchAndReplace( DEFINE_CONST_UNICODE( "$(DOC)" ),
 _rTitle );
 QueryBox aQBox( _pParent, WB_YES_NO_CANCEL | WB_DEF_YES, aText );
+aQBox.SetText(SfxResId(STR_QUERY_SAVE_DOCUMENT_TITLE).toString());
 aQBox.SetButtonText( BUTTONID_NO, SfxResId(STR_NOSAVEANDCLOSE).toString() );
 aQBox.SetButtonText( BUTTONID_YES, SfxResId(STR_SAVEDOC).toString() );
 return aQBox.Execute();
diff --git a/sfx2/source/doc/doc.src b/sfx2/source/doc/doc.src
index 3b5293d..640283d 100644
--- a/sfx2/source/doc/doc.src
+++ b/sfx2/source/doc/doc.src
@@ -46,9 +46,13 @@ QueryBox MSG_REGION_NOTEMPTY
 DefButton = WB_DEF_NO ;
 Message [ en-US ] = "The category is not empty.\nDelete anyway?" ;
 };
+String STR_QUERY_SAVE_DOCUMENT_TITLE
+{
+Text [ en-US ] = "Save document" ;
+};
 String STR_QUERY_SAVE_DOCUMENT
 {
-Text [ en-US ] = "The document \"$(DOC)\" has been modified.\nDo you want to save your changes?" ;
+Text [ en-US ] = "Save changes to document \"$(DOC)\" before closing?" ;
 };
 Bitmap BMP_STYLES_CLOSED { File = "newex.bmp" ; };
 Bitmap BMP_STYLES_OPENED { File = "newex.bmp" ; };
@@ -307,7 +311,7 @@ String STR_DOCTYPENAME_MESSAGE
 
 String STR_NOSAVEANDCLOSE
 {
-Text [ en-US ] = "~Discard" ;
+Text [ en-US ] = "Close ~without saving" ;
 };
 
 String STR_PACKNGO_NOACCESS
-- 
1.7.9.5

<><>___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice