[PATCH] Remove unused code
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3447
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3447/1
Remove unused code
Change-Id: Id4ce1d003db61374ba68f807090860595178b562
---
M chart2/source/controller/dialogs/res_ErrorBar.cxx
1 file changed, 0 insertions(+), 7 deletions(-)
diff --git a/chart2/source/controller/dialogs/res_ErrorBar.cxx
b/chart2/source/controller/dialogs/res_ErrorBar.cxx
index 713bb08..1a8c2fe 100644
--- a/chart2/source/controller/dialogs/res_ErrorBar.cxx
+++ b/chart2/source/controller/dialogs/res_ErrorBar.cxx
@@ -80,13 +80,6 @@
{
//.
-enum StatIndicator
-{
-INDICATE_BOTH,
-INDICATE_UP,
-INDICATE_DOWN
-};
-
ErrorBarResources::ErrorBarResources( Window* pParent, Dialog * pParentDialog,
const SfxItemSet rInAttrs, bool
bNoneAvailable,
tErrorBarType eType /* = ERROR_BAR_Y */
) :
--
To view, visit https://gerrit.libreoffice.org/3447
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4ce1d003db61374ba68f807090860595178b562
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Dunphy michael.w.dun...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code.
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3167
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3167/1
remove unused code.
A request (rReq) having anyone of following SID
SID_ATTR_CHAR_FONTHEIGHT, SID_ATTR_CHAR_FONT,SID_ATTR_CHAR_COLOR
doesn’t have a NULL pArgs .
that’s why execution control never enters into
drtxtob1.cxx:349 - if( !pArgs ) block of code
for a request (rReq) having anyone of mentioned SIDs.
Change-Id: I77945dd81108b3e0d3282fa7547311868f0bafae
---
M sd/source/ui/view/drtxtob1.cxx
1 file changed, 0 insertions(+), 32 deletions(-)
diff --git a/sd/source/ui/view/drtxtob1.cxx b/sd/source/ui/view/drtxtob1.cxx
index 4163ff1..e8e1179 100644
--- a/sd/source/ui/view/drtxtob1.cxx
+++ b/sd/source/ui/view/drtxtob1.cxx
@@ -476,38 +476,6 @@
aNewAttr.Put( aItem );
}
break;
-
-// attributes for TextObjectBar
-case SID_ATTR_CHAR_FONT:
-{
-if( pArgs )
-{
-if( SFX_ITEM_SET == pArgs-GetItemState(
EE_CHAR_FONTINFO, sal_True, pPoolItem ) )
-aNewAttr.Put( *pPoolItem );
-}
-else
-mpViewShell-GetViewFrame()-GetDispatcher()-
-Execute( SID_CHAR_DLG, SFX_CALLMODE_ASYNCHRON );
-}
-break;
-case SID_ATTR_CHAR_FONTHEIGHT:
-{
-if( pArgs )
-{
-if( SFX_ITEM_SET == pArgs-GetItemState(
EE_CHAR_FONTHEIGHT, sal_True, pPoolItem ) )
-aNewAttr.Put( *pPoolItem );
-}
-else
-mpViewShell-GetViewFrame()-GetDispatcher()-
-Execute( SID_CHAR_DLG, SFX_CALLMODE_ASYNCHRON );
-}
-break;
-case SID_ATTR_CHAR_COLOR:
-{
-if( pArgs SFX_ITEM_SET == pArgs-GetItemState(
EE_CHAR_COLOR, sal_True, pPoolItem ) )
-aNewAttr.Put( *pPoolItem );
-}
-break;
// #i35937# removed need for FN_NUM_BULLET_ON handling
}
--
To view, visit https://gerrit.libreoffice.org/3167
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77945dd81108b3e0d3282fa7547311868f0bafae
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: navin patidar pati...@kacst.edu.sa
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code svtools/bmpmaker
David Ostrovsky has created a new patch set by issuing a rebase in Gerrit (#4). Change subject: remove unused code svtools/bmpmaker .. remove unused code svtools/bmpmaker Investigated the usage of bmpmaker for fdo#39445, seemingly it's not used anywhere. I removed it but I would be happier if someone could confirm this. Change-Id: I21c98e7857299aef8c482bb07750f4c13529c937 --- M Repository.mk D svtools/Executable_bmp.mk D svtools/Executable_bmpsum.mk D svtools/Executable_g2g.mk M svtools/Module_svtools.mk D svtools/bmpmaker/bmp.cxx D svtools/bmpmaker/bmp.hrc D svtools/bmpmaker/bmp.src D svtools/bmpmaker/bmpcore.cxx D svtools/bmpmaker/bmpcore.hxx D svtools/bmpmaker/bmpsum.cxx D svtools/bmpmaker/g2g.cxx 12 files changed, 0 insertions(+), 1,751 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/2868/4 -- To view, visit https://gerrit.libreoffice.org/2868 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21c98e7857299aef8c482bb07750f4c13529c937 Gerrit-PatchSet: 4 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Krisztian Pinter pin.termina...@gmail.com Gerrit-Reviewer: Krisztian Pinter pin.termina...@gmail.com Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Noel Power noel.po...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/682 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/682/1 Remove unused code According to unusedcode.easy Change-Id: I31edd26d8ee7934b47ed7bf5ec6c07e1b8c5c5e9 --- M sd/source/ui/dlg/RemoteDialogClientBox.cxx 1 file changed, 0 insertions(+), 194 deletions(-) -- To view, visit https://gerrit.libreoffice.org/682 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I31edd26d8ee7934b47ed7bf5ec6c07e1b8c5c5e9 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Olivier Hallot olivier.hal...@alta.org.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code
From Babati Bence b.baa...@gmail.com: Babati Bence has uploaded a new change for review. Change subject: remove unused code .. remove unused code Change-Id: I49e84449a0ea1f77ff4d14b3631aeb7670d4f4e7 --- M sd/inc/pglink.hxx M sd/source/core/pglink.cxx 2 files changed, 0 insertions(+), 66 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/516/1 -- To view, visit https://gerrit.libreoffice.org/516 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I49e84449a0ea1f77ff4d14b3631aeb7670d4f4e7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Babati Bence b.baa...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (24)
On Sun, 2012-04-29 at 16:16 +0800, Elton Chung wrote: Hi there, This patch removes 1 unused method. Looks good to me, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (24)
Hi there, This patch removes 1 unused method. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email : el...@layerjet.com - Remove-unused-code-24.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Remove unused code (ImpSvtData)
On Wed, 2012-04-25 at 05:16 -0700, Javier Catala wrote: Hi everyone, This patch removes unused destructor in the ImpSvtData class, as listed in unusedcode.easy Yeah, but see unusedcode.README and f. If the constructor used, but the destructor is unused. Then its probably a leak and we should try and fix the leak and call the destructor somewhere rather than removing the destructor. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [RESOLVED][PATCH] Remove unused code (ImpSvtData)
On Wed, 2012-04-25 at 13:47 +0100, Caolán McNamara wrote: We should try and fix the leak and call the destructor somewhere rather than removing the destructor. Refactored now to not leave that gotcha in the unusedcode.easy list. Fixed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] PATCH: Remove unused code from editing
Thanks Caolan, I have not used a development environment and I have not noticed the lapse. I'm usually spoiled by working with Eclipse and automatically notify me of these errors. Did I correct it and send it back to? Yeah right, I will confirm the terms of license LGPLv3 + / MPL + combination. Sorry for my English. De: Caolán McNamara caol...@redhat.com Para: Vicente Rafael Estévez Vacas rafaeste...@yahoo.es CC: libreoffice@lists.freedesktop.org libreoffice@lists.freedesktop.org Enviado: Martes 24 de abril de 2012 0:22 Asunto: Re: [PUSHED] PATCH: Remove unused code from editing On Mon, 2012-04-23 at 17:13 +0100, Vicente Rafael Estévez Vacas wrote: Asunto: PATCH: Remove unused code from editing Basically good. Though you need to build after your make your changes to pick up that there's a small mixup between the unused sdr::contact::ViewObjectContactOfUnoControl::isControlVisible and the used sdr::contact::ViewObjectContactOfUnoControl_Impl::impl_isControlVisible_nofail fixed up with http://cgit.freedesktop.org/libreoffice/core/commit/?id=9be39efcc55f9c4a8f7c02bdded299c0ef7e54fd Can you confirm that your code is submitted under our preferred LGPLv3+/MPL+ combination ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in dpitemdata
On Mon, 2012-04-23 at 19:27 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good to me, pushed. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code
On Sun, 2012-04-22 at 20:48 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed. Thanks for this. It bothers me a little that there was a addListener and a removeListener where the addListener is used while removeListener is unused. It suggests that there might be a mistake in the original code where it fails to call removeListener to remove a listener added with addListener. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sc)
On Mon, 2012-04-23 at 19:39 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (ImpSvtData)
Hi everyone,
this patch removes the unused destructor in the ImpSvtData class, as listed in
unusedcode.easy
From bdfc550685d238a62602a4f93da0ab804d77b2f6 Mon Sep 17 00:00:00 2001
From: Javier Catala j_cat...@yahoo.com
Date: Tue, 24 Apr 2012 20:24:17 +0200
Subject: [PATCH] Remove unused ImpSvtData destructor.
Committer: Javier Catala j_cat...@yahoo.com
On branch master
Changes to be committed:
modified: svtools/inc/svtools/svtdata.hxx
modified: svtools/source/misc/svtdata.cxx
modified: unusedcode.easy
---
svtools/inc/svtools/svtdata.hxx |2 --
svtools/source/misc/svtdata.cxx |5 -
unusedcode.easy |1 -
3 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/svtools/inc/svtools/svtdata.hxx b/svtools/inc/svtools/svtdata.hxx
index 8689915..cb96bc5 100644
--- a/svtools/inc/svtools/svtdata.hxx
+++ b/svtools/inc/svtools/svtdata.hxx
@@ -48,8 +48,6 @@ private:
pItemDesruptList(0), pResMgr(0)
{}
-~ImpSvtData();
-
public:
ResMgr * GetResMgr(const ::com::sun::star::lang::Locale aLocale);
ResMgr * GetResMgr(); // VCL dependant, only available in SVT, not in SVL!
diff --git a/svtools/source/misc/svtdata.cxx b/svtools/source/misc/svtdata.cxx
index 66489f1..62b6588 100644
--- a/svtools/source/misc/svtdata.cxx
+++ b/svtools/source/misc/svtdata.cxx
@@ -39,11 +39,6 @@
//
//
-ImpSvtData::~ImpSvtData()
-{
-delete pResMgr;
-}
-
//
ResMgr * ImpSvtData::GetResMgr(const ::com::sun::star::lang::Locale aLocale)
{
diff --git a/unusedcode.easy b/unusedcode.easy
index d1f5e1d..3ab0009 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -10,7 +10,6 @@ HTMLControls::Insert(HTMLControl const**, unsigned short)
HTMLControls::Insert(HTMLControls const*, unsigned short, unsigned short)
HTMLControls::Remove(HTMLControl const*, unsigned short)
HTMLControls::Remove(unsigned short, unsigned short)
-ImpSvtData::~ImpSvtData()
InsCapOptArr::Insert(InsCapOptArr const*, unsigned short, unsigned short)
InsCapOptArr::Insert(InsCaptionOpt* const, unsigned short)
InsCapOptArr::Insert(InsCaptionOpt* const*, unsigned short)
--
1.7.5.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
PATCH: Remove unused code from editeng
Hello,
These is the patch that I've created. Is my first patch, so I hope this will be
correct. If you detect any problem, please let me know.Thanks!Licence: made
available under the MPL/LGPLv3+
Ferran Vidal From 553d11cbb902cf30f499c27e834d0f5c26c4f134 Mon Sep 17 00:00:00 2001
From: Ferran Vidal vidalmargi...@hotmail.com
Date: Sat, 21 Apr 2012 13:34:26 +0200
Subject: [PATCH] Removed unused code from editeng
---
editeng/source/editeng/editdoc.cxx |5 -
editeng/source/editeng/editdoc.hxx |1 -
2 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/editeng/source/editeng/editdoc.cxx b/editeng/source/editeng/editdoc.cxx
index 23549a7..110daf5 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -2711,11 +2711,6 @@ size_t CharAttribList::Count() const
return aAttribs.size();
}
-void CharAttribList::Clear()
-{
-aAttribs.clear();
-}
-
const EditCharAttrib* CharAttribList::FindAttrib( sal_uInt16 nWhich, sal_uInt16 nPos ) const
{
// Backwards, if one ends where the next starts.
diff --git a/editeng/source/editeng/editdoc.hxx b/editeng/source/editeng/editdoc.hxx
index 531652c..8dfe4f6 100644
--- a/editeng/source/editeng/editdoc.hxx
+++ b/editeng/source/editeng/editdoc.hxx
@@ -236,7 +236,6 @@ public:
voidOptimizeRanges( SfxItemPool rItemPool );
size_t Count() const;
-void Clear();
voidInsertAttrib( EditCharAttrib* pAttrib );
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
PATCH: Remove unused code from editing
- Mensaje reenviado - De: Vicente Rafael Estévez Vacas rafaeste...@yahoo.es Para: libreoffice-boun...@lists.freedesktop.org libreoffice-boun...@lists.freedesktop.org CC: Estévez Vacas Vicente rafaeste...@yahoo.es Enviado: Lunes 23 de abril de 2012 13:39 Asunto: PATCH: Remove unused code from editing Thanks 0001-PATCH-Remove-unused-code-from-editing.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (sc)
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] PATCH: Remove unused code from editing
On Mon, 2012-04-23 at 17:13 +0100, Vicente Rafael Estévez Vacas wrote: Asunto: PATCH: Remove unused code from editing Basically good. Though you need to build after your make your changes to pick up that there's a small mixup between the unused sdr::contact::ViewObjectContactOfUnoControl::isControlVisible and the used sdr::contact::ViewObjectContactOfUnoControl_Impl::impl_isControlVisible_nofail fixed up with http://cgit.freedesktop.org/libreoffice/core/commit/?id=9be39efcc55f9c4a8f7c02bdded299c0ef7e54fd Can you confirm that your code is submitted under our preferred LGPLv3+/MPL+ combination ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sw.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
PATCH: Remove unused code
Hello,These is the patch that I've created.
Licence: made available under the MPL/LGPLv3+
Ferran Vidal
From 5779030032ab9fd94c201a5797fea601011a8ffd Mon Sep 17 00:00:00 2001
From: Ferran Vidal vidalmargi...@hotmail.com
Date: Sun, 22 Apr 2012 21:10:08 +0200
Subject: [PATCH] Remove unused code
---
sc/inc/dbdata.hxx |1 -
sc/source/core/tool/dbdata.cxx |5 -
unusedcode.easy|1 -
3 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/sc/inc/dbdata.hxx b/sc/inc/dbdata.hxx
index 9dcd457..f770deb 100644
--- a/sc/inc/dbdata.hxx
+++ b/sc/inc/dbdata.hxx
@@ -218,7 +218,6 @@ public:
void insert(ScDBData* p);
void erase(iterator itr);
bool empty() const;
-size_t size() const;
bool operator== (const AnonDBs r) const;
};
diff --git a/sc/source/core/tool/dbdata.cxx b/sc/source/core/tool/dbdata.cxx
index 36d1914..60e6d28 100644
--- a/sc/source/core/tool/dbdata.cxx
+++ b/sc/source/core/tool/dbdata.cxx
@@ -852,11 +852,6 @@ bool ScDBCollection::AnonDBs::empty() const
return maDBs.empty();
}
-size_t ScDBCollection::AnonDBs::size() const
-{
-return maDBs.size();
-}
-
bool ScDBCollection::AnonDBs::operator== (const AnonDBs r) const
{
return maDBs == r.maDBs;
diff --git a/unusedcode.easy b/unusedcode.easy
index b62d53a..7a6a78b 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -62,7 +62,6 @@ ScConditionalFormats_Impl::Remove(unsigned short, unsigned short)
ScCsvControl::ScCsvControl(Window*, ScCsvLayoutData const, long)
ScDBCollection::AnonDBs::erase(boost::void_ptr_iterator__gnu_debug::_Safe_iterator__gnu_cxx::__normal_iteratorvoid**, std::__cxx1998::vectorvoid*, std::allocatorvoid* , std::__debug::vectorvoid*, std::allocatorvoid* , ScDBData)
ScDBCollection::AnonDBs::findByTable(short) const
-ScDBCollection::AnonDBs::size() const
ScDPItemData::ScDPItemData(rtl::OUString const*)
ScDPItemData::SetErrorString(rtl::OUString const)
ScDPLabelData::ScDPLabelData(rtl::OUString const, short, bool)
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (vlc)
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-vlc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code (vlc)
Thank you! On 04/23/2012 02:06 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] PATCH: Remove unused code
Pushed. Thank you! On 04/23/2012 12:44 AM, Ferran Vidal i Marginet wrote: Hello, These is the patch that I've created. Licence: made available under the MPL/LGPLv3+ Ferran Vidal ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
PATCH: Remove unused code from Spreadsheet-application-code
Hello,These is the patch that I've created.
Licence: made available under the MPL/LGPLv3+
Ferran Vidal
From 8d19526ff84cab319babf7e6b1f03c05fea5bdf0 Mon Sep 17 00:00:00 2001
From: Ferran Vidal vidalmargi...@hotmail.com
Date: Sat, 21 Apr 2012 18:08:11 +0200
Subject: [PATCH] Remove unused code from Spreadsheet application code
---
sc/inc/cell.hxx |1 -
sc/source/core/data/cell.cxx |5 -
unusedcode.easy |2 --
3 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/sc/inc/cell.hxx b/sc/inc/cell.hxx
index 08fbdfa..b4549d1 100644
--- a/sc/inc/cell.hxx
+++ b/sc/inc/cell.hxx
@@ -207,7 +207,6 @@ public:
DECL_FIXEDMEMPOOL_NEWDEL( ScStringCell )
#endif
-ScStringCell();
explicitScStringCell(const rtl::OUString rString);
#if OSL_DEBUG_LEVEL 0
diff --git a/sc/source/core/data/cell.cxx b/sc/source/core/data/cell.cxx
index 9ccadde..a4e5361 100644
--- a/sc/source/core/data/cell.cxx
+++ b/sc/source/core/data/cell.cxx
@@ -657,11 +657,6 @@ ScValueCell::~ScValueCell()
//
-ScStringCell::ScStringCell() :
-ScBaseCell( CELLTYPE_STRING )
-{
-}
-
ScStringCell::ScStringCell( const rtl::OUString rString ) :
ScBaseCell( CELLTYPE_STRING ),
maString( rString.intern() )
diff --git a/unusedcode.easy b/unusedcode.easy
index 89aa3c8..ef08833 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -1,5 +1,4 @@
CertificateExtension_XmlSecImpl::setCertExtn(com::sun::star::uno::Sequencesigned char, com::sun::star::uno::Sequencesigned char, unsigned char)
-CharAttribList::Clear()
Dialog::Dialog(Window*, ResId const)
EditEngine::GetNextVisPortion(ParaPortion const*) const
FmFieldWinMgr::GetChildWindowId()
@@ -86,7 +85,6 @@ ScRTFColTwips_SAR::_ForEach(unsigned short, unsigned short, unsigned char (*)(un
ScRangeData::ReplaceRangeNamesInUse(std::__debug::mapunsigned short, unsigned short, std::lessunsigned short, std::allocatorstd::pairunsigned short const, unsigned short const)
ScRangeData::ScRangeData(unsigned short)
ScSimpleRangeList::Range::contains(ScSimpleRangeList::Range const) const
-ScStringCell::ScStringCell()
ScTable::ReplaceRangeNamesInUse(short, int, short, int, std::__debug::mapunsigned short, unsigned short, std::lessunsigned short, std::allocatorstd::pairunsigned short const, unsigned short const)
ScTypedStrData::GetValue() const
ScValidationEntries_Impl::Insert(ScValidationData* const, unsigned short)
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] PATCH: Remove unused code from Spreadsheet-application-code
On Sat, 2012-04-21 at 17:20 +0100, Ferran Vidal i Marginet wrote: Hello, These is the patch that I've created. Looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (sc)
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sc.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sd)
On Sat, 2012-04-14 at 20:14 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (connectivity)
On Sat, 2012-04-14 at 19:34 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sc)
On Mon, 2012-04-16 at 20:10 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (connectivity)
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-connectivity.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (sd)
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-sd.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (oox)
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-oox.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (oox)
On Sun, 2012-04-08 at 21:56 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Yup, pushed now. Well, actually Julien removed the same code and got in first. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (oox)
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-oox.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] Remove unused code (vcl)
Hello, On 4 April 2012 17:14, Thomas Collerton tom.col...@gmail.com wrote: Hello all, this patch removes unused code in the Slider class as listed in unusedcode.easy Looks good = pushed Thanks, Matúš ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code (svx)
Pushed. Thank you! On 04/05/2012 12:10 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] remove unused code (oox)
Hi Petr, Petr Vorel píše v Po 02. 04. 2012 v 16:18 +0200: removed unused classes from oox. Pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=07ff032c805835355ff0dff75b8ad534dfb770e9 Thank you! :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (vcl)
Hello all, this patch removes unused code in the Slider class as listed in unusedcode.easy 0001-Remove-unused-code-vcl.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code (oox)
Hi there,
removed unused classes from oox.
Regards,
Petr
From b4350501d1fe85da2cce5750b480e33eb6409301 Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Mon, 2 Apr 2012 11:40:06 +0200
Subject: [PATCH] remove unused code (oox)
---
oox/inc/oox/dump/dumperbase.hxx | 18 --
oox/inc/oox/dump/oledumper.hxx | 21 ---
oox/source/dump/dumperbase.cxx | 107
oox/source/dump/oledumper.cxx | 114 ---
unusedcode.easy | 17 --
5 files changed, 0 insertions(+), 277 deletions(-)
diff --git a/oox/inc/oox/dump/dumperbase.hxx b/oox/inc/oox/dump/dumperbase.hxx
index 7f18220..a099886 100644
--- a/oox/inc/oox/dump/dumperbase.hxx
+++ b/oox/inc/oox/dump/dumperbase.hxx
@@ -395,7 +395,6 @@ public:
// token list -
static void appendToken( ::rtl::OUStringBuffer rStr, const ::rtl::OUString rToken, sal_Unicode cSep = OOX_DUMP_LISTSEP );
-static void appendToken( ::rtl::OUStringBuffer rStr, sal_Int64 nToken, sal_Unicode cSep = OOX_DUMP_LISTSEP );
static void appendIndex( ::rtl::OUStringBuffer rStr, const ::rtl::OUString rIdx );
static void appendIndex( ::rtl::OUStringBuffer rStr, sal_Int64 nIdx );
@@ -1074,9 +1073,6 @@ public:
voidwriteColRowRange( sal_Int32 nColRow1, sal_Int32 nColRow2 );
voidwriteColRange( sal_Int32 nCol1, sal_Int32 nCol2 );
voidwriteRowRange( sal_Int32 nRow1, sal_Int32 nRow2 );
-voidwriteAddress( const Address rPos );
-voidwriteRange( const Range rRange );
-voidwriteRangeList( const RangeList rRanges );
template typename Type
inline void writeDec( Type nData, sal_Int32 nWidth = 0, sal_Unicode cFill = ' ' )
@@ -1349,17 +1345,6 @@ protected:
voidwriteArrayItem( const String rName, const sal_uInt8* pnData, sal_Size nSize, sal_Unicode cSep = OOX_DUMP_LISTSEP );
voidwriteDateTimeItem( const String rName, const ::com::sun::star::util::DateTime rDateTime );
voidwriteGuidItem( const String rName, const ::rtl::OUString rGuid );
-voidwriteColIndexItem( const String rName, sal_Int32 nCol );
-voidwriteRowIndexItem( const String rName, sal_Int32 nRow );
-voidwriteColRangeItem( const String rName, sal_Int32 nCol1, sal_Int32 nCol2 );
-voidwriteRowRangeItem( const String rName, sal_Int32 nRow1, sal_Int32 nRow2 );
-voidwriteAddressItem( const String rName, const Address rPos );
-voidwriteRangeItem( const String rName, const Range rRange );
-voidwriteRangeListItem( const String rName, const RangeList rRanges );
-voidwriteTokenAddressItem( const String rName, const TokenAddress rPos, bool bNameMode );
-voidwriteTokenAddress3dItem( const String rName, const ::rtl::OUString rRef, const TokenAddress rPos, bool bNameMode );
-voidwriteTokenRangeItem( const String rName, const TokenRange rRange, bool bNameMode );
-voidwriteTokenRange3dItem( const String rName, const ::rtl::OUString rRef, const TokenRange rRange, bool bNameMode );
template typename Type
voidaddNameToItem( Type nData, const NameListWrapper rListWrp );
@@ -1753,9 +1738,6 @@ protected:
const OutputObjectBase rParent,
const BinaryInputStreamRef rxStrm,
rtl_TextEncoding eTextEnc );
-voidconstruct(
-const InputObjectBase rParent,
-rtl_TextEncoding eTextEnc );
virtual boolimplIsValid() const;
virtual voidimplDump();
diff --git a/oox/inc/oox/dump/oledumper.hxx b/oox/inc/oox/dump/oledumper.hxx
index 4d3ceaa..64d3d5c 100644
--- a/oox/inc/oox/dump/oledumper.hxx
+++ b/oox/inc/oox/dump/oledumper.hxx
@@ -84,27 +84,6 @@ protected:
};
//
-
-class StdHlinkObject : public OleInputObjectBase
-{
-public:
-explicitStdHlinkObject( const InputObjectBase rParent );
-
-protected:
-virtual voidimplDump();
-
-private:
-::rtl::OUString dumpHyperlinkString( const String rName, bool bUnicode );
-
-booldumpGuidAndMoniker();
-voiddumpUrlMoniker();
-voiddumpFileMoniker();
-voiddumpItemMoniker();
-voiddumpAntiMoniker();
-voiddumpCompositeMoniker
Re: [PUSHED][PATCH] Remove unused code in sqlnode
On Wed, 2012-03-28 at 21:31 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Look good, pushed now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (connectivity)
On Wed, 2012-03-28 at 21:51 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code (oox)
Hi there,
removed unused methods, hope better this time.
Regards,
Petr
From 2d8c47fede9ec6842a98663f16c4efa70f833e22 Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Thu, 29 Mar 2012 11:54:36 +0200
Subject: [PATCH] remove unused code (oox)
---
oox/inc/oox/dump/dffdumper.hxx |1 -
oox/inc/oox/dump/dumperbase.hxx | 10 --
oox/inc/oox/dump/oledumper.hxx |1 -
oox/inc/oox/ole/vbaprojectfilter.hxx |5 ---
oox/source/dump/dffdumper.cxx|6
oox/source/dump/dumperbase.cxx | 53 --
oox/source/dump/oledumper.cxx|5 ---
oox/source/ole/vbaprojectfilter.cxx |5 ---
unusedcode.easy | 12 ---
9 files changed, 0 insertions(+), 98 deletions(-)
diff --git a/oox/inc/oox/dump/dffdumper.hxx b/oox/inc/oox/dump/dffdumper.hxx
index 10f84f3..de0913f 100644
--- a/oox/inc/oox/dump/dffdumper.hxx
+++ b/oox/inc/oox/dump/dffdumper.hxx
@@ -49,7 +49,6 @@ protected:
inline explicit DffStreamObject() {}
using SequenceRecordObjectBase::construct;
-voidconstruct( const OutputObjectBase rParent, const BinaryInputStreamRef rxStrm );
virtual boolimplReadRecordHeader( BinaryInputStream rBaseStrm, sal_Int64 ornRecId, sal_Int64 ornRecSize );
virtual voidimplWriteExtHeader();
diff --git a/oox/inc/oox/dump/dumperbase.hxx b/oox/inc/oox/dump/dumperbase.hxx
index a8b16b0..0dd1abc 100644
--- a/oox/inc/oox/dump/dumperbase.hxx
+++ b/oox/inc/oox/dump/dumperbase.hxx
@@ -231,7 +231,6 @@ struct ItemFormat
explicitItemFormat();
voidset( DataType eDataType, FormatType eFmtType, const ::rtl::OUString rItemName );
-voidset( DataType eDataType, FormatType eFmtType, const ::rtl::OUString rItemName, const ::rtl::OUString rListName );
/** Initializes the struct from a vector of strings containing the item format.
@@ -398,7 +397,6 @@ public:
static void appendToken( ::rtl::OUStringBuffer rStr, const ::rtl::OUString rToken, sal_Unicode cSep = OOX_DUMP_LISTSEP );
static void appendToken( ::rtl::OUStringBuffer rStr, sal_Int64 nToken, sal_Unicode cSep = OOX_DUMP_LISTSEP );
static void prependToken( ::rtl::OUStringBuffer rStr, const ::rtl::OUString rToken, sal_Unicode cSep = OOX_DUMP_LISTSEP );
-static void prependToken( ::rtl::OUStringBuffer rStr, sal_Int64 nToken, sal_Unicode cSep = OOX_DUMP_LISTSEP );
static void appendIndex( ::rtl::OUStringBuffer rStr, const ::rtl::OUString rIdx );
static void appendIndex( ::rtl::OUStringBuffer rStr, sal_Int64 nIdx );
@@ -1047,11 +1045,9 @@ public:
voidincIndent();
voiddecIndent();
-voidresetIndent();
voidstartTable( sal_Int32 nW1 );
voidstartTable( sal_Int32 nW1, sal_Int32 nW2 );
-voidstartTable( sal_Int32 nW1, sal_Int32 nW2, sal_Int32 nW3 );
voidstartTable( sal_Int32 nW1, sal_Int32 nW2, sal_Int32 nW3, sal_Int32 nW4 );
voidstartTable( size_t nColCount, const sal_Int32* pnColWidths );
voidtab();
@@ -1209,8 +1205,6 @@ public:
explicitStorageIterator( const StorageRef rxStrg );
virtual ~StorageIterator();
-size_t getElementCount() const;
-
StorageIteratoroperator++();
::rtl::OUString getName() const;
@@ -1251,8 +1245,6 @@ protected:
//
-voidreconstructConfig( const ConfigRef rxConfig );
-
inline Config cfg() const { return *mxConfig; }
private:
@@ -1564,8 +1556,6 @@ protected:
::rtl::OUString dumpNullCharArray( const String rName, rtl_TextEncoding eTextEnc );
::rtl::OUString dumpNullUnicodeArray( const String rName );
-double dumpRk( const String rName = EMPTY_STRING );
-sal_Int32 dumpColorABGR( const String rName = EMPTY_STRING );
::com::sun::star::util::DateTime dumpFileTime( const String rName = EMPTY_STRING );
::rtl::OUString dumpGuid( const String rName = EMPTY_STRING );
diff --git a/oox/inc/oox/dump/oledumper.hxx b/oox/inc/oox/dump/oledumper.hxx
index 42abf2d..4d3ceaa 100644
--- a/oox/inc/oox/dump/oledumper.hxx
+++ b/oox/inc/oox/dump/oledumper.hxx
@@ -178,7 +178,6 @@ protected:
using StorageObjectBase::construct;
voidconstruct( const ObjectBase rParent, const StorageRef rxStrg, const ::rtl::OUString rSysPath );
-voidconstruct( const ObjectBase rParent );
virtual voidimplDumpStream(
const ::com::sun::star::uno::Reference ::com::sun::star::io::XInputStream rxStrm,
diff --git a/oox/inc/oox/ole/vbaprojectfilter.hxx
Re: [PUSHED][PATCH] remove unused code (oox)
On Thu, 2012-03-29 at 15:23 +0200, Petr Vorel wrote: Hi there, removed unused methods pushed, thanks for these C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code (oox, sc)
Hi there,
yet another remove unused code patch.
Regards,
Petr
From 38a7f343736f7049d28aae132307eba02a019f27 Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Wed, 28 Mar 2012 11:20:18 +0200
Subject: [PATCH] remove unused code (oox, sc)
---
oox/inc/oox/drawingml/textparagraphproperties.hxx |4 -
oox/inc/oox/dump/dffdumper.hxx|2 -
oox/inc/oox/dump/dumperbase.hxx | 13
oox/source/drawingml/textparagraphproperties.cxx | 25
oox/source/dump/dffdumper.cxx | 11
oox/source/dump/dumperbase.cxx| 65 -
sd/source/filter/eppt/epptooxml.hxx |1 -
sd/source/filter/eppt/pptx-epptooxml.cxx | 14 -
unusedcode.easy | 14 -
9 files changed, 0 insertions(+), 149 deletions(-)
diff --git a/oox/inc/oox/drawingml/textparagraphproperties.hxx b/oox/inc/oox/drawingml/textparagraphproperties.hxx
index b2c5096..e037ff2 100644
--- a/oox/inc/oox/drawingml/textparagraphproperties.hxx
+++ b/oox/inc/oox/drawingml/textparagraphproperties.hxx
@@ -114,10 +114,6 @@ public:
size can be zero and the default value is returned. */
float getCharHeightPoints( float fDefault ) const;
-#if OSL_DEBUG_LEVEL 0
-void dump() const;
-#endif
-
protected:
TextCharacterProperties maTextCharacterProperties;
diff --git a/oox/inc/oox/dump/dffdumper.hxx b/oox/inc/oox/dump/dffdumper.hxx
index a23d071..10f84f3 100644
--- a/oox/inc/oox/dump/dffdumper.hxx
+++ b/oox/inc/oox/dump/dffdumper.hxx
@@ -49,7 +49,6 @@ protected:
inline explicit DffStreamObject() {}
using SequenceRecordObjectBase::construct;
-voidconstruct( const ObjectBase rParent, const BinaryInputStreamRef rxStrm, const ::rtl::OUString rSysFileName );
voidconstruct( const OutputObjectBase rParent, const BinaryInputStreamRef rxStrm );
virtual boolimplReadRecordHeader( BinaryInputStream rBaseStrm, sal_Int64 ornRecId, sal_Int64 ornRecSize );
@@ -61,7 +60,6 @@ private:
voidconstructDffObj();
sal_uInt32 dumpDffSimpleColor( const String rName );
-sal_uInt32 dumpDffColor( const String rName );
voiddumpDffOpt();
sal_uInt16 dumpDffOptPropHeader();
diff --git a/oox/inc/oox/dump/dumperbase.hxx b/oox/inc/oox/dump/dumperbase.hxx
index 5989c1e..68a4848 100644
--- a/oox/inc/oox/dump/dumperbase.hxx
+++ b/oox/inc/oox/dump/dumperbase.hxx
@@ -480,26 +480,18 @@ static const String EMPTY_STRING;
class FormulaStack
{
public:
-explicitFormulaStack();
-
inline const ::rtl::OUString getFormulaString() const { return getString( maFmlaStack ); }
inline const ::rtl::OUString getClassesString() const { return getString( maClassStack ); }
voidpushOperand( const String rOp, const ::rtl::OUString rTokClass );
-voidpushOperand( const String rOp );
-voidpushUnaryOp( const String rLOp, const String rROp );
-voidpushBinaryOp( const String rOp );
-voidpushFuncOp( const String rFunc, const ::rtl::OUString rTokClass, sal_uInt8 nParamCount );
inline void setError() { mbError = true; }
-voidreplaceOnTop( const ::rtl::OUString rOld, const ::rtl::OUString rNew );
private:
typedef ::std::stack ::rtl::OUString StringStack;
inline bool check( bool bCond ) { return (mbError |= !bCond) == false; }
-const ::rtl::OUString getString( const StringStack rStack ) const;
voidpushUnaryOp( StringStack rStack, const ::rtl::OUString rLOp, const ::rtl::OUString rROp );
voidpushBinaryOp( StringStack rStack, const ::rtl::OUString rOp );
voidpushFuncOp( StringStack rStack, const ::rtl::OUString rOp, sal_uInt8 nParamCount );
@@ -612,9 +604,6 @@ private:
::rtl::OUString orKey,
::rtl::OUString orData ) const;
-LineTypereadConfigLine(
-TextInputStream rStrm ) const;
-
voidprocessConfigItem(
TextInputStream rStrm,
const ::rtl::OUString rKey,
@@ -1013,7 +1002,6 @@ public:
template typename Type
boolhasName( const NameListWrapper rListWrp, Type nKey ) const;
-::com::sun::star::uno::Sequence ::com::sun::star::beans::NamedValue requestEncryptionData( ::comphelper::IDocPasswordVerifier rVerifier );
boolisPasswordCancelled() const;
protected:
@@ -1598,7 +1586,6 @@ protected:
inline void dumpUnused( sal_Int32 nBytes ) { dumpArray( OOX_DUMP_UNUSED, nBytes ); }
inline void dumpUnknown( sal_Int32 nBytes
Re: [PUSHED][PATCH] remove unused code (oox, sc)
On Wed, 2012-03-28 at 16:23 +0200, Petr Vorel wrote: Hi there, yet another remove unused code patch. Pushed now, thanks for this. FWIW, if a class has only one constructor and that constructor is unused then it indicates that the whole class (except perhaps for any static methods it might have) should be possible to be removed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code in sqlnode
This patch removes unused code as listed in unusedcode.easy
From 75344c3cb19be787fce45bd06ad93a971e0b5292 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Wed, 28 Mar 2012 21:28:07 +0200
Subject: [PATCH] Remove unused code in sqlnode
---
connectivity/inc/connectivity/sqlnode.hxx |2 -
connectivity/source/parse/sqlnode.cxx | 41 -
unusedcode.easy |3 --
3 files changed, 0 insertions(+), 46 deletions(-)
diff --git a/connectivity/inc/connectivity/sqlnode.hxx b/connectivity/inc/connectivity/sqlnode.hxx
index 4f8385a..8874ed0 100644
--- a/connectivity/inc/connectivity/sqlnode.hxx
+++ b/connectivity/inc/connectivity/sqlnode.hxx
@@ -278,11 +278,9 @@ namespace connectivity
void append(OSQLParseNode* pNewSubTree);
void insert(sal_uInt32 nPos, OSQLParseNode* pNewSubTree);
-OSQLParseNode* replaceAt(sal_uInt32 nPos, OSQLParseNode* pNewSubTree);
OSQLParseNode* replace(OSQLParseNode* pOldSubTree, OSQLParseNode* pNewSubTree);
OSQLParseNode* removeAt(sal_uInt32 nPos);
-OSQLParseNode* remove(OSQLParseNode* pSubTree);
void replaceNodeValue(const ::rtl::OUString rTableAlias,const ::rtl::OUString rColumnName);
diff --git a/connectivity/source/parse/sqlnode.cxx b/connectivity/source/parse/sqlnode.cxx
index 7b4e4dd..5341a26 100644
--- a/connectivity/source/parse/sqlnode.cxx
+++ b/connectivity/source/parse/sqlnode.cxx
@@ -2386,45 +2386,9 @@ OSQLParseNode* OSQLParseNode::removeAt(sal_uInt32 nPos)
m_aChildren.erase(aPos);
return pNode;
}
-//-
-OSQLParseNode* OSQLParseNode::remove(OSQLParseNode* pSubTree)
-{
-RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, parse, ocke.jans...@sun.com, OSQLParseNode::remove );
-OSL_ENSURE(pSubTree != NULL, OSQLParseNode: invalid SubTree);
-OSQLParseNodes::iterator aPos = ::std::find(m_aChildren.begin(), m_aChildren.end(), pSubTree);
-if (aPos != m_aChildren.end())
-{
-// Set the getParent of the removed node to NULL
-pSubTree-setParent( NULL );
-m_aChildren.erase(aPos);
-return pSubTree;
-}
-else
-return NULL;
-}
// Replace methods
//-
-OSQLParseNode* OSQLParseNode::replaceAt(sal_uInt32 nPos, OSQLParseNode* pNewSubNode)
-{
-RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, parse, ocke.jans...@sun.com, OSQLParseNode::replaceAt );
-OSL_ENSURE(pNewSubNode != NULL, OSQLParseNode: invalid nodes);
-OSL_ENSURE(pNewSubNode-getParent() == NULL, OSQLParseNode: node already has getParent);
-OSL_ENSURE(nPos m_aChildren.size(), OSQLParseNode: invalid position);
-OSL_ENSURE(::std::find(m_aChildren.begin(), m_aChildren.end(), pNewSubNode) == m_aChildren.end(),
-OSQLParseNode::Replace() Node already element of parent);
-
-OSQLParseNode* pOldSubNode = m_aChildren[nPos];
-
-// Create connection to getParent
-pNewSubNode-setParent( this );
-pOldSubNode-setParent( NULL );
-
-m_aChildren[nPos] = pNewSubNode;
-return pOldSubNode;
-}
-
-//-
OSQLParseNode* OSQLParseNode::replace (OSQLParseNode* pOldSubNode, OSQLParseNode* pNewSubNode )
{
RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, parse, ocke.jans...@sun.com, OSQLParseNode::replace );
@@ -2791,11 +2755,6 @@ void OSQLParseNodesContainer::erase(OSQLParseNode* _pNode)
}
}
// -
-bool OSQLParseNodesContainer::empty() const
-{
-return m_aNodes.empty();
-}
-// -
void OSQLParseNodesContainer::clear()
{
::osl::MutexGuard aGuard(m_aMutex);
diff --git a/unusedcode.easy b/unusedcode.easy
index 61a0856..f791255 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -772,9 +772,6 @@ comphelper::findProperty(com::sun::star::beans::Property, com::sun::star::uno::
connectivity::OKeyValue::OKeyValue()
connectivity::ORowSetValue::setFromDouble(double const, int)
connectivity::OSQLInternalNode::OSQLInternalNode(unsigned short const*, connectivity::SQLNodeType, unsigned int)
-connectivity::OSQLParseNode::remove(connectivity::OSQLParseNode*)
-connectivity::OSQLParseNode::replaceAt(unsigned int, connectivity::OSQLParseNode*)
-connectivity::OSQLParseNodesContainer::empty() const
connectivity::OSQLScanner::GetCurrentRule() const
connectivity::OSortIndex::GetValue(int) const
connectivity::SQLError::getSQLState(int) const
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (connectivity)
This patch removes unused code as listed in unusedcode.easy 0001-Remove-unused-code-in-connectiviy.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code (oox, sc)
FWIW, if a class has only one constructor and that constructor is unused then it indicates that the whole class (except perhaps for any static methods it might have) should be possible to be removed. Sorry, I'll think more next time. Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code (oox, sc)
Hi there,
another bits of unused code removed.
Regards,
Petr
From e31c211d2ebb7cde8a260ec0bcef5359c0c1db8f Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Tue, 27 Mar 2012 11:03:09 +0200
Subject: [PATCH] remove unused code (oox, sc)
---
oox/inc/oox/dump/dumperbase.hxx |4 --
oox/inc/oox/mathml/importutils.hxx|4 --
oox/inc/oox/ppt/pptshape.hxx |1 -
oox/source/dump/dumperbase.cxx|5 ---
oox/source/mathml/importutils.cxx | 10 -
oox/source/ppt/pptshape.cxx |7
sc/source/filter/inc/addressconverter.hxx |1 -
sc/source/filter/inc/biffoutputstream.hxx | 14
sc/source/filter/inc/sheetdatabuffer.hxx | 10 -
sc/source/filter/oox/addressconverter.cxx |6 ---
sc/source/filter/oox/biffoutputstream.cxx | 23 -
sc/source/filter/oox/sheetdatabuffer.cxx | 52 +
unusedcode.easy | 12 ---
13 files changed, 1 insertions(+), 148 deletions(-)
diff --git a/oox/inc/oox/dump/dumperbase.hxx b/oox/inc/oox/dump/dumperbase.hxx
index 534776b..5989c1e 100644
--- a/oox/inc/oox/dump/dumperbase.hxx
+++ b/oox/inc/oox/dump/dumperbase.hxx
@@ -1860,10 +1860,6 @@ public:
const BinaryInputStreamRef rxStrm,
const ::rtl::OUString rSysFileName );
-explicitXmlStreamObject(
-const OutputObjectBase rParent,
-const BinaryInputStreamRef rxStrm );
-
protected:
virtual voidimplDumpText( TextInputStream rTextStrm );
};
diff --git a/oox/inc/oox/mathml/importutils.hxx b/oox/inc/oox/mathml/importutils.hxx
index 9b90681..fc0e276 100644
--- a/oox/inc/oox/mathml/importutils.hxx
+++ b/oox/inc/oox/mathml/importutils.hxx
@@ -213,10 +213,6 @@ public:
*/
bool findTag( int token );
/**
- Skips the given element (i.e. reads up to and including the matching closing tag).
-*/
-void skipElement( int token );
-/**
Handle the current (unexpected) tag.
*/
void handleUnexpectedTag();
diff --git a/oox/inc/oox/ppt/pptshape.hxx b/oox/inc/oox/ppt/pptshape.hxx
index e06fda6..07ab723 100644
--- a/oox/inc/oox/ppt/pptshape.hxx
+++ b/oox/inc/oox/ppt/pptshape.hxx
@@ -67,7 +67,6 @@ public:
static oox::drawingml::ShapePtr findPlaceholder( const sal_Int32 nMasterPlaceholder, std::vector oox::drawingml::ShapePtr rShapes );
static oox::drawingml::ShapePtr findPlaceholderByIndex( const sal_Int32 nIdx, std::vector oox::drawingml::ShapePtr rShapes );
-static oox::drawingml::ShapePtr findPlaceholder( sal_Int32 nFirstPlaceholder, sal_Int32 nSecondPlaceholder, std::vector oox::drawingml::ShapePtr rShapes );
static oox::drawingml::TextListStylePtr getSubTypeTextListStyle( const SlidePersist rSlidePersist, sal_Int32 nSubType );
diff --git a/oox/source/dump/dumperbase.cxx b/oox/source/dump/dumperbase.cxx
index f078111..366090c 100644
--- a/oox/source/dump/dumperbase.cxx
+++ b/oox/source/dump/dumperbase.cxx
@@ -2920,11 +2920,6 @@ XmlStreamObject::XmlStreamObject( const ObjectBase rParent,
TextStreamObjectBase::construct( rParent, rxStrm, RTL_TEXTENCODING_UTF8, rSysFileName );
}
-XmlStreamObject::XmlStreamObject( const OutputObjectBase rParent, const BinaryInputStreamRef rxStrm )
-{
-TextStreamObjectBase::construct( rParent, rxStrm, RTL_TEXTENCODING_UTF8 );
-}
-
void XmlStreamObject::implDumpText( TextInputStream rTextStrm )
{
/* Buffers a start element and the following element text. Needed to dump
diff --git a/oox/source/mathml/importutils.cxx b/oox/source/mathml/importutils.cxx
index ab9d224..41a254d 100644
--- a/oox/source/mathml/importutils.cxx
+++ b/oox/source/mathml/importutils.cxx
@@ -114,11 +114,6 @@ static OUString tokenToString( int token )
} // namespace
-bool XmlStream::AttributeList::hasAttribute( int token ) const
-{
-return attrs.find( token ) != attrs.end();
-}
-
rtl::OUString XmlStream::AttributeList::attribute( int token, const rtl::OUString def ) const
{
std::map int, rtl::OUString ::const_iterator find = attrs.find( token );
@@ -304,11 +299,6 @@ bool XmlStream::findTagInternal( int token, bool silent )
return false;
}
-void XmlStream::skipElement( int token )
-{
-return skipElementInternal( token, true ); // no debug about skipping if called from outside
-}
-
void XmlStream::skipElementInternal( int token, bool silent )
{
int closing = ( token ~TAG_OPENING ) | TAG_CLOSING; // make it a closing tag
diff --git a/oox/source/ppt/pptshape.cxx b/oox/source/ppt/pptshape.cxx
index a72a10c..2b017f0 100644
--- a/oox/source/ppt/pptshape.cxx
+++ b/oox/source/ppt/pptshape.cxx
@@ -423,13 +423,6 @@ oox::drawingml::ShapePtr PPTShape::findPlaceholderByIndex( const sal_Int32 nIdx,
return aShapePtr;
}
-// if nFirstPlaceholder can't be found, it will be searched for nSecondPlaceholder
-oox
Re: [PUSHED][PATCH] remove unused code (oox, sc)
On Tue, 2012-03-27 at 16:27 +0200, Petr Vorel wrote: Hi there, another bits of unused code removed. looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (l10ntools)
This patch removes unused code as listed in unusedcode.easy
From 85de68332e5419fbf2ef58957a9c11f588fad6c1 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Tue, 27 Mar 2012 21:16:50 +0200
Subject: [PATCH] Remove unused code in l10ntools.
---
l10ntools/inc/xmlparse.hxx|6
l10ntools/source/xmlparse.cxx | 61 -
unusedcode.easy |2 -
3 files changed, 0 insertions(+), 69 deletions(-)
diff --git a/l10ntools/inc/xmlparse.hxx b/l10ntools/inc/xmlparse.hxx
index cd9bc2b..0731a9f 100644
--- a/l10ntools/inc/xmlparse.hxx
+++ b/l10ntools/inc/xmlparse.hxx
@@ -169,13 +169,7 @@ public:
XMLChildNode *pChild , size_t pos /// the new child
);
-int RemoveChild( XMLElement *pRefElement );
void RemoveAndDeleteAllChildren();
-
-/// returns a child element which matches the given one
-XMLElement *GetChildElement(
-XMLElement *pRefElement // the reference elelement
-);
};
//-
diff --git a/l10ntools/source/xmlparse.cxx b/l10ntools/source/xmlparse.cxx
index e646308..5be1f0e 100644
--- a/l10ntools/source/xmlparse.cxx
+++ b/l10ntools/source/xmlparse.cxx
@@ -159,37 +159,6 @@ void XMLParentNode::AddChild( XMLChildNode *pChild , size_t pos )
}
/*/
-int XMLParentNode::RemoveChild( XMLElement *pRefElement )
-/*/
-{
-XMLElement* a;
-if ( pChildList ){
-for ( size_t i = 0; i pChildList-size(); i++ ) {
-XMLChildNode *pChild = (*pChildList)[ i ];
-if ( pChild-GetNodeType() == XML_NODE_TYPE_ELEMENT ){
-a = static_castXMLElement* (pChild);
-rtl::OString elemid(a-GetId().toAsciiLowerCase());
-rtl::OString elemLID(a-GetLanguageId().toAsciiLowerCase());
-rtl::OString pRefLID(
-pRefElement-GetLanguageId().toAsciiLowerCase());
-if (elemid == pRefElement-GetId() elemLID == pRefLID)
-{
-if( pRefElement-ToOString().compareTo( a-ToOString() )==0 ){
-XMLChildNodeList::iterator it = pChildList-begin();
-::std::advance( it, i );
-pChildList-erase( it );
-delete a; // Test
-return i;
-}
-}
-}
-
-}
-}
-return -1;
-}
-
-/*/
void XMLParentNode::RemoveAndDeleteAllChildren(){
/*/
if ( pChildList ) {
@@ -199,36 +168,6 @@ void XMLParentNode::RemoveAndDeleteAllChildren(){
}
}
-/*/
-XMLElement *XMLParentNode::GetChildElement( XMLElement *pRefElement )
-/*/
-{
-for ( size_t i = 0; i pChildList-size(); i++ ) {
-XMLChildNode *pChild = (*pChildList)[ i ];
-if ( pChild-GetNodeType() == XML_NODE_TYPE_ELEMENT )
-if ((( XMLElement * ) pChild )-GetName() ==
-pRefElement-GetName())
-{
-XMLAttributeList *pList = pRefElement-GetAttributeList();
-if ( !pList )
-return ( XMLElement * ) pChild;
-
-sal_Bool bMatch = sal_False;
-for ( size_t j = 0; j pList-size() bMatch; j++ ) {
-XMLAttribute *pAttribute = (*pList)[ j ];
-XMLAttribute *pCandidate =
-(( XMLElement * ) pChild )-GetAttribute(
-pAttribute-GetName() );
-if ( !pCandidate || !pAttribute-IsEqual( *pCandidate ))
-bMatch = sal_False;
-}
-if ( bMatch )
-return ( XMLElement * ) pChild;
-}
-}
-return NULL;
-}
-
//
// class XMLFile
//
diff --git a/unusedcode.easy b/unusedcode.easy
index 54ba512..79a729f 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -341,8 +341,6 @@ XMLFontAutoStylePoolNames_Impl::Remove(rtl::OUString*)
XMLFontAutoStylePool_Impl::GetPos(XMLFontAutoStylePoolEntry_Impl const*) const
XMLFontAutoStylePool_Impl::Remove(XMLFontAutoStylePoolEntry_Impl*)
XMLParentNode::AddChild(XMLChildNode*, unsigned long)
-XMLParentNode::GetChildElement(XMLElement*)
-XMLParentNode::RemoveChild(XMLElement*)
XMLPropertyBackpatcherrtl::OUString::XMLPropertyBackpatcher(char const*)
XMLPropertyBackpatcherrtl::OUString::XMLPropertyBackpatcher(char const*, char const*, unsigned char, rtl::OUString)
XMLPropertyBackpatcherrtl::OUString
Re: [PUSHED][PATCH] Remove unused code (l10ntools)
On Tue, 2012-03-27 at 21:20 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (scaddins)
On Fri, 2012-03-23 at 21:42 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks for that. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (vlc)
On Fri, 2012-03-23 at 22:07 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (xmloff)
On Sat, 2012-03-24 at 01:03 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy great, pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code (oox)
On Sun, 2012-03-25 at 20:43 +0200, Petr Vorel wrote: Hi there, removed some code from oox. Pushed, looks good. I suspect that this will have a bit of a cascade effect and a pile more stuff will become available for removal on the next run. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (svtools)
This patch removes unused code as listed in unusedcode.easy
From 08525faa466535c5f10bcd413199351f5d953975 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Sun, 25 Mar 2012 18:24:32 +0200
Subject: [PATCH] Remove unused code in svtools.
---
svtools/source/filter/wmf/winmtf.cxx | 23 ---
svtools/source/filter/wmf/winmtf.hxx |3 ---
2 files changed, 0 insertions(+), 26 deletions(-)
diff --git a/svtools/source/filter/wmf/winmtf.cxx b/svtools/source/filter/wmf/winmtf.cxx
index 090886e..d9597ff 100644
--- a/svtools/source/filter/wmf/winmtf.cxx
+++ b/svtools/source/filter/wmf/winmtf.cxx
@@ -658,13 +658,6 @@ void WinMtfOutput::SelectObject( sal_Int32 nIndex )
//---
-void WinMtfOutput::SetFont( const Font rFont )
-{
-maFont = rFont;
-}
-
-//---
-
const Font WinMtfOutput::GetFont() const
{
return maFont;
@@ -679,13 +672,6 @@ void WinMtfOutput::SetTextLayoutMode( const sal_uInt32 nTextLayoutMode )
//---
-sal_uInt32 WinMtfOutput::GetTextLayoutMode() const
-{
-return mnTextLayoutMode;
-}
-
-//---
-
void WinMtfOutput::SetBkMode( sal_uInt32 nMode )
{
mnBkMode = nMode;
@@ -1151,15 +1137,6 @@ void WinMtfOutput::LineTo( const Point rPoint, sal_Bool bRecordPath )
//---
-void WinMtfOutput::DrawLine( const Point rSource, const Point rDest )
-{
-UpdateClipRegion();
-UpdateLineStyle();
-mpGDIMetaFile-AddAction( new MetaLineAction( ImplMap( rSource), ImplMap( rDest ), maLineStyle.aLineInfo ) );
-}
-
-//---
-
void WinMtfOutput::DrawRect( const Rectangle rRect, sal_Bool bEdge )
{
UpdateClipRegion();
diff --git a/svtools/source/filter/wmf/winmtf.hxx b/svtools/source/filter/wmf/winmtf.hxx
index 6f5e778..bf81be5 100644
--- a/svtools/source/filter/wmf/winmtf.hxx
+++ b/svtools/source/filter/wmf/winmtf.hxx
@@ -696,10 +696,8 @@ public:
voidSelectObject( sal_Int32 nIndex );
CharSet GetCharSet(){ return maFont.GetCharSet(); };
WinMtfFillStyleGetFillStyle () { return maFillStyle; }
-voidSetFont( const Font rFont );
const Font GetFont() const;
voidSetTextLayoutMode( const sal_uInt32 nLayoutMode );
-sal_uInt32 GetTextLayoutMode() const;
voidClearPath(){ aPathObj.Init(); };
voidClosePath(){ aPathObj.ClosePath(); };
@@ -708,7 +706,6 @@ public:
voidMoveTo( const Point rPoint, sal_Bool bRecordPath = sal_False );
voidLineTo( const Point rPoint, sal_Bool bRecordPath = sal_False );
voidDrawPixel( const Point rSource, const Color rColor );
-voidDrawLine( const Point rSource, const Point rDest );
voidDrawRect( const Rectangle rRect, sal_Bool bEdge = sal_True );
voidDrawRoundRect( const Rectangle rRect, const Size rSize );
voidDrawEllipse( const Rectangle rRect );
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code (oox)
Hi there,
removed some code from oox.
Regards,
Petr
From e04049e2554a94ce80dc21dfe390e91c8fd8bc41 Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Thu, 22 Mar 2012 20:14:13 +0100
Subject: [PATCH] remove unused code (oox)
---
oox/source/ole/vbaprojectfilter.cxx | 13 -
sc/source/filter/inc/biffinputstream.hxx | 27 +---
sc/source/filter/inc/biffoutputstream.hxx |5 --
sc/source/filter/inc/drawingmanager.hxx |4 --
sc/source/filter/oox/biffdetector.cxx |5 --
sc/source/filter/oox/biffinputstream.cxx | 11 -
sc/source/filter/oox/biffoutputstream.cxx | 16 ---
sc/source/filter/oox/drawingmanager.cxx | 71 -
sc/source/filter/oox/excelfilter.cxx | 27 ---
sc/source/filter/oox/ooxformulaparser.cxx |5 --
unusedcode.easy | 13 -
11 files changed, 1 insertions(+), 196 deletions(-)
diff --git a/oox/source/ole/vbaprojectfilter.cxx b/oox/source/ole/vbaprojectfilter.cxx
index e152598..f4698fa 100644
--- a/oox/source/ole/vbaprojectfilter.cxx
+++ b/oox/source/ole/vbaprojectfilter.cxx
@@ -77,19 +77,6 @@ OUString SAL_CALL WordVbaProjectFilter_getImplementationName() throw()
return CREATE_OUSTRING( com.sun.star.comp.oox.WordVbaProjectFilter );
}
-Sequence OUString SAL_CALL WordVbaProjectFilter_getSupportedServiceNames() throw()
-{
-Sequence OUString aSeq( 1 );
-aSeq[ 0 ] = CREATE_OUSTRING( com.sun.star.document.ImportFilter );
-return aSeq;
-}
-
-Reference XInterface SAL_CALL WordVbaProjectFilter_createInstance(
-const Reference XComponentContext rxContext ) throw( Exception )
-{
-return static_cast ::cppu::OWeakObject* ( new WordVbaProjectFilter( rxContext ) );
-}
-
//
WordVbaProjectFilter::WordVbaProjectFilter( const Reference XComponentContext rxContext ) throw( RuntimeException ) :
diff --git a/sc/source/filter/inc/biffinputstream.hxx b/sc/source/filter/inc/biffinputstream.hxx
index 9f01b02..47ee2b0 100644
--- a/sc/source/filter/inc/biffinputstream.hxx
+++ b/sc/source/filter/inc/biffinputstream.hxx
@@ -129,16 +129,7 @@ private:
Trying to read over the record limits results in a stream error. The
isValid() function indicates that by returning false. From now on the data
returned by the read functions is undefined. The error state will be reset,
-if the record is reset (with the function resetRecord()), or if the next
-record is started.
-
-To switch off the automatic lookup of CONTINUE records, use resetRecord()
-with false parameter. This is useful e.g. on import of drawing layer data,
-where sometimes solely CONTINUE records will occur. The automatic lookup
-keeps switched off until the method resetRecord() is called with parameter
-true. All other settings done on the stream (e.g. alternative CONTINUE
-record identifier, enabled decryption, NUL substitution character) will be
-reset to default values, if a new record is started.
+if the next record is started.
The import stream supports decrypting the stream data. The contents of a
record (not the record header) will be encrypted by Excel if the file has
@@ -189,22 +180,6 @@ public:
*/
boolstartRecordByHandle( sal_Int64 nRecHandle );
-/** Sets stream pointer to begin of record content.
-
-@param bContLookup
-Automatic CONTINUE lookup on/off. In difference to other stream
-settings, this setting is persistent until next call of this
-function (because it is wanted to receive the next CONTINUE records
-separately).
-@param nAltContId
-Sets an alternative record identifier for content continuation.
-This value is reset automatically when a new record is started with
-startNextRecord().
- */
-voidresetRecord(
-bool bContLookup,
-sal_uInt16 nAltContId = BIFF_ID_UNKNOWN );
-
/** Sets stream pointer before current record and invalidates stream.
The next call to startNextRecord() will start again the current record.
diff --git a/sc/source/filter/inc/biffoutputstream.hxx b/sc/source/filter/inc/biffoutputstream.hxx
index a38bfdf..f7a6462 100644
--- a/sc/source/filter/inc/biffoutputstream.hxx
+++ b/sc/source/filter/inc/biffoutputstream.hxx
@@ -110,8 +110,6 @@ public:
/** Returns the absolute position in the wrapped binary stream. */
sal_Int64 tellBase() const;
-/** Returns the total size of the wrapped binary stream. */
-sal_Int64 sizeBase() const;
// BinaryOutputStream interface (stream write access) -
@@ -120,9 +118,6 @@ public:
/** Writes nBytes bytes from the passed buffer pMem. */
virtual voidwriteMemory( const void* pMem
[PATCH] Remove unused code (scaddins)
This patch removes unused code as listed in unusedcode.easy
From 00975e8dec9da11e13b4523d1d9e918bac5f5222 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Fri, 23 Mar 2012 21:37:59 +0100
Subject: [PATCH] Remove unused code in scaddins.
---
scaddins/source/datefunc/datefunc.cxx | 17 -
scaddins/source/datefunc/datefunc.hxx |1 -
unusedcode.easy |1 -
3 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/scaddins/source/datefunc/datefunc.cxx b/scaddins/source/datefunc/datefunc.cxx
index 4ae9543..6ba6d44 100644
--- a/scaddins/source/datefunc/datefunc.cxx
+++ b/scaddins/source/datefunc/datefunc.cxx
@@ -83,23 +83,6 @@ void ScaList::_Grow()
pData = pNewData;
}
-void ScaList::Insert( void* pNew, sal_uInt32 nIndex )
-{
-if( nIndex = nCount )
-Append( pNew );
-else
-{
-Grow();
-
-void** pIns = pData + nIndex;
-memmove( pIns + 1, pIns, (nCount - nIndex) * sizeof( void* ) );
-
-*pIns = pNew;
-nCount++;
-}
-}
-
-
//--
ScaStringList::~ScaStringList()
diff --git a/scaddins/source/datefunc/datefunc.hxx b/scaddins/source/datefunc/datefunc.hxx
index fae7983..61ba8da 100644
--- a/scaddins/source/datefunc/datefunc.hxx
+++ b/scaddins/source/datefunc/datefunc.hxx
@@ -76,7 +76,6 @@ public:
inline void*Next() { return (nCurr + 1 nCount) ? pData[ ++nCurr ] : NULL; }
inline void Append( void* pNew );
-voidInsert( void* pNew, sal_uInt32 nIndex );
};
diff --git a/unusedcode.easy b/unusedcode.easy
index b8d6b87..1065082 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -109,7 +109,6 @@ ScVbaFormatooo::vba::excel::XStyle::getXServiceInfo()
ScVbaFormatooo::vba::excel::XStyle::setAddIndent(com::sun::star::uno::Any const)
ScVbaFormatooo::vba::excel::XStyle::setNumberFormat(com::sun::star::lang::Locale, rtl::OUString const)
ScVbaWorksheet::ScVbaWorksheet(com::sun::star::uno::Referenceooo::vba::XHelperInterface const, com::sun::star::uno::Referencecom::sun::star::uno::XComponentContext const)
-ScaList::Insert(void*, unsigned int)
ScrollBarBox::ScrollBarBox(Window*, ResId const)
ScrollableWindow::MakeVisible(Rectangle const, unsigned char)
SectReprArr::Insert(SectRepr* const, unsigned short)
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (vlc)
This patch removes unused code as listed in unusedcode.easy
From 8d0dca528f9cb12dc8e5cdb2f2c1dcaf2270a04f Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Fri, 23 Mar 2012 22:05:00 +0100
Subject: [PATCH] Remove unused code in vlc.
---
unusedcode.easy |1 -
vcl/inc/vcl/scrbar.hxx|1 -
vcl/source/control/scrbar.cxx | 10 --
3 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/unusedcode.easy b/unusedcode.easy
index 1065082..02bc1c9 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -109,7 +109,6 @@ ScVbaFormatooo::vba::excel::XStyle::getXServiceInfo()
ScVbaFormatooo::vba::excel::XStyle::setAddIndent(com::sun::star::uno::Any const)
ScVbaFormatooo::vba::excel::XStyle::setNumberFormat(com::sun::star::lang::Locale, rtl::OUString const)
ScVbaWorksheet::ScVbaWorksheet(com::sun::star::uno::Referenceooo::vba::XHelperInterface const, com::sun::star::uno::Referencecom::sun::star::uno::XComponentContext const)
-ScrollBarBox::ScrollBarBox(Window*, ResId const)
ScrollableWindow::MakeVisible(Rectangle const, unsigned char)
SectReprArr::Insert(SectRepr* const, unsigned short)
SectReprArr::Insert(SectRepr* const*, unsigned short)
diff --git a/vcl/inc/vcl/scrbar.hxx b/vcl/inc/vcl/scrbar.hxx
index 36c31b6..a3bf0ef 100644
--- a/vcl/inc/vcl/scrbar.hxx
+++ b/vcl/inc/vcl/scrbar.hxx
@@ -162,7 +162,6 @@ private:
public:
ScrollBarBox( Window* pParent, WinBits nStyle = 0 );
-ScrollBarBox( Window* pParent, const ResId rResId );
virtual voidStateChanged( StateChangedType nType );
virtual voidDataChanged( const DataChangedEvent rDCEvt );
diff --git a/vcl/source/control/scrbar.cxx b/vcl/source/control/scrbar.cxx
index d2611c6..44a093b 100644
--- a/vcl/source/control/scrbar.cxx
+++ b/vcl/source/control/scrbar.cxx
@@ -1536,16 +1536,6 @@ ScrollBarBox::ScrollBarBox( Window* pParent, WinBits nStyle ) :
// ---
-ScrollBarBox::ScrollBarBox( Window* pParent, const ResId rResId ) :
-Window( WINDOW_SCROLLBARBOX )
-{
-rResId.SetRT( RSC_SCROLLBAR );
-ImplInit( pParent, ImplInitRes( rResId ) );
-ImplLoadRes( rResId );
-}
-
-// ---
-
void ScrollBarBox::ImplInitSettings()
{
// Hack, damit man auch DockingWindows ohne Hintergrund bauen kann
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (xmloff)
This patch removes unused code as listed in unusedcode.easy
From a934503727e8f8970695d3a61f78e7e2d66ce137 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Sat, 24 Mar 2012 01:01:49 +0100
Subject: [PATCH] Remove unused code in xmloff.
---
unusedcode.easy |2 --
xmloff/inc/xmloff/xmlerror.hxx | 12
xmloff/source/core/xmlerror.cxx | 17 -
3 files changed, 0 insertions(+), 31 deletions(-)
diff --git a/unusedcode.easy b/unusedcode.easy
index 134cc54..d19d8c8 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -337,8 +337,6 @@ Window::PostUserEvent(unsigned long, unsigned long, void*)
X11SalGraphics::SetMask(int, int, unsigned int, unsigned int, int, int, unsigned long)
X509Certificate_NssImpl::getImplementation(com::sun::star::uno::Referencecom::sun::star::uno::XInterface)
XMLElement::Equals(rtl::OUString)
-XMLErrors::AddRecord(int, com::sun::star::uno::Sequencertl::OUString const)
-XMLErrors::AddRecord(int, com::sun::star::uno::Sequencertl::OUString const, rtl::OUString const)
XMLFamilyDataList_Impl::GetPos(XMLFamilyData_Impl const*) const
XMLFamilyDataList_Impl::Remove(XMLFamilyData_Impl*)
XMLFontAutoStylePoolNames_Impl::GetPos(rtl::OUString const*) const
diff --git a/xmloff/inc/xmloff/xmlerror.hxx b/xmloff/inc/xmloff/xmlerror.hxx
index 46595f6..b5fbbd8 100644
--- a/xmloff/inc/xmloff/xmlerror.hxx
+++ b/xmloff/inc/xmloff/xmlerror.hxx
@@ -143,18 +143,6 @@ public:
const ::com::sun::star::uno::Reference
::com::sun::star::xml::sax::XLocator rLocator); /// location
-void AddRecord(
-sal_Int32 nId, /// error ID == error flags + error class + error number
-const ::com::sun::star::uno::Sequence
- ::rtl::OUString rParams, /// parameters for error message
-const ::rtl::OUString rExceptionMessage); /// original exception string
-
-void AddRecord(
-sal_Int32 nId, /// error ID == error flags + error class + error number
-const ::com::sun::star::uno::Sequence
- ::rtl::OUString rParams); /// parameters for error message
-
-
/**
* throw a SAXParseException that describes the first error that matches
* the given mask
diff --git a/xmloff/source/core/xmlerror.cxx b/xmloff/source/core/xmlerror.cxx
index 10c437b..8d765d2 100644
--- a/xmloff/source/core/xmlerror.cxx
+++ b/xmloff/source/core/xmlerror.cxx
@@ -216,23 +216,6 @@ void XMLErrors::AddRecord(
}
}
-void XMLErrors::AddRecord(
-sal_Int32 nId,
-const SequenceOUString rParams,
-const OUString rExceptionMessage)
-{
-OUString sEmpty;
-AddRecord( nId, rParams, rExceptionMessage, -1, -1, sEmpty, sEmpty );
-}
-
-void XMLErrors::AddRecord(
-sal_Int32 nId,
-const SequenceOUString rParams)
-{
-OUString sEmpty;
-AddRecord( nId, rParams, sEmpty, -1, -1, sEmpty, sEmpty );
-}
-
void XMLErrors::ThrowErrorAsSAXException(sal_Int32 nIdMask)
throw( SAXParseException )
{
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code
On Fri, 2012-03-16 at 20:20 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good to me, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code (oox, sc)
On Sun, 2012-03-18 at 14:40 +0100, Petr Vorel wrote: Hi there, some unused code removed (oox, sc). Looks good to me, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code
On Sat, 2012-03-17 at 15:34 +0100, Chr. Rossmanith wrote: Hi, I had a look at unusedcode.easy (sdext/presenter) and removed a little bit more than mentioned there: as there are no end callbacks added (AddEndCallback() was unused), there is no need to run them - RunEndCallbacks() could be removed as well. Same logic for start callbacks. Finally mpStartCallbacks and mpEndCallbacks could leave, too. Yup, I agree, I pushed this now. In PresenterAnimator AddAnimation() was unused and it seems that the whole class might be removed?!? Yeah, in unused.easy I see that the PresenterAnimator::PresenterAnimator ctor is never called, and its the only constructor, so one is never instantiated, so you can remove the whole thing without loss of functionality. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sdext)
On Sat, 2012-03-17 at 21:03 +0100, Chr. Rossmanith wrote: Hi, some more code removal. Looks good, pushed this now. Probably the private variable maTransform can be removed as well: it is initialized with the identity transform and never changed afterwards. Does that suggest that the actual call to mxSprite-transform(maTransform) is actually a no-op ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sdext)
Hi, Probably the private variable maTransform can be removed as well: it is initialized with the identity transform and never changed afterwards. Does that suggest that the actual call to mxSprite-transform(maTransform) is actually a no-op ? At least it doesn't change the position of mxSprite. Only the cpu is a little less idle :-) Then I'll continue to remove maTransform? Or should it be kept for future use? Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code
On Tue, 2012-03-20 at 13:54 +, Caolán McNamara wrote: Yeah, in unused.easy I see that the PresenterAnimator::PresenterAnimator ctor is never called, and its the only constructor, so one is never instantiated, so you can remove the whole thing without loss of functionality. Whoops, its PresenterAnimation (not PresenterAnimator) which has only one ctor that is never used and so is never instantiated and is trivial to remove. Nevertheless, PresenterAnimator itself only has a trivial ctor which doesn't do anything much and no public methods, so as far as I can see the only thing that currently actually gets executed is that we call PresenterTimer::CancelTask(0) in the PresenterAnimator dtor. I have no idea if anything relies on that sort of accident to continue working. I *doubt* it, but its possible I suppose. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sdext)
On Tue, 2012-03-20 at 15:24 +0100, Chr. Rossmanith wrote: At least it doesn't change the position of mxSprite. Only the cpu is a little less idle :-) Then I'll continue to remove maTransform? Or should it be kept for future use? I'm not a fan of some day we'll use it, ditch it if it doesn't do anything right now would be my feeling. I've a shed full of stuff I can't throw out just in case some day we need it. Not that removing stuff from sdext will give me more space in my shed I suppose. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sdext)
On Tue, 2012-03-20 at 15:07 +, Caolán McNamara wrote: I've a shed full of stuff I can't throw out just in case some day we need it. Not that removing stuff from sdext will give me more space in my shed I suppose. :-) I have a similar shed - I can't get into it either ;-) but I really ought to do something about it, I love the attitude. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code (oox, sc)
Hi there,
some unused code removed (oox, sc).
Regards,
Petr
From 3c03ddd6eb8e0cefa229f3874e3da35bd0a57788 Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Sat, 17 Mar 2012 20:25:52 +0100
Subject: [PATCH 1/2] remove unused code (oox, sc)
---
oox/inc/oox/dump/dumperbase.hxx |7 ---
oox/inc/oox/dump/oledumper.hxx |5 -
oox/inc/oox/ole/vbacontrol.hxx |2 --
oox/source/dump/dumperbase.cxx | 15 ---
oox/source/dump/oledumper.cxx|7 ---
oox/source/ole/vbacontrol.cxx|5 -
sc/source/filter/inc/formulabase.hxx |3 ---
sc/source/filter/oox/formulabase.cxx |9 -
unusedcode.easy |7 ---
9 files changed, 0 insertions(+), 60 deletions(-)
diff --git a/oox/inc/oox/dump/dumperbase.hxx b/oox/inc/oox/dump/dumperbase.hxx
index 7cba7ae..534776b 100644
--- a/oox/inc/oox/dump/dumperbase.hxx
+++ b/oox/inc/oox/dump/dumperbase.hxx
@@ -993,8 +993,6 @@ public:
inline const StorageRef getRootStorage() const { return mxCfgData-getRootStorage(); }
inline const ::rtl::OUString getSysFileName() const { return mxCfgData-getSysFileName(); }
-voidsetStringOption( const String rKey, const String rData );
-
const ::rtl::OUString getStringOption( const String rKey, const ::rtl::OUString rDefault ) const;
boolgetBoolOption( const String rKey, bool bDefault ) const;
template typename Type
@@ -1005,7 +1003,6 @@ public:
template typename ListType
::boost::shared_ptr ListType createNameList( const String rListName );
-voidsetNameList( const String rListName, const NameListRef rxList );
voideraseNameList( const String rListName );
NameListRef getNameList( const String rListName ) const;
@@ -1792,10 +1789,6 @@ public:
const BinaryInputStreamRef rxStrm,
const ::rtl::OUString rSysFileName );
-explicitBinaryStreamObject(
-const OutputObjectBase rParent,
-const BinaryInputStreamRef rxStrm );
-
protected:
voiddumpBinaryStream( bool bShowOffset = true );
diff --git a/oox/inc/oox/dump/oledumper.hxx b/oox/inc/oox/dump/oledumper.hxx
index 1a94e77..42abf2d 100644
--- a/oox/inc/oox/dump/oledumper.hxx
+++ b/oox/inc/oox/dump/oledumper.hxx
@@ -331,11 +331,6 @@ protected:
const String rPropNameList,
bool b64BitPropFlags = false );
voidconstruct(
-const OutputObjectBase rParent,
-const BinaryInputStreamRef rxStrm,
-const String rPropNameList,
-bool b64BitPropFlags = false );
-voidconstruct(
const InputObjectBase rParent,
const String rPropNameList,
bool b64BitPropFlags = false );
diff --git a/oox/inc/oox/ole/vbacontrol.hxx b/oox/inc/oox/ole/vbacontrol.hxx
index 4647245..b4d2afb 100644
--- a/oox/inc/oox/ole/vbacontrol.hxx
+++ b/oox/inc/oox/ole/vbacontrol.hxx
@@ -65,8 +65,6 @@ public:
inline const AxPairData getPosition() const { return maPos; }
/** Returns the unique identifier of this control. */
inline sal_Int32getId() const { return mnId; }
-/** Returns true, if the control is visible. */
-boolisVisible() const;
/** Returns true, if this control is a container control. */
boolisContainer() const;
/** Returns the length of the stream data for stream based controls. */
diff --git a/oox/source/dump/dumperbase.cxx b/oox/source/dump/dumperbase.cxx
index 54159b440..f078111 100644
--- a/oox/source/dump/dumperbase.cxx
+++ b/oox/source/dump/dumperbase.cxx
@@ -1699,11 +1699,6 @@ void Config::construct( const sal_Char* pcEnvVar, const Reference XComponentCon
mxCfgData.reset( new SharedConfigData( OUString::createFromAscii( pcFileName ), rxContext, rxRootStrg, rSysFileName, rMediaDesc ) );
}
-void Config::setStringOption( const String rKey, const String rData )
-{
-mxCfgData-setOption( rKey, rData );
-}
-
const OUString Config::getStringOption( const String rKey, const OUString rDefault ) const
{
const OUString* pData = implGetOption( rKey );
@@ -1726,11 +1721,6 @@ bool Config::isImportEnabled() const
return getBoolOption( enable-import, true );
}
-void Config::setNameList( const String rListName, const NameListRef rxList )
-{
-mxCfgData-setNameList( rListName, rxList );
-}
-
void Config::eraseNameList( const String rListName )
{
mxCfgData-eraseNameList( rListName );
@@ -2837,11 +2827,6 @@ BinaryStreamObject::BinaryStreamObject( const ObjectBase rParent, const BinaryI
InputObjectBase::construct( rParent, rxStrm,
[PATCH] Remove unused code
Hi,
I had a look at unusedcode.easy (sdext/presenter) and removed a little
bit more than mentioned there: as there are no end callbacks added
(AddEndCallback() was unused), there is no need to run them -
RunEndCallbacks() could be removed as well. Same logic for start
callbacks. Finally mpStartCallbacks and mpEndCallbacks could leave, too.
In PresenterAnimator AddAnimation() was unused and it seems that the
whole class might be removed?!?
It builds successfully but nevertheless a review would be nice.
Christina
From e327a98220bd6da430c71b5cf22b4c3a4a9b8e0f Mon Sep 17 00:00:00 2001
From: Christina Rossmanith chrrossman...@web.de
Date: Wed, 14 Mar 2012 19:50:29 +0100
Subject: [PATCH 1/2] Remove unused code
---
sdext/source/presenter/PresenterWindowManager.cxx | 11 ---
sdext/source/presenter/PresenterWindowManager.hxx |2 --
2 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/sdext/source/presenter/PresenterWindowManager.cxx b/sdext/source/presenter/PresenterWindowManager.cxx
index 5dceffc..d25358f 100644
--- a/sdext/source/presenter/PresenterWindowManager.cxx
+++ b/sdext/source/presenter/PresenterWindowManager.cxx
@@ -1168,17 +1168,6 @@ void PresenterWindowManager::Invalidate (void)
{
mpPresenterController-GetPaintManager()-Invalidate(mxParentWindow);
}
-
-Referenceawt::XWindow PresenterWindowManager::GetParentWindow (void) const
-{
-return mxParentWindow;
-}
-
-Referencerendering::XCanvas PresenterWindowManager::GetParentCanvas (void) const
-{
-return mxParentCanvas;
-}
-
void PresenterWindowManager::Update (void)
{
mxClipPolygon = NULL;
diff --git a/sdext/source/presenter/PresenterWindowManager.hxx b/sdext/source/presenter/PresenterWindowManager.hxx
index 3051c38..d2a5ae2 100644
--- a/sdext/source/presenter/PresenterWindowManager.hxx
+++ b/sdext/source/presenter/PresenterWindowManager.hxx
@@ -97,8 +97,6 @@ public:
const double nWidth,
const double nHeight);
void SetPaneBorderPainter (const ::rtl::ReferencePresenterPaneBorderPainter rPainter);
-css::uno::Referencecss::awt::XWindow GetParentWindow (void) const;
-css::uno::Referencecss::rendering::XCanvas GetParentCanvas (void) const;
void Update (void);
void Layout (void);
--
1.7.4.1
From 8c8d61c1604d2a1e8889b3681d9e5bf519cd18b0 Mon Sep 17 00:00:00 2001
From: Christina Rossmanith chrrossman...@web.de
Date: Sat, 17 Mar 2012 15:24:39 +0100
Subject: [PATCH 2/2] Remove unused code (sdext)
---
sdext/source/presenter/PresenterAnimation.cxx | 31 +
sdext/source/presenter/PresenterAnimation.hxx | 17 -
sdext/source/presenter/PresenterAnimator.cxx | 11 -
sdext/source/presenter/PresenterAnimator.hxx |8 +-
unusedcode.easy |4 ---
5 files changed, 2 insertions(+), 69 deletions(-)
diff --git a/sdext/source/presenter/PresenterAnimation.cxx b/sdext/source/presenter/PresenterAnimation.cxx
index cacf98d..b5c30ec 100644
--- a/sdext/source/presenter/PresenterAnimation.cxx
+++ b/sdext/source/presenter/PresenterAnimation.cxx
@@ -47,9 +47,7 @@ PresenterAnimation::PresenterAnimation (
const sal_uInt64 nStepDuration)
: mnStartTime(GetCurrentTime()+nStartDelay),
mnTotalDuration(nTotalDuration),
- mnStepDuration(nStepDuration),
- mpStartCallbacks(),
- mpEndCallbacks()
+ mnStepDuration(nStepDuration)
{
}
@@ -72,33 +70,6 @@ sal_uInt64 PresenterAnimation::GetStepDuration (void)
return mnStepDuration;
}
-void PresenterAnimation::AddEndCallback (const Callback rCallback)
-{
-if (mpEndCallbacks.get() == NULL)
-mpEndCallbacks.reset(new ::std::vectorCallback());
-mpEndCallbacks-push_back(rCallback);
-}
-
-void PresenterAnimation::RunStartCallbacks (void)
-{
-if (mpStartCallbacks.get() != NULL)
-{
-::std::vectorCallback::const_iterator iCallback;
-for (iCallback=mpStartCallbacks-begin(); iCallback!=mpStartCallbacks-end(); ++iCallback)
-(*iCallback)();
-}
-}
-
-void PresenterAnimation::RunEndCallbacks (void)
-{
-if (mpEndCallbacks.get() != NULL)
-{
-::std::vectorCallback::const_iterator iCallback;
-for (iCallback=mpEndCallbacks-begin(); iCallback!=mpEndCallbacks-end(); ++iCallback)
-(*iCallback)();
-}
-}
-
} } // end of namespace ::sdext::presenter
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sdext/source/presenter/PresenterAnimation.hxx b/sdext/source/presenter/PresenterAnimation.hxx
index fdd8de6..8c2ce42 100644
--- a/sdext/source/presenter/PresenterAnimation.hxx
+++ b/sdext/source/presenter/PresenterAnimation.hxx
@@ -83,11 +83,6 @@ public:
typedef ::boost::functionvoid(void) Callback;
-/** Add a callback that is executed after Run() is called for the last
-time.
-*/
-void AddEndCallback (const Callback rCallback);
-
/** Called with nProgress taking on values between 0 and 1.
[PATCH] Remove unused code (sdext)
Hi,
some more code removal. Probably the private variable maTransform can be
removed as well: it is initialized with the identity transform and never
changed afterwards.
Christina
From 50b891e4dc8c9ae3587ea59a8f9e02c5ec21bf6a Mon Sep 17 00:00:00 2001
From: Christina Rossmanith chrrossman...@web.de
Date: Sat, 17 Mar 2012 20:57:16 +0100
Subject: [PATCH] Remove unused code (sdext)
---
sdext/source/presenter/PresenterController.cxx |5 -
sdext/source/presenter/PresenterController.hxx |1 -
sdext/source/presenter/PresenterGeometryHelper.cxx | 19 ---
sdext/source/presenter/PresenterGeometryHelper.hxx |4
sdext/source/presenter/PresenterSprite.cxx | 17 -
sdext/source/presenter/PresenterSprite.hxx |6 --
sdext/source/presenter/PresenterSpritePane.cxx |4
sdext/source/presenter/PresenterSpritePane.hxx |2 --
unusedcode.easy|8
9 files changed, 0 insertions(+), 66 deletions(-)
diff --git a/sdext/source/presenter/PresenterController.cxx b/sdext/source/presenter/PresenterController.cxx
index 9629aab..46960c9 100644
--- a/sdext/source/presenter/PresenterController.cxx
+++ b/sdext/source/presenter/PresenterController.cxx
@@ -494,11 +494,6 @@ rtl::ReferencePresenterPaneContainer PresenterController::GetPaneContainer (vo
return mpPaneBorderPainter;
}
-::boost::shared_ptrPresenterAnimator PresenterController::GetAnimator (void) const
-{
-return mpAnimator;
-}
-
::boost::shared_ptrPresenterCanvasHelper PresenterController::GetCanvasHelper (void) const
{
return mpCanvasHelper;
diff --git a/sdext/source/presenter/PresenterController.hxx b/sdext/source/presenter/PresenterController.hxx
index 196adb6..8b53342 100644
--- a/sdext/source/presenter/PresenterController.hxx
+++ b/sdext/source/presenter/PresenterController.hxx
@@ -119,7 +119,6 @@ public:
GetSlideShowController (void) const;
rtl::ReferencePresenterPaneContainer GetPaneContainer (void) const;
::rtl::ReferencePresenterPaneBorderPainter GetPaneBorderPainter (void) const;
-::boost::shared_ptrPresenterAnimator GetAnimator (void) const;
::boost::shared_ptrPresenterCanvasHelper GetCanvasHelper (void) const;
css::uno::Referencecss::drawing::XPresenterHelper GetPresenterHelper (void) const;
::boost::shared_ptrPresenterPaintManager GetPaintManager (void) const;
diff --git a/sdext/source/presenter/PresenterGeometryHelper.cxx b/sdext/source/presenter/PresenterGeometryHelper.cxx
index af75dee..211bf8e 100644
--- a/sdext/source/presenter/PresenterGeometryHelper.cxx
+++ b/sdext/source/presenter/PresenterGeometryHelper.cxx
@@ -161,25 +161,6 @@ bool PresenterGeometryHelper::IsInside (
rBox1.Y+rBox1.Height = rBox2.Y+rBox2.Height;
}
-awt::Rectangle PresenterGeometryHelper::Union (
-const css::awt::Rectangle rBox1,
-const css::awt::Rectangle rBox2)
-{
-if (rBox1.Width=0 || rBox1.Height=0)
-return rBox2;
-else if (rBox2.Width=0 || rBox2.Height=0)
-return rBox1;
-
-const sal_Int32 nLeft (::std::min(rBox1.X, rBox2.X));
-const sal_Int32 nTop (::std::min(rBox1.Y, rBox2.Y));
-const sal_Int32 nRight (::std::max(Right(rBox1), Right(rBox2)));
-const sal_Int32 nBottom (::std::max(Bottom(rBox1), Bottom(rBox2)));
-if (nLeft = nRight || nTop = nBottom)
-return awt::Rectangle();
-else
-return awt::Rectangle(nLeft,nTop, Width(nLeft,nRight), Height(nTop,nBottom));
-}
-
geometry::RealRectangle2D PresenterGeometryHelper::Union (
const geometry::RealRectangle2D rBox1,
const geometry::RealRectangle2D rBox2)
diff --git a/sdext/source/presenter/PresenterGeometryHelper.hxx b/sdext/source/presenter/PresenterGeometryHelper.hxx
index b5901a6..4e88748 100644
--- a/sdext/source/presenter/PresenterGeometryHelper.hxx
+++ b/sdext/source/presenter/PresenterGeometryHelper.hxx
@@ -93,10 +93,6 @@ public:
const css::awt::Rectangle rBox1,
const css::awt::Rectangle rBox2);
-static css::awt::Rectangle Union (
-const css::awt::Rectangle rBox1,
-const css::awt::Rectangle rBox2);
-
static css::geometry::RealRectangle2D Union (
const css::geometry::RealRectangle2D rBox1,
const css::geometry::RealRectangle2D rBox2);
diff --git a/sdext/source/presenter/PresenterSprite.cxx b/sdext/source/presenter/PresenterSprite.cxx
index 45ea49b..0fca939 100644
--- a/sdext/source/presenter/PresenterSprite.cxx
+++ b/sdext/source/presenter/PresenterSprite.cxx
@@ -109,11 +109,6 @@ void PresenterSprite::Resize (const css::geometry::RealSize2D rSize)
ProvideSprite();
}
-css::geometry::RealSize2D PresenterSprite::GetSize (void) const
-{
-return maSize;
-}
-
void PresenterSprite::MoveTo (const css::geometry::RealPoint2D rLocation)
{
maLocation = rLocation;
@@ -131,18 +126,6 @@ void PresenterSprite::MoveTo (const css::geometry::RealPoint2D rLocation
[PATCH] Remove unused code
This patch removes unused code as listed in unusedcode.easy
From e2ce9edf1b94bff6443257b875fa13255ac71e81 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Fri, 16 Mar 2012 20:12:53 +0100
Subject: [PATCH] Remove unused code as listed in unusedcode.easy
---
.../source/drivers/evoab2/NDatabaseMetaData.cxx|7 --
.../source/drivers/evoab2/NDatabaseMetaData.hxx|1 -
connectivity/source/drivers/evoab2/NStatement.cxx | 12
connectivity/source/drivers/evoab2/NStatement.hxx |1 -
connectivity/source/drivers/file/FNoException.cxx |5 --
connectivity/source/drivers/file/fanalyzer.cxx | 61
connectivity/source/inc/file/fanalyzer.hxx |2 -
unusedcode.easy|4 -
8 files changed, 0 insertions(+), 93 deletions(-)
diff --git a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
index 929150a..0a89e58 100644
--- a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
@@ -147,13 +147,6 @@ namespace connectivity
}
-guint
-getFieldCount()
-{
-initFields();
-return nFields;
-}
-
const ColumnProperty *
getField(guint n)
{
diff --git a/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx b/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
index 45f93b9..2cb7207 100644
--- a/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
+++ b/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
@@ -64,7 +64,6 @@ namespace connectivity
const SplitEvoColumns* get_evo_addr();
const ColumnProperty *getField(guint n);
-guint getFieldCount() ;
GType getGFieldType(guint nCol) ;
sal_Int32 getFieldType(guint nCol) ;
rtl::OUString getFieldTypeName(guint nCol) ;
diff --git a/connectivity/source/drivers/evoab2/NStatement.cxx b/connectivity/source/drivers/evoab2/NStatement.cxx
index 36786a4..81beb26 100644
--- a/connectivity/source/drivers/evoab2/NStatement.cxx
+++ b/connectivity/source/drivers/evoab2/NStatement.cxx
@@ -163,18 +163,6 @@ void SAL_CALL OCommonStatement::close( ) throw(SQLException, RuntimeException)
}
// -
-void OCommonStatement::reset() throw (SQLException)
-{
-::osl::MutexGuard aGuard( m_aMutex );
-checkDisposed(OCommonStatement_IBase::rBHelper.bDisposed);
-
-
-clearWarnings ();
-
-if (m_xResultSet.get().is())
-clearMyResultSet();
-}
-
void OCommonStatement::clearMyResultSet () throw (SQLException)
{
::osl::MutexGuard aGuard( m_aMutex );
diff --git a/connectivity/source/drivers/evoab2/NStatement.hxx b/connectivity/source/drivers/evoab2/NStatement.hxx
index d12956e..3d6d923 100644
--- a/connectivity/source/drivers/evoab2/NStatement.hxx
+++ b/connectivity/source/drivers/evoab2/NStatement.hxx
@@ -190,7 +190,6 @@ namespace connectivity
virtual ~OCommonStatement();
protected:
-void reset () throw( ::com::sun::star::sdbc::SQLException);
void clearMyResultSet () throw( ::com::sun::star::sdbc::SQLException);
void parseSql( const ::rtl::OUString sql, QueryData _out_rQueryData );
EBookQuery *whereAnalysis( const OSQLParseNode* parseTree );
diff --git a/connectivity/source/drivers/file/FNoException.cxx b/connectivity/source/drivers/file/FNoException.cxx
index 8090295..67599cb 100644
--- a/connectivity/source/drivers/file/FNoException.cxx
+++ b/connectivity/source/drivers/file/FNoException.cxx
@@ -66,11 +66,6 @@ void OPredicateCompiler::Clean()
m_aCodeList.clear();
}
// -
-void OSQLAnalyzer::clean()
-{
-m_aCompiler-Clean();
-}
-// -
void OSQLAnalyzer::bindParameterRow(OValueRefRow _pRow)
{
OCodeList rCodeList= m_aCompiler-m_aCodeList;
diff --git a/connectivity/source/drivers/file/fanalyzer.cxx b/connectivity/source/drivers/file/fanalyzer.cxx
index d5f327d..fcaba19 100644
--- a/connectivity/source/drivers/file/fanalyzer.cxx
+++ b/connectivity/source/drivers/file/fanalyzer.cxx
@@ -212,67 +212,6 @@ void OSQLAnalyzer::bindSelectRow(const OValueRefRow _pRow)
return pKeySet;
}
-//--
-void OSQLAnalyzer::describeParam(::rtl::ReferenceOSQLColumns rParameterColumns)
-{
-OCodeList rCodeList= m_aCompiler-m_aCodeList;
-OCodeStack aCodeStack;
-
-if (!rCodeList.size())
-return; // no predicate
-if (!rParameterColumns-get().size())
-return; // no parameters
-
-// Create columns, that have a more precise description for the included
[PATCH] remove unused code (oox, sd)
Hi there,
remove some unused code in oox and sd.
Regards,
Petr
From 2cc831282d53c3a14dd10fc8cb190f1d15df3354 Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Thu, 15 Mar 2012 11:40:15 +0100
Subject: [PATCH] remove unused code (oox, sd)
---
oox/inc/oox/helper/attributelist.hxx |6 --
oox/inc/oox/helper/containerhelper.hxx | 16
oox/inc/oox/helper/graphichelper.hxx |2 --
oox/source/helper/attributelist.cxx | 10 --
oox/source/helper/containerhelper.cxx| 18 --
oox/source/helper/graphichelper.cxx |5 -
sd/source/filter/eppt/epptooxml.hxx |1 -
sd/source/filter/eppt/pptx-epptooxml.cxx | 10 --
unusedcode.easy |5 -
9 files changed, 0 insertions(+), 73 deletions(-)
diff --git a/oox/inc/oox/helper/attributelist.hxx b/oox/inc/oox/helper/attributelist.hxx
index d0a0600..c60c6f8 100644
--- a/oox/inc/oox/helper/attributelist.hxx
+++ b/oox/inc/oox/helper/attributelist.hxx
@@ -66,12 +66,6 @@ public:
/** Returns the 32-bit signed integer value from the passed string (hexadecimal). */
static sal_Int32decodeIntegerHex( const ::rtl::OUString rValue );
-
-/** Returns the 32-bit unsigned integer value from the passed string (hexadecimal). */
-static sal_uInt32 decodeUnsignedHex( const ::rtl::OUString rValue );
-
-/** Returns the 64-bit signed integer value from the passed string (hexadecimal). */
-static sal_Int64decodeHyperHex( const ::rtl::OUString rValue );
};
//
diff --git a/oox/inc/oox/helper/containerhelper.hxx b/oox/inc/oox/helper/containerhelper.hxx
index 5c9dc88..eef9429 100644
--- a/oox/inc/oox/helper/containerhelper.hxx
+++ b/oox/inc/oox/helper/containerhelper.hxx
@@ -173,22 +173,6 @@ public:
static ::com::sun::star::uno::Reference ::com::sun::star::container::XIndexContainer
createIndexContainer( const ::com::sun::star::uno::Reference ::com::sun::star::uno::XComponentContext rxContext );
-/** Inserts an object into an indexed container.
-
-@param rxIndexContainer com.sun.star.container.XIndexContainer
-interface of the indexed container.
-
-@param nIndex Insertion index for the object.
-
-@param rObject The object to be inserted.
-
-@return True = object successfully inserted.
- */
-static bool insertByIndex(
-const ::com::sun::star::uno::Reference ::com::sun::star::container::XIndexContainer rxIndexContainer,
-sal_Int32 nIndex,
-const ::com::sun::star::uno::Any rObject );
-
// com.sun.star.container.XNameContainer --
/** Creates a new name container object from scratch. */
diff --git a/oox/inc/oox/helper/graphichelper.hxx b/oox/inc/oox/helper/graphichelper.hxx
index d3507fa..9881200 100644
--- a/oox/inc/oox/helper/graphichelper.hxx
+++ b/oox/inc/oox/helper/graphichelper.hxx
@@ -93,8 +93,6 @@ public:
sal_Int32 convertScreenPixelXToHmm( double fPixelX ) const;
/** Converts the passed value from vertical screen pixels to 1/100 mm. */
sal_Int32 convertScreenPixelYToHmm( double fPixelY ) const;
-/** Converts the passed point from screen pixels to 1/100 mm. */
-::com::sun::star::awt::Point convertScreenPixelToHmm( const ::com::sun::star::awt::Point rPixel ) const;
/** Converts the passed size from screen pixels to 1/100 mm. */
::com::sun::star::awt::Size convertScreenPixelToHmm( const ::com::sun::star::awt::Size rPixel ) const;
diff --git a/oox/source/helper/attributelist.cxx b/oox/source/helper/attributelist.cxx
index 33f4ed5..f1d114d 100644
--- a/oox/source/helper/attributelist.cxx
+++ b/oox/source/helper/attributelist.cxx
@@ -122,16 +122,6 @@ sal_Int32 AttributeConversion::decodeIntegerHex( const OUString rValue )
return rValue.toInt32( 16 );
}
-sal_uInt32 AttributeConversion::decodeUnsignedHex( const OUString rValue )
-{
-return getLimitedValue sal_uInt32, sal_Int64 ( rValue.toInt64( 16 ), 0, SAL_MAX_UINT32 );
-}
-
-sal_Int64 AttributeConversion::decodeHyperHex( const OUString rValue )
-{
-return rValue.toInt64( 16 );
-}
-
//
AttributeList::AttributeList( const Reference XFastAttributeList rxAttribs ) :
diff --git a/oox/source/helper/containerhelper.cxx b/oox/source/helper/containerhelper.cxx
index 23bad22..a19e9b4 100644
--- a/oox/source/helper/containerhelper.cxx
+++ b/oox/source/helper/containerhelper.cxx
@@ -119,24 +119,6 @@ Reference XIndexContainer ContainerHelper::createIndexContainer( const Refere
return xContainer;
}
-bool ContainerHelper::insertByIndex(
-const Reference XIndexContainer rxIndexContainer,
-sal_Int32
Re: [PUSHED][PATCH] Remove unused code in drawingml
On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote: Hi! These patches remove unused code as listed in unusedcode.easy Looks good, pushed now. Thanks for these. If I'm not wrong, this is you first submission ? If so, can you add yourself to http://wiki.documentfoundation.org/Development/Developers and confirm that your code is submitted under the preferred LGPLv3+/MPLv1.1+ combo ? Its typical to do a sort of blanket, all patches until I state otherwise, should be links to examples on the above wiki page. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in drawingml
On Wed, Mar 14, 2012 at 6:46 PM, Caolán McNamara caol...@redhat.com wrote: On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote: Hi! These patches remove unused code as listed in unusedcode.easy Looks good, pushed now. Thanks for these. If I'm not wrong, this is you first submission ? If so, can you add yourself to http://wiki.documentfoundation.org/Development/Developers and confirm that your code is submitted under the preferred LGPLv3+/MPLv1.1+ combo ? Its typical to do a sort of blanket, all patches until I state otherwise, should be links to examples on the above wiki page. Yes, this was my first submission :D. I sent a mail regarding the license, and also modified the wiki page. Thanks, Mariana Mărășoiu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code in drawingml
Hi!
These patches remove unused code as listed in unusedcode.easy
Mariana Marasoiu
From 2fa32c691f2af987bb32bff8b9b3f940c90b08aa Mon Sep 17 00:00:00 2001
From: Mariana Marasoiu mariana.maras...@gmail.com
Date: Wed, 14 Mar 2012 01:07:16 +0200
Subject: [PATCH 1/4] Remove unused code in drawingml.
---
oox/inc/oox/drawingml/customshapeproperties.hxx |1 -
oox/source/drawingml/customshapeproperties.cxx | 10 --
unusedcode.easy |1 -
3 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/oox/inc/oox/drawingml/customshapeproperties.hxx b/oox/inc/oox/drawingml/customshapeproperties.hxx
index 5fd6cd0..1b88ed3 100644
--- a/oox/inc/oox/drawingml/customshapeproperties.hxx
+++ b/oox/inc/oox/drawingml/customshapeproperties.hxx
@@ -155,7 +155,6 @@ public:
voidsetMirroredY( sal_Bool bMirroredY ) { mbMirroredY = bMirroredY; };
voidsetTextRotateAngle( sal_Int32 nAngle ) { mnTextRotateAngle = nAngle; };
-double getValue( const std::vector CustomShapeGuide , sal_uInt32 nIndex ) const;
static sal_Int32 SetCustomShapeGuideValue( std::vector CustomShapeGuide rGuideList, const CustomShapeGuide rGuide );
static sal_Int32 GetCustomShapeGuideValue( const std::vector CustomShapeGuide rGuideList, const rtl::OUString rFormulaName );
diff --git a/oox/source/drawingml/customshapeproperties.cxx b/oox/source/drawingml/customshapeproperties.cxx
index 29844b8..071f37a 100644
--- a/oox/source/drawingml/customshapeproperties.cxx
+++ b/oox/source/drawingml/customshapeproperties.cxx
@@ -359,16 +359,6 @@ void CustomShapeProperties::pushToPropSet( const ::oox::core::FilterBase /* rFi
}
}
-double CustomShapeProperties::getValue( const std::vector CustomShapeGuide rGuideList, sal_uInt32 nIndex ) const
-{
-double fRet = 0.0;
-if ( nIndex rGuideList.size() )
-{
-
-}
-return fRet;
-}
-
Any CustomShapeProvider::createStringSequence( size_t nStrings, const char **pStrings )
{
Sequence OUString aStringSequence( nStrings );
diff --git a/unusedcode.easy b/unusedcode.easy
index 77ae5b4..b2450c7 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -907,7 +907,6 @@ oox::drawingml::ChartExport::exportXAxis(oox::drawingml::AxisIdPair)
oox::drawingml::ChartExport::exportYAxis(oox::drawingml::AxisIdPair)
oox::drawingml::ColorPropertySet::getColor()
oox::drawingml::ColorPropertySet::setColor(int)
-oox::drawingml::CustomShapeProperties::getValue(std::__debug::vectoroox::drawingml::CustomShapeGuide, std::allocatoroox::drawingml::CustomShapeGuide const, unsigned int) const
oox::drawingml::DiagramLayout::layout(std::__debug::vectoroox::drawingml::dgm::Point, std::allocatoroox::drawingml::dgm::Point const, com::sun::star::awt::Point const)
oox::drawingml::GraphicProperties::assignUsed(oox::drawingml::GraphicProperties const)
oox::drawingml::TextBodyProperties::pushToPropMap(oox::PropertyMap) const
--
1.7.0.4
From 9e68e6fdf658f4c11bb4ac93402d402544a9d0d1 Mon Sep 17 00:00:00 2001
From: Mariana Marasoiu mariana.maras...@gmail.com
Date: Wed, 14 Mar 2012 01:15:11 +0200
Subject: [PATCH 2/4] Remove unused code in drawingml/diagram.
---
oox/source/drawingml/diagram/diagram.cxx |3 ---
oox/source/drawingml/diagram/diagram.hxx |2 --
unusedcode.easy |1 -
3 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/oox/source/drawingml/diagram/diagram.cxx b/oox/source/drawingml/diagram/diagram.cxx
index 58c8de8..8e6586d 100644
--- a/oox/source/drawingml/diagram/diagram.cxx
+++ b/oox/source/drawingml/diagram/diagram.cxx
@@ -95,9 +95,6 @@ void DiagramData::dump()
boost::bind( dgm::Point::dump, _1 ) );
}
-void DiagramLayout::layout( const dgm::Points /*pTree*/, const awt::Point /*pt*/ )
-{
-}
void Diagram::setData( const DiagramDataPtr pData)
{
diff --git a/oox/source/drawingml/diagram/diagram.hxx b/oox/source/drawingml/diagram/diagram.hxx
index 633f452..0e5bfef 100644
--- a/oox/source/drawingml/diagram/diagram.hxx
+++ b/oox/source/drawingml/diagram/diagram.hxx
@@ -237,8 +237,6 @@ public:
const DiagramDataPtr getStyleData() const
{ return mpStyleData; }
-void layout( const dgm::Points pTree, const com::sun::star::awt::Point pt );
-
private:
::rtl::OUString msDefStyle;
::rtl::OUString msMinVer;
diff --git a/unusedcode.easy b/unusedcode.easy
index b2450c7..e357027 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -907,7 +907,6 @@ oox::drawingml::ChartExport::exportXAxis(oox::drawingml::AxisIdPair)
oox::drawingml::ChartExport::exportYAxis(oox::drawingml::AxisIdPair)
oox::drawingml::ColorPropertySet::getColor()
oox::drawingml::ColorPropertySet::setColor(int)
-oox::drawingml::DiagramLayout::layout(std::__debug::vectoroox::drawingml::dgm::Point, std::allocatoroox::drawingml::dgm::Point const, com::sun::star::awt::Point const)
[PATCH] Remove unused code
This patch removes unused code as listed in unusedcode.easy
From 1d2ad5f05d4b415df6ff636c7f62c9ba1ea4a1bf Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Mon, 12 Mar 2012 19:04:03 +0100
Subject: [PATCH] Remove unused code in dpcache
---
sc/inc/dpcache.hxx |3 ---
sc/source/core/data/dpcache.cxx | 32
unusedcode.easy |3 ---
3 files changed, 0 insertions(+), 38 deletions(-)
diff --git a/sc/inc/dpcache.hxx b/sc/inc/dpcache.hxx
index 9f33db5..8ece780 100644
--- a/sc/inc/dpcache.hxx
+++ b/sc/inc/dpcache.hxx
@@ -136,9 +136,7 @@ public:
long AppendGroupField();
void ResetGroupItems(long nDim, const ScDPNumGroupInfo rNumInfo);
SCROW SetGroupItem(long nDim, const ScDPItemData rData);
-const DataListType* GetGroupDimMemberValues(long nDim) const;
void GetGroupDimMemberIds(long nDim, std::vectorSCROW rIds) const;
-void ClearGroupFields();
SCCOL GetDimensionIndex(const rtl::OUString sName) const;
sal_uLong GetNumberFormat( long nDim ) const;
@@ -158,7 +156,6 @@ public:
ScDocument* GetDoc() const;
long GetColumnCount() const;
-long GetGroupFieldCount() const;
const ScDPItemData* GetItemDataById( long nDim, SCROW nId ) const;
diff --git a/sc/source/core/data/dpcache.cxx b/sc/source/core/data/dpcache.cxx
index 9ce9e25..a4705b4 100644
--- a/sc/source/core/data/dpcache.cxx
+++ b/sc/source/core/data/dpcache.cxx
@@ -1013,27 +1013,6 @@ SCROW ScDPCache::SetGroupItem(long nDim, const ScDPItemData rData)
return -1;
}
-const ScDPCache::DataListType* ScDPCache::GetGroupDimMemberValues(long nDim) const
-{
-if (nDim 0)
-return NULL;
-
-long nSourceCount = static_castlong(maFields.size());
-if (nDim nSourceCount)
-{
-if (!maFields.at(nDim).mpGroup)
-return NULL;
-
-return maFields[nDim].mpGroup-maItems;
-}
-
-nDim -= nSourceCount;
-if (nDim static_castlong(maGroupFields.size()))
-return maGroupFields.at(nDim).maItems;
-
-return NULL;
-}
-
void ScDPCache::GetGroupDimMemberIds(long nDim, std::vectorSCROW rIds) const
{
if (nDim 0)
@@ -1074,12 +1053,6 @@ struct ClearGroupItems : std::unary_functionScDPCache::Field, void
}
-void ScDPCache::ClearGroupFields()
-{
-maGroupFields.clear();
-std::for_each(maFields.begin(), maFields.end(), ClearGroupItems());
-}
-
SCROW ScDPCache::GetOrder(long nDim, SCROW nIndex) const
{
OSL_ENSURE( nDim =0 nDim mnColumnCount, ScDPTableDataCache::GetOrder : out of bound );
@@ -1110,9 +1083,4 @@ long ScDPCache::GetColumnCount() const
return mnColumnCount;
}
-long ScDPCache::GetGroupFieldCount() const
-{
-return maGroupFields.size();
-}
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/unusedcode.easy b/unusedcode.easy
index b591d6a..ecc821d 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -72,9 +72,6 @@ ScConditionalFormats_Impl::Remove(unsigned short, unsigned short)
ScCsvControl::ScCsvControl(Window*, ScCsvLayoutData const, long)
ScDBCollection::AnonDBs::erase(boost::void_ptr_iterator__gnu_debug::_Safe_iterator__gnu_cxx::__normal_iteratorvoid**, std::__cxx1998::vectorvoid*, std::allocatorvoid* , std::__debug::vectorvoid*, std::allocatorvoid* , ScDBData)
ScDBCollection::AnonDBs::size() const
-ScDPCache::ClearGroupFields()
-ScDPCache::GetGroupDimMemberValues(long) const
-ScDPCache::GetGroupFieldCount() const
ScDPInitState::GetNameIdForIndex(long) const
ScDPItemData::ScDPItemData(double)
ScDPItemData::SetGroupValue(int, int)
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code in dptabres
This patch removes unused code as listed in unusedcode.easy
From 2552218909dbee683a87c3052d1c4dd85b4a58fe Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Mon, 12 Mar 2012 19:22:44 +0100
Subject: [PATCH] Remove unused code in dptabres
---
sc/inc/dptabres.hxx |3 ---
sc/source/core/data/dptabres.cxx | 18 --
unusedcode.easy |2 --
3 files changed, 0 insertions(+), 23 deletions(-)
diff --git a/sc/inc/dptabres.hxx b/sc/inc/dptabres.hxx
index bfdef7f..36ed4ac 100644
--- a/sc/inc/dptabres.hxx
+++ b/sc/inc/dptabres.hxx
@@ -83,7 +83,6 @@ public:
longGetCount() const{ return nCount; }
const long* GetSource() const { return pIndex; }
const SCROW* GetNameIds() const{ return pData; }
-SCROW GetNameIdForIndex( long nIndexValue ) const;
};
typedef ::std::vectorsal_Int32 ScMemberSortOrder;
@@ -337,8 +336,6 @@ public:
boolIsBaseForGroup( long nDim ) const; // any group
longGetGroupBase( long nGroupDim ) const;
boolIsNumOrDateGroup( long nDim ) const;
-boolIsInGroup( const ScDPItemData rGroupData, long nGroupIndex,
- long nBaseDataId, long nBaseIndex ) const;
boolIsInGroup( SCROW nGroupDataId, long nGroupIndex,
const ScDPItemData rBaseData, long nBaseIndex ) const;
boolHasCommonElement( SCROW nFirstDataId, long nFirstIndex,
diff --git a/sc/source/core/data/dptabres.cxx b/sc/source/core/data/dptabres.cxx
index 3372d68..8db141e 100644
--- a/sc/source/core/data/dptabres.cxx
+++ b/sc/source/core/data/dptabres.cxx
@@ -279,15 +279,6 @@ void ScDPInitState::RemoveMember()
--nCount;
}
-SCROW ScDPInitState::GetNameIdForIndex( long nIndexValue ) const
-{
-for (long i=0; inCount; i++)
-if ( pIndex[i] == nIndexValue )
-return pData[i];
-
-return -1;// not found
-}
-
// ---
void lcl_DumpRow( const String rType, const String rName, const ScDPAggData* pAggData,
@@ -920,15 +911,6 @@ bool ScDPResultData::IsNumOrDateGroup( long nDim ) const
return pSource-GetData()-IsNumOrDateGroup( nDim );
}
-bool ScDPResultData::IsInGroup( const ScDPItemData rGroupData, long nGroupIndex,
-long nBaseDataId, long nBaseIndex ) const
-{
-const ScDPItemData* pData = pSource-GetItemDataById( nGroupIndex , nBaseDataId);
-if ( pData )
- return pSource-GetData()-IsInGroup( rGroupData, nGroupIndex, *pData , nBaseIndex );
-else
-return false;
-}
bool ScDPResultData::IsInGroup( SCROW nGroupDataId, long nGroupIndex,
const ScDPItemData rBaseData, long nBaseIndex ) const
{
diff --git a/unusedcode.easy b/unusedcode.easy
index ecc821d..e1067ed 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -72,11 +72,9 @@ ScConditionalFormats_Impl::Remove(unsigned short, unsigned short)
ScCsvControl::ScCsvControl(Window*, ScCsvLayoutData const, long)
ScDBCollection::AnonDBs::erase(boost::void_ptr_iterator__gnu_debug::_Safe_iterator__gnu_cxx::__normal_iteratorvoid**, std::__cxx1998::vectorvoid*, std::allocatorvoid* , std::__debug::vectorvoid*, std::allocatorvoid* , ScDBData)
ScDBCollection::AnonDBs::size() const
-ScDPInitState::GetNameIdForIndex(long) const
ScDPItemData::ScDPItemData(double)
ScDPItemData::SetGroupValue(int, int)
ScDPLabelData::ScDPLabelData(rtl::OUString const, short, bool)
-ScDPResultData::IsInGroup(ScDPItemData const, long, long, long) const
ScDocRowHeightUpdater::TabRanges::TabRanges()
ScFilterDetect::impl_createFactory(com::sun::star::uno::Referencecom::sun::star::lang::XMultiServiceFactory const)
ScHTMLColOffset::Insert(ScHTMLColOffset const*, unsigned short, unsigned short)
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code in dpitemdata
This patch removes unused code as listed in unusedcode.easy
From 585721f333baa53199ab2dbe36964e5759b3089a Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Mon, 12 Mar 2012 20:38:51 +0100
Subject: [PATCH] Remove unused code in dpitemdata
---
sc/inc/dpitemdata.hxx |2 --
sc/source/core/data/dpitemdata.cxx | 11 ---
unusedcode.easy|2 --
3 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/sc/inc/dpitemdata.hxx b/sc/inc/dpitemdata.hxx
index 3e09d89..10363be 100644
--- a/sc/inc/dpitemdata.hxx
+++ b/sc/inc/dpitemdata.hxx
@@ -79,7 +79,6 @@ public:
ScDPItemData();
ScDPItemData(const ScDPItemData r);
ScDPItemData(const rtl::OUString rStr);
-ScDPItemData(double fVal);
ScDPItemData(sal_Int32 nGroupType, sal_Int32 nValue);
~ScDPItemData();
@@ -89,7 +88,6 @@ public:
void SetRangeStart(double fVal);
void SetRangeFirst();
void SetRangeLast();
-void SetGroupValue(sal_Int32 nGroupType, sal_Int32 nValue);
void SetErrorString(const rtl::OUString rS);
bool IsCaseInsEqual(const ScDPItemData r) const;
diff --git a/sc/source/core/data/dpitemdata.cxx b/sc/source/core/data/dpitemdata.cxx
index 77c01b9..dd370ca 100644
--- a/sc/source/core/data/dpitemdata.cxx
+++ b/sc/source/core/data/dpitemdata.cxx
@@ -112,9 +112,6 @@ void ScDPItemData::DisposeString()
ScDPItemData::ScDPItemData(const rtl::OUString rStr) :
mpString(new rtl::OUString(rStr)), meType(String) {}
-ScDPItemData::ScDPItemData(double fVal) :
-mfValue(fVal), meType(Value) {}
-
ScDPItemData::ScDPItemData(sal_Int32 nGroupType, sal_Int32 nValue) :
meType(GroupValue)
{
@@ -167,14 +164,6 @@ void ScDPItemData::SetRangeLast()
meType = RangeStart;
}
-void ScDPItemData::SetGroupValue(sal_Int32 nGroupType, sal_Int32 nValue)
-{
-DisposeString();
-maGroupValue.mnGroupType = nGroupType;
-maGroupValue.mnValue = nValue;
-meType = GroupValue;
-}
-
void ScDPItemData::SetErrorString(const rtl::OUString rS)
{
SetString(rS);
diff --git a/unusedcode.easy b/unusedcode.easy
index e1067ed..77ae5b4 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -72,8 +72,6 @@ ScConditionalFormats_Impl::Remove(unsigned short, unsigned short)
ScCsvControl::ScCsvControl(Window*, ScCsvLayoutData const, long)
ScDBCollection::AnonDBs::erase(boost::void_ptr_iterator__gnu_debug::_Safe_iterator__gnu_cxx::__normal_iteratorvoid**, std::__cxx1998::vectorvoid*, std::allocatorvoid* , std::__debug::vectorvoid*, std::allocatorvoid* , ScDBData)
ScDBCollection::AnonDBs::size() const
-ScDPItemData::ScDPItemData(double)
-ScDPItemData::SetGroupValue(int, int)
ScDPLabelData::ScDPLabelData(rtl::OUString const, short, bool)
ScDocRowHeightUpdater::TabRanges::TabRanges()
ScFilterDetect::impl_createFactory(com::sun::star::uno::Referencecom::sun::star::lang::XMultiServiceFactory const)
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code
Hi Petr, On 09.03.2012 11:39, Petr Vorel wrote: another patch removing unused code. Actually I need an advice this time. Is method oox::core::XmlFilterBase::getChartConverter() really unused / unwanted? As it's used in Shape::finalizeXShape (oox/source/drawingml/shape.cxx). So feel free to drop it if it's not valid. Btw can we really rely on the tool which generates unusedcode.easy? :) see http://lists.freedesktop.org/archives/libreoffice/2012-February/026889.html pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b6ff047a572189a2b000ffbd437e573e518773db Thanks, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code
Hi there,
another patch removing unused code. Actually I need an advice this time. Is
method oox::core::XmlFilterBase::getChartConverter() really unused / unwanted?
As it's used in Shape::finalizeXShape (oox/source/drawingml/shape.cxx). So feel
free to drop it if it's not valid.
Btw can we really rely on the tool which generates unusedcode.easy?
Regards,
Petr
From 94f6485cdfd7e87af6c432708c16aed061a8c2cb Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Thu, 8 Mar 2012 16:11:03 +0100
Subject: [PATCH] remove unused code
---
oox/inc/oox/core/xmlfilterbase.hxx|4
oox/inc/oox/ppt/dgmimport.hxx |1 -
oox/inc/oox/ppt/dgmlayout.hxx |1 -
oox/inc/oox/ppt/pptimport.hxx |1 -
oox/inc/oox/xls/excelfilter.hxx |1 -
oox/source/core/xmlfilterbase.cxx |5 -
oox/source/drawingml/shape.cxx|2 --
oox/source/ppt/dgmimport.cxx |5 -
oox/source/ppt/dgmlayout.cxx |5 -
oox/source/ppt/pptimport.cxx |5 -
oox/source/shape/ShapeFilterBase.cxx |5 -
oox/source/shape/ShapeFilterBase.hxx |2 --
oox/source/xls/excelfilter.cxx|5 -
sc/source/filter/excel/xestream.cxx |6 --
sc/source/filter/inc/xestream.hxx |1 -
sd/source/filter/eppt/epptooxml.hxx |1 -
sw/source/filter/ww8/docxexportfilter.hxx |1 -
unusedcode.easy |1 -
18 files changed, 0 insertions(+), 52 deletions(-)
diff --git a/oox/inc/oox/core/xmlfilterbase.hxx b/oox/inc/oox/core/xmlfilterbase.hxx
index 0e015da..09c76ee 100644
--- a/oox/inc/oox/core/xmlfilterbase.hxx
+++ b/oox/inc/oox/core/xmlfilterbase.hxx
@@ -95,10 +95,6 @@ public:
/** Has to be implemented by each filter to return the collection of VML shapes. */
virtual ::oox::vml::Drawing* getVmlDrawing() = 0;
-/** Has to be implemented by each filter, returns a filter-specific chart
-converter object, that should be global per imported document. */
-virtual ::oox::drawingml::chart::ChartConverter* getChartConverter() = 0;
-
/** Has to be implemented by each filter to return the table style list. */
virtual const ::oox::drawingml::table::TableStyleListPtr getTableStyles() = 0;
diff --git a/oox/inc/oox/ppt/dgmimport.hxx b/oox/inc/oox/ppt/dgmimport.hxx
index 74f8020..99332a8 100644
--- a/oox/inc/oox/ppt/dgmimport.hxx
+++ b/oox/inc/oox/ppt/dgmimport.hxx
@@ -57,7 +57,6 @@ public:
virtual const oox::drawingml::table::TableStyleListPtr getTableStyles();
virtual oox::vml::Drawing* getVmlDrawing();
-virtual oox::drawingml::chart::ChartConverter* getChartConverter();
private:
virtual ::rtl::OUString implGetImplementationName() const;
diff --git a/oox/inc/oox/ppt/dgmlayout.hxx b/oox/inc/oox/ppt/dgmlayout.hxx
index 35c0857..a263eed 100644
--- a/oox/inc/oox/ppt/dgmlayout.hxx
+++ b/oox/inc/oox/ppt/dgmlayout.hxx
@@ -57,7 +57,6 @@ public:
virtual const oox::drawingml::table::TableStyleListPtr getTableStyles();
virtual ::oox::vml::Drawing* getVmlDrawing();
-virtual ::oox::drawingml::chart::ChartConverter* getChartConverter();
private:
virtual ::rtl::OUString implGetImplementationName() const;
diff --git a/oox/inc/oox/ppt/pptimport.hxx b/oox/inc/oox/ppt/pptimport.hxx
index 79df421..ddb67a4 100644
--- a/oox/inc/oox/ppt/pptimport.hxx
+++ b/oox/inc/oox/ppt/pptimport.hxx
@@ -57,7 +57,6 @@ public:
virtual const ::oox::drawingml::Theme* getCurrentTheme() const;
virtual ::oox::vml::Drawing* getVmlDrawing();
virtual const oox::drawingml::table::TableStyleListPtr getTableStyles();
-virtual ::oox::drawingml::chart::ChartConverter* getChartConverter();
voidsetActualSlidePersist( SlidePersistPtr pActualSlidePersist ){ mpActualSlidePersist = pActualSlidePersist; };
std::map rtl::OUString, oox::drawingml::ThemePtr getThemes(){ return maThemes; };
diff --git a/oox/inc/oox/xls/excelfilter.hxx b/oox/inc/oox/xls/excelfilter.hxx
index c15b6cc..8585dc2 100644
--- a/oox/inc/oox/xls/excelfilter.hxx
+++ b/oox/inc/oox/xls/excelfilter.hxx
@@ -71,7 +71,6 @@ public:
virtual const ::oox::drawingml::Theme* getCurrentTheme() const;
virtual ::oox::vml::Drawing* getVmlDrawing();
virtual const ::oox::drawingml::table::TableStyleListPtr getTableStyles();
-virtual ::oox::drawingml::chart::ChartConverter* getChartConverter();
virtual sal_Bool SAL_CALL filter( const ::com::sun::star::uno::Sequence ::com::sun::star::beans::PropertyValue rDescriptor ) throw( ::com::sun::star::uno::RuntimeException );
diff --git a/oox/source/core/xmlfilterbase.cxx b/oox/source/core/xmlfilterbase.cxx
index f5868bf..f1aebdd 100644
--- a/oox/source/core/xmlfilterbase.cxx
+++ b/oox/source/core/xmlfilterbase.cxx
@@ -672,11 +672,6 @@ XmlFilterBase XmlFilterBase::exportDocumentProperties
[PATCH] Remove unused code
This patch removes unused code as listed in unusedcode.easy
From 7b4e4199bdf631796f69813e60c296b0a0561e0c Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Wed, 7 Mar 2012 20:32:25 +0100
Subject: [PATCH] Remove unused code
---
connectivity/inc/connectivity/dbcharset.hxx |1 -
connectivity/source/commontools/dbcharset.cxx |6 --
unusedcode.easy |1 -
3 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/connectivity/inc/connectivity/dbcharset.hxx b/connectivity/inc/connectivity/dbcharset.hxx
index 60c96fb..cb13fcd 100644
--- a/connectivity/inc/connectivity/dbcharset.hxx
+++ b/connectivity/inc/connectivity/dbcharset.hxx
@@ -116,7 +116,6 @@ namespace dbtools
::rtl::OUString getIanaName() const { return m_aIanaName; }
protected:
-CharsetIteratorDerefHelper();
CharsetIteratorDerefHelper( const rtl_TextEncoding _eEncoding, const ::rtl::OUString _rIanaName );
};
diff --git a/connectivity/source/commontools/dbcharset.cxx b/connectivity/source/commontools/dbcharset.cxx
index 87b78c4..45729df 100644
--- a/connectivity/source/commontools/dbcharset.cxx
+++ b/connectivity/source/commontools/dbcharset.cxx
@@ -154,12 +154,6 @@ namespace dbtools
{
}
-//-
-CharsetIteratorDerefHelper::CharsetIteratorDerefHelper()
-:m_eEncoding(RTL_TEXTENCODING_DONTKNOW)
-{
-}
-
//=
//= OCharsetMap::CharsetIterator
//=
diff --git a/unusedcode.easy b/unusedcode.easy
index 80eff11..9e16d5f 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -875,7 +875,6 @@ cppcanvas::internal::(anonymous namespace)::TransparencyGroupAction::Transparenc
cppcanvas::internal::ImplSprite::ImplSprite(com::sun::star::uno::Referencecom::sun::star::rendering::XSpriteCanvas const, com::sun::star::uno::Referencecom::sun::star::rendering::XAnimatedSprite const, boost::shared_ptrcppcanvas::internal::ImplSpriteCanvas::TransformationArbiter const)
cppcanvas::internal::ImplText::ImplText(boost::shared_ptrcppcanvas::Canvas const, rtl::OUString const)
dbaui::getKeyColumns(com::sun::star::uno::Referencecom::sun::star::container::XIndexAccess const, int)
-dbtools::CharsetIteratorDerefHelper::CharsetIteratorDerefHelper()
dbtools::DBTypeConversion::toINT64(com::sun::star::util::DateTime const)
dbtools::SQLExceptionInfo::SQLExceptionInfo(com::sun::star::sdb::SQLErrorEvent const)
dbtools::SQLExceptionIteratorHelper::SQLExceptionIteratorHelper(com::sun::star::sdb::SQLContext const)
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code in vbahelper
This patch removes unused code as listed in unusedcode.eas
From 4299bf917c9ac0c02dd5aecc8b40e09e775136f6 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Wed, 7 Mar 2012 20:54:46 +0100
Subject: [PATCH] Remove unused code in vbahelper
---
unusedcode.easy |4
vbahelper/inc/vbahelper/vbahelper.hxx|4
vbahelper/source/vbahelper/vbahelper.cxx | 14 --
3 files changed, 0 insertions(+), 22 deletions(-)
diff --git a/unusedcode.easy b/unusedcode.easy
index 9e16d5f..255ef66 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -907,10 +907,6 @@ nullcanvas::SpriteCanvasHelper::opaqueUpdate(basegfx::B2DConnectedRangescanvas:
nullcanvas::SpriteCanvasHelper::scrollUpdate(basegfx::B2DRange const, basegfx::B2DRange const, basegfx::B2DConnectedRangescanvas::SpriteRedrawManager::SpriteInfo::ConnectedComponents const)
o3tltests::cow_wrapper_client2::queryUnmodified() const
o3tltests::cow_wrapper_client3::queryUnmodified() const
-ooo::vba::Millimeter::get()
-ooo::vba::Millimeter::getInPoints()
-ooo::vba::Millimeter::set(double)
-ooo::vba::Millimeter::setInHundredthsOfOneMillimeter(double)
ooo::vba::createVBAUnoAPIService(SfxObjectShell*, char const*)
ooo::vba::excel::getViewFrame(com::sun::star::uno::Referencecom::sun::star::frame::XModel const)
ooo::vba::excel::isInPrintPreview(SfxViewFrame*)
diff --git a/vbahelper/inc/vbahelper/vbahelper.hxx b/vbahelper/inc/vbahelper/vbahelper.hxx
index 00dfe58..190243c 100644
--- a/vbahelper/inc/vbahelper/vbahelper.hxx
+++ b/vbahelper/inc/vbahelper/vbahelper.hxx
@@ -147,12 +147,8 @@ public:
Millimeter(double mm);
-void set(double mm);
void setInPoints(double points) ;
-void setInHundredthsOfOneMillimeter(double hmm);
-double get();
double getInHundredthsOfOneMillimeter();
-double getInPoints();
static sal_Int32 getInHundredthsOfOneMillimeter(double points);
static double getInPoints(int _hmm);
};
diff --git a/vbahelper/source/vbahelper/vbahelper.cxx b/vbahelper/source/vbahelper/vbahelper.cxx
index f99077d..70fe850 100644
--- a/vbahelper/source/vbahelper/vbahelper.cxx
+++ b/vbahelper/source/vbahelper/vbahelper.cxx
@@ -1179,29 +1179,15 @@ Millimeter::Millimeter():m_nMillimeter(0) {}
Millimeter::Millimeter(double mm):m_nMillimeter(mm) {}
-void Millimeter::set(double mm) { m_nMillimeter = mm; }
void Millimeter::setInPoints(double points)
{
m_nMillimeter = points * factor / 100.0;
}
-void Millimeter::setInHundredthsOfOneMillimeter(double hmm)
-{
-m_nMillimeter = hmm / 100;
-}
-
-double Millimeter::get()
-{
-return m_nMillimeter;
-}
double Millimeter::getInHundredthsOfOneMillimeter()
{
return m_nMillimeter * 100;
}
-double Millimeter::getInPoints()
-{
-return m_nMillimeter / factor * 100.0;
-}
sal_Int32 Millimeter::getInHundredthsOfOneMillimeter(double points)
{
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code(2)
This patch removes unused code as listed in unusedcode.easy
From 19f0c3ee363967fdd01601d640aff69c705b0303 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Wed, 7 Mar 2012 21:32:29 +0100
Subject: [PATCH] Remove unused code in vbahelper
---
unusedcode.easy |3 ---
vbahelper/inc/vbahelper/vbahelper.hxx|7 ---
vbahelper/source/vbahelper/vbahelper.cxx | 17 -
3 files changed, 0 insertions(+), 27 deletions(-)
diff --git a/unusedcode.easy b/unusedcode.easy
index 255ef66..381d978 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -907,11 +907,8 @@ nullcanvas::SpriteCanvasHelper::opaqueUpdate(basegfx::B2DConnectedRangescanvas:
nullcanvas::SpriteCanvasHelper::scrollUpdate(basegfx::B2DRange const, basegfx::B2DRange const, basegfx::B2DConnectedRangescanvas::SpriteRedrawManager::SpriteInfo::ConnectedComponents const)
o3tltests::cow_wrapper_client2::queryUnmodified() const
o3tltests::cow_wrapper_client3::queryUnmodified() const
-ooo::vba::createVBAUnoAPIService(SfxObjectShell*, char const*)
ooo::vba::excel::getViewFrame(com::sun::star::uno::Referencecom::sun::star::frame::XModel const)
ooo::vba::excel::isInPrintPreview(SfxViewFrame*)
-ooo::vba::extractBoolFromAny(com::sun::star::uno::Any const, bool)
-ooo::vba::extractIntFromAny(com::sun::star::uno::Any const, int)
oox::AttributeConversion::decodeHyperHex(rtl::OUString const)
oox::AttributeConversion::decodeUnsignedHex(rtl::OUString const)
oox::ContainerHelper::insertByIndex(com::sun::star::uno::Referencecom::sun::star::container::XIndexContainer const, int, com::sun::star::uno::Any const)
diff --git a/vbahelper/inc/vbahelper/vbahelper.hxx b/vbahelper/inc/vbahelper/vbahelper.hxx
index 190243c..9a3da3c 100644
--- a/vbahelper/inc/vbahelper/vbahelper.hxx
+++ b/vbahelper/inc/vbahelper/vbahelper.hxx
@@ -75,7 +75,6 @@ namespace ooo
VBAHELPER_DLLPUBLIC css::uno::Reference XHelperInterface getVBADocument( const css::uno::Reference css::frame::XModel xModel );
VBAHELPER_DLLPUBLIC css::uno::Reference XHelperInterface getUnoDocModule( const String aModName, SfxObjectShell* pShell );
VBAHELPER_DLLPUBLIC SfxObjectShell* getSfxObjShell( const css::uno::Reference css::frame::XModel xModel ) throw ( css::uno::RuntimeException);
-VBAHELPER_DLLPUBLIC css::uno::Reference css::uno::XInterface createVBAUnoAPIService( SfxObjectShell* pShell, const sal_Char* _pAsciiName ) throw (css::uno::RuntimeException);
css::uno::Reference css::frame::XModel getCurrentDoc( const rtl::OUString sKey ) throw (css::uno::RuntimeException);
VBAHELPER_DLLPUBLIC css::uno::Reference css::frame::XModel getThisExcelDoc( const css::uno::Reference css::uno::XComponentContext xContext ) throw (css::uno::RuntimeException);
@@ -103,16 +102,10 @@ namespace ooo
/** Extracts a 32-bit integer value from the passed Any, which may contain an integer or floating-point value.
Throws, if the Any is empty or contains an incompatible type. */
VBAHELPER_DLLPUBLIC sal_Int32 extractIntFromAny( const css::uno::Any rAny ) throw (css::uno::RuntimeException);
-/** Extracts a 32-bit integer value from the passed Any, which may contain an integer or floating-point value.
-Returns nDefault, if rAny is empty. Throws, if the Any contains an incompatible type. */
-VBAHELPER_DLLPUBLIC sal_Int32 extractIntFromAny( const css::uno::Any rAny, sal_Int32 nDefault ) throw (css::uno::RuntimeException);
/** Extracts a boolean value from the passed Any, which may contain a Boolean or an integer or floating-point value.
Throws, if the Any is empty or contains an incompatible type. */
VBAHELPER_DLLPUBLIC bool extractBoolFromAny( const css::uno::Any rAny ) throw (css::uno::RuntimeException);
-/** Extracts a boolean value from the passed Any, which may contain a Boolean or an integer or floating-point value.
-Returns bDefault, if rAny is empty. Throws, if the Any contains an incompatible type. */
-VBAHELPER_DLLPUBLIC bool extractBoolFromAny( const css::uno::Any rAny, bool bDefault ) throw (css::uno::RuntimeException);
/** Extracts a string from the passed Any, which may contain a Boolean, a value, or a string.
Throws, if the Any is empty or contains an incompatible type. */
diff --git a/vbahelper/source/vbahelper/vbahelper.cxx b/vbahelper/source/vbahelper/vbahelper.cxx
index 70fe850..03525baf 100644
--- a/vbahelper/source/vbahelper/vbahelper.cxx
+++ b/vbahelper/source/vbahelper/vbahelper.cxx
@@ -97,13 +97,6 @@ namespace vba
namespace { const double factor = 2540.0 / 72.0; }
-css::uno::Reference css::uno::XInterface createVBAUnoAPIService( SfxObjectShell* pShell, const sal_Char* _pAsciiName ) throw (css::uno::RuntimeException)
-{
-OSL_PRECOND( pShell, createVBAUnoAPIService: no shell! );
-::rtl::OUString sVarName( ::rtl::OUString
[PATCH] Remove unused code(3)
This patch removes unused code as listed in unusedcode.easy
From 5ad94b05322b615da580027ed99e8a4e7ca68a51 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Wed, 7 Mar 2012 21:46:11 +0100
Subject: [PATCH] Remove unused code as listed in unusedcode.easy
---
sc/source/ui/vba/excelvbahelper.cxx | 22 --
sc/source/ui/vba/excelvbahelper.hxx |1 -
unusedcode.easy |2 --
3 files changed, 0 insertions(+), 25 deletions(-)
diff --git a/sc/source/ui/vba/excelvbahelper.cxx b/sc/source/ui/vba/excelvbahelper.cxx
index 7ee13b2..3d80796 100644
--- a/sc/source/ui/vba/excelvbahelper.cxx
+++ b/sc/source/ui/vba/excelvbahelper.cxx
@@ -139,19 +139,6 @@ void implSetZoom( const uno::Reference frame::XModel xModel, sal_Int16 nZoom
pViewSh-GetViewData()-SetZoom( aFract, aFract, nTabs );
pViewSh-RefreshZoom();
}
-bool isInPrintPreview( SfxViewFrame* pView )
-{
-sal_uInt16 nViewNo = SID_VIEWSHELL1 - SID_VIEWSHELL0;
-if ( pView-GetObjectShell()-GetFactory().GetViewFactoryCount()
-nViewNo !pView-GetObjectShell()-IsInPlaceActive() )
-{
-SfxViewFactory rViewFactory =
-pView-GetObjectShell()-GetFactory().GetViewFactory(nViewNo);
-if ( pView-GetCurViewId() == rViewFactory.GetOrdinal() )
-return true;
-}
-return false;
-}
const ::rtl::OUString REPLACE_CELLS_WARNING( RTL_CONSTASCII_USTRINGPARAM( ReplaceCellsWarning));
@@ -321,15 +308,6 @@ getCurrentBestViewShell( const uno::Reference uno::XComponentContext xConte
return getBestViewShell( xModel );
}
-SfxViewFrame*
-getViewFrame( const uno::Reference frame::XModel xModel )
-{
-ScTabViewShell* pViewShell = getBestViewShell( xModel );
-if ( pViewShell )
-return pViewShell-GetViewFrame();
-return NULL;
-}
-
sal_Bool IsR1C1ReferFormat( ScDocument* pDoc, const rtl::OUString sRangeStr )
{
ScRangeList aCellRanges;
diff --git a/sc/source/ui/vba/excelvbahelper.hxx b/sc/source/ui/vba/excelvbahelper.hxx
index 85031ad..53f44c9 100644
--- a/sc/source/ui/vba/excelvbahelper.hxx
+++ b/sc/source/ui/vba/excelvbahelper.hxx
@@ -59,7 +59,6 @@ bool implnCopyRange( const css::uno::Reference css::frame::XModel xModel, con
ScTabViewShell* getBestViewShell( const css::uno::Reference css::frame::XModel xModel ) ;
ScDocShell* getDocShell( const css::uno::Reference css::frame::XModel xModel ) ;
ScTabViewShell* getCurrentBestViewShell( const css::uno::Reference css::uno::XComponentContext xContext );
-SfxViewFrame* getViewFrame( const css::uno::Reference css::frame::XModel xModel );
sal_Bool IsR1C1ReferFormat( ScDocument* pDoc, const ::rtl::OUString sRangeStr );
formula::FormulaGrammar::Grammar GetFormulaGrammar( ScDocument* pDoc, const ScAddress sAddress, const css::uno::Any aFormula );
diff --git a/unusedcode.easy b/unusedcode.easy
index 381d978..58a4e92 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -907,8 +907,6 @@ nullcanvas::SpriteCanvasHelper::opaqueUpdate(basegfx::B2DConnectedRangescanvas:
nullcanvas::SpriteCanvasHelper::scrollUpdate(basegfx::B2DRange const, basegfx::B2DRange const, basegfx::B2DConnectedRangescanvas::SpriteRedrawManager::SpriteInfo::ConnectedComponents const)
o3tltests::cow_wrapper_client2::queryUnmodified() const
o3tltests::cow_wrapper_client3::queryUnmodified() const
-ooo::vba::excel::getViewFrame(com::sun::star::uno::Referencecom::sun::star::frame::XModel const)
-ooo::vba::excel::isInPrintPreview(SfxViewFrame*)
oox::AttributeConversion::decodeHyperHex(rtl::OUString const)
oox::AttributeConversion::decodeUnsignedHex(rtl::OUString const)
oox::ContainerHelper::insertByIndex(com::sun::star::uno::Referencecom::sun::star::container::XIndexContainer const, int, com::sun::star::uno::Any const)
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code in vbahelper
Pushed. On 03/08/2012 01:27 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.eas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code
Pushed. On 03/08/2012 01:05 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code(3)
Pushed. On 03/08/2012 02:19 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code(2)
Pushed. On 03/08/2012 02:07 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (23)
Hi, This patch removes 2 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email: el...@layerjet.com - Remove-unused-code-23.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (22)
Hi, This patch removes 12 unused methods. Best Regards, Elton Remove-unused-code-22.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] remove unused code
Another unused code removed.
From 226fccc7f2fd022ed9d329ac9c6bb373fbeff265 Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Sat, 3 Mar 2012 02:16:31 +0100
Subject: [PATCH] remove unused code
---
oox/inc/oox/helper/binaryinputstream.hxx |4
oox/inc/oox/helper/modelobjecthelper.hxx |3 ---
oox/inc/oox/helper/propertymap.hxx |1 -
oox/inc/oox/helper/propertyset.hxx | 14 +++---
oox/source/drawingml/customshapeproperties.cxx |1 -
oox/source/helper/binaryinputstream.cxx|8
oox/source/helper/modelobjecthelper.cxx| 13 -
oox/source/helper/propertymap.cxx |5 -
oox/source/helper/propertyset.cxx | 24
sd/source/filter/eppt/epptooxml.hxx|2 --
sd/source/filter/eppt/pptx-epptooxml.cxx | 16
unusedcode.easy|6 --
12 files changed, 3 insertions(+), 94 deletions(-)
diff --git a/oox/inc/oox/helper/binaryinputstream.hxx b/oox/inc/oox/helper/binaryinputstream.hxx
index 5add5f4..6e952a2 100644
--- a/oox/inc/oox/helper/binaryinputstream.hxx
+++ b/oox/inc/oox/helper/binaryinputstream.hxx
@@ -164,10 +164,6 @@ public:
template typename Type
voidskipArray( sal_Int32 nElemCount );
-/** Reads a NUL-terminated byte character array and returns the string.
- */
-::rtl::OString readNulCharArray();
-
/** Reads a NUL-terminated Unicode character array and returns the string.
*/
::rtl::OUString readNulUnicodeArray();
diff --git a/oox/inc/oox/helper/modelobjecthelper.hxx b/oox/inc/oox/helper/modelobjecthelper.hxx
index 86459ec..10131de 100644
--- a/oox/inc/oox/helper/modelobjecthelper.hxx
+++ b/oox/inc/oox/helper/modelobjecthelper.hxx
@@ -56,9 +56,6 @@ public:
/** Returns true, if the object with the passed name exists in the container. */
boolhasObject( const ::rtl::OUString rObjName ) const;
-/** Returns the object with the passed name from the container. */
-::com::sun::star::uno::Any getObject( const ::rtl::OUString rObjName ) const;
-
/** Inserts the passed object into the container, returns its final name. */
::rtl::OUString insertObject(
const ::rtl::OUString rObjName,
diff --git a/oox/inc/oox/helper/propertymap.hxx b/oox/inc/oox/helper/propertymap.hxx
index 2696d49..dabd2e4 100644
--- a/oox/inc/oox/helper/propertymap.hxx
+++ b/oox/inc/oox/helper/propertymap.hxx
@@ -102,7 +102,6 @@ public:
#if OSL_DEBUG_LEVEL 0
#ifdef DBG_UTIL
static void dump( ::com::sun::star::uno::Reference ::com::sun::star::beans::XPropertySet rXPropSet);
- void dump();
#endif
static void dumpCode( ::com::sun::star::uno::Reference ::com::sun::star::beans::XPropertySet rXPropSet);
void dumpCode();
diff --git a/oox/inc/oox/helper/propertyset.hxx b/oox/inc/oox/helper/propertyset.hxx
index fd0c1a7..14ca79b 100644
--- a/oox/inc/oox/helper/propertyset.hxx
+++ b/oox/inc/oox/helper/propertyset.hxx
@@ -50,9 +50,9 @@ class PropertyMap;
com.sun.star.beans.XPropertySet interface then). The reference to the
property set will be kept as long as the instance of this class is alive.
-The functions getProperties() and setProperties() try to handle all passed
-values at once, using the com.sun.star.beans.XMultiPropertySet interface.
-If the implementation does not support the XMultiPropertySet interface, all
+The functions setProperties() tries to handle all passed values at once,
+using the com.sun.star.beans.XMultiPropertySet interface. If the
+implementation does not support the XMultiPropertySet interface, all
properties are handled separately in a loop.
*/
class PropertySet
@@ -103,14 +103,6 @@ public:
@return true = property contains true; false = property contains false or error occurred. */
inline bool getBoolProperty( sal_Int32 nPropId ) const
{ bool bValue = false; return getProperty( bValue, nPropId ) bValue; }
-
-/** Gets the specified properties from the property set. Tries to use the XMultiPropertySet interface.
-@param orValues (out-parameter) The related property values.
-@param rPropNames The property names. MUST be ordered alphabetically. */
-voidgetProperties(
-::com::sun::star::uno::Sequence ::com::sun::star::uno::Any orValues,
-const ::com::sun::star::uno::Sequence ::rtl::OUString rPropNames ) const;
-
// Set properties -
/** Puts the passed any into the property set. */
diff --git a/oox/source/drawingml/customshapeproperties.cxx b/oox/source/drawingml/customshapeproperties.cxx
index ab99e82..29844b8 100644
--- a/oox/source/drawingml/customshapeproperties.cxx
+++ b
[PATCH] Remove unused code (21)
Hi, This patch removes 5 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email : el...@layerjet.com - Remove-unused-code-21.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in BiffObjLineModel
On Mon, 2012-02-27 at 20:10 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in BiffInputStream
On Mon, 2012-02-27 at 21:10 +0100, Santiago Martinez wrote: Hi, i'm not sure if this patch is correct so please review. I deleted BiffInputStream::sizeBase(), skipByteString(bool) and skipUniString() methods listed in unusedcode.easy. But also deleted another two methods (skipUniStringBody and skipUniStringChars ) because these two methods are used only by previously deleted methods. Looks fine, pushed now. Thanks for these. The next respin of unusedcode.easy would have picked them up, but looks fine. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code in BiffObjLineModel
This patch removes unused code as listed in unusedcode.easy
From 038875906820927ecb026f16db40ab3621e8a58d Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Mon, 27 Feb 2012 20:07:47 +0100
Subject: [PATCH] Remove unused code in BiffObjLineModel.
---
oox/inc/oox/xls/drawingmanager.hxx |3 ---
oox/source/xls/drawingmanager.cxx |5 -
unusedcode.easy|1 -
3 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/oox/inc/oox/xls/drawingmanager.hxx b/oox/inc/oox/xls/drawingmanager.hxx
index 4ec80d7..758c60e 100644
--- a/oox/inc/oox/xls/drawingmanager.hxx
+++ b/oox/inc/oox/xls/drawingmanager.hxx
@@ -59,9 +59,6 @@ struct BiffObjLineModel
boolmbAuto; /// True = automatic line format.
explicitBiffObjLineModel();
-
-/** Returns true, if the line formatting is visible (automatic or explicit). */
-boolisVisible() const;
};
//
diff --git a/oox/source/xls/drawingmanager.cxx b/oox/source/xls/drawingmanager.cxx
index d8cf3b1..afadd1f 100644
--- a/oox/source/xls/drawingmanager.cxx
+++ b/oox/source/xls/drawingmanager.cxx
@@ -191,11 +191,6 @@ BiffObjLineModel::BiffObjLineModel() :
{
}
-bool BiffObjLineModel::isVisible() const
-{
-return mbAuto || (mnStyle != BIFF_OBJ_LINE_NONE);
-}
-
BiffInputStream operator( BiffInputStream rStrm, BiffObjLineModel rModel )
{
sal_uInt8 nFlags;
diff --git a/unusedcode.easy b/unusedcode.easy
index b5090c1..f6637a4 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -1070,7 +1070,6 @@ oox::xls::BiffHelper::calcRkFromDouble(int, double)
oox::xls::BiffInputStream::sizeBase() const
oox::xls::BiffInputStream::skipByteString(bool)
oox::xls::BiffInputStream::skipUniString()
-oox::xls::BiffObjLineModel::isVisible() const
oox::xls::BiffOutputStream::BiffOutputStream(oox::BinaryOutputStream, unsigned short)
oox::xls::BiffOutputStream::endRecord()
oox::xls::BiffOutputStream::fill(unsigned char, int, unsigned long)
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (19)
Hi, This patch removes 14 unused methods. Best Regards, Elton Remove-unused-code-19.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code (20)
Hi, This patch removes 20 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email: el...@layerjet.com - Remove-unused-code-20.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code in ScUserList
This patch removes unused code as listed in unusedcode.easy
From 6c990c918ee985ee22ab432aa46f51823ed0ef24 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Wed, 22 Feb 2012 21:38:16 +0100
Subject: [PATCH] Remove unused code in ScUserList
---
sc/inc/userlist.hxx |2 --
sc/source/core/tool/userlist.cxx | 10 --
unusedcode.easy |2 --
3 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/sc/inc/userlist.hxx b/sc/inc/userlist.hxx
index 5fa00eb..541c66e 100644
--- a/sc/inc/userlist.hxx
+++ b/sc/inc/userlist.hxx
@@ -92,9 +92,7 @@ public:
booloperator!=( const ScUserList r ) const;
iterator begin();
-iterator end();
const_iterator begin() const;
-const_iterator end() const;
void clear();
size_t size() const;
void push_back(ScUserListData* p);
diff --git a/sc/source/core/tool/userlist.cxx b/sc/source/core/tool/userlist.cxx
index 4a97af0..28aecfc 100644
--- a/sc/source/core/tool/userlist.cxx
+++ b/sc/source/core/tool/userlist.cxx
@@ -345,21 +345,11 @@ ScUserList::iterator ScUserList::begin()
return maData.begin();
}
-ScUserList::iterator ScUserList::end()
-{
-return maData.end();
-}
-
ScUserList::const_iterator ScUserList::begin() const
{
return maData.begin();
}
-ScUserList::const_iterator ScUserList::end() const
-{
-return maData.end();
-}
-
void ScUserList::clear()
{
maData.clear();
diff --git a/unusedcode.easy b/unusedcode.easy
index 758f612..3869a88 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -108,8 +108,6 @@ ScRangeData::ScRangeData(unsigned short)
ScSimpleRangeList::Range::contains(ScSimpleRangeList::Range const) const
ScStringCell::ScStringCell()
ScTypedStrData::GetValue() const
-ScUserList::end()
-ScUserList::end() const
ScValidationEntries_Impl::Insert(ScValidationData* const, unsigned short)
ScValidationEntries_Impl::Insert(ScValidationData* const*, unsigned short)
ScValidationEntries_Impl::Insert(ScValidationEntries_Impl const*, unsigned short, unsigned short)
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
