Re: [PATCH] fdo#39468 translate German comments in vcl
Hi Christian, Christian Heller píše v Ne 03. 03. 2013 v 18:54 -0500: Shall I change this once this is in ? Muthu has pushed the changes, so yes, please do the changes as necessary :-) [I think we talked on the IRC, but just for the record - the next time, you can directly update your change by pushing again to gerrit with an unchanged Change-Id:, gerrit should notice that it is still the same patch.] All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#39468 translate German comments in vcl
Hi Christian, The wiki has some instructions on how to do this: https://wiki.documentfoundation.org/Development/gerrit#Updating_patch Cheers, Philipp On 4 March 2013 14:05, Jan Holesovsky ke...@suse.cz wrote: Hi Christian, Christian Heller píše v Ne 03. 03. 2013 v 18:54 -0500: Shall I change this once this is in ? Muthu has pushed the changes, so yes, please do the changes as necessary :-) [I think we talked on the IRC, but just for the record - the next time, you can directly update your change by pushing again to gerrit with an unchanged Change-Id:, gerrit should notice that it is still the same patch.] All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#39468 translate German comments in /vcl
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2552
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/2552/1
fdo#39468 translate German comments in /vcl
Change-Id: Icead8400db3bab570b5ef55d5079ea50e2e3b7b9
---
M vcl/source/control/combobox.cxx
M vcl/source/control/fixed.cxx
M vcl/source/control/ilstbox.cxx
3 files changed, 47 insertions(+), 48 deletions(-)
diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx
index fd09ccb..13e3f2e 100644
--- a/vcl/source/control/combobox.cxx
+++ b/vcl/source/control/combobox.cxx
@@ -381,7 +381,7 @@
{
aText = mpSubEdit-GetText();
-// remove all entries to which there is an selected entry
+// remove all entries to which there is an entry, but which is not
selected
xub_StrLen nIndex = 0;
while ( nIndex != STRING_NOTFOUND )
{
diff --git a/vcl/source/control/fixed.cxx b/vcl/source/control/fixed.cxx
index b6a4d10..35a47f3 100644
--- a/vcl/source/control/fixed.cxx
+++ b/vcl/source/control/fixed.cxx
@@ -386,7 +386,7 @@
if ( pControl-GetStyle() WB_EXTRAOFFSET )
aSize.Width() += 2;
-// GetTextRect cannot take and empty string
+// GetTextRect cannot take an empty string
if ( aSize.Width() 0 )
aSize.Width() = 0;
if ( aSize.Height() = 0 )
diff --git a/vcl/source/control/ilstbox.cxx b/vcl/source/control/ilstbox.cxx
index 475d074..411f37f 100644
--- a/vcl/source/control/ilstbox.cxx
+++ b/vcl/source/control/ilstbox.cxx
@@ -199,7 +199,7 @@
// defined values are {-1, 0, 1} which is compatible with
StringCompare
StringCompare eComp = (StringCompare)rSorter.compare(rStr,
pTemp-maStr);
-// Schnelles Einfuegen bei sortierten Daten
+// fast insert for sorted data
if ( eComp != COMPARE_LESS )
{
insPos = maEntries.size();
@@ -218,7 +218,7 @@
}
else
{
-// Binaeres Suchen
+// binary search
nHigh--;
do
{
@@ -298,7 +298,7 @@
sal_uInt16 nPos = LISTBOX_ENTRY_NOTFOUND;
sal_uInt16 nEntryCount = GetEntryCount();
if ( !bForward )
-nStart++; // wird sofort dekrementiert
+nStart++; // decrement right away
const vcl::I18nHelper rI18nHelper =
mpWindow-GetSettings().GetLocaleI18nHelper();
for ( sal_uInt16 n = nStart; bForward ? ( n nEntryCount ) : n; )
@@ -738,8 +738,8 @@
if ( !aMetrics.bText !aMetrics.bImage !IsUserDrawEnabled() )
{
-// entries which have no (aka an empty) text, and no image, and are
not user-drawn, should be
-// shown nonetheless
+// entries which have no (aka an empty) text, and no image,
+// and are not user-drawn, should beshown nonetheless
aMetrics.nEntryHeight = mnTextHeight + mnBorder;
}
@@ -912,7 +912,7 @@
void ImplListBoxWindow::MouseButtonDown( const MouseEvent rMEvt )
{
-mbMouseMoveSelect = sal_False; // Nur bis zum ersten MouseButtonDown
+mbMouseMoveSelect = sal_False; // only till the first MouseButtonDown
maQuickSelectionEngine.Reset();
if ( !IsReadOnly() )
@@ -1005,8 +1005,8 @@
}
}
-// Falls der DD-Button gedrueckt wurde und jemand mit gedrueckter
-// Maustaste in die ListBox faehrt...
+// if the DD button was pressed and someone moved into the ListBox
+// with the mouse button pressed...
if ( rMEvt.IsLeft() !rMEvt.IsSynthetic() )
{
if ( !mbMulti GetEntryList()-GetSelectEntryCount() )
@@ -1045,7 +1045,7 @@
{
if( !mbMulti )
{
-// Selektierten Eintrag deselektieren
+// deselect the selected entry
sal_uInt16 nDeselect = GetEntryList()-GetSelectEntryPos( 0 );
if( nDeselect != LISTBOX_ENTRY_NOTFOUND )
{
@@ -1094,7 +1094,7 @@
if( IsEnabled() mpEntryList-IsEntrySelectable( nSelect ) )
{
-// Hier (Single-ListBox) kann nur ein Eintrag deselektiert werden
+// here (Single-ListBox) only one entry can be deselected
if( !mbMulti )
{
sal_uInt16 nDeselect = mpEntryList-GetSelectEntryPos( 0 );
@@ -1106,7 +1106,7 @@
bSelectionChanged = sal_True;
}
}
-// MultiListBox ohne Modifier
+// MultiListBox without Modifier
else if( mbSimpleMode !bCtrl !bShift )
{
sal_uInt16 nEntryCount = mpEntryList-GetEntryCount();
@@ -1123,10 +1123,10 @@
mpEntryList-SetLastSelected( nSelect );
mpEntryList-SetSelectionAnchor( nSelect );
}
-// MultiListBox nur mit CTRL/SHIFT
[PATCH] fdo#39468 translate German comments in vcl
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2534 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/2534/1 fdo#39468 translate German comments in vcl modified: vcl/inc/vcl/fltcall.hxx modified: vcl/inc/vcl/textdata.hxx modified: vcl/inc/vcl/texteng.hxx modified: vcl/source/control/combobox.cxx modified: vcl/source/control/fixed.cxx Change-Id: I8af3fe962ba77d7047eac8d7570c5bc572585363 --- M vcl/inc/vcl/fltcall.hxx M vcl/inc/vcl/textdata.hxx M vcl/inc/vcl/texteng.hxx M vcl/source/control/combobox.cxx M vcl/source/control/fixed.cxx 5 files changed, 31 insertions(+), 30 deletions(-) diff --git a/vcl/inc/vcl/fltcall.hxx b/vcl/inc/vcl/fltcall.hxx index 91e4d28..03a6340 100644 --- a/vcl/inc/vcl/fltcall.hxx +++ b/vcl/inc/vcl/fltcall.hxx @@ -49,19 +49,19 @@ typedef sal_Bool (*PFilterCall)(SvStream rStream, Graphic rGraphic, FilterConfigItem* pConfigItem, sal_Bool bPrefDialog); -// Von diesem Typ sind sowohl Export-Filter-Funktionen als auch Import-Filter-Funktionen. -// rFileName ist der komplette Pfadname der zu importierenden bzw. zu exportierenden Datei. -// pCallBack darf auch NULL sein. pCallerData wird der Callback-Funktion uebergeben. -// pOptionsConfig darf NULL sein. Anderenfalls ist die Gruppe des Config schon gesetzt -// und darf von dem Filter nicht geaendert werden! -// Wenn bPrefDialog==sal_True gilt, wird ggf. ein Preferences-Dialog durchgefuehrt. +// Of this type are both export-filter and import-filter functions +// rFileName is the complete path to the file to be imported or exported +// pCallBack can be NULL. pCallerData is handed to the callback function +// pOptionsConfig can be NULL; if not, the group of the config is already set +// and may not be changed by this filter! +// If bPrefDialog==sal_True, a Preferences-Dialog might be called typedef sal_Bool ( *PFilterDlgCall )( FltCallDialogParameter ); -// Von diesem Typ sind sowohl Export-Filter-Funktionen als auch Import-Filter-Funktionen. -// Uebergeben wird ein Pointer auf ein Parent-Fenster und auf die Options-Config. -// pOptions und pWindow duerfen NULL sein, in diesem Fall wird sal_False zurueckgeliefert. -// Anderenfalls ist die Gruppe der Config schon gesetzt -// und darf von dem Filter nicht geaendert werden! +// Of this type are both export-filter and import-filter functions +// hands a pointer to the parent window and to the options config +// pOptions and pWindow can be NULL; in this case sal_False is returned, +// otherwise the group of the config is already set +// and may not be changed by this filter! #endif diff --git a/vcl/inc/vcl/textdata.hxx b/vcl/inc/vcl/textdata.hxx index 4ee0e2f..476ba00 100644 --- a/vcl/inc/vcl/textdata.hxx +++ b/vcl/inc/vcl/textdata.hxx @@ -25,7 +25,7 @@ #include svl/smplhint.hxx #include tools/string.hxx -// Fuer Notify, wenn alle Absaetze geloescht wurden... +// for Notify, if all paragraphs were deleted #define TEXT_PARA_ALL 0x class TextPaM diff --git a/vcl/inc/vcl/texteng.hxx b/vcl/inc/vcl/texteng.hxx index e5f4582..2fc0314 100644 --- a/vcl/inc/vcl/texteng.hxx +++ b/vcl/inc/vcl/texteng.hxx @@ -122,7 +122,7 @@ TxtAlignmeAlign; -sal_BoolmbIsFormatting : 1;// Semaphore wegen der Hook's +sal_BoolmbIsFormatting : 1;// semaphore for the Hook's sal_BoolmbFormatted : 1; sal_BoolmbUpdate: 1; sal_BoolmbModified : 1; @@ -161,7 +161,7 @@ SAL_DLLPRIVATE ::com::sun::star::uno::Reference ::com::sun::star::i18n::XExtendedInputSequenceChecker GetInputSequenceChecker() const; SAL_DLLPRIVATE sal_Bool IsInputSequenceCheckingRequired( sal_Unicode c, const TextSelection rCurSel ) const; -// Broadcasten bzw. Selektionen anpassen: +// broadcast or adjust selections voidImpParagraphInserted( sal_uLong nPara ); voidImpParagraphRemoved( sal_uLong nPara ); voidImpCharsRemoved( sal_uLong nPara, sal_uInt16 nPos, sal_uInt16 nChars ); @@ -210,12 +210,12 @@ sal_uLong CalcTextWidth( sal_uLong nPara, sal_uInt16 nPortionStart, sal_uInt16 nPortionLen, const Font* pFont = 0 ); Range GetInvalidYOffsets( sal_uLong nPortion ); -// Fuer Undo/Redo +// for Undo/Redo voidInsertContent( TextNode* pNode, sal_uLong nPara ); TextPaM SplitContent( sal_uLong nNode, sal_uInt16 nSepPos ); TextPaM ConnectContents( sal_uLong nLeftNode ); -// Ans API uebergebene PaM's und Selektionen auf einen gueltigen Bereich einstellen +// adjust PaM's and selections that were transfered to
Re: [PATCH] fdo#39468 translate German comments in vcl
-// Alle Eintraege entfernen, zu denen es einen Entry gibt, der aber nicht selektiert ist. +// remove all entries to which there is an selected entry sorry, this should have been +// remove all entries to which there is an entry, but which is not selected On Sun, Mar 3, 2013 at 6:08 PM, Christian M. Heller (via Code Review) ger...@gerrit.libreoffice.org wrote: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2534 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/corerefs/changes/34/2534/1 fdo#39468 translate German comments in vcl modified: vcl/inc/vcl/fltcall.hxx modified: vcl/inc/vcl/textdata.hxx modified: vcl/inc/vcl/texteng.hxx modified: vcl/source/control/combobox.cxx modified: vcl/source/control/fixed.cxx Change-Id: I8af3fe962ba77d7047eac8d7570c5bc572585363 --- M vcl/inc/vcl/fltcall.hxx M vcl/inc/vcl/textdata.hxx M vcl/inc/vcl/texteng.hxx M vcl/source/control/combobox.cxx M vcl/source/control/fixed.cxx 5 files changed, 31 insertions(+), 30 deletions(-) diff --git a/vcl/inc/vcl/fltcall.hxx b/vcl/inc/vcl/fltcall.hxx index 91e4d28..03a6340 100644 --- a/vcl/inc/vcl/fltcall.hxx +++ b/vcl/inc/vcl/fltcall.hxx @@ -49,19 +49,19 @@ typedef sal_Bool (*PFilterCall)(SvStream rStream, Graphic rGraphic, FilterConfigItem* pConfigItem, sal_Bool bPrefDialog); -// Von diesem Typ sind sowohl Export-Filter-Funktionen als auch Import-Filter-Funktionen. -// rFileName ist der komplette Pfadname der zu importierenden bzw. zu exportierenden Datei. -// pCallBack darf auch NULL sein. pCallerData wird der Callback-Funktion uebergeben. -// pOptionsConfig darf NULL sein. Anderenfalls ist die Gruppe des Config schon gesetzt -// und darf von dem Filter nicht geaendert werden! -// Wenn bPrefDialog==sal_True gilt, wird ggf. ein Preferences-Dialog durchgefuehrt. +// Of this type are both export-filter and import-filter functions +// rFileName is the complete path to the file to be imported or exported +// pCallBack can be NULL. pCallerData is handed to the callback function +// pOptionsConfig can be NULL; if not, the group of the config is already set +// and may not be changed by this filter! +// If bPrefDialog==sal_True, a Preferences-Dialog might be called typedef sal_Bool ( *PFilterDlgCall )( FltCallDialogParameter ); -// Von diesem Typ sind sowohl Export-Filter-Funktionen als auch Import-Filter-Funktionen. -// Uebergeben wird ein Pointer auf ein Parent-Fenster und auf die Options-Config. -// pOptions und pWindow duerfen NULL sein, in diesem Fall wird sal_False zurueckgeliefert. -// Anderenfalls ist die Gruppe der Config schon gesetzt -// und darf von dem Filter nicht geaendert werden! +// Of this type are both export-filter and import-filter functions +// hands a pointer to the parent window and to the options config +// pOptions and pWindow can be NULL; in this case sal_False is returned, +// otherwise the group of the config is already set +// and may not be changed by this filter! #endif diff --git a/vcl/inc/vcl/textdata.hxx b/vcl/inc/vcl/textdata.hxx index 4ee0e2f..476ba00 100644 --- a/vcl/inc/vcl/textdata.hxx +++ b/vcl/inc/vcl/textdata.hxx @@ -25,7 +25,7 @@ #include svl/smplhint.hxx #include tools/string.hxx -// Fuer Notify, wenn alle Absaetze geloescht wurden... +// for Notify, if all paragraphs were deleted #define TEXT_PARA_ALL 0x class TextPaM diff --git a/vcl/inc/vcl/texteng.hxx b/vcl/inc/vcl/texteng.hxx index e5f4582..2fc0314 100644 --- a/vcl/inc/vcl/texteng.hxx +++ b/vcl/inc/vcl/texteng.hxx @@ -122,7 +122,7 @@ TxtAlignmeAlign; -sal_BoolmbIsFormatting : 1;// Semaphore wegen der Hook's +sal_BoolmbIsFormatting : 1;// semaphore for the Hook's sal_BoolmbFormatted : 1; sal_BoolmbUpdate: 1; sal_BoolmbModified : 1; @@ -161,7 +161,7 @@ SAL_DLLPRIVATE ::com::sun::star::uno::Reference ::com::sun::star::i18n::XExtendedInputSequenceChecker GetInputSequenceChecker() const; SAL_DLLPRIVATE sal_Bool IsInputSequenceCheckingRequired( sal_Unicode c, const TextSelection rCurSel ) const; -// Broadcasten bzw. Selektionen anpassen: +// broadcast or adjust selections voidImpParagraphInserted( sal_uLong nPara ); voidImpParagraphRemoved( sal_uLong nPara ); voidImpCharsRemoved( sal_uLong nPara, sal_uInt16 nPos, sal_uInt16 nChars ); @@ -210,12 +210,12 @@ sal_uLong CalcTextWidth( sal_uLong nPara, sal_uInt16 nPortionStart, sal_uInt16 nPortionLen, const Font* pFont = 0 );
Re: [PATCH] fdo#39468 translate German comments in vcl
-// GetTextRect verkraftet keinen leeren String: +// GetTextRect cannot take and empty string and another one: +// GetTextRect cannot take an empty string Sorry for the noise! Shall I change this once this is in ? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
