Re: [PUSHED][PATCH] Remove unused code (24)
On Sun, 2012-04-29 at 16:16 +0800, Elton Chung wrote: Hi there, This patch removes 1 unused method. Looks good to me, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] PATCH: Remove unused code from editing
Thanks Caolan, I have not used a development environment and I have not noticed the lapse. I'm usually spoiled by working with Eclipse and automatically notify me of these errors. Did I correct it and send it back to? Yeah right, I will confirm the terms of license LGPLv3 + / MPL + combination. Sorry for my English. De: Caolán McNamara caol...@redhat.com Para: Vicente Rafael Estévez Vacas rafaeste...@yahoo.es CC: libreoffice@lists.freedesktop.org libreoffice@lists.freedesktop.org Enviado: Martes 24 de abril de 2012 0:22 Asunto: Re: [PUSHED] PATCH: Remove unused code from editing On Mon, 2012-04-23 at 17:13 +0100, Vicente Rafael Estévez Vacas wrote: Asunto: PATCH: Remove unused code from editing Basically good. Though you need to build after your make your changes to pick up that there's a small mixup between the unused sdr::contact::ViewObjectContactOfUnoControl::isControlVisible and the used sdr::contact::ViewObjectContactOfUnoControl_Impl::impl_isControlVisible_nofail fixed up with http://cgit.freedesktop.org/libreoffice/core/commit/?id=9be39efcc55f9c4a8f7c02bdded299c0ef7e54fd Can you confirm that your code is submitted under our preferred LGPLv3+/MPL+ combination ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in dpitemdata
On Mon, 2012-04-23 at 19:27 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good to me, pushed. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code
On Sun, 2012-04-22 at 20:48 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed. Thanks for this. It bothers me a little that there was a addListener and a removeListener where the addListener is used while removeListener is unused. It suggests that there might be a mistake in the original code where it fails to call removeListener to remove a listener added with addListener. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sc)
On Mon, 2012-04-23 at 19:39 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] PATCH: Remove unused code from editing
On Mon, 2012-04-23 at 17:13 +0100, Vicente Rafael Estévez Vacas wrote: Asunto: PATCH: Remove unused code from editing Basically good. Though you need to build after your make your changes to pick up that there's a small mixup between the unused sdr::contact::ViewObjectContactOfUnoControl::isControlVisible and the used sdr::contact::ViewObjectContactOfUnoControl_Impl::impl_isControlVisible_nofail fixed up with http://cgit.freedesktop.org/libreoffice/core/commit/?id=9be39efcc55f9c4a8f7c02bdded299c0ef7e54fd Can you confirm that your code is submitted under our preferred LGPLv3+/MPL+ combination ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code (vlc)
Thank you! On 04/23/2012 02:06 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] PATCH: Remove unused code
Pushed. Thank you! On 04/23/2012 12:44 AM, Ferran Vidal i Marginet wrote: Hello, These is the patch that I've created. Licence: made available under the MPL/LGPLv3+ Ferran Vidal ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] PATCH: Remove unused code from Spreadsheet-application-code
On Sat, 2012-04-21 at 17:20 +0100, Ferran Vidal i Marginet wrote: Hello, These is the patch that I've created. Looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sd)
On Sat, 2012-04-14 at 20:14 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (connectivity)
On Sat, 2012-04-14 at 19:34 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy pushed, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sc)
On Mon, 2012-04-16 at 20:10 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed. Thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (oox)
On Sun, 2012-04-08 at 21:56 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Yup, pushed now. Well, actually Julien removed the same code and got in first. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code (svx)
Pushed. Thank you! On 04/05/2012 12:10 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in sqlnode
On Wed, 2012-03-28 at 21:31 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Look good, pushed now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (connectivity)
On Wed, 2012-03-28 at 21:51 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code (oox)
On Thu, 2012-03-29 at 15:23 +0200, Petr Vorel wrote: Hi there, removed unused methods pushed, thanks for these C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code (oox, sc)
On Wed, 2012-03-28 at 16:23 +0200, Petr Vorel wrote: Hi there, yet another remove unused code patch. Pushed now, thanks for this. FWIW, if a class has only one constructor and that constructor is unused then it indicates that the whole class (except perhaps for any static methods it might have) should be possible to be removed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code (oox, sc)
FWIW, if a class has only one constructor and that constructor is unused then it indicates that the whole class (except perhaps for any static methods it might have) should be possible to be removed. Sorry, I'll think more next time. Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code (oox, sc)
On Tue, 2012-03-27 at 16:27 +0200, Petr Vorel wrote: Hi there, another bits of unused code removed. looks good, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (l10ntools)
On Tue, 2012-03-27 at 21:20 +0200, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (scaddins)
On Fri, 2012-03-23 at 21:42 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks for that. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (vlc)
On Fri, 2012-03-23 at 22:07 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy looks good, pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (xmloff)
On Sat, 2012-03-24 at 01:03 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy great, pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code (oox)
On Sun, 2012-03-25 at 20:43 +0200, Petr Vorel wrote: Hi there, removed some code from oox. Pushed, looks good. I suspect that this will have a bit of a cascade effect and a pile more stuff will become available for removal on the next run. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code
On Fri, 2012-03-16 at 20:20 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good to me, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code (oox, sc)
On Sun, 2012-03-18 at 14:40 +0100, Petr Vorel wrote: Hi there, some unused code removed (oox, sc). Looks good to me, pushed now, thanks for these. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code
On Sat, 2012-03-17 at 15:34 +0100, Chr. Rossmanith wrote: Hi, I had a look at unusedcode.easy (sdext/presenter) and removed a little bit more than mentioned there: as there are no end callbacks added (AddEndCallback() was unused), there is no need to run them - RunEndCallbacks() could be removed as well. Same logic for start callbacks. Finally mpStartCallbacks and mpEndCallbacks could leave, too. Yup, I agree, I pushed this now. In PresenterAnimator AddAnimation() was unused and it seems that the whole class might be removed?!? Yeah, in unused.easy I see that the PresenterAnimator::PresenterAnimator ctor is never called, and its the only constructor, so one is never instantiated, so you can remove the whole thing without loss of functionality. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sdext)
On Sat, 2012-03-17 at 21:03 +0100, Chr. Rossmanith wrote: Hi, some more code removal. Looks good, pushed this now. Probably the private variable maTransform can be removed as well: it is initialized with the identity transform and never changed afterwards. Does that suggest that the actual call to mxSprite-transform(maTransform) is actually a no-op ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sdext)
Hi, Probably the private variable maTransform can be removed as well: it is initialized with the identity transform and never changed afterwards. Does that suggest that the actual call to mxSprite-transform(maTransform) is actually a no-op ? At least it doesn't change the position of mxSprite. Only the cpu is a little less idle :-) Then I'll continue to remove maTransform? Or should it be kept for future use? Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code
On Tue, 2012-03-20 at 13:54 +, Caolán McNamara wrote: Yeah, in unused.easy I see that the PresenterAnimator::PresenterAnimator ctor is never called, and its the only constructor, so one is never instantiated, so you can remove the whole thing without loss of functionality. Whoops, its PresenterAnimation (not PresenterAnimator) which has only one ctor that is never used and so is never instantiated and is trivial to remove. Nevertheless, PresenterAnimator itself only has a trivial ctor which doesn't do anything much and no public methods, so as far as I can see the only thing that currently actually gets executed is that we call PresenterTimer::CancelTask(0) in the PresenterAnimator dtor. I have no idea if anything relies on that sort of accident to continue working. I *doubt* it, but its possible I suppose. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sdext)
On Tue, 2012-03-20 at 15:24 +0100, Chr. Rossmanith wrote: At least it doesn't change the position of mxSprite. Only the cpu is a little less idle :-) Then I'll continue to remove maTransform? Or should it be kept for future use? I'm not a fan of some day we'll use it, ditch it if it doesn't do anything right now would be my feeling. I've a shed full of stuff I can't throw out just in case some day we need it. Not that removing stuff from sdext will give me more space in my shed I suppose. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (sdext)
On Tue, 2012-03-20 at 15:07 +, Caolán McNamara wrote: I've a shed full of stuff I can't throw out just in case some day we need it. Not that removing stuff from sdext will give me more space in my shed I suppose. :-) I have a similar shed - I can't get into it either ;-) but I really ought to do something about it, I love the attitude. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in drawingml
On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote: Hi! These patches remove unused code as listed in unusedcode.easy Looks good, pushed now. Thanks for these. If I'm not wrong, this is you first submission ? If so, can you add yourself to http://wiki.documentfoundation.org/Development/Developers and confirm that your code is submitted under the preferred LGPLv3+/MPLv1.1+ combo ? Its typical to do a sort of blanket, all patches until I state otherwise, should be links to examples on the above wiki page. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in drawingml
On Wed, Mar 14, 2012 at 6:46 PM, Caolán McNamara caol...@redhat.com wrote: On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote: Hi! These patches remove unused code as listed in unusedcode.easy Looks good, pushed now. Thanks for these. If I'm not wrong, this is you first submission ? If so, can you add yourself to http://wiki.documentfoundation.org/Development/Developers and confirm that your code is submitted under the preferred LGPLv3+/MPLv1.1+ combo ? Its typical to do a sort of blanket, all patches until I state otherwise, should be links to examples on the above wiki page. Yes, this was my first submission :D. I sent a mail regarding the license, and also modified the wiki page. Thanks, Mariana Mărășoiu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] remove unused code
Hi Petr, On 09.03.2012 11:39, Petr Vorel wrote: another patch removing unused code. Actually I need an advice this time. Is method oox::core::XmlFilterBase::getChartConverter() really unused / unwanted? As it's used in Shape::finalizeXShape (oox/source/drawingml/shape.cxx). So feel free to drop it if it's not valid. Btw can we really rely on the tool which generates unusedcode.easy? :) see http://lists.freedesktop.org/archives/libreoffice/2012-February/026889.html pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b6ff047a572189a2b000ffbd437e573e518773db Thanks, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code in vbahelper
Pushed. On 03/08/2012 01:27 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.eas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code
Pushed. On 03/08/2012 01:05 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code(3)
Pushed. On 03/08/2012 02:19 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Pushed] [PATCH] Remove unused code(2)
Pushed. On 03/08/2012 02:07 AM, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in BiffObjLineModel
On Mon, 2012-02-27 at 20:10 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in BiffInputStream
On Mon, 2012-02-27 at 21:10 +0100, Santiago Martinez wrote: Hi, i'm not sure if this patch is correct so please review. I deleted BiffInputStream::sizeBase(), skipByteString(bool) and skipUniString() methods listed in unusedcode.easy. But also deleted another two methods (skipUniStringBody and skipUniStringChars ) because these two methods are used only by previously deleted methods. Looks fine, pushed now. Thanks for these. The next respin of unusedcode.easy would have picked them up, but looks fine. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (15)
On 19.02.2012 12:25, Elton Chung wrote: This patch removes 5 unused methods. Pushed, thank you! Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code (14)
On 18.02.2012 19:35, Elton Chung wrote: This patch is an addendum to commit 600c27470380f80445fecb4b5691e0d11060494d. Yeah, nice catch. Thanks, pushed. Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PARTIALLY PUSHED][PATCH] Remove unused code from connectivity::odbc
On Tue, Feb 14, 2012 at 01:43:11PM +, Caolán McNamara wrote: On Tue, 2012-02-14 at 06:06 +0100, Lionel Elie Mamane wrote: Thanks, but this one should actually be used in ODatabaseMetaData::getTableTypes. It is probably a bug that it is not, I'll convert getTableTypes to using it How about the other one ? Ah yes, I had missed that there was a second part. Let's see... On Mon, Feb 13, 2012 at 10:06:17PM +, Kate Goss wrote: Subject: [PATCH 2/2] Remove unused code from connectivity::odbc::OPreparedStatement --- a/connectivity/source/drivers/odbcbase/OPreparedStatement.cxx +++ b/connectivity/source/drivers/odbcbase/OPreparedStatement.cxx -sal_Int8* OPreparedStatement::getDataBuf (sal_Int32 index) Not particularly attached to it. -sal_Int32 OPreparedStatement::getParamLength ( sal_Int32 index) That's a near-duplicate of getLengthBuf, and is buggy anyway: it copies the bottom 32 bits of a 64 bit integer into a 32 bit integer. Depending on the endianess, that's either (value % 2^32) or (value / 2^32). Remove! -sal_Int32 OPreparedStatement::getPrecision ( sal_Int32 sqlType) Not particularly attached to it. OK, I'm pushing the second patch to master. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED][PATCH] Remove unused code
On Mon, 2012-02-13 at 15:38 +, Caolán McNamara wrote: On Mon, 2012-02-13 at 00:08 +, Björgvin Ragnarsson wrote: Hello, Attached is my first contribution to Libreoffice Looks good to me, pushed now, thanks for this. adding PUSHED tag dammit. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED][PATCH] Remove unused code
On Thu, 2012-02-09 at 21:02 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy Looks good, pushed, thanks for this. C. p.s. of course, my intention was that *elses* utterly useless unused code should go, *mine* of course was a work in progress which I was going to use any day now :-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED][PATCH] Remove unused code (4)
On Thu, 2012-02-09 at 02:44 +0800, Elton Chung wrote: Hi, This contribution is licensed under MPL 1.1 / GPL v3+ / LGPL v3+. Thanks for these, pushed now. C. p.s. Well, I did leave out the DDe* ones because at least some are used under windows, and it needs a bit more work to identify if they are all unused under windows or not and/or tweak code to move them into windows only code. Given that they're not easy, I've filtered them out of the easy list for now. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED][PATCH] Remove unused code
Hi Elton, thanks for your patch; I tweaked it a bit and then pushed. Notes: 1. ScVbaWorksheet( const css::uno::Reference ov::XHelperInterface xParent, const css::uno::Reference css::uno::XComponentContext xContext ); is *not* unused, we can see it at least in sc/source/ui/vba/vbaworkbook.cxx:85. Caolan, what do you think, why it was listed in unusedcode.easy? 2. ScVbaCommandBarControl ctor, that was removed in the patch, is actually used, it seems you mixed up these two overloaded ctors. :) I fixed that. Thanks, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED][PATCH] Remove unused code (2)
Pushed, thanks; however I have returned ScSubTotalDescriptorBase::GetData(ScSubTotalParam) const ScSubTotalDescriptorBase::PutData(ScSubTotalParam const) back to the header, because these functions are is pure virtual, and the implementations in ScSubTotalDescriptorBase is unused, not the all implementaions. Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED][PATCH] Remove unused code (3)
pushed this one after all. SfxMedium::GetHdl() seems to be used for now (in tools/inc/tools/ref.hxx), maybe we can remove all of those macro definitions... I also removed 'using SfxControllerItem::GetCoreMetric;' statement from sfx2/inc/sfx2/unoctitm.hxx, and then the build has succeeded. Thanks, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED][PATCH] Remove unused code
Hi Santiago, 28.01.2012 02:02, Santiago Martinez пишет: This patch removes unused code as listed in unusedcode.easy Pushed, thank you! http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b507836fc88f294ef55652174b66dc706125599 Cheers, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED][PATCH] Remove unused code
Hi, On Friday, 2012-01-20 21:53:57 +0100, Michael Stahl wrote: thanks Santiago for the patch, pushed: Marking thread [PUSHED] Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgp539B2XLIiP.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
