Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB
On 03/08/12 03:54, Korrawit Pruegsanusak wrote: Hello Noel, Thanks for fixing this bug. :-) Anyway, ... On Fri, Aug 3, 2012 at 1:30 AM, Noel Power nopo...@suse.com wrote: master:f29c91f3351db2887f994c2cc82ceaaa6d717906 'reverts the previous patch' This is: Revert fix for fdo#47907. Seems you have reverted the wrong commit? (which fixed another bug) yes, embarrassingly I got mixed up with the trees I was working in and assumed ( without even looking ) that the last patch in the log was the previous incarnation of this fix, just now I have indulged in a revert-fest and for the purposes of 3.6 the relevant patch to be cherry-picked is now master:00f1a3ed8ec17b8274a7bf3ee8f5d394a8a16bab the previous patch incarnation for the bug should now also be reverted ( but that's only relevant on master ) thanks for spotting that Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB
please review master:6068f2f7cf5d66c68241b3831851b413b2e0b3ba ( sorry don't have the cgit url as cgit is dead ) Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB
Hi Noel, On Thursday, 2012-08-02 14:32:16 +0100, Noel Power wrote: master:6068f2f7cf5d66c68241b3831851b413b2e0b3ba ( sorry don't have the cgit url as cgit is dead ) git show 6068f2f7cf5d66c68241b3831851b413b2e0b3ba | vim - works fine ;-) However, that is supposed to fix that comments disappear when saving to .xls, correct (as bz is down as well ...) ? It doesn't for me in 3-6, reloading the .xls the comment is gone. The patch itself looks correct, but apparently there's more to it. Placing a breakpoint there revealed that a XclExpNote record is never added.. some seconds later: this if a note is on a cell without content ... notes are saved only for cells with content. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpxDIW6uQVNR.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB
On 02/08/12 17:15, Eike Rathke wrote: Hi Noel, On Thursday, 2012-08-02 14:32:16 +0100, Noel Power wrote: master:6068f2f7cf5d66c68241b3831851b413b2e0b3ba ( sorry don't have the cgit url as cgit is dead ) git show 6068f2f7cf5d66c68241b3831851b413b2e0b3ba | vim - works fine ;-) However, that is supposed to fix that comments disappear when saving to .xls, correct (as bz is down as well ...) ? It doesn't for me in 3-6, but works in master right, sigh yes I did test it in 3.6 but I mustn't have reloaded there reloading the .xls the comment is gone. The patch itself looks correct, but apparently there's more to it. yes, markus sent me a mail pointing to http://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/excdoc.cxx#428 which should have done the trick ( but it's obvious the mxNoteList isn't used ) it seems there is some confusion because of the co-existence of the old and new code, I will fix it ( but right now gotta take kid to surf life/rescue training ) with any luck the fresh air and a walk on the beach will clear my head and make it easier, anyway thanks for noticiing Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB
Hello Noel 2012/8/2 Noel Power nopo...@suse.com: On 02/08/12 17:15, Eike Rathke wrote: Hi Noel, On Thursday, 2012-08-02 14:32:16 +0100, Noel Power wrote: master:6068f2f7cf5d66c68241b3831851b413b2e0b3ba ( sorry don't have the cgit url as cgit is dead ) git show 6068f2f7cf5d66c68241b3831851b413b2e0b3ba | vim - works fine ;-) However, that is supposed to fix that comments disappear when saving to .xls, correct (as bz is down as well ...) ? It doesn't for me in 3-6, but works in master right, sigh yes I did test it in 3.6 but I mustn't have reloaded there reloading the .xls the comment is gone. The patch itself looks correct, but apparently there's more to it. yes, markus sent me a mail pointing to http://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/excdoc.cxx#428 which should have done the trick ( but it's obvious the mxNoteList isn't used ) it seems there is some confusion because of the co-existence of the old and new code, I will fix it ( but right now gotta take kid to surf life/rescue training ) with any luck the fresh air and a walk on the beach will clear my head and make it easier, anyway thanks for noticiing I think you made the same mistake I did when I wrote the patch. Opening a test file and resavinf it without changes will produce the right output. As soon as you create a new file or change anything it will not use the cached import values for the output. I can take care of this bug if it helps. I think I know what is broken in this case. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB
Hi Eike, Markus On 02/08/12 18:05, Markus Mohrhard wrote: Hello Noel 2012/8/2 Noel Power nopo...@suse.com: On 02/08/12 17:15, Eike Rathke wrote: but works in master right, sigh yes I did test it in 3.6 but I mustn't have reloaded there actually I think did really reload it, but.. it's like Markus said any new comments are dropped yes, markus sent me a mail pointing to http://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/excdoc.cxx#428 which should have done the trick ( but it's obvious the mxNoteList isn't used ) and as suspected that was the problem, see master:f29c91f3351db2887f994c2cc82ceaaa6d717906 'reverts the previous patch' master:285a5ae06cf51927c2df4b47043e51394aab98b7 'new patch' I can take care of this bug if it helps. I think I know what is broken in this case. hopefully my latest attempt does the trick :-) Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
