[WONTFIX properly] Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

[Julien Nabet]

Thank you for the feedback, I added it on 
https://wiki.documentfoundation.org/Development/stuck_stuff.

Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

[Heiko Tietze]

With alias I had TargetURL in mind (sorry for the confusion). For example, the 
command .uno:ViewTrackChanges runs actually .uno:ShowTrackedChanges.


OpenPGP_signature.asc
Description: OpenPGP digital signature

Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

[Thorsten Behrens]

Hi!

Heiko Tietze wrote:
> The typo is there for more than twenty years and macros may depend on it.
> 
> Can we change the label but add an alias to the new "unchain" command, flag
> this alias as deprecated, and remove it with the next release?
> 
Adding an alias, and cleaning up our code sounds like a good idea.

Removing the original, wrong UNO command in the next release - not so
much. Those things end up in recorded macros, changing that will break
an unknown number of macros for an unknown number of likely not very
technical users.

My 2 cents,

-- Thorsten


signature.asc
Description: PGP signature

Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

[Julien Nabet]

The typo is there for more than twenty years and macros may depend on it.

Are we sure macros which used "UnhainFrame" were working?

I mean here are the uses of "UnchainFrame":

bin/find-can-be-private-symbols.functions.results:12898:SwFlyFrame::UnchainFrames(SwFlyFrame*, 
SwFlyFrame*)
sw/source/core/inc/flyfrm.hxx:195:    static void UnchainFrames( 
SwFlyFrame *pMaster, SwFlyFrame *pFollow );
sw/source/core/layout/fly.cxx:382:    UnchainFrames( GetPrevLink(), 
this );
sw/source/core/layout/fly.cxx:384:    UnchainFrames( this, 
GetNextLink() );
sw/source/core/layout/fly.cxx:568:void SwFlyFrame::UnchainFrames( 
SwFlyFrame *pMaster, SwFlyFrame *pFollow )
sw/source/core/layout/fly.cxx:1171: SwFlyFrame::UnchainFrames( this, 
GetNextLink());
sw/source/core/layout/fly.cxx:1176: SwFlyFrame::UnchainFrames( 
pFollow->GetPrevLink(),
sw/source/core/layout/fly.cxx:1183: SwFlyFrame::UnchainFrames( this, 
GetNextLink() );
sw/source/core/layout/fly.cxx:1188: SwFlyFrame::UnchainFrames( 
GetPrevLink(), this );

sw/source/core/layout/fly.cxx:1193: SwFlyFrame::UnchainFrames( pMaster,
sw/source/core/layout/fly.cxx:1200: SwFlyFrame::UnchainFrames( 
GetPrevLink(), this );


I don't know how the link would be done between ".uno:UnhainFrame" and 
"UnchainFrame" method.




Can we change the label but add an alias to the new "unchain" command, flag this
alias as deprecated, and remove it with the next release?

I don't know how to do this but I suppose other people know.

Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

[Heiko Tietze]

The typo is there for more than twenty years and macros may depend on it.

Can we change the label but add an alias to the new "unchain" command, flag this 
alias as deprecated, and remove it with the next release?


On 22.10.23 22:49, Julien Nabet wrote:

Hello,

Olivier spotted a typo in UNO command ".uno:UnhainFrame", can it be fixed or is 
this another thing to add in 
https://wiki.documentfoundation.org/Development/stuck_stuff ?


Here's the patch https://gerrit.libreoffice.org/c/core/+/158328 waiting for 
review so you'll see what it impacts (if I haven't forgotten anything).


Julien



--
Dr. Heiko Tietze, UX-Designer and UX-Mentor
Tel: +49 30 5557992-63 | Mail: heiko.tie...@documentfoundation.org
The Document Foundation, Winterfeldtstraße 52, 10781 Berlin, DE
Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: https://www.documentfoundation.org/imprint


OpenPGP_signature.asc
Description: OpenPGP digital signature

About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

[Julien Nabet]

Hello,

Olivier spotted a typo in UNO command ".uno:UnhainFrame", can it be 
fixed or is this another thing to add in 
https://wiki.documentfoundation.org/Development/stuck_stuff ?


Here's the patch https://gerrit.libreoffice.org/c/core/+/158328 waiting 
for review so you'll see what it impacts (if I haven't forgotten anything).


Julien