Re: Changing Cell Validate Text

[Daniel Bankston]

On 06/13/2012 03:07 PM, Joel Madero wrote:

Hi Daniel,

Just a quick email to see if you have finished up with the stuff
needed so I can do the patch for this minor change that has been
brought up as a bug. The files that will be changed are:

validate.src
validate.cxx
validate.hrc


Object name changes:

SC_VALIDDLG_DATA_BETWEEN
SC_VALIDDLG_DATA_NOTBETWEEN

Let me know if I can make these changes and shoot a patch out. Not
even sure if it'll be accepted but I want to try as a user is
concerned about wording.

Thanks,

Joel



Hi, Joel,

Although I did have a commit last week that used some code from 
validate.cxx, Markus was the one that was working in this area 
directly.  So Markus would be the one to check with.  Regardless, I 
think that I would be ok just to send the patch to the mailing list, and 
we can take a look.


Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Changing Cell Validate Text

[Joel Madero]

Please let me know when I can do the changes. They are really small as it's
just the text and name of one variable.
On Jun 7, 2012 10:43 PM, "Daniel Bankston" 
wrote:

> On 06/08/2012 12:31 AM, Markus Mohrhard wrote:
>
>> Hey Joel,
>>
>> 2012/6/8 Joel Madero:
>>
>>> Thanks for pointing that out, correction:
>>>
>>> https://bugs.freedesktop.org/**show_bug.cgi?id=43192
>>>
>>>  Please don't change anything in this area right now. I have a really
>> large clean-up in this area that is yet unpushed and it would be a
>> real nightmare if I would have to resolve several merge conflicts for
>> master and a different set for 3-6.
>>
>> I hope to finish this tomorrow and after that I don't mind if you change
>> it.
>>
>> Regards,
>> Markus
>>
> I sent my last reply to Joel before I saw this message from Markus.
>  Regardless, I defer to Markus's comments.
>
>
> Respectfully,
> Daniel Bankston
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Changing Cell Validate Text

[Daniel Bankston]

On 06/08/2012 12:31 AM, Markus Mohrhard wrote:

Hey Joel,

2012/6/8 Joel Madero:

Thanks for pointing that out, correction:

https://bugs.freedesktop.org/show_bug.cgi?id=43192


Please don't change anything in this area right now. I have a really
large clean-up in this area that is yet unpushed and it would be a
real nightmare if I would have to resolve several merge conflicts for
master and a different set for 3-6.

I hope to finish this tomorrow and after that I don't mind if you change it.

Regards,
Markus
I sent my last reply to Joel before I saw this message from Markus.  
Regardless, I defer to Markus's comments.



Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Changing Cell Validate Text

[Daniel Bankston]

On 06/08/2012 12:24 AM, Joel Madero wrote:

Thanks for pointing that out, correction:

https://bugs.freedesktop.org/show_bug.cgi?id=43192

On Thu, Jun 7, 2012 at 10:20 PM, Daniel Bankston 
> wrote:


On 06/07/2012 10:58 PM, Joel Madero wrote:

Hi All,
Before I push this (which I will do tomorrow). I want to get
preference opinions if possible. Here is the bug report:

https://bugs.freedesktop.org/show_bug.cgi?id=43518

I tend to agree with the complaint (although it's incredibly
minor). Technically "between" should not include the minimum
and maximum numbers put in. Since they are (and I think that
this is preferred) the text should be changed. I opted for
"valid range" and "invalid range". There are other options
including:

between (inclusive) & not between (inclusive) or simply
include range & exclude range

This is really minor but I'm trying to knock off some of these
little bugs that just take a small amount of time to fix. If
you're opposed to any change in language &/or prefer different
wording please respond, otherwise I'm pushing my updates as
soon as possible.

Lastly, on a technical note. What's the easiest way for me to
replace all occurrence of a variable with another name. In
order to be consistent I'll have to update the variable name
along with the actual text name.

Thanks all,
Joel


Hi, Joel,

Maybe I misunderstand, but I think you accidentally linked the
wrong bug report.


Respectfully,
Daniel Bankston



Hi, Joel,

Ironically, I have been working today on ODS's import of Data Validity 
in the feature/gsoc-calc-perf branch which will eventually be merged to 
master.  If you are only changing the UI, I don't think there will be 
any conflicts, but can you please show us your patch before you push?  I 
haven't committed my own changes to my feature branch yet, but I will soon.



Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Changing Cell Validate Text

[Markus Mohrhard]

Hey Joel,

2012/6/8 Joel Madero :
> Thanks for pointing that out, correction:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=43192
>

Please don't change anything in this area right now. I have a really
large clean-up in this area that is yet unpushed and it would be a
real nightmare if I would have to resolve several merge conflicts for
master and a different set for 3-6.

I hope to finish this tomorrow and after that I don't mind if you change it.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Changing Cell Validate Text

[Joel Madero]

Thanks for pointing that out, correction:

https://bugs.freedesktop.org/show_bug.cgi?id=43192

On Thu, Jun 7, 2012 at 10:20 PM, Daniel Bankston <
daniel.dev.libreoff...@gmail.com> wrote:

> On 06/07/2012 10:58 PM, Joel Madero wrote:
>
>> Hi All,
>> Before I push this (which I will do tomorrow). I want to get preference
>> opinions if possible. Here is the bug report:
>>
>> https://bugs.freedesktop.org/show_bug.cgi?id=43518
>>
>> I tend to agree with the complaint (although it's incredibly minor).
>> Technically "between" should not include the minimum and maximum numbers
>> put in. Since they are (and I think that this is preferred) the text should
>> be changed. I opted for "valid range" and "invalid range". There are other
>> options including:
>>
>> between (inclusive) & not between (inclusive) or simply include range &
>> exclude range
>>
>> This is really minor but I'm trying to knock off some of these little
>> bugs that just take a small amount of time to fix. If you're opposed to any
>> change in language &/or prefer different wording please respond, otherwise
>> I'm pushing my updates as soon as possible.
>>
>> Lastly, on a technical note. What's the easiest way for me to replace all
>> occurrence of a variable with another name. In order to be consistent I'll
>> have to update the variable name along with the actual text name.
>>
>> Thanks all,
>> Joel
>>
>>
> Hi, Joel,
>
> Maybe I misunderstand, but I think you accidentally linked the wrong bug
> report.
>
>
> Respectfully,
> Daniel Bankston
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Changing Cell Validate Text

[Daniel Bankston]

On 06/07/2012 10:58 PM, Joel Madero wrote:

Hi All,
Before I push this (which I will do tomorrow). I want to get 
preference opinions if possible. Here is the bug report:


https://bugs.freedesktop.org/show_bug.cgi?id=43518

I tend to agree with the complaint (although it's incredibly minor). 
Technically "between" should not include the minimum and maximum 
numbers put in. Since they are (and I think that this is preferred) 
the text should be changed. I opted for "valid range" and "invalid 
range". There are other options including:


between (inclusive) & not between (inclusive) or simply include range 
& exclude range


This is really minor but I'm trying to knock off some of these little 
bugs that just take a small amount of time to fix. If you're opposed 
to any change in language &/or prefer different wording please 
respond, otherwise I'm pushing my updates as soon as possible.


Lastly, on a technical note. What's the easiest way for me to replace 
all occurrence of a variable with another name. In order to be 
consistent I'll have to update the variable name along with the actual 
text name.


Thanks all,
Joel



Hi, Joel,

Maybe I misunderstand, but I think you accidentally linked the wrong bug 
report.



Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Changing Cell Validate Text

[Joel Madero]

Hi All,
Before I push this (which I will do tomorrow). I want to get preference
opinions if possible. Here is the bug report:

https://bugs.freedesktop.org/show_bug.cgi?id=43518

I tend to agree with the complaint (although it's incredibly minor).
Technically "between" should not include the minimum and maximum numbers
put in. Since they are (and I think that this is preferred) the text should
be changed. I opted for "valid range" and "invalid range". There are other
options including:

between (inclusive) & not between (inclusive) or simply include range &
exclude range

This is really minor but I'm trying to knock off some of these little bugs
that just take a small amount of time to fix. If you're opposed to any
change in language &/or prefer different wording please respond, otherwise
I'm pushing my updates as soon as possible.

Lastly, on a technical note. What's the easiest way for me to replace all
occurrence of a variable with another name. In order to be consistent I'll
have to update the variable name along with the actual text name.

Thanks all,
Joel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice