Re: Compiling --enable-pdfium fails
Hi, On Fri, Apr 20, 2018 at 09:34:23AM +0200, Stephan Bergmann wrote: > And note that your issue is with LO's bundled external/pdfium, not core LO > code, building against system jpeg. Arguably, whatever missing configure > checks are missing from pdfium's configure; so if you come up with a fix for > that, that should probably go to the pdfium upstream. pdfium has its unhelpful own build system inherited from Chromium, so we don't use that, instead we just build their code with gbuild. But otherwise sure, if changes to pdfium itself are necessary, it's good to upstream that, I've already sent a number of patches upstream in the recent past and it was a pleasure to work with the maintainers, so it's not wasted effort. Regards, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Compiling --enable-pdfium fails
On 19/04/18 17:45, Дилян Палаузов wrote: --with-system-jpeg was indeed the problem. What libjpeg has to be installed in order for this to work? Are libturbo-jpeg and jpeg-9c.zip interchangable, as they both provide libjpeg.so? Can I use jpeg-9b instead of jpeg-9c and why doesn't ./configure fail in such cases? LO should work with bot libjpeg and libjpeg-turbo. And given that there's zero checking for specific details in LO's configure.ac for the --with-system-jpeg case, I'd assume that various jpeg-9* would all work. But you'd need to check; configure checks are typically only added once somebody ran into a non-working combination. And note that your issue is with LO's bundled external/pdfium, not core LO code, building against system jpeg. Arguably, whatever missing configure checks are missing from pdfium's configure; so if you come up with a fix for that, that should probably go to the pdfium upstream. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Compiling --enable-pdfium fails
Hello, thanks for your answer. --with-system-jpeg was indeed the problem. What libjpeg has to be installed in order for this to work? Are libturbo-jpeg and jpeg-9c.zip interchangable, as they both provide libjpeg.so? Can I use jpeg-9b instead of jpeg-9c and why doesn't ./configure fail in such cases? Regards Dilian - Message from Stephan Bergmann - Date: Tue, 17 Apr 2018 17:40:38 +0200 From: Stephan Bergmann Subject: Re: Compiling --enable-pdfium fails To: LibreOffice Cc: Дилян Палаузов On 17/04/18 17:23, Дилян Палаузов wrote: for 6.0.3.2 I call ./configure --enable-evolution2 --enable-avahi --enable-python=system --enable-eot --enable-online-update --enable-introspection=yes --without-doxygen --with-jdk-home=/opt/jdk --with-ant-home=/opt/ant --without-junit --enable-formula-logger --enable-introspection --with-system-bzip2 --with-system-cairo --with-system-epoxy --with-system-zlib --with-system-jpeg --with-system-expat --with-system-libxml --with-system-icu --with-system-openldap --with-system-poppler --with-system-curl --with-system-boost --with-webdav --with-krb5 --with-gssapi --with-system-lcms2 --with-boost --with-system-nss --with-system-graphite --with-system-harfbuzz --with-system-openssl --with-system-libpng --disable-firebird-sdbc which implies --enable-pdfium, and then `make` shows: mkdir -p /src/libreoffice-6.0.3.2/instdir /src/libreoffice-6.0.3.2/solenv/bin/install-gdb-printers -a /src/libreoffice-6.0.3.2/instdir -c make -j 4 -rs -f /src/libreoffice-6.0.3.2/Makefile.gbuild all [build DEP] LNK:Executable/unoidl-write [build DEP] LNK:Executable/unoidl-check [build DEP] LNK:Library/libunoidllo.so [build DEP] LNK:Library/libpdfiumlo.so [build DEP] LNK:Executable/cppumaker [build PAT] liborcus [build DEP] LNK:Library/libunoidllo.so [build LNK] Library/libunoidllo.so [build UIC] modules/BasicIDE [build CXX] workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp /src/libreoffice-6.0.3.2/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp: In function ‘boolean _src_fill_buffer(j_decompress_ptr)’: /src/libreoffice-6.0.3.2/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp:78:10: error: invalid conversion from ‘int’ to ‘boolean’ [-fpermissive] return 0; ^ I assume some weird boolean typedef from your --with-system-jpeg. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice - End message from Stephan Bergmann - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Compiling --enable-pdfium fails
On 17/04/18 17:23, Дилян Палаузов wrote: for 6.0.3.2 I call ./configure --enable-evolution2 --enable-avahi --enable-python=system --enable-eot --enable-online-update --enable-introspection=yes --without-doxygen --with-jdk-home=/opt/jdk --with-ant-home=/opt/ant --without-junit --enable-formula-logger --enable-introspection --with-system-bzip2 --with-system-cairo --with-system-epoxy --with-system-zlib --with-system-jpeg --with-system-expat --with-system-libxml --with-system-icu --with-system-openldap --with-system-poppler --with-system-curl --with-system-boost --with-webdav --with-krb5 --with-gssapi --with-system-lcms2 --with-boost --with-system-nss --with-system-graphite --with-system-harfbuzz --with-system-openssl --with-system-libpng --disable-firebird-sdbc which implies --enable-pdfium, and then `make` shows: mkdir -p /src/libreoffice-6.0.3.2/instdir /src/libreoffice-6.0.3.2/solenv/bin/install-gdb-printers -a /src/libreoffice-6.0.3.2/instdir -c make -j 4 -rs -f /src/libreoffice-6.0.3.2/Makefile.gbuild all [build DEP] LNK:Executable/unoidl-write [build DEP] LNK:Executable/unoidl-check [build DEP] LNK:Library/libunoidllo.so [build DEP] LNK:Library/libpdfiumlo.so [build DEP] LNK:Executable/cppumaker [build PAT] liborcus [build DEP] LNK:Library/libunoidllo.so [build LNK] Library/libunoidllo.so [build UIC] modules/BasicIDE [build CXX] workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp /src/libreoffice-6.0.3.2/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp: In function ‘boolean _src_fill_buffer(j_decompress_ptr)’: /src/libreoffice-6.0.3.2/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp:78:10: error: invalid conversion from ‘int’ to ‘boolean’ [-fpermissive] return 0; ^ I assume some weird boolean typedef from your --with-system-jpeg. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Compiling --enable-pdfium fails
Hello, for 6.0.3.2 I call ./configure --enable-evolution2 --enable-avahi --enable-python=system --enable-eot --enable-online-update --enable-introspection=yes --without-doxygen --with-jdk-home=/opt/jdk --with-ant-home=/opt/ant --without-junit --enable-formula-logger --enable-introspection --with-system-bzip2 --with-system-cairo --with-system-epoxy --with-system-zlib --with-system-jpeg --with-system-expat --with-system-libxml --with-system-icu --with-system-openldap --with-system-poppler --with-system-curl --with-system-boost --with-webdav --with-krb5 --with-gssapi --with-system-lcms2 --with-boost --with-system-nss --with-system-graphite --with-system-harfbuzz --with-system-openssl --with-system-libpng --disable-firebird-sdbc which implies --enable-pdfium, and then `make` shows: mkdir -p /src/libreoffice-6.0.3.2/instdir /src/libreoffice-6.0.3.2/solenv/bin/install-gdb-printers -a /src/libreoffice-6.0.3.2/instdir -c make -j 4 -rs -f /src/libreoffice-6.0.3.2/Makefile.gbuildall [build DEP] LNK:Executable/unoidl-write [build DEP] LNK:Executable/unoidl-check [build DEP] LNK:Library/libunoidllo.so [build DEP] LNK:Library/libpdfiumlo.so [build DEP] LNK:Executable/cppumaker [build PAT] liborcus [build DEP] LNK:Library/libunoidllo.so [build LNK] Library/libunoidllo.so [build UIC] modules/BasicIDE [build CXX] workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp /src/libreoffice-6.0.3.2/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp: In function ‘boolean _src_fill_buffer(j_decompress_ptr)’: /src/libreoffice-6.0.3.2/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp:78:10: error: invalid conversion from ‘int’ to ‘boolean’ [-fpermissive] return 0; ^ /src/libreoffice-6.0.3.2/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp: In function ‘boolean _src_resync(j_decompress_ptr, int)’: /src/libreoffice-6.0.3.2/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp:82:10: error: invalid conversion from ‘int’ to ‘boolean’ [-fpermissive] return 0; ^ /src/libreoffice-6.0.3/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp: In function ‘bool JpegLoadInfo(const uint8_t*, uint32_t, int*, int*, int*, int*, bool*)’: /src/libreoffice-6.0.3/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp:151:42: error: cannot convert ‘bool’ to ‘boolean’ for argument ‘2’ to ‘int jpeg_read_header(j_decompress_ptr, boolean)’ int ret = jpeg_read_header(&cinfo, true); ^ /src/libreoffice-6.0.3/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp: In member function ‘bool CCodec_JpegDecoder::InitDecode()’: /src/libreoffice-6.0.3/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp:235:42: error: cannot convert ‘bool’ to ‘boolean’ for argument ‘2’ to ‘int jpeg_read_header(j_decompress_ptr, boolean)’ int ret = jpeg_read_header(&cinfo, true); ^ /src/libreoffice-6.0.3.2/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp: In member function ‘int CCodec_JpegModule::ReadHeader(CCodec_JpegModule::Context*, int*, int*, int*)’: /src/libreoffice-6.0.3.2/workdir/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.cpp:463:48: error: cannot convert ‘bool’ to ‘boolean’ for argument ‘2’ to ‘int jpeg_read_header(j_decompress_ptr, boolean)’ int ret = jpeg_read_header(&ctx->m_Info, true); ^ make[1]: *** [/src/libreoffice-6.0.3.2/solenv/gbuild/LinkTarget.mk:340: /src/libreoffice-6.0.3.2/workdir/GenCxxObject/UnpackedTarball/pdfium/core/fxcodec/codec/fx_codec_jpeg.o] Error 1 make[1]: *** Waiting for unfinished jobs [build CXX] codemaker/source/javamaker/javamaker.cxx [build CXX] codemaker/source/javamaker/javaoptions.cxx [build CXX] codemaker/source/javamaker/classfile.cxx make: *** [Makefile:268: build] Error 2 I use gcc 7.3.1 20180416. Any ideas? Regards Dilian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
