Re: New bug, looking for source location for setting Calc formulas
Thanks for looking Eike! Good to know for sure that it is a bug rather than intended behavior. I will contact a few others that are not on this list and update them. On 08/30/2013 03:27 PM, Eike Rathke wrote: Hi Andrew, On Friday, 2013-08-30 01:27:05 -0400, Andrew Douglas Pitonyak wrote: On 08/29/2013 10:44 PM, Andrew Douglas Pitonyak wrote: Setting the Formula property on a Calc cell has always expected English formulas. Use the FormulaLocal property otherwise. The new behavior is that the Formula property acts the same as FormulaLocal Plus .Formula is influenced by the current work locale (not UI language), which it should not. https://bugs.freedesktop.org/show_bug.cgi?id=67836 I'll take a look. I became aware of this based on a post on the mailing list. Turns out there was already an open and not verified bug. I have verified the behavior but would like to chat with the responsible developer before changing to confirmed and asking the responsible party to consider backing out their change (as well as can be done after a release). Better fix it.. Finding the range of commits btw that introduced a change in behavior can be done with bibisect, see https://wiki.documentfoundation.org/Bibisect Alternatively, I can at least document the new behavior that the two properties are identical so you might as well deprecate one. No, it's a bug. Looks like setting the FormulaLocal property is probably handled in sc/source/ui/unoobj/cellsuno.cxx ScCellObj::SetOnePropertyValue this calls SetString_Impl With (should be) bEnglish=true for .Formula and bEnglish=false for .FormulaLocal My head hurts now. Understandably ;-) Eike -- Andrew Pitonyak My Macro Document: http://www.pitonyak.org/AndrewMacro.odt Info: http://www.pitonyak.org/oo.php ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: New bug, looking for source location for setting Calc formulas
Hi Andrew, On Friday, 2013-08-30 15:50:09 -0400, Andrew Douglas Pitonyak wrote: Good to know for sure that it is a bug rather than intended behavior. I will contact a few others that are not on this list and update them. Cause identified, easy fix ... pending review for 4-1 as https://gerrit.libreoffice.org/5712 Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A For key transition see http://erack.de/key-transition-2013-01-10.txt.asc Support the FSFE, care about Free Software! https://fsfe.org/support/?erack pgpImfelUGiaJ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: New bug, looking for source location for setting Calc formulas
On 08/30/2013 04:53 PM, Eike Rathke wrote: Hi Andrew, On Friday, 2013-08-30 15:50:09 -0400, Andrew Douglas Pitonyak wrote: Good to know for sure that it is a bug rather than intended behavior. I will contact a few others that are not on this list and update them. Cause identified, easy fix ... pending review for 4-1 as https://gerrit.libreoffice.org/5712 Ahhh, so the fix is in sc/source/ui/docshell/docfunc.css Thanks Eike, This is actually very useful for me to see as I attempt to understand the code base. -- Andrew Pitonyak My Macro Document: http://www.pitonyak.org/AndrewMacro.odt Info: http://www.pitonyak.org/oo.php ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
New bug, looking for source location for setting Calc formulas
Anyone know off hand where I can find the sourcecode to set the the Formula and FormulaLocal property. Then, how can I see how changed that code last? A bug was introduced in 4.1 and I am trying to track the developer responsible. So, what is the bug? Setting the Formula property on a Calc cell has always expected English formulas. Use the FormulaLocal property otherwise. The new behavior is that the Formula property acts the same as FormulaLocal https://bugs.freedesktop.org/show_bug.cgi?id=67836 I became aware of this based on a post on the mailing list. Turns out there was already an open and not verified bug. I have verified the behavior but would like to chat with the responsible developer before changing to confirmed and asking the responsible party to consider backing out their change (as well as can be done after a release). Alternatively, I can at least document the new behavior that the two properties are identical so you might as well deprecate one. -- Andrew Pitonyak My Macro Document: http://www.pitonyak.org/AndrewMacro.odt Info: http://www.pitonyak.org/oo.php ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: New bug, looking for source location for setting Calc formulas
On 08/29/2013 10:44 PM, Andrew Douglas Pitonyak wrote: Anyone know off hand where I can find the sourcecode to set the the Formula and FormulaLocal property. Then, how can I see how changed that code last? A bug was introduced in 4.1 and I am trying to track the developer responsible. So, what is the bug? Setting the Formula property on a Calc cell has always expected English formulas. Use the FormulaLocal property otherwise. The new behavior is that the Formula property acts the same as FormulaLocal https://bugs.freedesktop.org/show_bug.cgi?id=67836 I became aware of this based on a post on the mailing list. Turns out there was already an open and not verified bug. I have verified the behavior but would like to chat with the responsible developer before changing to confirmed and asking the responsible party to consider backing out their change (as well as can be done after a release). Alternatively, I can at least document the new behavior that the two properties are identical so you might as well deprecate one. Looks like setting the FormulaLocal property is probably handled in sc/source/ui/unoobj/cellsuno.cxx ScCellObj::SetOnePropertyValue this calls SetString_Impl My head hurts now. -- Andrew Pitonyak My Macro Document: http://www.pitonyak.org/AndrewMacro.odt Info: http://www.pitonyak.org/oo.php ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
