[PUSHED] Re: [Libreoffice] [PATCH] Remove unused code
Noel Power píše v Út 31. 01. 2012 v 12:39 +: ok, pushed, Just marking the thread [PUSHED] :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove unused code
Hi Elton
First thanks for submitting your patch, it's appreciated however could I
ask if you could please repost your patch as an attachment [1] ? patch
content inline in a mail message just does't work as the mail client
breaks the lines in such a way as the patch program no longer
understands the diff. A patch as an attachmentwill help the reviewers
integrate your work easily, thanks again
Noel
p.s. could you also confirm you contribution is under the MPL 1.1 /
GPLv3+ / LGPLv3+ license(s)
[1]
http://wiki.documentfoundation.org/Development/Patch_Handling_Guidelines#How_to_submit_a_patch
On 31/01/12 07:58, Elton Chung wrote:
---
sc/inc/scdll.hxx |1 -
sc/source/core/inc/ddelink.hxx|1 -
sc/source/core/tool/ddelink.cxx | 11 -
sc/source/ui/app/scdll.cxx| 10
sc/source/ui/dbgui/fieldwnd.cxx |5
sc/source/ui/inc/areasave.hxx |1 -
sc/source/ui/inc/cellmergeoption.hxx |1 -
sc/source/ui/inc/fieldwnd.hxx |1 -
sc/source/ui/inc/scuitphfedit.hxx |4 ---
sc/source/ui/pagedlg/scuitphfedit.cxx | 39 -
sc/source/ui/undo/areasave.cxx|5
sc/source/ui/view/cellmergeoption.cxx |9 ---
unusedcode.easy |9 ---
13 files changed, 0 insertions(+), 97 deletions(-)
diff --git a/sc/inc/scdll.hxx b/sc/inc/scdll.hxx
index 93cff7e..43a9c9f 100644
--- a/sc/inc/scdll.hxx
+++ b/sc/inc/scdll.hxx
@@ -61,7 +61,6 @@ public:
// DLL-init/exit-code must be linked to the DLL only
static void Init(); // called directly after loading the DLL
-static void Exit(); // called directly befor unloading the DLL
static sal_uLongDetectFilter( SfxMedium rMedium, const
SfxFilter** ppFilter,
SfxFilterFlags nMust,
SfxFilterFlags nDont );
diff --git a/sc/source/core/inc/ddelink.hxx b/sc/source/core/inc/ddelink.hxx
index e3794e4..216d6d6 100644
--- a/sc/source/core/inc/ddelink.hxx
+++ b/sc/source/core/inc/ddelink.hxx
@@ -87,7 +87,6 @@ public:
const StringGetItem() const { return aItem; }
sal_uInt8 GetMode() const { return nMode; }
-voidResetValue(); // Wert zuruecksetzen
voidTryUpdate();
sal_BoolNeedsUpdate() const { return bNeedUpdate; }
diff --git a/sc/source/core/tool/ddelink.cxx b/sc/source/core/tool/ddelink.cxx
index 3bd75ae..5d36e52 100644
--- a/sc/source/core/tool/ddelink.cxx
+++ b/sc/source/core/tool/ddelink.cxx
@@ -228,17 +228,6 @@ sfx2::SvBaseLink::UpdateResult ScDdeLink::DataChanged(
return SUCCESS;
}
-void ScDdeLink::ResetValue()
-{
-pResult.reset();
-
-// Es hat sich was getan...
-// Tracking, FID_DATACHANGED etc. passiert von aussen
-
-if (HasListeners())
-Broadcast( ScHint( SC_HINT_DATACHANGED, ScAddress(), NULL ) );
-}
-
void ScDdeLink::ListenersGone()
{
sal_Bool bWas = bIsInUpdate;
diff --git a/sc/source/ui/app/scdll.cxx b/sc/source/ui/app/scdll.cxx
index 9cf9555..0a57bf6 100644
--- a/sc/source/ui/app/scdll.cxx
+++ b/sc/source/ui/app/scdll.cxx
@@ -312,16 +312,6 @@ void ScDLL::Init()
// StarOne Services are now handled in the registry
}
-void ScDLL::Exit()
-{
-// the SxxModule must be destroyed
-ScModule **ppShlPtr = (ScModule**) GetAppData(SHL_CALC);
-delete (*ppShlPtr);
-(*ppShlPtr) = NULL;
-
-// ScGlobal::Clear ist schon im Module-dtor
-}
-
//--
// Statusbar
//--
diff --git a/sc/source/ui/dbgui/fieldwnd.cxx b/sc/source/ui/dbgui/fieldwnd.cxx
index 40eb873..9139be4 100644
--- a/sc/source/ui/dbgui/fieldwnd.cxx
+++ b/sc/source/ui/dbgui/fieldwnd.cxx
@@ -254,11 +254,6 @@ size_t ScDPFieldControlBase::GetSelectedField() const
return mnFieldSelected;
}
-void ScDPFieldControlBase::SetSelectedField(size_t nSelected)
-{
-mnFieldSelected = nSelected;
-}
-
vectorScDPFieldControlBase::FieldName
ScDPFieldControlBase::GetFieldNames()
{
return maFieldNames;
diff --git a/sc/source/ui/inc/areasave.hxx b/sc/source/ui/inc/areasave.hxx
index c9ff348..1a0b1cd 100644
--- a/sc/source/ui/inc/areasave.hxx
+++ b/sc/source/ui/inc/areasave.hxx
@@ -78,7 +78,6 @@ public:
const ScAreaLinkSaver* operator[](size_t nIndex) const;
size_t size() const;
-void clear();
void push_back(ScAreaLinkSaver* p);
};
diff --git a/sc/source/ui/inc/cellmergeoption.hxx
b/sc/source/ui/inc/cellmergeoption.hxx
index ad5fe34..62e4279 100644
--- a/sc/source/ui/inc/cellmergeoption.hxx
+++ b/sc/source/ui/inc/cellmergeoption.hxx
@@ -44,7 +44,6 @@ struct ScCellMergeOption
SCROW mnEndRow;
bool mbCenter;
-explicit ScCellMergeOption();
explicit ScCellMergeOption(const ScRange rRange);
Re: [Libreoffice] [PATCH] Remove unused code
Hi Noel, *, I have attached the patch as an attachment. I also confirm that this contribution, as well as future ones are licensed under MPL 1.1 / GPL v3+ / LGPL v3+. Best Regards, Elton -- Elton Chung Administrator, sponsor of mirror.layerjet.com Language Maintainer of ReactOS Open Source operating system project | http://reactos.org Email/ IM: el...@elton.tk 0001-Remove-unused-code.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove unused code
On 31/01/12 11:05, Elton Chung wrote: Hi Noel, *, I have attached the patch as an attachment. I also confirm that this contribution, as well as future ones are licensed under MPL 1.1 / GPL v3+ / LGPL v3+. ok, pushed, thank, ps. next time don't chop off the header of the formatted patch 'cause 'git am' had problems processing the patch, anyway not to worry as 'patch' still accepted it and I added the author and description manually thanks again Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove unused code
On 20/01/12 19:56, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy thanks Santiago for the patch, pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7ce98f34150d430b12804eb9796e4142b7c6517c ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove unused code
On 20/01/12 20:13, Santiago Martinez wrote:
-VclEventListeners2::~VclEventListeners2()
-{
-}
i'm not sure this is right; if a destructor of a class is unused, but
its other methods are used, then that usually indicates a memory leak:
the destructor is never called because all instances are leaked.
regards,
michael
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove unused code
On 01/20/2012 09:57 PM, Michael Stahl wrote: i'm not sure this is right; if a destructor of a class is unused, but its other methods are used, then that usually indicates a memory leak: the destructor is never called because all instances are leaked. It might make sense to treat destructors specially in callcatcher, as they indicate resource leak (unless all the constructors of a given class are also unused) rather than unused code. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove unused code
Hi Michael,
On Friday, 2012-01-20 21:57:25 +0100, Michael Stahl wrote:
-VclEventListeners2::~VclEventListeners2()
-{
-}
i'm not sure this is right; if a destructor of a class is unused, but
its other methods are used, then that usually indicates a memory leak:
the destructor is never called because all instances are leaked.
Yup.. given that we have
class VclEventListeners2 : public vcl::DeletionNotifier
{
~VclEventListeners2();
}
maybe it's sufficient to make the dtor virtual if there's a delete
baseclasspointer somewhere?
Eike
--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
pgpjfZc971kQS.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove unused code
On Wed, 2010-12-22 at 12:00 +0100, Radek Doulik wrote: On Wed, 2010-12-22 at 11:29 +0100, Radek Doulik wrote: Hi Anders, thanks for your patch. Looks good to me so I pushed it. It contains sd/ module changes only though, so maybe you forget the ure part? ops, sorry. I managed to miss it when reading your mail, I will review it as well. pushed it too. Thanks once more! Cheers Radek Cheers Radek Cheers Radek On Wed, 2010-12-22 at 08:31 +0100, Anders Jonsson wrote: Some more unused code, this time in ure and impress. All code has been commented out at least since 2005. Anders Jonsson (LGPLv3+,MPL) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
