Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function

2011-01-08 Thread Norbert Thiebaud
On Sat, Jan 8, 2011 at 8:51 AM, Miklos Vajna vmik...@frugalware.org wrote:
 Hi,

 See the attached patch. Motivation:

 17:51  boobaa kohei: is there a way to bind F13/F15 to previous/next sheet 
 in calc?
 17:58 @kohei boobaa, no idea.  did you look into View - Toolbars - 
 Customize - Keyboard?
 17:58  boobaa kohei: exactly
 17:59 @kohei boobaa, if it's not there, then the answer will be 'no'.
 18:01  boobaa kohei: ok, let me rephrase. how difficult to implement this? 
 :)
 18:02 @kohei boobaa, this is a bit tricky, since ctrl-pageup pagedown have 
 special handling in vcl not tied to key bindings.
 18:02 @kohei boobaa, oh wait, I may be talking about shift-pageup/down.
 18:03  boobaa kohei: well, from my user point of view all i'm missing is 
 the f13 and f15 from the available keys' list. everything else is there 
 already.
 18:05 @kohei boobaa, then it should be fairly simple I think.  Just add F13 
 and up as bindable keys in vcl, and modify the key binding pane in somewhere 
 in svx/svtools/svl is all you'd need to do, I think.
 18:05  * kohei forgets exactly how to add new keys.

 The patch is pretty trivial once it turned out vcl already supports up
 to F24 (and at some places F26), but what I can test is F13-F16, so I
 enabled only that.

Isn't F13 - F24 = Shift-F1 - Shift-F12 ? (which are already in the
customization panel)

Norbert


 OK to push to master?

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function

2011-01-08 Thread Miklos Vajna
On Sat, Jan 08, 2011 at 01:40:05PM -0600, Norbert Thiebaud 
nthieb...@gmail.com wrote:
 Isn't F13 - F24 = Shift-F1 - Shift-F12 ? (which are already in the
 customization panel)

Not really, it's possible to map those crazy multimedia buttons to F13
etc - then you'll even have Shift-F13. :)


pgpjLHXl2ZbTV.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function

2011-01-08 Thread Norbert Thiebaud
On Sat, Jan 8, 2011 at 4:51 PM, Miklos Vajna vmik...@frugalware.org wrote:
 On Sat, Jan 08, 2011 at 01:40:05PM -0600, Norbert Thiebaud 
 nthieb...@gmail.com wrote:
 Isn't F13 - F24 = Shift-F1 - Shift-F12 ? (which are already in the
 customization panel)

 Not really, it's possible to map those crazy multimedia buttons to F13
 etc - then you'll even have Shift-F13. :)

then why limit it to F13-F16
on my mac keyboard it goes to f19, and historically you could see up to f24

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function

2011-01-08 Thread Kohei Yoshida
Hi Miklos,

On Sat, Jan 8, 2011 at 9:51 AM, Miklos Vajna vmik...@frugalware.org wrote:

 OK to push to master?

Yeah, looks indeed trivial.  Let's push this baby.

Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function

2011-01-08 Thread Miklos Vajna
On Sat, Jan 08, 2011 at 06:28:01PM -0500, Kohei Yoshida 
kohei.yosh...@gmail.com wrote:
 Hi Miklos,
 
 On Sat, Jan 8, 2011 at 9:51 AM, Miklos Vajna vmik...@frugalware.org wrote:
 
  OK to push to master?
 
 Yeah, looks indeed trivial.  Let's push this baby.

Done. :)

Thanks.


pgp4CTWGdMqPT.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] cui: make it possible to bind F13/F14/F15/F16 to a function

2011-01-08 Thread Miklos Vajna
On Sat, Jan 08, 2011 at 05:27:08PM -0600, Norbert Thiebaud 
nthieb...@gmail.com wrote:
 On Sat, Jan 8, 2011 at 4:51 PM, Miklos Vajna vmik...@frugalware.org wrote:
  On Sat, Jan 08, 2011 at 01:40:05PM -0600, Norbert Thiebaud 
  nthieb...@gmail.com wrote:
  Isn't F13 - F24 = Shift-F1 - Shift-F12 ? (which are already in the
  customization panel)
 
  Not really, it's possible to map those crazy multimedia buttons to F13
  etc - then you'll even have Shift-F13. :)
 
 then why limit it to F13-F16
 on my mac keyboard it goes to f19, and historically you could see up to f24

That's what I could test on my hardware. Feel free to extend it if you
want. :)


pgpZVpdvnC4jq.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice