Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.
On Tue, 2011-09-06 at 11:07 +0200, Stephan Bergmann wrote: Found a regression from a recent Disable fake VBA events for the old-style form controls commit that causes the forms/qa/unoapi check to fail. Attached patch fixes it. pushed, this is part of getting the subsequent tests working again, right ? I think Bjoern might have a list of bugs for those somewhere FWIW. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.
On Tue, 06 Sep 2011 11:00:26 +0100 Caolán McNamara caol...@redhat.com wrote: On Tue, 2011-09-06 at 11:07 +0200, Stephan Bergmann wrote: Found a regression from a recent Disable fake VBA events for the old-style form controls commit that causes the forms/qa/unoapi check to fail. Attached patch fixes it. pushed, this is part of getting the subsequent tests working again, right ? I think Bjoern might have a list of bugs for those somewhere FWIW. Yes, there is: https://bugs.freedesktop.org/buglist.cgi?status_whiteboard_type=anywordssubstrquery_format=advancedstatus_whiteboard=unoapitest%20complextestbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENED (whiteboard keywords: unoapitest, complextest) all should be blocking: https://bugs.freedesktop.org/show_bug.cgi?id=35690 Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.
Hi Stephan, On 06/09/11 10:07, Stephan Bergmann wrote: Found a regression from a recent Disable fake VBA events for the old-style form controls commit that causes the forms/qa/unoapi check to fail. Attached patch fixes it. -Stephan thanks for fixing, ( I see Caolán pushed ) btw what exactly was null /me just doesn't see where/why moving the getPropertyValue makes a difference. thanks for cc'ing me 'cause at the moment due to some problems I don't understand it appears I am not getting any libreoffice-dev mails at all :-/ Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.
On 09/06/2011 12:25 PM, Noel Power wrote: Hi Stephan, On 06/09/11 10:07, Stephan Bergmann wrote: Found a regression from a recent Disable fake VBA events for the old-style form controls commit that causes the forms/qa/unoapi check to fail. Attached patch fixes it. -Stephan thanks for fixing, ( I see Caolán pushed ) btw what exactly was null /me just doesn't see where/why moving the getPropertyValue makes a difference. The unoapi tests call insertByIndex with a null interface, approveNewElement called from OInterfaceContainer::implInsert checks for null and throws an exception, but your modification accessed _rxElement before it got passed to approveNewElement. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
