Re: [Libreoffice] [PUSHED] [PATCH] remove dead code and uncompiled code in 'sd' module

2011-04-14 Thread Thorsten Behrens 
cocofan wrote:
   Attached is a patch for the Easy Hack removing commented out code
 (dead or uncompiled code).

Hi cocofan,

cool, many thanks for that cleanup - pushed with a few tweaks:

 * stuff commented out with a todo-mark - paraphrased intent into
   one-liner todo statement, we usually want to keep those reminders
 * references to bug ids (#i35937 mostly) - we also usually want to
   keep those ids around, of course without loads of disabled code
   alongside
 * whitespace-only changes - elided them, as they make merging
   unnecessarily painful

 **Note to Thorsten:
   In the next few days I'm going email a partially-working patch of the
 old Autolayout code from 2009.  It's going to take some doing as the old
 patch doesn't apply at all to the new build (the directories are
 different) and I'm manually separating out the code and adding it
 gradually (there's quite a bit of rewriting to do).  Should I send this
 to you directly instead of the mailing list as its not something that
 will be added to the main repository right now?
 
Wow, looking forward to that - please mail to this list, we love
sharing and public discussions. :)

Cheers,

-- Thorsten


pgpaiN8o8z6fa.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] Remove dead code

2011-03-01 Thread Thomas Arnhold 
Nice, thanks :) Pushed it.

Thomas

On 02/28/2011 11:21 PM, Michael Lefevre wrote:
 ACCESSIBLE_EVENT_NOTIFICATION_ENABLED was never define. So the #ifdef #endif 
 brackets could go away.
 ---
  .../extended/accessibleiconchoicectrlentry.hxx |   16 
  .../extended/accessibleiconchoicectrlentry.cxx |   15 ---
  2 files changed, 0 insertions(+), 31 deletions(-)
 
 diff --git 
 a/accessibility/inc/accessibility/extended/accessibleiconchoicectrlentry.hxx 
 b/accessibility/inc/accessibility/extended/accessibleiconchoicectrlentry.hxx
 index 3e9cec0..b2c145d 100644
 --- 
 a/accessibility/inc/accessibility/extended/accessibleiconchoicectrlentry.hxx
 +++ 
 b/accessibility/inc/accessibility/extended/accessibleiconchoicectrlentry.hxx
 @@ -83,22 +83,6 @@ namespace accessibility
  ::com::sun::star::uno::Reference 
 ::com::sun::star::accessibility::XAccessible  m_xParent;
  
  private:
 -#ifdef ACCESSIBLE_EVENT_NOTIFICATION_ENABLED
 -// (the following method is unused currently. If you need it, simply 
 remove the #ifdef thing here and
 -// in the cxx)
 -/** notifies all listeners that this object has changed
 -@param   _nEventId
 -is the event id
 -@param   _aOldValue
 -is the old value
 -@param   _aNewValue
 -is the new value
 -*/
 -void NotifyAccessibleEvent( sal_Int16 _nEventId,
 -   const ::com::sun::star::uno::Any 
 _aOldValue,
 -   const ::com::sun::star::uno::Any 
 _aNewValue );
 -#endif
 -
  RectangleGetBoundingBox_Impl() const;
  RectangleGetBoundingBoxOnScreen_Impl() 
 const;
  sal_Bool IsAlive_Impl() const;
 diff --git a/accessibility/source/extended/accessibleiconchoicectrlentry.cxx 
 b/accessibility/source/extended/accessibleiconchoicectrlentry.cxx
 index 6a613de..791d89a 100644
 --- a/accessibility/source/extended/accessibleiconchoicectrlentry.cxx
 +++ b/accessibility/source/extended/accessibleiconchoicectrlentry.cxx
 @@ -122,21 +122,6 @@ throw(RuntimeException)
  dispose();
  }
  }
 -#ifdef ACCESSIBLE_EVENT_NOTIFICATION_ENABLED
 -// (the following method is unused currently. If you need it, simply 
 remove the #ifdef thing here and
 -// in the hxx)
 -// 
 -
 -void AccessibleIconChoiceCtrlEntry::NotifyAccessibleEvent( sal_Int16 
 _nEventId,
 -   const 
 ::com::sun::star::uno::Any _aOldValue,
 -   const 
 ::com::sun::star::uno::Any _aNewValue )
 -{
 -Reference uno::XInterface  xSource( *this );
 -AccessibleEventObject aEventObj( xSource, _nEventId, _aNewValue, 
 _aOldValue );
 -
 -if (m_nClientId)
 -comphelper::AccessibleEventNotifier::addEvent( m_nClientId, 
 aEventObj );
 -}
 -#endif
  // 
 -
  Rectangle AccessibleIconChoiceCtrlEntry::GetBoundingBox_Impl() const
  {

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [Patch] remove dead code

2011-03-01 Thread Thomas Arnhold 
Thanks, pushed the first one. The second didn't apply (0002-..).

Thomas

On 02/27/2011 10:26 PM, Xisco Faulí wrote:
 Remode all dead code from /libs-core/sfx2/source
 
 
 
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice