Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

2011-11-02 Thread Eike Rathke 
Hi Markus,

On Tuesday, 2011-11-01 22:45:57 +0100, Markus Mohrhard wrote:

 http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0dd2113527ba0a601c5c59de7f7f44da161d21
 fixes a crash that happens if you use ROW() or COLUMN() in a matrix
 function. We try to get an entry from an empty mdds container which
 results in a crash.

Sounds like this fixes a symptom rather than a cause, why would a matrix
be empty?

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpL19YkevQpJ.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

2011-11-02 Thread Kohei Yoshida 
On Wed, 2011-11-02 at 12:39 +0100, Markus Mohrhard wrote:

 Pushed a fix to master:
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=b03e931439c54f4abaa520cf11ed24560ca1709a.
 Could anyone push that to the 3-4 branch.

Done.  Pushed to the 3-4 branch with my sign-off (though it should
really be Eike's).

And as Eike said, I'd be also curious why the matrix is empty in the
first place (when it gets pushed to the stack)...

 P.S. the commit message should be silly mistake by me

Yup, I caught that too.  Fixed. ;-)

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

2011-11-02 Thread Markus Mohrhard 
Hello Kohei, Eike

2011/11/2 Kohei Yoshida kohei.yosh...@suse.com:
 On Wed, 2011-11-02 at 12:39 +0100, Markus Mohrhard wrote:

 Pushed a fix to master:
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=b03e931439c54f4abaa520cf11ed24560ca1709a.
 Could anyone push that to the 3-4 branch.

 Done.  Pushed to the 3-4 branch with my sign-off (though it should
 really be Eike's).

 And as Eike said, I'd be also curious why the matrix is empty in the
 first place (when it gets pushed to the stack)...


I think that {=ROW()} is interpreted as ROW with an empty matrix. That
would explain why {=ROW(A2:B6)} works without a problem and why
{=ROW()} creates an empty matrix. I'm not sure if this intended or a
bug.

Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice