Re: [Libreoffice] .: sal/inc sal/osl
Michael Meeks píše v Pá 20. 01. 2012 v 17:34 +: On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote: +#if defined(__GNUC__) (__GNUC__ 3) +struct ::stat a_stat, b_stat; +#else +struct stat a_stat, b_stat; +#endif do we really need to have ifdefs for GCC 2 in LO? Probably not :-) I just re-used what was there already to avoid causing even more novel problems :-) I suspect we can rid ourselves of gcc2 everywhere (as an easy hack ?) but I'd prefer to have Petr check whatever ultra-old systems we build for ;-) The oldest system, we use, is SLED10 with gcc-4.1.2. Also we use gcc-4.2.4 for the official LO builds for TDF. So, I think that it is perfectly fine to remove support for GCC 2. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] .: sal/inc sal/osl
On 23/01/12 10:03, Petr Mladek wrote: Michael Meeks píše v Pá 20. 01. 2012 v 17:34 +: On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote: +#if defined(__GNUC__) (__GNUC__ 3) +struct ::stat a_stat, b_stat; +#else +struct stat a_stat, b_stat; +#endif do we really need to have ifdefs for GCC 2 in LO? Probably not :-) I just re-used what was there already to avoid causing even more novel problems :-) I suspect we can rid ourselves of gcc2 everywhere (as an easy hack ?) but I'd prefer to have Petr check whatever ultra-old systems we build for ;-) The oldest system, we use, is SLED10 with gcc-4.1.2. Also we use gcc-4.2.4 for the official LO builds for TDF. ah, yes, that's about what i expected; also, for MacOSX gcc 4.0.1 is used, which is AFAIK the oldest one. So, I think that it is perfectly fine to remove support for GCC 2. i'd be very, very surprised if anything older than 4.0.1 still builds at all (and even that one is annoying with it's spurious uno::Any warnings), so there's some cleanup potential here. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] .: sal/inc sal/osl
On Mon, 2012-01-23 at 12:35 +0100, Michael Stahl wrote: ah, yes, that's about what i expected; also, for MacOSX gcc 4.0.1 is used, which is AFAIK the oldest one. Great. So, I think that it is perfectly fine to remove support for GCC 2. i'd be very, very surprised if anything older than 4.0.1 still builds at all (and even that one is annoying with it's spurious uno::Any warnings), so there's some cleanup potential here. I added: https://bugs.freedesktop.org/show_bug.cgi?id=45131 If you think we can up ver 3 to ver 4 - please do update the bug. Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] .: sal/inc sal/osl
On 19/01/12 18:04, Michael Meeks wrote: sal/inc/osl/detail/file.h |6 -- sal/osl/unx/file_stat.cxx | 20 ++-- 2 files changed, 10 insertions(+), 16 deletions(-) New commits: commit c5d4f4967e5d9d0220fadf3f313ddc35002cdf27 Author: Michael Meeks michael.me...@suse.com Date: Thu Jan 19 17:03:16 2012 + implement inode compare for identical directory item checking diff --git a/sal/osl/unx/file_stat.cxx b/sal/osl/unx/file_stat.cxx index 320744f..e5fc091 100644 --- a/sal/osl/unx/file_stat.cxx +++ b/sal/osl/unx/file_stat.cxx +#if defined(__GNUC__) (__GNUC__ 3) +struct ::stat a_stat, b_stat; +#else +struct stat a_stat, b_stat; +#endif do we really need to have ifdefs for GCC 2 in LO? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] .: sal/inc sal/osl
On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote: +#if defined(__GNUC__) (__GNUC__ 3) +struct ::stat a_stat, b_stat; +#else +struct stat a_stat, b_stat; +#endif do we really need to have ifdefs for GCC 2 in LO? Probably not :-) I just re-used what was there already to avoid causing even more novel problems :-) I suspect we can rid ourselves of gcc2 everywhere (as an easy hack ?) but I'd prefer to have Petr check whatever ultra-old systems we build for ;-) Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
