Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed
On Tue, 2011-10-25 at 14:02 -0400, Kohei Yoshida wrote: > > > > The state what sheets are selected is clearly view related and does not > > belong to the document. In fact two different views can have different > > sheets selected. > > Well, I wouldn't say "clearly", since I had the same idea about tab > colors being view properties, but apparently the tab colors do belong to > the document (as I was told back in the day). The tab colors are stored > in ScTable currently. > > With regard to different views having different sheet selections, I > wonder if that is really an intended behavior, or just a side-effect of > how we currently store this property. I personally wouldn't mind > changing this behavior so that all views would have identical sheet > selections. Anyway. In the end, I've decided not to follow my original plan, and fix it differently. The tab selection data stays with ScMarkData, and I worked around it by copying that data from ScTabViewShell to ScPreviewShell during print preview. It should be fixed on master. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed
>> Is it something where I can be of help? >So, Comment 8 in the bug should serve as a code pointer to start the >work. >Kohei Yoshida, LibreOffice hacker, Calc Considering the discussion regarding the various solutions I leave this to you and other experts and I'll start on easy hacks first. Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed
Hello Eike, On Tue, 2011-10-25 at 19:36 +0200, Eike Rathke wrote: > Hi Kohei, > > On Tuesday, 2011-10-25 10:55:33 -0400, Kohei Yoshida wrote: > > > However, this one is a bit complex, as we would need to move the flags > > that tell you which sheets are selected, from ScMarkData to ScDocument > > (or most likely ScTable) in order for the mentioned code to access this > > information during print preview. > > The state what sheets are selected is clearly view related and does not > belong to the document. In fact two different views can have different > sheets selected. Well, I wouldn't say "clearly", since I had the same idea about tab colors being view properties, but apparently the tab colors do belong to the document (as I was told back in the day). The tab colors are stored in ScTable currently. With regard to different views having different sheet selections, I wonder if that is really an intended behavior, or just a side-effect of how we currently store this property. I personally wouldn't mind changing this behavior so that all views would have identical sheet selections. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed
Hi Kohei, On Tuesday, 2011-10-25 10:55:33 -0400, Kohei Yoshida wrote: > However, this one is a bit complex, as we would need to move the flags > that tell you which sheets are selected, from ScMarkData to ScDocument > (or most likely ScTable) in order for the mentioned code to access this > information during print preview. The state what sheets are selected is clearly view related and does not belong to the document. In fact two different views can have different sheets selected. Maybe pDocShell->GetBestViewShell() helps? If not, then ScPreviewShell needs to know about and pass around the ScTabViewShell it corresponds to, i.e. in ctor remember the pOldSh if it is a ScTabViewShell* Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgp0yx5CLUsvd.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed
On Tue, 2011-10-25 at 10:23 +0200, Winfried Donkers wrote: > I see that a solution is/was targeted for version 3.5. As of > yesterday, that had not yet been achieved (the problem still persists > with 3.5 and code from yesterday). > > The problem is quite annoying for users (such as in our company). > > > > Does anyone know (Kohei Yoshida?) the current status of the work on > this bug? > > Is it something where I can be of help? (I used to develop in C++, > before I had a stroke, nowadays the complexity must be low for me to > work on it. Also, I will need assistence to get started. I can make > LibO from source on an opensuse platform). So, Comment 8 in the bug should serve as a code pointer to start the work. https://bugs.freedesktop.org/show_bug.cgi?id=32826#c8 However, this one is a bit complex, as we would need to move the flags that tell you which sheets are selected, from ScMarkData to ScDocument (or most likely ScTable) in order for the mentioned code to access this information during print preview. There are lots of places where we query for the selected sheets, so this transition will not be trivial, to say the least. Having said that, it is still doable, with enough willingness to hack and test. I'd set the target for this bug to 3.5, but I have to admit, bug fixes for 3.4.x has kept me busy for longer time than I expected, so I can't guarantee that I get this fixed in time for 3.5.0 release. Currently I have 17 bugs with target 3.5. Right now, there are still several features I'd like to squeeze into 3.5. So my plan is to squeeze those features in first, then start fixing 3.5-targeted bugs. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
