Re: [Libreoffice] cppcheck duplicate if expressions in bulmaper.cxx (sd part)

2011-09-14 Thread Kevin Hunter 

At 12:45pm -0400 Wed, 14 Sep 2011, Kevin Hunter wrote:

At 2:19am -0400 Fri, 09 Sep 2011, Stephan Bergmann wrote:

On 09/08/2011 10:47 PM, julien2412 wrote:

Here is the pb :
if( 0 )<--- Found duplicate if expressions.
{ [...code...] }
else if( 0 ) { [...code...] }

I checked the history, it's there since 16/11/2000 (commit
5dc708093d1ee179099abdcbf0c6f649b1c4deeb)

could anyone explain to me the purpose of this ? Just a typo ?


It's preceded by comment "to be implemented if module supports CJK"
a few lines above at sd/source/ui/func/bulmaper.cxx:73, so I would
say its something like commented-out code that still awaits
implementation...


Gah, sorry for the noise.  Hadn't finished reading the entire thread, 
obviously.


"Late to the party"

Kevin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] cppcheck duplicate if expressions in bulmaper.cxx (sd part)

2011-09-14 Thread Kevin Hunter 

At 2:19am -0400 Fri, 09 Sep 2011, Stephan Bergmann wrote:

On 09/08/2011 10:47 PM, julien2412 wrote:

Here is the pb :
if( 0 )<--- Found duplicate if expressions.
{ [...code...] }
else if( 0 ) { [...code...] }

I checked the history, it's there since 16/11/2000 (commit
5dc708093d1ee179099abdcbf0c6f649b1c4deeb)

could anyone explain to me the purpose of this ? Just a typo ?


It's preceded by comment "to be implemented if module supports CJK" a
few lines above at sd/source/ui/func/bulmaper.cxx:73, so I would say its
something like commented-out code that still awaits implementation...


Not that it's terribly large in terms of computation/memory in the grand 
scheme of things, but why have it compiled in, as opposed to using an 
#if 0 ?


Kevin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] cppcheck duplicate if expressions in bulmaper.cxx (sd part)

2011-09-09 Thread Caolán McNamara 
On Fri, 2011-09-09 at 08:19 +0200, Stephan Bergmann wrote:
> On 09/08/2011 10:47 PM, julien2412 wrote:
> > I checked the history, it's there since 16/11/2000 (commit
> > 5dc708093d1ee179099abdcbf0c6f649b1c4deeb)
> >
> > could anyone explain to me the purpose of this ? Just a typo ?
> 
> It's preceded by comment "to be implemented if module supports CJK" a 
> few lines above at sd/source/ui/func/bulmaper.cxx:73, so I would say its 
> something like commented-out code that still awaits implementation...

At this point with 11 years as a to-do I suggest you ditch the if'0ed
out code and comment.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] cppcheck duplicate if expressions in bulmaper.cxx (sd part)

2011-09-08 Thread Stephan Bergmann 

On 09/08/2011 10:47 PM, julien2412 wrote:

Here is the pb :
 if( 0 )<--- Found duplicate if expressions.
 {
 nFontID = EE_CHAR_FONTINFO_CJK;
  nFontHeightID = EE_CHAR_FONTHEIGHT_CJK;
 nWeightID = EE_CHAR_WEIGHT_CJK;
 nPostureID = EE_CHAR_ITALIC_CJK;
 }
 else if( 0 )
 {
 nFontID = EE_CHAR_FONTINFO_CTL;
  nFontHeightID = EE_CHAR_FONTHEIGHT_CTL;
 nWeightID = EE_CHAR_WEIGHT_CTL;
 nPostureID = EE_CHAR_ITALIC_CTL;
 }
I checked the history, it's there since 16/11/2000 (commit
5dc708093d1ee179099abdcbf0c6f649b1c4deeb)

could anyone explain to me the purpose of this ? Just a typo ?


It's preceded by comment "to be implemented if module supports CJK" a 
few lines above at sd/source/ui/func/bulmaper.cxx:73, so I would say its 
something like commented-out code that still awaits implementation...


-Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice