Re: [PATCH][PUSHED] update cppunit to version 1-13
On 06/28/2012 10:57 AM, Markus Mohrhard wrote:
2012/6/28 Philipp Riemer :
(1) In lines 288-291 of the patch you also delete the comment showing
from where you got the CPPUNIT file. Might be helpful to keep the
URL...
The URL is wrong now. Our cppunit version is from
http://cgit.freedesktop.org/libreoffice/cppunit/log/ so I don't think
that we need this URL now.
IIUC, ooo.lst.in specifies where the tar.gz is downloaded from
("http://dev-www.libreoffice.org/src";) these days, so repeating that in
cppunit/makefile.mk would no longer be useful.
However, that there appears to be no information about the true origin
of all the files listed in ooo.lst.in as coming from
is worrying.
Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH][PUSHED] update cppunit to version 1-13
2012/6/28 Markus Mohrhard : > Hellp Philipp > > 2012/6/28 Philipp Riemer : >> Hey Markus, Michael, all, >> >> Two minor things from my side as a newbie to the LO project: >> >> (1) In lines 288-291 of the patch you also delete the comment showing >> from where you got the CPPUNIT file. Might be helpful to keep the >> URL... > > The URL is wrong now. Our cppunit version is from > http://cgit.freedesktop.org/libreoffice/cppunit/log/ so I don't think > that we need this URL now. > >> >> (2) In addition, I was wondering why the install folder is still >> "ooo-install" in the makefile (lines 321-257)? Backward compatibility >> reasons? >> > > Why should we make a riskful change to something that is clearly > working as it should. IMHO changing internal names without a good > reason is not a good idea. > > Patches is already pushed because Michael needed it for his rebasing. > > Regards, > Markus Hey Markus, thanks for the fast answers. Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH][PUSHED] update cppunit to version 1-13
Hellp Philipp 2012/6/28 Philipp Riemer : > Hey Markus, Michael, all, > > Two minor things from my side as a newbie to the LO project: > > (1) In lines 288-291 of the patch you also delete the comment showing > from where you got the CPPUNIT file. Might be helpful to keep the > URL... The URL is wrong now. Our cppunit version is from http://cgit.freedesktop.org/libreoffice/cppunit/log/ so I don't think that we need this URL now. > > (2) In addition, I was wondering why the install folder is still > "ooo-install" in the makefile (lines 321-257)? Backward compatibility > reasons? > Why should we make a riskful change to something that is clearly working as it should. IMHO changing internal names without a good reason is not a good idea. Patches is already pushed because Michael needed it for his rebasing. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
