Re: [PUSHED] proposed fix for fdo#49859

2012-06-08 Thread Michael Meeks 

On Thu, 2012-06-07 at 10:35 +0200, Thorsten Behrens wrote:
 I notice you're not yet listed on

Ah - that was me being slow ... ;-)

 , did you state the license your work is under already? If not, the
 easiest way is to send a mail saying something along the lines of

Yes, Stephan did that, but I didn't get around to adding a link /
record for him until yesterday (with one thing and another).

HTH,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] proposed fix for fdo#49859

2012-06-07 Thread Thorsten Behrens 
Stephan van den Akker wrote:
 I believe I found the cause of fdo#49859 FORMATTING, UI: numbering
 alignment or
 indentation is not applied in Impress
 
Excellent, thanks so much - now finally pushed, to both master and
-3-6 -

 I propose an addition to DeactivatePage():
 
 int  SvxNumPositionTabPage::DeactivatePage(SfxItemSet *_pSet)
 {
 if(_pSet)
 {
 if(aDistBorderMF.IsEnabled())
 DistanceHdl_Impl(aDistBorderMF);
 DistanceHdl_Impl(aIndentMF);
 FillItemSet(*_pSet);
 }
 return sal_True;
 }
 
Yep, makes sense.

 Question:
 
 Ideally, I would wrap the DistanceHdl_Impl() calls in ..MF.HasFocus() checks
 to prevent unnecessary calls:
 
 if(aDistBorderMF.HasFocus()  aDistBorderMF.IsEnabled())
 DistanceHdl_Impl(aDistBorderMF);
 if(aIndentMF.HasFocus())
 DistanceHdl_Impl(aIndentMF);
 FillItemSet(*_pSet);
 
 But both aDistBorderMF.HasFocus() and aIndentMF.HasFocus() always seem to
 return
 false! Is this intentional, or a bug?

Looks like the same reason as for the actual bug - stuff gets
messaged in different orders here. I wouldn't bother too much.

Cheers,

-- Thorsten


pgplMmADoIQx3.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice