Re: [PUSHED-3-5] Revert Set the listbox height to an integer multiple of the listbox entry height

2012-06-09 Thread Luke Symes
Hi,

The problem I was trying to fix was that if a custom animation list item
was part shown at the bottom of the list, then moving the item above it
down one item would leave it part visible, when I felt that when an item
was moved, it should stay fully visible. Please see attached image to see
what I mean.

I don't have a current LO git checkout/build, but I would like to fix this
properly; I'll have a look into it after exams.

Regards,

Luke.
attachment: animation-list-item.png___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PUSHED-3-5] Revert Set the listbox height to an integer multiple of the listbox entry height

2012-05-09 Thread Ivan Timofeev

On 09.05.2012 15:06, Michael Meeks wrote:


On Mon, 2012-05-07 at 22:55 +0400, Ivan Timofeev wrote:

this patch reverts commit
http://cgit.freedesktop.org/libreoffice/core/commit/?id=16c9d63da67897e51960f3684d8d05b06f2c8f81
Quote:
This ensures that we don't get a half visible entry at the bottom of
the view.


I think Luke did that for some annoying problems in the presenter view
where we have this side-panel with an incomplete / partial list of
transitions and/or other bits; which caused some interaction annoyance;
but I guess this needs to be done at a higher level there. Then again -
Cor reported problems there somehow.


Hmm, maybe this is annoying. But what if we would just draw a border 
around the control. See the attached image. Not so annoying now, right?


Opinions from the UX point of view? :) Do we really need to shrink a 
listbox so that it does not show a partially visible item at the bottom, 
or adding a border is enough?



Actually that creates some problems:
1. Some listboxes get too small so that it's impossible to use the
scrollbar.[1]
2. Just open the LibreOffice file picker and resize it. Notice the ugly
gray space between the bottom of the listbox and the bottom of the
decoration.


I just reverted it on 3-5; thanks for that.


Yes, I can make the current behavior optional and use it somewhere. But
where?..


That'd be good I guess :-) It'd be good to get a description of the
problem in the bug, so we can improve the slideshow as well as the
file-selector.


The file-selector is ok now, let's find a solution for Impress' slide 
transitions list right here...


Regards,
Ivan
attachment: box-with-border.png___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PUSHED-3-5] Revert Set the listbox height to an integer multiple of the listbox entry height

2012-05-09 Thread Jean-Baptiste Faure
Hi,

Le 09/05/2012 13:52, Ivan Timofeev a écrit :
 [...]

 Opinions from the UX point of view? :) Do we really need to shrink a
 listbox so that it does not show a partially visible item at the
 bottom,[...]?
A partially visible item at the bottom of a listbox, shows clearly that
there is something else to see. It is a useful information.
In the case of the Navigator or the Stylist, shrinking the listbox has
very unsightly effects when you resize the window, particularly when
they are docked, one above the other, on the side of the main window.

Best regards.
JBF

-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice