Re: C++11 on master (towards LO 4.5)

[Jan Holesovsky]

Hi,

Stephan Bergmann píše v Pá 28. 11. 2014 v 09:22 +0100:

> Maintainers of active Windows tinderboxes (on cc, as of 
> ),
>  
> please make sure until, say, mid of next week (Dec 3) that they are 
> using MSVC 2013 for master builds.  I'll then make configure fail on 
> anything less.

Sorry for the delay, tb39 is updated now.

I've installed there the MSVC 2013 Community Edition (not Professional
this time) to be closer to what are volunteers likely to use :-)

All the best,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Andras Timar]

On Fri, Dec 5, 2014 at 11:49 AM, Stephan Bergmann  wrote:
> On 12/04/2014 09:55 PM, Terrence Enger wrote:
>>
>> It's not a big deal for me (because I am just looking for trouble,
>> not trying to get work done), but maybe somebody cares: my attempt to
>> run LibreOffice installed from (I am retyping this with newlines
>> added)
>>
>>   http://dev-build.libreoffice.org/daily/master/Win-x86@43/current/
>>
>> libo-master~2014-12-04_02.44.11_LibreOfficeDev_4.5.0.0.alpha0_Win_x86.msi
>>
>> on Windows Vista fails with message
>>
>>  This application has failed to start because MSVCR120.dll was not
>>  found.  Re-installing the application may fix this problem.
>>
>> A comparison with my previous installation, "TinderBox:
>> Win-x86@51-TDF, Branch:MASTER, Time: 2014-11-28_08:54:54", shows that
>> program/ within the older installation has msvc480.dll but the newer
>> version does not.  Neither program/ has MSVCR120.dll.
>
>
> I assume you mean @42, not @43?  Looking into
> 
> with Orca, there /is/ a msvcr120.dll included in the File table.  It is not
> clear to me why that apparently does not get installed onto your machine or
> is not found by LO (and it is neither clear to me where it would be
> installed to, into the LO program directory or into some global Windows
> directory).  Maybe Timar knows more.
>

It is to be installed into System directory of Windows (provided by
the VC++ Runtime merge module). It is not enough to unpack the msi
with msiexex /a (so called "parallel install"), if the correct VC++
Runtime was never installed to the system.

Regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Stephan Bergmann]

On 12/04/2014 09:55 PM, Terrence Enger wrote:

It's not a big deal for me (because I am just looking for trouble,
not trying to get work done), but maybe somebody cares: my attempt to
run LibreOffice installed from (I am retyping this with newlines
added)

  http://dev-build.libreoffice.org/daily/master/Win-x86@43/current/

libo-master~2014-12-04_02.44.11_LibreOfficeDev_4.5.0.0.alpha0_Win_x86.msi

on Windows Vista fails with message

 This application has failed to start because MSVCR120.dll was not
 found.  Re-installing the application may fix this problem.

A comparison with my previous installation, "TinderBox:
Win-x86@51-TDF, Branch:MASTER, Time: 2014-11-28_08:54:54", shows that
program/ within the older installation has msvc480.dll but the newer
version does not.  Neither program/ has MSVCR120.dll.


I assume you mean @42, not @43?  Looking into 
 
with Orca, there /is/ a msvcr120.dll included in the File table.  It is 
not clear to me why that apparently does not get installed onto your 
machine or is not found by LO (and it is neither clear to me where it 
would be installed to, into the LO program directory or into some global 
Windows directory).  Maybe Timar knows more.


(Older dailies would likely not contain nor require msvcr120.dll, as 
that is the runtime corresponding to the MSVC 2013 compiler.  Older 
dailies had likely been built with the MSVC 2012 compiler, with 
corresponding runtime msvcr110.dll.)


I assume you mean msvcr80.dll, not msvc480.dll?  msvcr80.dll 
(corresponding to MSVC 2005, I think) is included in LO installation 
sets because LO's Mozilla address book driver needs it.  It is only 
included if the build has been configured --enable-win-mozab-driver. 
There appears to be no useful accounting for the daily builds, but I'd 
assume that the given 
libo-master~2014-12-04_22.57.23_LibreOfficeDev_4.5.0.0.alpha0_Win_x86.msi has 
been configured --disable-win-mozab-driver.  Thorsten should know more.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Terrence Enger]

On Wed, 2014-12-03 at 15:35 +0100, Stephan Bergmann wrote:
> On 11/28/2014 09:22 AM, Stephan Bergmann wrote:
> > Maintainers of active Windows tinderboxes (on cc, as of
> >
),
> > please make sure until, say, mid of next week (Dec 3) that they are
> > using MSVC 2013 for master builds.  I'll then make configure fail on
> > anything less.
> 
> In place now with 
>

 
> "Master requires MSVC 2013 now."

It's not a big deal for me (because I am just looking for trouble,
not trying to get work done), but maybe somebody cares: my attempt to
run LibreOffice installed from (I am retyping this with newlines
added)

 http://dev-build.libreoffice.org/daily/master/Win-x86@43/current/

libo-master~2014-12-04_02.44.11_LibreOfficeDev_4.5.0.0.alpha0_Win_x86.msi

on Windows Vista fails with message

This application has failed to start because MSVCR120.dll was not
found.  Re-installing the application may fix this problem.

A comparison with my previous installation, "TinderBox:
Win-x86@51-TDF, Branch:MASTER, Time: 2014-11-28_08:54:54", shows that
program/ within the older installation has msvc480.dll but the newer
version does not.  Neither program/ has MSVCR120.dll.

HTH,
Terry.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Thorsten Behrens]

Stephan Bergmann wrote:
> Maintainers of active Windows tinderboxes (on cc, as of
> ),
> please make sure until, say, mid of next week (Dec 3) that they are
> using MSVC 2013 for master builds.
>
To make it explicit: win@42 is updated & working.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Stephan Bergmann]

On 11/28/2014 09:22 AM, Stephan Bergmann wrote:

Maintainers of active Windows tinderboxes (on cc, as of
),
please make sure until, say, mid of next week (Dec 3) that they are
using MSVC 2013 for master builds.  I'll then make configure fail on
anything less.


In place now with 
 
"Master requires MSVC 2013 now."


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Stephan Bergmann]

On 12/03/2014 07:39 AM, julien2412 wrote:

Will we be able to consider that erase method of every container (not just
some of them) will return an iterator so we won't need a temporary iterator
when using erase in a loop block?
(eg: http://www.cplusplus.com/reference/map/map/erase/)


The only answer to questions like this is---try it out.  There's no good 
reference that I know of that would provide a sufficiently detailed 
matrix of what's available in which compiler's standard library to be 
able to answer it "theoretically."

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[julien2412]

Hi,

Will we be able to consider that erase method of every container (not just
some of them) will return an iterator so we won't need a temporary iterator
when using erase in a loop block?
(eg: http://www.cplusplus.com/reference/map/map/erase/)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/C-11-on-master-towards-LO-4-5-tp4130265p4131354.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Stephan Bergmann]

On 11/25/2014 09:13 AM, Stephan Bergmann wrote:

So dropping MSVC 2012 for 2013 would give us six new features:

* Variadic templates
* Initializer lists
* Default template argumetns for function templates
* Explicit conversion operators
* Raw string literals
* Defaulted and deleted functions

And additionally dropping GCC 4.6 for 4.7 would give us an additional
three new features:

* Non-static data member initializers
* Alias templates
* Delegating constructors


In yesterday's ESC we decided to on master drop MSVC 2012 in favor of 
2013 but keep GCC 4.6 for now.  (Which means that the features in the 
upper list will presumably become available on master while those in the 
lower list presumably won't.  I write "presumably" because the theory of 
the compilers' feature advertisements still has to pass the test of 
real-life usage in that notorious toolchain killer called LO.  Try 
things out with caution first.)


Maintainers of active Windows tinderboxes (on cc, as of 
), 
please make sure until, say, mid of next week (Dec 3) that they are 
using MSVC 2013 for master builds.  I'll then make configure fail on 
anything less.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Michael Stahl]

On 25.11.2014 09:13, Stephan Bergmann wrote:
> Until now, our minimum C++ compiler requirements on master are:
> 
>* Clang 3.1
>* GCC 4.6 (specifically for Munich; preferred 4.7)
>* MSVC 2012
> 
> Branch-off of LO 4.4 from master seems like a good time to re-visit. 
> And natural candidates for consideration appear to be dropping MSVC 2012 
> for 2013, and/or the feasibility of dropping GCC 4.6 for 4.7.

apparently it's possible to use a "v120_xp" toolset with MSVC 2013 to
get the all-important Windows XP compatibility, so our users can
continue to run the latest LO on an OS that doesn't get security fixes:

http://www.visualstudio.com/en-us/products/visual-studio-2013-compatibility-vs.aspx

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Jan-Marek Glogowski]

Am 25.11.2014 um 09:13 schrieb Stephan Bergmann:
> Until now, our minimum C++ compiler requirements on master are:
> 
>   * Clang 3.1
>   * GCC 4.6 (specifically for Munich; preferred 4.7)
>   * MSVC 2012
> 
> Branch-off of LO 4.4 from master seems like a good time to re-visit. And
> natural candidates for consideration appear to be dropping MSVC 2012 for
> 2013, and/or the feasibility of dropping GCC 4.6 for 4.7.
> 
> What could that buy us in terms of newly available C++ features?  Based
> on the progress from MSVC 2012 to 2013, the following list shows which
> core language features became available where:
> 
> And additionally dropping GCC 4.6 for 4.7 would give us an additional
> three new features:
> 
> * Non-static data member initializers
> * Alias templates
> * Delegating constructors
> 
> Thoughts?

Munichs point of view hasn't changed. I'll expect us to be on Ubuntu
12.04 for at least the next 1 1/2+ years. And we're quite reluctant to
support our own build tool chain. So as long as the gcc 4.7+ features
aren't needed, we would like to stay on gcc 4.6.

As another datapoint, Firefox 31esr still builds on 12.04, but it's the
first ESR, which doesn't build on 10.04 using gcc 4.4. I hope FF 38esr
will still be compilable on 12.04.

As we'll just begin switching to LO 4.1.6+ next month, I'm planning to
do our next LO release based on 4.5 at the end of next year; it might
even be in the support timeline of LO.

Jan-Marek
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Stephan Bergmann]

On 11/25/2014 04:34 PM, Terrence Enger wrote:

The range-based `for` offers clearer code, IMHO.  When, I wonder, is
it appropriate to use it?
(*) New code?
(*) When I am changing a for-statement anyway?
(*) Throughout a function when I am changing a for-statement anyway?
(*) Not at all until we are ready to make the change throughout the
 system?

Similarly, what about `auto` type declarations (which often fit
naturally into variable definitions in a for-statement?


Both range-based for and auto are available across all compilers we 
currently support, so feel free to use them in new code anyway.  (The 
only exemption is include files that are part of the URE interface.)


As to changing existing code, I think the answer is no different for 
these C++11 features than for any other sort of clean up:  There is no 
hard and fast rules.  Weigh "don't needlessly touch existing code" 
against "keep the code clean and easily maintainable" and draw your 
conclusion.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Terrence Enger]

On Tue, 2014-11-25 at 09:13 +0100, Stephan Bergmann wrote:
interesting stuff about features of C++ supported by various
compilers.

The range-based `for` offers clearer code, IMHO.  When, I wonder, is
it appropriate to use it?
(*) New code?
(*) When I am changing a for-statement anyway?
(*) Throughout a function when I am changing a for-statement anyway?
(*) Not at all until we are ready to make the change throughout the
system?

Similarly, what about `auto` type declarations (which often fit
naturally into variable definitions in a for-statement?

Thanks,
Terry, 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 on master (towards LO 4.5)

[Tor Lillqvist]

> Thoughts?
>

I am all for it! I already tried using initializer lists (which IMHO seem
quite useful and not "obscure" at all;) but was then saddened to notice
that MSVS2012 did not support them.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice