Re: Disappearing graphics in Write: where to look (bug 33393)
Le 22/02/12 16:55, Michael Meeks a écrit : Hi all, Well - I think it's pretty clear that there are issues with storing meta-files, though the only bustage I can see is in having them renamed underneath you when saving them as ODF - AFAICS any save as ODF of that document, whether auto-save or not will destroy the document model hence any subsequent save will not have images in it. It appears that this bug also affects Base forms containing buttons into which background images have been embedded. In LO 3.5, if the form is opened for work, then saved/closed after data entry, the images disappear from the buttons - cf. bug report : https://bugs.freedesktop.org/show_bug.cgi?id=47832 Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
On 02/21/2012 06:49 AM, Michael Meeks wrote: On Tue, 2012-02-21 at 10:36 +0100, Jan Holesovsky wrote: So - I have already spent some 4 hours, or more, trying to fix this one. I spent a little time too ;-) cf. my comments in the bug. IMHO the lifecycle of images is highly non-intuitive there, I have high hopes that Thorsten will find the snafu, ATB, Michael. My little carries (My 3 year old, six year old, and my wife) have managed to pass on to me their illness so I have been sleeping a lot rather than trying to nail this one down as well. I do appreciate the pointers so that I can take a look as well. Yesterday, I had all of the graphics disappear out of a file when I chose to save as a DOCX file. I wonder if this is related. I expect not since save as DOC file worked just fine. -- Andrew Pitonyak My Macro Document: http://www.pitonyak.org/AndrewMacro.odt Info: http://www.pitonyak.org/oo.php ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
Hi Andrew, On Wed, 2012-02-22 at 09:37 -0500, Andrew Douglas Pitonyak wrote: My little carries (My 3 year old, six year old, and my wife) have managed to pass on to me their illness so I have been sleeping a lot rather than trying to nail this one down as well. I do appreciate the pointers so that I can take a look as well. Sorry to hear that. I keep pushing things into the bug. Yesterday, I had all of the graphics disappear out of a file when I chose to save as a DOCX file. I wonder if this is related. I expect not since save as DOC file worked just fine. Well - I think it's pretty clear that there are issues with storing meta-files, though the only bustage I can see is in having them renamed underneath you when saving them as ODF - AFAICS any save as ODF of that document, whether auto-save or not will destroy the document model hence any subsequent save will not have images in it. HTH, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
Hi Cor, all, On 2012-02-20 at 17:11 +0100, Cor Nouws wrote: Having a well formed, and reproducible bug report would be rather useful :-) Yes, I think we realise that :-) Therefore I added some comments on how I can reliably reproduce (more opening the doc and doing some random work for some time, but it will lose the images). However I failed to see any comments from devs that tried to follow my advise and what it did for them ;-p So - I have already spent some 4 hours, or more, trying to fix this one. The Autosave executes nearly the same code path as Save As; but there is something different happening - at some stage, the ID's get invalidated (both during Save As, as well as during Autosave), but in the Save As case, they are re-created, while during the Autosave, they are still the old ones - leading to loss of the images. I dropped the ball at that stage did not find where exactly the ID's are recreated in the Save As case. Should the above ring any bell to someone wants to step in, just set the Autosave to 1 minute, open the document from the bug, and wait one minute; and you'll lose the images :-( Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
On Tue, 2012-02-21 at 10:36 +0100, Jan Holesovsky wrote: So - I have already spent some 4 hours, or more, trying to fix this one. I spent a little time too ;-) cf. my comments in the bug. IMHO the lifecycle of images is highly non-intuitive there, I have high hopes that Thorsten will find the snafu, ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
Andrew Douglas Pitonyak wrote: Have been poking around the LO code today trying to decide where I might put break points to help in tracking this. Looks like this occurs (for my sample) when auto-save kicks in, so I may place a break point in the auto save code and then start stepping through it to see if anything obvious looks wrong. Hi Andrew, so the high-level object handling images in Writer is SwGrfNode (sw/source/core/graphic/ndgrf.cxx) It builds upon the GraphicManager framework, to be found around here: (svtools/source/graphic/grfmgr2.cxx) Note that saving graphics is a bit nasty, since no objects are handed around, but urls containing image checksums - grep for mxGraphicResolver in xmloff, mxGraphicResolver-resolveGraphicObjectURL( aURL ) puts that into the package (and may fail in your case - for checksums subtly changing, or graphics ceasing to be registered with their checksum at the GraphicManager). HTH, -- Thorsten pgpE6GPo2x6Nb.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
Hi Andrew, *, Thorsten Behrens wrote (20-02-12 12:59) Andrew Douglas Pitonyak wrote: Have been poking around the LO code today trying to decide where I might put break points to help in tracking this. Looks like this occurs (for my sample) when auto-save kicks in, so I may place a break point in the auto save code and then start stepping through it to see if anything obvious looks wrong. so the high-level object handling images in Writer is SwGrfNode [...] thanks for picking this one up. Now with 3.5 out in the wild, reports of people loosing data appear. I would like to propose this issue as *blocker* for 3.5.1 .. nothing less. Regards, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
On Mon, 2012-02-20 at 16:27 +0100, Cor Nouws wrote: thanks for picking this one up. Now with 3.5 out in the wild, reports of people loosing data appear. I would like to propose this issue as *blocker* for 3.5.1 .. nothing less. Having a well formed, and reproducible bug report would be rather useful :-) Having said that, the graphics object thing is an unbelievably bad pre-existing mess, the idea of holding string pointers to images, with no well thought through, and/or defined lifecycle mechanism is really poisonous. Still - we have another week before 3.5.1 if we can get some steps to reproduce it. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
Hi Michael, Michael Meeks wrote (20-02-12 17:05) Having a well formed, and reproducible bug report would be rather useful :-) Yes, I think we realise that :-) Therefore I added some comments on how I can reliably reproduce (more opening the doc and doing some random work for some time, but it will lose the images). However I failed to see any comments from devs that tried to follow my advise and what it did for them ;-p Regards, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
On 02/17/2012 08:31 PM, Andrew Douglas Pitonyak wrote: While updating LO documentation using the latest release of LO, most of the embedded graphics just disappeared so I have been looking at this: https://www.libreoffice.org/bugzilla/show_bug.cgi?id=33393 I spent a few hours poking around the generated files trying to understand what happened. My next step is to spend a few more hours checking to see if I am able to reproduce. And after that (even if I cannot reproduce) I intend to poke through the source code. I am not familiar with the write code so I am hoping that someone can kind of push me towards the code dealing with holding graphics objects in Write. I am not looking for a fine grained answer, just broadly speaking what code might represent a graphic object or contain a list of them (I figure it is as good as any place to look). I can reproduce the error at will, so now I just need to track it in the code to find where things go awry! -- Andrew Pitonyak My Macro Document: http://www.pitonyak.org/AndrewMacro.odt Info: http://www.pitonyak.org/oo.php ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
You may find some guidelines to debug LO here : http://wiki.documentfoundation.org/Development/How_to_debug Julien. -- View this message in context: http://nabble.documentfoundation.org/Disappearing-graphics-in-Write-where-to-look-bug-33393-tp3755433p3757064.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Disappearing graphics in Write: where to look (bug 33393)
On 02/18/2012 04:43 PM, julien2412 wrote: You may find some guidelines to debug LO here : http://wiki.documentfoundation.org/Development/How_to_debug Julien. Thanks Julien, very helpful. I am able to cause the problem every time in LO but unable to cause it at all in OOo. Have been poking around the LO code today trying to decide where I might put break points to help in tracking this. Looks like this occurs (for my sample) when auto-save kicks in, so I may place a break point in the auto save code and then start stepping through it to see if anything obvious looks wrong. -- Andrew Pitonyak My Macro Document: http://www.pitonyak.org/AndrewMacro.odt Info: http://www.pitonyak.org/oo.php ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
