Re: Linking error in headless(--without-x) build

2015-06-17 Thread Riccardo Magliocchetti

Hello,

thanks for reporting and providing a fix at the same time :)

Il 17/06/2015 08:39, Abhimanyu Singh ha scritto:

= SOLVED =

I was able to fix it myself.

For fixing linking error you need to edit "vcl/Library_vcl.mk"


[snip]


You also need to add "basebmp" entry because later you would get linking error
again because "vcl/headless/svpbmp.cxx" is using "basebmp".


Any chance you can cook a patch so that would be easier to apply? Otherwise I'll 
take care of it.
Before we can accept your code though you have to send a Code Contributor 
Statement, see:

https://wiki.documentfoundation.org/Development/Developers

If you plan to continue contributing to LibreOffice you may went to read this 
and setup your machine for being able to push to gerrit:

https://wiki.documentfoundation.org/Development/GetInvolved


After this you would get few other errors as

ERROR: Removing file ui-previewer from file list.
: ERROR: Removing file shell_scripts_gnome.filelist from file list.
: ERROR: Removing file shell_scripts_kde.filelist from file list.
: ERROR: Removing file shell_scripts.filelist from file list.

Since you don't need these in headless so delete these entries from
"workdir/InstallScriptTarget/setup_osl.ins"
similar to
http://libreoffice-bugs.freedesktop.narkive.com/kFp7vjv9/bug-78857-new-error-source-for-bsh-jar-not-found-when-building-with-java-no


Will take a look at that, thanks!

--
Riccardo Magliocchetti
@rmistaken
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Linking error in headless(--without-x) build

2015-06-16 Thread Abhimanyu Singh
= SOLVED =

I was able to fix it myself.

For fixing linking error you need to edit "vcl/Library_vcl.mk"

==Before=
ifeq ($(ENABLE_HEADLESS),TRUE)
$(eval $(call gb_Library_add_exception_objects,vcl,\
$(vcl_generic_code) \
vcl/unx/generic/printer/jobdata \
vcl/unx/generic/printer/ppdparser \
vcl/null/printerinfomanager \
vcl/headless/headlessinst \
))

$(eval $(call gb_Library_use_externals,vcl,\
fontconfig \
freetype \
))
endif
==

=== After 
ifeq ($(ENABLE_HEADLESS),TRUE)
$(eval $(call gb_Library_add_exception_objects,vcl,\
$(vcl_generic_code) \
vcl/unx/generic/printer/jobdata \
vcl/unx/generic/printer/ppdparser \
vcl/null/printerinfomanager \
vcl/headless/headlessinst \
$(vcl_headless_code) \
$(vcl_headless_freetype_code) \
))

$(eval $(call gb_Library_use_libraries,vcl,\
basebmp \
))

$(eval $(call gb_Library_use_externals,vcl,\
fontconfig \
freetype \
))
endif

==

You also need to add "basebmp" entry because later you would get linking
error again because "vcl/headless/svpbmp.cxx" is using "basebmp".


After this you would get few other errors as

ERROR: Removing file ui-previewer from file list.
: ERROR: Removing file shell_scripts_gnome.filelist from file list.
: ERROR: Removing file shell_scripts_kde.filelist from file list.
: ERROR: Removing file shell_scripts.filelist from file list.

Since you don't need these in headless so delete these entries from
"workdir/InstallScriptTarget/setup_osl.ins"
similar to
http://libreoffice-bugs.freedesktop.narkive.com/kFp7vjv9/bug-78857-new-error-source-for-bsh-jar-not-found-when-building-with-java-no

Thanks


On 16 June 2015 at 22:30, Abhimanyu Singh  wrote:

> I can build libreoffice(latest code) completely without any error but when
> I tried to build it in headless mode as mentioned here
> https://wiki.documentfoundation.org/Development/HeadlessBuild
>
> I am getting linking error for "headlessinst.o" as
>
> usr/local/home/abhimanyusingh/Documents/libreoffice_headless/core/workdir/CxxObject/vcl/headless/headlessinst.o:
> In function `HeadlessSalInstance::~HeadlessSalInstance()':
> headlessinst.cxx:(.text+0x4f): undefined reference to
> `SvpSalInstance::~SvpSalInstance()'
>
>
> What I found surprising that in directory
> "workdir/CxxObject/vcl/headless/" only "headlessinst.o" file is there.
> There is no file as "svpinst.o" for "svpinst.cxx" which contains definition
> of "SvpSalInstance".
>
>
> FYI for full build(without headless option) directory
> "workdir/CxxObject/vcl/headless/" contains "svpinst.o" . It is having issue
> only in --without-x build.
>
>
> Any help on this would be really great.
>
> Thanks
>
> complete log:-
>
> usr/local/home/abhimanyusingh/Documents/libreoffice_headless/core/workdir/CxxObject/vcl/headless/headlessinst.o:
> In function `HeadlessSalInstance::~HeadlessSalInstance()':
> headlessinst.cxx:(.text+0x4f): undefined reference to
> `SvpSalInstance::~SvpSalInstance()'
> /usr/local/home/abhimanyusingh/Documents/libreoffice_headless/core/workdir/CxxObject/vcl/headless/headlessinst.o:
> In function `HeadlessSalInstance::HeadlessSalInstance(SalYieldMutex*)':
> headlessinst.cxx:(.text+0xb5): undefined reference to
> `SvpSalInstance::SvpSalInstance(SalYieldMutex*)'
> /usr/local/home/abhimanyusingh/Documents/libreoffice_headless/core/workdir/CxxObject/vcl/headless/headlessinst.o:
> In function `CreateSalInstance()':
> headlessinst.cxx:(.text+0x31f): undefined reference to
> `SvpSalInstance::SvpSalInstance(SalYieldMutex*)'
> /usr/local/home/abhimanyusingh/Documents/libreoffice_headless/core/workdir/CxxObject/vcl/headless/headlessinst.o:
> In function `HeadlessSalInstance::~HeadlessSalInstance()':
> headlessinst.cxx:(.text+0x3b): undefined reference to
> `SvpSalInstance::~SvpSalInstance()'
> /usr/local/home/abhimanyusingh/Documents/libreoffice_headless/core/workdir/CxxObject/vcl/headless/headlessinst.o:
> In function `HeadlessSalSystem::~HeadlessSalSystem()':
> headlessinst.cxx:(.text._ZN17HeadlessSalSystemD2Ev[_ZN17HeadlessSalSystemD5Ev]+0xb):
> undefined reference to `SvpSalSystem::~SvpSalSystem()'
> /usr/local/home/abhimanyusingh/Documents/libreoffice_headless/core/workdir/CxxObject/vcl/headless/headlessinst.o:
> In function `HeadlessSalSystem::~HeadlessSalSystem()':
> headlessinst.cxx:(.text._ZN17HeadlessSalSystemD0Ev[_ZN17HeadlessSalSystemD0Ev]+0xf):
> undefined reference to `SvpSalSystem::~SvpSalSystem()'
> /usr/local/home/abhimanyusingh/Documents/libreoffice_headless/core/workdir/CxxObject/vcl/headless/headlessinst.o:(.data.rel.ro._ZTI19HeadlessSalInstance[_ZTI19HeadlessSalInstance]+0x10):
> undefined reference to `typeinfo for SvpSalInstance'
> /usr/local/home/abhimanyusingh/Documents/libreoffice_headless/core/workdir/CxxObject/vcl/headless/headlessinst.o:(.data.rel.ro._ZTI17HeadlessSalSystem[_ZTI17HeadlessSalSystem]+0x10):
> undefined reference to `typein