Re: Personas in LibreOffice
Hi Machanch, Michael Meeks píše v Pá 08. 03. 2013 v 10:01 +: > > I have just install a persona into LibreOffce.. It happens to be a dark > > image. This has obscure the menus which are in dark text so they are not > > visable. > > As Robinson points out - this is a known issue; this is the developers > list however - so I assume you'll want some code pointers for fixing > it ? :-) > > If so - the colors come from: > > vcl/inc/vcl/settings.hxx (StyleSettings) > > the persona dialog is here: > > cui/source/options/personalization.cxx > > I guess it'd be worth un-tangling how the personas are read - and (as a > first cut) just clobbering the colours when a persona is parsed. Just to be more specific - you want to update static void setupPersonaHeaderFooter() in vcl/source/app/settings.cxx to update maMenuBarTextColor too. The color is available in aPersonaSettings as the next token after the footer bitmap. I've turned the bug into an Easy Hack, and added the instructions here: https://bugs.freedesktop.org/show_bug.cgi?id=60542#c8 All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Personas in LibreOffice
Hi Machanch, On Thu, 2013-03-07 at 17:33 -0800, machanch wrote: > I have just install a persona into LibreOffce.. It happens to be a dark > image. This has obscure the menus which are in dark text so they are not > visable. As Robinson points out - this is a known issue; this is the developers list however - so I assume you'll want some code pointers for fixing it ? :-) If so - the colors come from: vcl/inc/vcl/settings.hxx (StyleSettings) the persona dialog is here: cui/source/options/personalization.cxx I guess it'd be worth un-tangling how the personas are read - and (as a first cut) just clobbering the colours when a persona is parsed. ATB, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Personas in LibreOffice
On Thu, Mar 7, 2013 at 8:33 PM, machanch wrote: > I have just install a persona into LibreOffce.. It happens to be a dark > image. This has obscure the menus which are in dark text so they are not > visable. > > This issue is not seen in firefox.. the text color changes to ensure it is > always visible.. > Has anyone seen this and address it here before. fdo#60542 - Color of menu items does not update to match personas - NEW https://bugs.freedesktop.org/show_bug.cgi?id=60542 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Personas in LibreOffice
I have just install a persona into LibreOffce.. It happens to be a dark image. This has obscure the menus which are in dark text so they are not visable. This issue is not seen in firefox.. the text color changes to ensure it is always visible.. Has anyone seen this and address it here before. -- View this message in context: http://nabble.documentfoundation.org/Personas-in-LibreOffice-tp4022898p4042358.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Personas in LibreOffice
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Astron, all Em 14-12-2012 14:53, Stefan Knorr (Astron) escreveu: > Sorry to rain on the parade here .. but is there some good reason why > we need this feature? That was, very likely, the same question people at Mozilla asked when they saw it beeing cooked for FFox... but then, a few month after release, they got tens of thousands of Personas. Many users like to put fancy ringtones in their mobiles, and we all know people put ringtones not for themselves but for *you/we/us/they* to "listen how fancy is my ringtone, dude!". Admitedly, this Personas stuff won't add a bit in performance or solve any MAB, but if correctly worked by our MarCom at release time, it will make a hit in terms of branding, not to make sure we look prettier than others (includes Microsoft) not to say that we may hear some rumbling drums around the teepees. And at the same time I am +1 to replace the tedious, tasteless application background (grey shade) by a user-choice bitmap... Full personalization is a trend I believe people want for their personal stuff. They want to convey a message to their social environment. Kind regards - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany Fundação responsável civilmente, de acordo com o direito civil Detalhes Legais: http://www.documentfoundation.org/imprint LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJQy6OAAAoJEJp3R7nH3vLxWjkH/jrLNF2SinYSsFfOAY/51yHF XIToSniiDWnPgMn6GG/3dkMnT5COXWL9EPptC8z8xayImzZ0IxxyaEoH6nRaWbfp YMS7FDXSh2aOqDtJn8Tc8Q9l6664LX8hVvxbk08aROqOJcOGCBTgMTGRx3APAyyN TmZfLEVZVcZWXdpEPFnZJxPuecx3ogrVWeaEAelk2ifoXasjiYmCvqcXGa+QJ5cT dZzwkSfDbCYkU0MGsOdrbzfdPOEd1+v1Ie9tZXalXmk8oiyT07uam84UAy8ZVF4Y xIbyjbihCcXrzmhPnb5xk0QCwEdVvuaPkKG9DXx9xa4M5inVwLw2HeZpAEOzPzk= =8rAi -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Personas in LibreOffice
On 12/14/2012 05:21 PM, Jan Holesovsky wrote: Hi all, Is there some reason why this then appears in the Linux version of my master build and does absolutely nothing ? From that I mean, that if I select a background image, e.g. jpg, then nothing happens and the dialog just cycles (repeated select/enter/no effect/display dialog, until I cancel it ? Is there some limit to the size of the image one can use, or is it not supposed to work on Linux at all ? And if the latter, why do we have access to it on Linux ? Or have I totally misunderstood what this is about ? Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Personas in LibreOffice
Sorry, really have no business in this thread, but I just couldnt resist... Why not 'best of both worlds' ? Allow user persona's, and improve the default look ? you could even do a contest, where the best user persona wins to be the new default look ? just my 2 $ Well, shutting up now again... - John Smith. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Personas in LibreOffice
Hi Astron, Stefan Knorr (Astron) píše v Pá 14. 12. 2012 v 17:53 +0100: > > So far this is still not finished, and I am fighting to have some time > > to finish that for Beta 2, and for late feature approval ;-) - so it > > still may happen that I'll need to just disable that code in 4.0, even > > though I'd love to finish that - I am close. > > > > The reason why it is Windows-only so far is that we do much more theming > > of the menu and toolbars ourselves on Windows, so we can better control > > there what is going on; so want to go the safe way, and do it > > Windows-only first, then extend to Linux too. > > Sorry to rain on the parade here .. but is there some good reason why > we need this feature? In the first place - sorry for my poor communication of this :-( I should have poked UX-advise in advance that I am poking this. There are actually 3 reasons: people love using their personalized pictures for backgrounds - I can see it everywhere. Photos of kids on the screens of mobile phones, desktop backgrounds etc. The other reason is that this has even enterprise use - I have a real customer who is unhappy with the look of the background behind the menu + toolbar. It is much easier to provide them with a way to tweak that than trying to find out a balance between their needs and needs of other customers - you will never do everyone happy. And the last thing - should you decide to change the background under the menu + toolbars, it will be as easy as drawing a new bitmap, instead of having to programaticaly change the look, which is not that fun with GDI functions :-) > If people are unhappy with how LibreOffice looks, we should probably > tweak the platform specific look until it is better. And from looking > at screenshots from Mac OS (and to a much lesser extent, working with > Windows), I do understand why people would say that. Unfortunately, eg. on Windows there is no real standard that would look good :-( > The thing is, those problems won't be solved at all when we allow > people to put pictures of their cats in the application background. In > fact, that will make matters for the most part. (I haven't yet seen > the feature working so far... But even Firefox's implementation of it > which tries to make sure everything stays usable does not guarantee > readable results.) Yes - people will be able to set something that it will do the app unusable; but hard to blame us for that, I think. Again - sorry for not communicating this in advance. All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Personas in LibreOffice
Hi Kendy, On 14 December 2012 17:21, Jan Holesovsky wrote: > So far this is still not finished, and I am fighting to have some time > to finish that for Beta 2, and for late feature approval ;-) - so it > still may happen that I'll need to just disable that code in 4.0, even > though I'd love to finish that - I am close. > > The reason why it is Windows-only so far is that we do much more theming > of the menu and toolbars ourselves on Windows, so we can better control > there what is going on; so want to go the safe way, and do it > Windows-only first, then extend to Linux too. Sorry to rain on the parade here .. but is there some good reason why we need this feature? If people are unhappy with how LibreOffice looks, we should probably tweak the platform specific look until it is better. And from looking at screenshots from Mac OS (and to a much lesser extent, working with Windows), I do understand why people would say that. The thing is, those problems won't be solved at all when we allow people to put pictures of their cats in the application background. In fact, that will make matters for the most part. (I haven't yet seen the feature working so far... But even Firefox's implementation of it which tries to make sure everything stays usable does not guarantee readable results.) Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Personas in LibreOffice
Hi Marcos, Marcos Souza píše v Čt 06. 12. 2012 v 09:57 -0200: > After take a look in some commits in LO about the FFox Personas, I saw > that this is only for Windows until now... > > There is a reason for that? > > There is something that we can do for extend this for Linux users? So far this is still not finished, and I am fighting to have some time to finish that for Beta 2, and for late feature approval ;-) - so it still may happen that I'll need to just disable that code in 4.0, even though I'd love to finish that - I am close. The reason why it is Windows-only so far is that we do much more theming of the menu and toolbars ourselves on Windows, so we can better control there what is going on; so want to go the safe way, and do it Windows-only first, then extend to Linux too. All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
