Re: testVerticallyMergedCellBorder failing on some systems
On 12.7.2021 14.24, Miklos Vajna wrote: On Mon, Jul 12, 2021 at 01:56:45PM +0300, Ilmari Lauhakangas wrote: Here is how it looks like for me on Linux: https://postimg.cc/2bN6WFfS Same result with 7.1.4 as well. Yes, that's perfect. I assume it doesn't look like this on a system where the test fails. Table seems to shift outside the left margin. That's a feature. The markup in the docx file declares that the first paragraph and the paragraph in the A1 cell has the same left position, which requires this. After discussing on IRC with Miklos I created this patch to increase the tolerance: https://gerrit.libreoffice.org/c/core/+/118778 My mentee can run full make check now without any patches, so apparently the result was wobbly. Ilmari ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: testVerticallyMergedCellBorder failing on some systems
Hi Ilmari, On Mon, Jul 12, 2021 at 01:56:45PM +0300, Ilmari Lauhakangas wrote: > Here is how it looks like for me on Linux: https://postimg.cc/2bN6WFfS > > Same result with 7.1.4 as well. Yes, that's perfect. I assume it doesn't look like this on a system where the test fails. > Table seems to shift outside the left margin. That's a feature. The markup in the docx file declares that the first paragraph and the paragraph in the A1 cell has the same left position, which requires this. Regards, Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: testVerticallyMergedCellBorder failing on some systems
On 12.7.2021 10.30, Miklos Vajna wrote: On Sat, Jul 10, 2021 at 10:00:31AM +0300, Ilmari Lauhakangas wrote: It was added in https://git.libreoffice.org/core/commit/66ac8e60896f6306bed8fbb34606fd14474f19ce On Windows the failure was C:/cygwin/home/user/lode/dev/core/sw/qa/core/layout/layout.cxx:493:testVerticallyMergedCellBorder::TestBody assertion failed - Expression: bFound - Bad vertical position for border point: 4594 Expected positions: 3022, 3540, 4059, 4578 Can you manually load the document and see how the borders look like? https://vmiklos.hu/blog/sw-merged-border.html has reference/old/new render results, hopefully the intention is quite clear. Here is how it looks like for me on Linux: https://postimg.cc/2bN6WFfS Same result with 7.1.4 as well. Table seems to shift outside the left margin. Ilmari ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: testVerticallyMergedCellBorder failing on some systems
Hi Ilmari, On Sat, Jul 10, 2021 at 10:00:31AM +0300, Ilmari Lauhakangas wrote: > It was added in > https://git.libreoffice.org/core/commit/66ac8e60896f6306bed8fbb34606fd14474f19ce > > On Windows the failure was > > C:/cygwin/home/user/lode/dev/core/sw/qa/core/layout/layout.cxx:493:testVerticallyMergedCellBorder::TestBody > assertion failed > - Expression: bFound > - Bad vertical position for border point: 4594 Expected positions: 3022, > 3540, 4059, 4578 Can you manually load the document and see how the borders look like? https://vmiklos.hu/blog/sw-merged-border.html has reference/old/new render results, hopefully the intention is quite clear. Regards, Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
