Re: Tinderbox@42 test failures

2018-05-20 Thread Thorsten Behrens
Khaled Hosny wrote:
> Here is a revert of the only commit that looks relevant
> https://gerrit.libreoffice.org/#/c/54567/, no idea if it will fix it.
> 
Yep, a local cherry-pick of that one solves the issue. I'm running a
3rd build now to be extra-sure & then merge the patch.

Cheers,

-- Thorsten
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Tinderbox@42 test failures

2018-05-20 Thread Luke Benes
The SdOOXMLExportTest2::testFontScale issue is hard to track down because it's 
an intermittent failure. I first thought it was related to Windows display 
scaling settings as I saw some correlation in my testing.  However, now I think 
it's related to the build type.  At first, I could only reproduce this issue on 
1/3 of my Win 10 boxes. However, after I changed the release type from DEBUG to 
RELEASE, I could reproduce it  on all 3.

Thorsten,
Is @42 also a release build?

Khaled,
It takes 5-10 builds to reproduce this failure, so it will take some time to 
see if your patch helped.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Tinderbox@42 test failures

2018-05-19 Thread Khaled Hosny
On Thu, May 17, 2018 at 11:27:07PM +0200, t...@libreoffice.org wrote:
> Hi Luke, hi Khaled,
> 
> the Win@42 box seems to be unhappy since Sunday, with the following
> error:
> 
> D:/lode/dev/core/test/source/diff/diff.cxx(268) : error : Assertion
> Test name: SdImportTest::testDocumentLayout
> double equality assertion failed
> - Expected: 610
> - Actual  : -237
> - Delta   : 1e-08
> - Reference: D:/lode/dev/core/sd/qa/unit/data/xml/n758621_1.xml
> - Node: /XShapes/XShape[1]
> - Attr: positionY
> 
> Which appears to correlate with this commits:
> 
> e8d48dd75a1b  Fixup 23c5125148a8110d88385b29570bf0b7d4400458
> ab03a09745fe  Add more more dependencies to VCL makefiles
> 4ad07c563e50  Make SalLayout overrides final

Here is a revert of the only commit that looks relevant
https://gerrit.libreoffice.org/#/c/54567/, no idea if it will fix it.

Regards,
Khaled


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Tinderbox@42 test failures

2018-05-17 Thread thb
Hi Luke, hi Khaled,

the Win@42 box seems to be unhappy since Sunday, with the following
error:

D:/lode/dev/core/test/source/diff/diff.cxx(268) : error : Assertion
Test name: SdImportTest::testDocumentLayout
double equality assertion failed
- Expected: 610
- Actual  : -237
- Delta   : 1e-08
- Reference: D:/lode/dev/core/sd/qa/unit/data/xml/n758621_1.xml
- Node: /XShapes/XShape[1]
- Attr: positionY

Which appears to correlate with this commits:

e8d48dd75a1b  Fixup 23c5125148a8110d88385b29570bf0b7d4400458
ab03a09745fe  Add more more dependencies to VCL makefiles
4ad07c563e50  Make SalLayout overrides final

I've rebooted the box for good measure, no luck. Beyond that - Luke
had _some_ success reproducing layout issues, it seems to correlate
with Windows UI scaling. Note that the box is headless, and the
rdesktop default screen size is 800x600. Hope that rings any bell; any
further input (logs, trying some local patch, remote acces) - please
poke me!

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice