calling order of sw/source/filter/ww8/attributeoutputbase callbacks

2013-01-30 Thread Nicolas Boulenguez
Hello.

In class sw/source/filter/ww8/docxattributeoutput.hxx or its parent
sw/source/filter/ww8/attributeoutputbase.hxx, the possible orders in
which the EndURL, RunText, EndRun (and probably StartURL) callbacks
may be executed when exporting an hyperlink is not explicit. This has
already caused at least four bugs: 47669, 52610, 53175 and 55820.

Docs.libreoffice.org only confirms what the names suggest:
* StartURL() and EndURL() are called in this order by
  SwWW8AttrIter::OutAttrWithRange() and
  MSWord_SdrAttrIter::OutEEField()
* RunText() and EndRun() are called in this order by
  MSWordExportBase::OutputTextNode.

Could someone tell me what can be asserted about the calling order, or
give me a link to some documentation?

(I am not subscribed to this list)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: calling order of sw/source/filter/ww8/attributeoutputbase callbacks

2013-01-30 Thread Cedric Bosdonnat
Bonjour Nicolas,

On Wed, 2013-01-30 at 19:56 +0100, Nicolas Boulenguez wrote:
> In class sw/source/filter/ww8/docxattributeoutput.hxx or its parent
> sw/source/filter/ww8/attributeoutputbase.hxx, the possible orders in
> which the EndURL, RunText, EndRun (and probably StartURL) callbacks
> may be executed when exporting an hyperlink is not explicit. This has
> already caused at least four bugs: 47669, 52610, 53175 and 55820.

It seems pretty tricky to get all these bugs properly fixed.

> Docs.libreoffice.org only confirms what the names suggest:
> * StartURL() and EndURL() are called in this order by
>   SwWW8AttrIter::OutAttrWithRange() and
>   MSWord_SdrAttrIter::OutEEField()
> * RunText() and EndRun() are called in this order by
>   MSWordExportBase::OutputTextNode.
> 
> Could someone tell me what can be asserted about the calling order, or
> give me a link to some documentation?

The only documentation to help you are the doc / RTF and OOXML
specifications (available on the MSDN library).

> (I am not subscribed to this list)

There is no need to subscribe :)

--
Cedric

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: calling order of sw/source/filter/ww8/attributeoutputbase callbacks

2013-02-02 Thread Jan Holesovsky
Hi Nicolas,

Nicolas Boulenguez píše v St 30. 01. 2013 v 19:56 +0100:

> In class sw/source/filter/ww8/docxattributeoutput.hxx or its parent
> sw/source/filter/ww8/attributeoutputbase.hxx, the possible orders in
> which the EndURL, RunText, EndRun (and probably StartURL) callbacks
> may be executed when exporting an hyperlink is not explicit. This has
> already caused at least four bugs: 47669, 52610, 53175 and 55820.
> 
> Docs.libreoffice.org only confirms what the names suggest:
> * StartURL() and EndURL() are called in this order by
>   SwWW8AttrIter::OutAttrWithRange() and
>   MSWord_SdrAttrIter::OutEEField()
> * RunText() and EndRun() are called in this order by
>   MSWordExportBase::OutputTextNode.
> 
> Could someone tell me what can be asserted about the calling order, or
> give me a link to some documentation?

Do you mean documentation about the DOCX export as we have it in the
code, or about the fileformat in general, please?

If you mean the former - I tried to document as much as possible when
splitting the original .doc exporter into its .doc and .docx parts, like
here:

http://docs.libreoffice.org/sw/html/classDocxAttributeOutput.html

but to learn details about the calling order of various things, the best
is just to read the sources.

Do you have a case in mind that you'd like to fix?  Or are you just
interested in helping improving the DOCX export in general? - in that
case it would be awesome to improve our DOCX export test coverage by
slowly copying the import tests to the import/export tests + fix
whatever is not preserved during the roundtrip :-)

All the best,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice