Re: coverity warnings update, < 200
Caolan McNamara wrote: > I reckon practically all the "swapped arguments" are ok except maybe for > 1242508. (caolanm->quikee: in 1b23e46051d8cc7c01fd8b4d0ea51bfec145db8e > there is.. > - pWriteAcc->SetPixel( i, x, aResultColor ); > + pWriteAcc->SetPixel( x, y, aResultColor ); > and SetPixel takes args named x, y. so are those arguments definitely > not the wrong way around or is it actually a real detected problem?) > Aye. But SetPixel arg ordering is just being totally silly. Fix pushed though. Cheers, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: coverity warnings update, < 200
Hi Caolán, On Thursday, 2014-10-30 16:03:53 +, Caolán McNamara wrote: > Nearly all the other "swapped arguments" are around column/rows possibly > being swapped, especially in calc, e.g. a lot of them are like 1242513 > bChartRowAsHdr passed to bCol on line 3176 > ScCellRangesBase::setRowDescriptions. I assume those are ok ? Yes, a row as headers means the cells are column headers, I set those to Intentional with a comment. > There are also 4 remaining (from originally 1842) "uninitialized members > in ctors", all from calc, where there are quite a few members and only > some of them get initialized directly in the ctor. It'd be good to get > someone from calc to have a once-over on those and see if they are > intentionally uninitialized for e.g. performance reasons. Fixed two (actually for unused cases, but..), Intentional one, and investigating the last one about RowInfo/FillInfo. Also grabbed a few of the remaining others. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Care about Free Software, support the FSFE https://fsfe.org/support/?erack pgpDUOHygdbc7.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
coverity warnings update, < 200
So, we now have < 200 non-(intentional/false positive) warnings remaining in coverity from an original count of approx 11 thousand or thereabouts. the biggest remaining categories are... 50 "Tainted scalars" 23 "Uncaught exceptions" 19 "Unchecked returns" 19 "divide by zeros" 14 "Swapped arguments" and a handful in a bunch of various other categories. I reckon practically all the "swapped arguments" are ok except maybe for 1242508. (caolanm->quikee: in 1b23e46051d8cc7c01fd8b4d0ea51bfec145db8e there is.. - pWriteAcc->SetPixel( i, x, aResultColor ); + pWriteAcc->SetPixel( x, y, aResultColor ); and SetPixel takes args named x, y. so are those arguments definitely not the wrong way around or is it actually a real detected problem?) Nearly all the other "swapped arguments" are around column/rows possibly being swapped, especially in calc, e.g. a lot of them are like 1242513 bChartRowAsHdr passed to bCol on line 3176 ScCellRangesBase::setRowDescriptions. I assume those are ok ? There are also 4 remaining (from originally 1842) "uninitialized members in ctors", all from calc, where there are quite a few members and only some of them get initialized directly in the ctor. It'd be good to get someone from calc to have a once-over on those and see if they are intentionally uninitialized for e.g. performance reasons. So in general, we have only a very small count of remaining warnings to be decided about one way or the other, logging into coverity and choosing "outstanding defects" and sorting by file and having a quick scan through whatever modules you consider "yours" especially for "swapped arguments" and "unchecked returns" to see if any of them need fixing or can be dismissed as "intentional". FWIW coverity "Unchecked returns" can be silenced in code with foo() -> (void)foo() as is typical for some compilers' similar compile-time warnings. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
