Re: list.cxx in VCL
I have changed my mind, and gone ahead and submitted the patch to Gerrit. I'd be very interested in your and anyone else's feedback regarding the approach. It compiles fine, but I still need to figure out how to test it. I also still have reservations about mixing C++ and C memory allocation. Thanks, Chris -- View this message in context: http://nabble.documentfoundation.org/list-cxx-in-VCL-tp4109073p4119395.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: list.cxx in VCL
On Fri, 2014-05-16 at 10:46 -0700, Chris Laplante wrote: Would it be possible to remove vcl/source/fontsubset/list.cxx and replace its usage with std::list? The only place I see it being used is in ttcr.cxx (same folder). Looks like it should be reasonably straightforward to do that. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: list.cxx in VCL
I took a crack at it, but it resulted in too much mixing of C and C++ style memory allocation, which I'm not comfortable intermingling. The overwhelming majority of the original is implemented in C anyway, so I'm not sure it's worth me replacing just one facet of the code with C++. Perhaps one day if I build up the courage I can rewrite the entire thing in C++, if the community thought it would useful for the long-term. Chris -- View this message in context: http://nabble.documentfoundation.org/list-cxx-in-VCL-tp4109073p4109188.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
list.cxx in VCL
Would it be possible to remove vcl/source/fontsubset/list.cxx and replace its usage with std::list? The only place I see it being used is in ttcr.cxx (same folder). It is hard to tell because most of the files in that directory appear to be C code hiding in .cxx files. Chris -- View this message in context: http://nabble.documentfoundation.org/list-cxx-in-VCL-tp4109073.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
