Re: per library debug builds now possible via ./configure
On Friday 20 of April 2012, Lubos Lunak wrote: On Monday 16 of April 2012, Bjoern Michaelsen wrote: On Mon, Apr 16, 2012 at 01:50:00PM +0200, Lubos Lunak wrote: Is it possible to do the build also the other way around, i.e. e.g. all but sc? Not yet, feel free to add it if you think it is essential. ... and if I understand the change correctly, I'd have to manually find out what all the dependencies actually are. Given that sc/sd/sw are the biggest three, it probably even makes the biggest difference to disable the two that one does not work on. ALLBUTSCSW=`find . -name Library*.mk| sed -e 's/^.*Library_//' -e 's/.mk$//'|grep -v sc |grep -v sw` ./autogen.sh --enable-debug=$ALLBUTSCSW should be enough. How about this? Pushed. Short version for whoever has already started to use this: Prepend Library_ to every item you pass to --enable-debug, or simply use directory names with / appended, and pass it to --enable-symbols instead. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: per library debug builds now possible via ./configure
On Monday 16 of April 2012, Bjoern Michaelsen wrote: On Mon, Apr 16, 2012 at 01:50:00PM +0200, Lubos Lunak wrote: Is it possible to do the build also the other way around, i.e. e.g. all but sc? Not yet, feel free to add it if you think it is essential. ... and if I understand the change correctly, I'd have to manually find out what all the dependencies actually are. Given that sc/sd/sw are the biggest three, it probably even makes the biggest difference to disable the two that one does not work on. ALLBUTSCSW=`find . -name Library*.mk| sed -e 's/^.*Library_//' -e 's/.mk$//'|grep -v sc |grep -v sw` ./autogen.sh --enable-debug=$ALLBUTSCSW should be enough. How about this? -- Lubos Lunak l.lu...@suse.cz From 6987137582e0ac5d5bf642054f008635bfbacfae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= l.lu...@suse.cz Date: Fri, 20 Apr 2012 12:13:24 +0200 Subject: [PATCH 2/6] fixes for debug flags handling - move using optimization, symbols (i.e. debug) and environment cflags/cxxflags into one place - --enable-dbgutils is independent from --enable-debug, and thus also --enable-symbols, so it should not set debuglevel - setting -g flag is controlled by --enable-symbols, not --enable-debug, so it should be used also for selective -g enabling - setting debug flags depending on debuglevel being 2 is certainly wrong - do not let environment cflags/cxxflags disable optimization/symbols flags completely, if one wants, it's possible to explicitly specify e.g. -g0, but the current way does not make it easily possible to specify e.g. -fcolor-diagnostics - do not set debug flag globally now that it can be done selectively --- config_host.mk.in|2 +- configure.in | 35 ++- solenv/gbuild/LinkTarget.mk | 34 +++--- solenv/gbuild/gbuild.mk |2 -- solenv/gbuild/platform/unxgcc.mk |5 - 5 files changed, 34 insertions(+), 44 deletions(-) diff --git a/config_host.mk.in b/config_host.mk.in index fe5fc87..a3668d7 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -74,7 +74,6 @@ export DBUS_LIBS=@DBUS_LIBS@ export DB_CPPLIB=@DB_CPPLIB@ export DB_LIB=@DB_LIB@ export debug=@ENABLE_DEBUG@ -export ENABLE_DEBUG_ONLY=@ENABLE_DEBUG_ONLY@ export DEFAULT_MOZILLA_TOOLKIT=@MOZILLA_TOOLKIT@ export DEFAULT_TO_ENGLISH_FOR_PACKING=yes export DIAGRAM_EXTENSION_PACK=@DIAGRAM_EXTENSION_PACK@ @@ -136,6 +135,7 @@ export ENABLE_SCRIPTING_JAVASCRIPT=@ENABLE_SCRIPTING_JAVASCRIPT@ export ENABLE_SCRIPTING_PYTHON=@ENABLE_SCRIPTING_PYTHON@ export ENABLE_SILENT_MSI=@ENABLE_SILENT_MSI@ export ENABLE_SYMBOLS=@ENABLE_SYMBOLS@ +export ENABLE_SYMBOLS_ONLY=@ENABLE_SYMBOLS_ONLY@ export ENABLE_SYSTRAY_GTK=@ENABLE_SYSTRAY_GTK@ export ENABLE_XMLSEC=@ENABLE_XMLSEC@ export ENABLE_ZENITY=@ENABLE_ZENITY@ diff --git a/configure.in b/configure.in index c3847c1..054aebb 100644 --- a/configure.in +++ b/configure.in @@ -610,7 +610,10 @@ AC_ARG_ENABLE(atl, AC_ARG_ENABLE(symbols, AS_HELP_STRING([--enable-symbols], [Include debugging symbols in output. WARNING - a complete build needs - 8 Gb of space and takes much longer (enables -g compiler flag).]) + 8 Gb of space and takes much longer (enables -g compiler flag). + You can also use this switch as follows: + --enable-symbols=tl svx to enable symbols only for the specified + gbuild-build libraries.]) [ Enabling symbols disables the stripping of the solver (--disable-strip-solver). @@ -637,9 +640,7 @@ AC_ARG_ENABLE(debug, [Include debugging symbols from --enable-symbols plus extra debugging code. Extra large build! (enables -g compiler flag and dmake debug=true) If you need even more verbose output, build a module with - build -- debug=true dbglevel=2. You can also use this switch as follows: - --enable-debug=tl svx to enable debug only for the specified - gbuild-build libraries.])) + build -- debug=true dbglevel=2.])) AC_ARG_ENABLE(dbgutil, AS_HELP_STRING([--enable-dbgutil], @@ -3426,25 +3427,17 @@ else fi AC_SUBST(EXTERNAL_WARNINGS_NOT_ERRORS) -dnl Set the ENABLE_DEBUG variable. (Activate --enable-symbols) +dnl Set the ENABLE_DEBUG variable. dnl === AC_MSG_CHECKING([whether to do a debug build]) if test -n $enable_debug test $enable_debug != no; then -if test $enable_debug = y || test $enable_debug = yes; then -ENABLE_DEBUG=TRUE -ENABLE_DEBUG_ONLY= -else -ENABLE_DEBUG= -ENABLE_DEBUG_ONLY=$enable_debug -AC_MSG_RESULT([for $enable_debug]) -fi +ENABLE_DEBUG=TRUE +AC_MSG_RESULT([yes]) else ENABLE_DEBUG= -ENABLE_DEBUG_ONLY= AC_MSG_RESULT([no]) fi AC_SUBST(ENABLE_DEBUG)
Re: per library debug builds now possible via ./configure
On Friday 20 of April 2012, Lubos Lunak wrote: On Monday 16 of April 2012, Bjoern Michaelsen wrote: On Mon, Apr 16, 2012 at 01:50:00PM +0200, Lubos Lunak wrote: Is it possible to do the build also the other way around, i.e. e.g. all but sc? Not yet, feel free to add it if you think it is essential. ... and if I understand the change correctly, I'd have to manually find out what all the dependencies actually are. Given that sc/sd/sw are the biggest three, it probably even makes the biggest difference to disable the two that one does not work on. ALLBUTSCSW=`find . -name Library*.mk| sed -e 's/^.*Library_//' -e 's/.mk$//'|grep -v sc |grep -v sw` ./autogen.sh --enable-debug=$ALLBUTSCSW should be enough. How about this? And one more. -- Lubos Lunak l.lu...@suse.cz From 42ef01bdc3b1e08ef90dc0d05d1d978b2085a088 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= l.lu...@suse.cz Date: Fri, 20 Apr 2012 17:26:01 +0200 Subject: [PATCH] if debug symbols are enabled indirectly, make sure they are actually built --- solenv/gbuild/gbuild.mk |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk index 8e5141b..a37cb8b 100644 --- a/solenv/gbuild/gbuild.mk +++ b/solenv/gbuild/gbuild.mk @@ -105,6 +105,11 @@ endif endif ifneq ($(gb_DEBUGLEVEL),0) +# if symbols are triggered by something else than --enable-symbols, +# make sure they are actually enabled +ifneq ($(gb_SYMBOL),$(true)) +ENABLE_SYMBOLS_FOR = all +endif gb_SYMBOL := $(true) endif -- 1.7.7 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
per library debug builds now possible via ./configure
Hi, it should now be possible to build one (or more) libraries for debugging, while building the rest nondebug. Thanks for Tor giving the inspiration to this at the Hackfest! details: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ebed42c38ae91147633c47873307e07984bc62c1 Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: per library debug builds now possible via ./configure
On Monday 16 of April 2012, Bjoern Michaelsen wrote: Hi, it should now be possible to build one (or more) libraries for debugging, while building the rest nondebug. Thanks for Tor giving the inspiration to this at the Hackfest! Is it possible to do the build also the other way around, i.e. e.g. all but sc? If I work on something, I generally want to have also all its dependencies built with debug (does it even make sense to build it otherwise?), and if I understand the change correctly, I'd have to manually find out what all the dependencies actually are. Given that sc/sd/sw are the biggest three, it probably even makes the biggest difference to disable the two that one does not work on. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: per library debug builds now possible via ./configure
On Mon, Apr 16, 2012 at 01:50:00PM +0200, Lubos Lunak wrote: Is it possible to do the build also the other way around, i.e. e.g. all but sc? Not yet, feel free to add it if you think it is essential. If I work on something, I generally want to have also all its dependencies built with debug (does it even make sense to build it otherwise?), yes, it does. If you are in sw there are a lot of thinks that can be solved just in sw. If not, you recompile those libs. and if I understand the change correctly, I'd have to manually find out what all the dependencies actually are. Given that sc/sd/sw are the biggest three, it probably even makes the biggest difference to disable the two that one does not work on. ALLBUTSCSW=`find . -name Library*.mk| sed -e 's/^.*Library_//' -e 's/.mk$//'|grep -v sc |grep -v sw` ./autogen.sh --enable-debug=$ALLBUTSCSW should be enough. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
