removing unused functions
Hi folks, I'm currently working on removing unused functions (mentioned in unused.easy). Should I do it one by one with separate commits or in one big commit ? An big commit would make it easier/quicker for me (as I dont need so many rebuilds), but perhaps could make review a bit harder. cu -- Mit freundlichen Grüßen / Kind regards Enrico Weigelt VNC - Virtual Network Consult GmbH Head Of Development Pariser Platz 4a, D-10117 Berlin Tel.: +49 (30) 3464615-20 Fax: +49 (30) 3464615-59 enrico.weig...@vnc.biz; www.vnc.de ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: removing unused functions
On Thu, Nov 15, 2012 at 5:24 AM, Enrico Weigelt enrico.weig...@vnc.biz wrote: Hi folks, I'm currently working on removing unused functions (mentioned in unused.easy). Should I do it one by one with separate commits or in one big commit ? An big commit would make it easier/quicker for me (as I dont need so many rebuilds), but perhaps could make review a bit harder. and increase the odd that the patch would get rejected for removing something that _is_ really used (albeit not on linux) the unused.easy thing is parsing a linux build... so there may be some false positive there... SO I would suggest smaller patch (rebuilding should not be that painfull, if you stay on the same position on master and just do incremental build... Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: removing unused functions
Hi Enrico, On Thursday, 2012-11-15 12:24:08 +0100, Enrico Weigelt wrote: I'm currently working on removing unused functions (mentioned in unused.easy). Should I do it one by one with separate commits or in one big commit ? An big commit would make it easier/quicker for me (as I dont need so many rebuilds), but perhaps could make review a bit harder. Much preferred to split them up instead of having one large patch that's diffcult to review. Maybe a good chunk size would be per module patches. This also helps to find a reviewer who is familiar with the code in question. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD Support the FSFE, care about Free Software! https://fsfe.org/support/?erack pgpzjsdRpR4dG.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
