Re: [Libreoffice] UI disaster on Windows: soffice -h
Hi Andras Andras Timar wrote > > 1. Dialog is not localisable. Help text comes from const char arrays > in desktop/source/app/cmdlinehelp.cxx > 2. Help text is clipped, there is not enough room on the dialog. > 3. If I resized the dialog, it would not fit on a 1024x768 screen. > > I wonder, if we could fix this before UI freeze on Monday. I need your > input regarding how to present this information to users. > I would say disaster is a pretty strong word :) In fact if no one noticed or complained until now, it means it is a pretty obscure (though interesting and useful) feature. 1. Making it localisable and getting l10n for all available languages before Monday seems unrealistic. Which doesn't mean that it shouldn't be tackled ASAP 2. That is indeed annoying but adding l10n to that will only aggravate the problem :) 3. Actually I think LO should use as the minimum reference 1024x600 (the screen resolution of a 10" netbook) HTH, Pedro -- View this message in context: http://nabble.documentfoundation.org/UI-disaster-on-Windows-soffice-h-tp3641073p3641655.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] UI disaster on Windows: soffice -h
Hello Pedro, Andras, all, On Sun, Jan 8, 2012 at 16:35, Pedro wrote: > Andras Timar wrote >> I wonder, if we could fix this before UI freeze on Monday. I need your >> input regarding how to present this information to users. [snip] > 1. Making it localisable and getting l10n for all available languages before > Monday seems unrealistic. Which doesn't mean that it shouldn't be tackled > ASAP IMHO Andras' meaning is to make the string "localize-able", not to "localize" (translate) them, which the latter seems impossible before tomorrow :-) Then, after the string is localize-able, l10n people will translate them later, not necessary before Monday. If not translated, it will be default English string, IIUC. Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Cherry-pick in 3.5 (3.4 ?) for fdo#44065
Thank you Ivan, just pushed the fix on 3.5 branch. Julien. -- View this message in context: http://nabble.documentfoundation.org/REVIEW-Cherry-pick-in-3-5-3-4-for-fdo-44065-tp3640531p3641699.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Fix for pt-BR spelling dict project Reference URL
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Project VERO (pt-BR spelling dictionary) has migrated to LibreOffice infra. This patch updates description.xml for the extension that is bundled in LO 3.5 It should be chery-picked to 3.5 - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPCXXaAAoJEJp3R7nH3vLxhLIH/0wu+/ArVF/uDfVDumxnVMot gaGKtXtcmFxaNbpAOPbBSU0J6ADCV6uOanw6nMZPZ3sc6Q2Kf5YklmlkdhcJdUE8 2qUhWljZYBbKACWPZPEEooCow/ev9YFW/JywjpAPGO2eZkWVqw0026iI87qY+uag LmfpclLYUrsZJaekc6Eh1rvdvRUgK3y+WPcEo7doMv8e/8xHKVp7M3fKDcgvlbe0 UTj2B8ZqKZIGzkL7VNUo7IDVC/ugYt3Zz2OcSnWvzTDezKWn4uiYgZbnNN3frp42 A1mEQUniX9PZ1f4zRzhjRTYNG9PWiag7l5rqfXrcdxNMDjIRnoHj8v1ywS3+Wqs= =nP1O -END PGP SIGNATURE- >From 4308fdc134dc3cdebdbe6df8648953b3cb152b59 Mon Sep 17 00:00:00 2001 From: Olivier Hallot Date: Sun, 8 Jan 2012 08:26:10 -0200 Subject: [PATCH] Fix URL for pt-BR spelling dictionary reference page This patch fixes the URL for VERO - pt-BR community spelling dictionary project page --- dictionaries/pt_BR/description.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dictionaries/pt_BR/description.xml b/dictionaries/pt_BR/description.xml index 01b1a46..9a09b45 100644 --- a/dictionaries/pt_BR/description.xml +++ b/dictionaries/pt_BR/description.xml @@ -10,6 +10,6 @@ -http://www.broffice.org/verortografico"; lang="pt-BR">Vero +http://pt-br.libreoffice.org/projetos/projeto-vero-verificador-ortografico"; lang="pt-BR">VERO -- 1.7.5.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] About cppcheck 2 reports for desktop/unx/source/file_image_unx.c
Hello, For the file desktop/unx/source/file_image_unx.c, cppcheck tells : 120 duplicateExpression style Same expression on both sides of '-'. 93 unreadVariable style Variable 'c' is assigned a value that is never used line 93 is : volatile char c = 0 Should this variable just be removed or c should be used in a way ? line 120 is : w.m_size -= w.m_size; Either this is right and it could be simplified with w.m_size = 0 or it's wrong and what should it be ? (this time no overload operator trick since it's plain C :-) ) For both of them, if there's a easy fix, I suppose I may commit/push it on master, but on branch 3.5 too ? Julien -- View this message in context: http://nabble.documentfoundation.org/About-cppcheck-2-reports-for-desktop-unx-source-file-image-unx-c-tp3641757p3641757.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Fix for pt-BR spelling dict project Reference URL
2012/1/8 Andras Timar : > Hi Olivier, > > 2012/1/8 Olivier Hallot : >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Hi >> >> Project VERO (pt-BR spelling dictionary) has migrated to LibreOffice >> infra. This patch updates description.xml for the extension that is >> bundled in LO 3.5 >> >> It should be chery-picked to 3.5 >> > > Done, many thanks. > Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Newbie question: git push
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi This is a newbie question: I have commit A and commit B, with A and B totally independent, and A was committed before B in my local copy. I want to push B to the repository. How can it be done? Thanks - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPCYeLAAoJEJp3R7nH3vLxVLwH/RywdBxEuaa7WqY2Fho4avqV IGVLohZKLuDKEyTiG/llnUC/jkhGs+JoD4miQmNsPH933ZWQN+tgtDxiU2HYPRUl NIKzrsqjW08yh5+tWdszdwdeSV6g1uSZQV4OiSlp4ID6YFV1lwjPJSJlb0eXnXBX 0YuDov7hrX7ZWKhV3e+anz4CWSnVEYE2py0BhWQqR39Hk0w6gGeIOXBjlqN68eoh 4zO1cpce+7tNNBRhwSFG+38j0y6e5YDgc7HPpYhqyY6XnQq3QJ65V4sxOStm+5Wr WbjyUNaXj7CU2OjFpf5AZxcaqhIjRun7Hp3Iq7GGcmWsdDRfEQQYfyQVN186ss4= =d2wH -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Newbie question: git push
Hello Olivier, I never did this but found this : http://stackoverflow.com/questions/3230074/git-pushing-specific-commit (in http://groups.google.com/group/git-users/browse_thread/thread/e20536c0f222d97a too) so : git push : Hope it helps. Julien -- View this message in context: http://nabble.documentfoundation.org/Newbie-question-git-push-tp3641809p3641830.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Newbie question: git push
On 8 January 2012 13:21, julien2412 wrote: > Hello Olivier, > > I never did this but found this : > http://stackoverflow.com/questions/3230074/git-pushing-specific-commit (in > http://groups.google.com/group/git-users/browse_thread/thread/e20536c0f222d97a > too) so : > git push : I think this will push all commits up to commit SHA, that means also A from previous mail, so it's the same as plain git push. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Newbie question: git push
On 8 January 2012 13:09, Olivier Hallot wrote: > This is a newbie question: I have commit A and commit B, with A and B > totally independent, and A was committed before B in my local copy. > > I want to push B to the repository. > > How can it be done? Assuming you don't have any uncommited changes, you can do: git format-patch HEAD~2 git reset --hard HEAD~2 git am 0002-commit-B-you-want-to-push git push then you can also git am 0001-commit-A HTH, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations
Hi Christoph, William, everyone reading, I've made a new patch that does only the following things: * Correct the [en-US] thing * Use Christoph's proposal "Confirm File Format" as the window title * Remove the [en-US-old] text as that would have only been confusing * (Probably most controversial:) shortened the body text, but added a question in again, so now this is: "This document may contain content that cannot be saved in the currently selected file format "FORMATNAME". Do you really want to use "FORMATNAME"? To be sure the document is saved correctly, use the ODF format." If there is no uproar, I will push this and ask for a cherry-pick (my git skills are still a bit rudimentary and I don't want to mess up the release). Regards, Astron. 0001-Make-the-title-of-foreign-file-format-warning-transl.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Complete removal of the Windows/Linux quickstarter, was: Re: Removing LibO on Windows ...
Hi all, First of all, I am hereby renaming the thread and am adding UX-Advise, even if that won't necessarily gain us more participants in this discussion. Second,... On 5 January 2012 18:12, Cor Nouws wrote: > - 0 > > People use it as quick-access too. > Should we maybe ask the users? It's the OS's domain to (quickly) start applications, and OS's are pretty good at that. If you want to start anything particularly quickly on... Windows 7: you can add it to the task bar, attach it to the start menu, add it to the desktop Windows Vista or below: you can add it the Quick Launch bar, attach it to the start menu, add it to the desktop Gnome 2: add it to the panel or the desktop Gnome 3: add it to the dock-like thing in the application overview Unity: add it to the desktop or the floating panel KDE: add it to the panel, the desktop, or attach it to the the K menu (I believe) Mac OS X: add it to the dock I really believe, the quick-starter should just go. Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Cherry-pick in 3.5 (3.4 ?) for fdo#44065
Hello Ivan, On Sun, Jan 8, 2012 at 01:44, Ivan Timofeev wrote: > And +1 for 3-4. Could you please push it? :-) Because the -3-4 branch requires only 1 reviewer after last beta. [1] [1] http://wiki.documentfoundation.org/Development/Branches Thanks! Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations
Hello Christoph, all, On Sun, Jan 8, 2012 at 03:14, Christoph Noack wrote: > Furthermore, there is a recent bug reporting this issue (also) for the > German translation. So, whoever has the power of the source *g*, please > subscribe (assign) to it: > https://bugs.freedesktop.org/show_bug.cgi?id=44155 For the choice buttons that are too small, IMHO this could be fixed by resizing them to be larger, if don't want to change the texts. :-) Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] libvisio: how can I help?
On 03/01/12 22:29, Bruno Girin wrote: On 03/01/12 21:34, Fridrich Strba wrote: Hello, Bruno, If you are looking at something cool to do inside libvisio, I might have an idea or two :) For the while, libvisio is converting binary MS Visio files in versions 6 (Visio 2000 and 2002) and 11 (Visio 2003 -> 2010). There is another format that Visio can export to, and it is the XML version called also VDX. This file-format is specified (contrary to the binary one). If you could come with an abstract SAX interface and implement a parser of this file-format, it would fill some gap we have. But any bugfix is welcome. Hi Fridrich, Yes, I had a look at the VDX spec last year and it is indeed well documented and reasonably straight-forward, although there are difference between the 2003, 2007 and 2010 versions as far as I remember. I assume that all classes prefixed VSDX were designed to support both VSD and VDX and therefore should be shared between both types of parser? I'd be very interested in working on that but in order not to over-commit myself and to get familiar with the code, I'll probably start with some tests and simple bug reports / patches. I've been doing some tests with sample Visio files and I've now added a grand total of 7 bug reports [1]. I would like to start tackling some of them but as I'm not familiar with the code base, I would welcome suggestions as to which ones are likely to be reasonably easy hacks. [1] https://bugs.freedesktop.org/buglist.cgi?query_format=advanced&component=Drawing&product=LibreOffice&short_desc=Libvisio&short_desc_type=allwordssubstr&list_id=31438 Cheers, Bruno ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-ux-advise] Complete removal of the Windows/Linux quickstarter, was: Re: Removing LibO on Windows ...
Hi all, Stefan Knorr (Astron) schrieb: Hi all, First of all, I am hereby renaming the thread and am adding UX-Advise, even if that won't necessarily gain us more participants in this discussion. Second,... On 5 January 2012 18:12, Cor Nouws wrote: - 0 People use it as quick-access too. Should we maybe ask the users? It's the OS's domain to (quickly) start applications, and OS's are pretty good at that. If you want to start anything particularly quickly on... Windows 7: you can add it to the task bar, attach it to the start menu, add it to the desktop Windows Vista or below: you can add it the Quick Launch bar, attach it to the start menu, add it to the desktop Gnome 2: add it to the panel or the desktop Gnome 3: add it to the dock-like thing in the application overview Unity: add it to the desktop or the floating panel KDE: add it to the panel, the desktop, or attach it to the the K menu (I believe) Mac OS X: add it to the dock I really believe, the quick-starter should just go. Astron. Do you remember the strom of protest, when OOo had removed the items to start a module from the quickstarter? Are you sure, user will not miss this feature? https://issues.apache.org/ooo/show_bug.cgi?id=30853 Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] LibreOffice for browsers
Hi there! In October I have seen a youtube video about a online or browser version of LibreOffice. http://www.youtube.com/watch?v=wdqgSB9axZQ Is this only available in the source code, or are there any ready-to-use versions yet? I am not used to compile anything, but if there is a good instruction, I'll give it a try! -- Yours! Florian LibO 3.4.4 Windows 7 SP1 64-bit ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Also gives BoundListeners a CPPUHELPER_DLLPUBLIC
Hello all, The following series of patches (in separate thread) is to fix building on windows / cygwin. I'm at commit d74c77428deba9619c678a59d6442ec281385264 on Jan 7. I've tried these patches using incremental build and it builds fine, but smoketest can't run. [1] Anyway, the program could be run :-) This attached patch gives class BoundListeners a CPPUHELPER_DLLPUBLIC, which resolves "error LNK2019: unresolved external symbol" for the symbols in this class. Although BoundListeners' parent (PropertySetMixinImpl) already has CPPUHELPER_DLLPUBLIC, but it seems to be not enough, which I'm not sure why. [1] `/opt/lo/bin/make check` gives http://pastebin.com/EarX4TC0 I'll address this again in new thread. Please feel free to comment :-) Best Regards, -- Korrawit Pruegsanusak 0001-Also-gives-BoundListeners-a-CPPUHELPER_DLLPUBLIC-to-.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice for browsers
Hi Florian, *, On Sun, Jan 8, 2012 at 5:18 PM, Florian Reisinger wrote: > In October I have seen a youtube video about a online or browser version of > LibreOffice. > http://www.youtube.com/watch?v=wdqgSB9axZQ > > Is this only available in the source code, or are there any ready-to-use > versions yet? There are no ready-to-use versions yet, and note that you also need to compile gtk3 with --enable-broadway to make use of it. > I am not used to compile anything, but if there is a good instruction, I'll > give it a try! Well, trying to build LO will never hurt, but you should start off with a plain build first, and when you managed to do that, move to the more or less experimental stuff. http://people.gnome.org/~michael/blog/2011-08-07.html So: it is not only LO-specific stuff that needs to changed, but you also need to have stuff enabled in your system's GTK. ciao Chrisitan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] msvc doesn't allow dll interface in both class and functions
Hello all, This patch fixes building on windows / cygwin. IMHO, the problem is caused by part of the commit [1] Seems msvc doesn't allow us to have SAL_DLLPUBLIC_EXPORT in both class and functions definition. It throws compiler error C2487 [2] So, I tried to fix with 2 methods: 1. Remove dll interface from functions definition, now the whole class has dll interface 2. Remove dll interface from class definition, and only some functions has dll interface which I attached both patches. Anyway, since both methods build and program started fine, I don't know which one is better / more correct. And the manual test shouldn't work, since we don't have any new version to check for update, right? [1] http://cgit.freedesktop.org/libreoffice/core/diff/extensions/source/update/check/updatecheck.hxx?id=9d79b12871522cb9daebf4f6c850e07edcdce08a [2] http://msdn.microsoft.com/en-us/library/t72ahzw1%28v=VS.90%29.aspx Please feel free to comment :-) Best Regards, -- Korrawit Pruegsanusak update-1.patch Description: Binary data update-2.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] If there's no java, don't do the java stuff
Hello all, This attached patch fixes build on windows / cygwin. I'm building --without-java, and it breaks because not found "java_uno_accessbridge", which seems java-related. So, I add a check whether we have "SOLAR_JAVA" before doing this thing. My incremental build went fine after this patch, and the program started well :-) Please feel free to comment :-) Best Regards, -- Korrawit Pruegsanusak 0001-If-there-is-no-java-don-t-do-the-java-stuff.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Newbie question: git push
On 08/01/2012 13:54, Matúš Kukan wrote: On 8 January 2012 13:21, julien2412 wrote: Hello Olivier, I never did this but found this : http://stackoverflow.com/questions/3230074/git-pushing-specific-commit (in http://groups.google.com/group/git-users/browse_thread/thread/e20536c0f222d97a too) so : git push : I think this will push all commits up to commit SHA, that means also A from previous mail, so it's the same as plain git push. You're right Matúš, someone in the same url I gave confirms what you think (cf http://stackoverflow.com/a/4512933) Sorry for this mistake :-( Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Cherry-pick in 3.5 (3.4 ?) for fdo#44065
Hi Korrawit, 08.01.2012 18:11, Korrawit Pruegsanusak пишет: On Sun, Jan 8, 2012 at 01:44, Ivan Timofeev wrote: And +1 for 3-4. Could you please push it? :-) Because the -3-4 branch requires only 1 reviewer after last beta. [1] [1] http://wiki.documentfoundation.org/Development/Branches Oh, indeed... :) It somehow escaped from my mind. But since I haven't got the old repositories and most likely this is the first and the last time when I review patches for it, could anyone else push the patch, please? Thanks, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Does smoketest run on cygwin? or package format another than "archive"?
Hello all, This is a consequence of trying to fix the build on windows / cygwin. I tried to run a smoketest by running `/opt/lo/bin/make check`, and it gives an error http://pastebin.com/EarX4TC0 >From an error, IMHO it tried to find an "archive" version of the installation tree, which I don't have, because I build with --with-package-format=installed. OK, I should have tried --with-package-format=archive, but I don't have time to do this (my exam is coming and my computer isn't so powerful), thus sorry for my too-fast question. Anyway, I noticed that the path should be (comparing with what I have) instsetoo_native/wntmsci12.pro/LibreOffice_Dev/archive/... instead of current instsetoo_native/wntmsci12.pro/LibreOffice/archive/... or this smoketest is not for "dev build", but for "release build" only? Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Does help need update? was: text orientation, not text direction
Hello all, /me bumping this thread and change subject after two months :-) On Sat, Nov 5, 2011 at 22:06, Korrawit Pruegsanusak wrote: > IMHO the help content also needs some love :D > As I don't quite understand this thread, I was just grepping for > LB_TEXTDIRECTION and get this > http://opengrok.libreoffice.org/search?q=LB_TEXTDIRECTION&project=help&defs=&refs=&path=&hist= > which might have to change to LB_TEXTORIENTATION and update the > content as well (FT_TEXTDIRECTION not found in opengrok) ... Could > someone take a look at this? The old thread is at http://nabble.documentfoundation.org/REVIEW-text-orientation-not-text-direction-td3466349.html Andras, could you please have a look? would be good to get in -3-5 before string freeze, which is due today :-\ P.S. Sorry to bump this very late, and sorry if it doesn't need an update. Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Python Bridge on MacOS x64 with python default
On Wed, Jan 4, 2012 at 3:05 AM, Stephan Bergmann wrote: > On 01/03/2012 09:58 PM, Ovnicraft wrote: > >> I want to know if there is any plan to get LO for x64, python comes in >> LO was built in x32. >> > > Nobody is working on such a port as far as I know. > > > I get the SDK for Libre office but has no python bridge. >> > > The Python--UNO bridge is included in LO itself (see > LibreOffice.app/Contents/**MacOS/py*), the SDK traditionally has little > (additional) support for PyUNO. Well i found it in 3.5 beta, so there is any way to use/compile python-uno bridge in standalone mode ? I was thinking in a harder way to write a python layer over c/c++ bridge, any opinion around ? Regards, > > > Stephan > -- Cristian Salamea @ovnicraft ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Newbie question: git push
There are multiple ways, here are two Let's assume that your tree looks like * ---> /origin/master | * ---> commit A | * ---> commit B : HEAD let's say that sha-A is the sha of commit A and sha-B is the sha1 of commit B 1/ You can swap the 2 commits with git-rebase -i git rebase -i origin/master then swap the 2 lines in the editor that pop-up and save. that should rewrite the commits in the order B,A at this point is it wise to rebase the whole things so that you can push git pull -r Now you want to save the corrent head: git branch save HEAD move master one up: git reset --hard master HEAD^ now your master is on B you can push it git push and finally restore you master to A (the saved point) git reset --hard save we don't need the save branch anymore git branch -d save 2/ you can play with branches and cherry pick to achieve the same save our branch and our 2 commits git branch save master 'rollback A and B on master' git reset --hard origin/master Now cherry pick B git cherry-pick save push it git push cherry pick A git cherry-pick save^ now master is back to having both commit in reverse order and B is pushed we don't need the 'save' branch anymore git branch -D save Norbert PS: you can do a gitk --all before all of the and keep it open, and File/Update after each step to visualize what is happening... Note that the second scenario can completely be done with gitk user interface ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Cherry-pick in 3.5 (3.4 ?) for fdo#44065
2012/1/8 Ivan Timofeev : > Hi Korrawit, > > 08.01.2012 18:11, Korrawit Pruegsanusak пишет: > >> On Sun, Jan 8, 2012 at 01:44, Ivan Timofeev >> wrote: >>> >>> And +1 for 3-4. >> >> >> Could you please push it? :-) Because the -3-4 branch requires only 1 >> reviewer after last beta. [1] >> >> [1] http://wiki.documentfoundation.org/Development/Branches > > > Oh, indeed... :) It somehow escaped from my mind. > > But since I haven't got the old repositories and most likely this is the > first and the last time when I review patches for it, could anyone else push > the patch, please? > I pushed to libreoffice-3-4. Regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36843, which changed state. Bug 36843 Summary: Address Datasource wizard does nothing / doesn't function https://bugs.freedesktop.org/show_bug.cgi?id=36843 What|Old Value |New Value Resolution||WORKSFORME Status|NEEDINFO|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Does help need update? was: text orientation, not text direction
Hi Korrawit, 2012/1/8 Korrawit Pruegsanusak : > Hello all, > > /me bumping this thread and change subject after two months :-) > > On Sat, Nov 5, 2011 at 22:06, Korrawit Pruegsanusak > wrote: >> IMHO the help content also needs some love :D >> As I don't quite understand this thread, I was just grepping for >> LB_TEXTDIRECTION and get this >> http://opengrok.libreoffice.org/search?q=LB_TEXTDIRECTION&project=help&defs=&refs=&path=&hist= >> which might have to change to LB_TEXTORIENTATION and update the >> content as well (FT_TEXTDIRECTION not found in opengrok) ... Could >> someone take a look at this? > > The old thread is at > http://nabble.documentfoundation.org/REVIEW-text-orientation-not-text-direction-td3466349.html > Andras, could you please have a look? would be good to get in -3-5 > before string freeze, which is due today :-\ > > P.S. Sorry to bump this very late, and sorry if it doesn't need an update. > Thanks for raising the issue. I updated the help now. Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#44442, crash in ScInterpreter::GetDBParam with specific document
On Sat, Jan 7, 2012 at 11:44 PM, Kohei Yoshida wrote: > Hi Markus, > > On Sat, Jan 7, 2012 at 10:40 PM, Markus Mohrhard > wrote: > >> I think it is a simple patch fixing a crash and should be pushed to 3-4. > > Simple and makes sense. You have my approval. And pushed to the -3-4 branch with my sign-off. In case this needs to go to the -3-4-5 branch, we'll need 2 more sign-off's. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#44442, crash in ScInterpreter::GetDBParam with specific document
Hello Kohei, >> >> On Sat, Jan 7, 2012 at 10:40 PM, Markus Mohrhard >> wrote: >> >>> I think it is a simple patch fixing a crash and should be pushed to 3-4. >> >> Simple and makes sense. You have my approval. > > And pushed to the -3-4 branch with my sign-off. > > In case this needs to go to the -3-4-5 branch, we'll need 2 more sign-off's. > I think that 3-4-5 is through and it is not a high priority patch. I think it only happens in rare circumstances. Thanks for your review. Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [GBUILD PATCH] merging libraries
Hi,
could someone please review attached patch ?
Especially I did not know where to put gb_MERGEDLIBS (or you may come
up with better name) (until now it's gb_CORE_LIBS in LinkTarget.mk)
so I put it in solenv/gbuild/extensions/pre_MergedLibsList.mk.
And I'm not sure about gb_LINKED_LIBS in LinkTarget.mk.
The horrible expression could be correct,
but it's probably not nice to have variable used that way there (but it is now).
The rest should be ok.
Thanks,
Matus
From ec43c77ad73f9194676d921c1df615bcd8b04c07 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mat=C3=BA=C5=A1=20Kukan?=
Date: Fri, 6 Jan 2012 10:48:43 +0100
Subject: [PATCH] improve support for merging libraries
---
Library_merged.mk | 32 ++-
solenv/gbuild/Library.mk |2 +-
solenv/gbuild/LinkTarget.mk| 23 +++
solenv/gbuild/extensions/pre_MergedLibsList.mk | 50
4 files changed, 62 insertions(+), 45 deletions(-)
create mode 100644 solenv/gbuild/extensions/pre_MergedLibsList.mk
diff --git a/Library_merged.mk b/Library_merged.mk
index 4a8ccaf..9fe9c2d 100644
--- a/Library_merged.mk
+++ b/Library_merged.mk
@@ -21,26 +21,16 @@
# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
# instead of those above.
-
$(eval $(call gb_Library_Library,merged))
-$(eval $(call gb_Library_add_linked_libs,merged,$(filter-out $(gb_MERGED_LIBS),\
- avmedia \
+$(eval $(call gb_Library_add_linked_libs,merged,\
basegfx \
- canvastools \
comphelper \
- cppcanvas \
cppu \
cppuhelper \
- drawinglayer \
- editeng \
fwe \
i18nisolang1 \
i18npaper \
- i18nutil \
- jvmfwk \
- lng \
- fwe \
sal \
salhelper \
sax \
@@ -49,28 +39,24 @@ $(eval $(call gb_Library_add_linked_libs,merged,$(filter-out $(gb_MERGED_LIBS),\
sot \
svl \
svt \
- svx \
- svxcore \
tk \
tl \
ucbhelper \
utl \
vcl \
- xo \
xcr \
$(gb_STDLIBS) \
-)))
+))
$(eval $(call gb_Library_use_externals,merged,\
- icui18n \
+ berkeleydb \
icuuc \
- jpeg \
- libxml2 \
zlib \
))
+# gb_MERGEDLIBS is defined in solenv/gbuild/extensions/pre_MergedLibsList.mk
$(eval $(call gb_Library_add_library_objects,merged,\
- $(gb_CORE_LIBS) \
+ $(gb_MERGEDLIBS) \
))
ifeq ($(OS),WNT)
@@ -85,12 +71,4 @@ $(eval $(call gb_Library_add_linked_libs,merged,\
))
endif
-# something is missing here for sure
-ifeq ($(OS),MACOSX)
-$(eval $(call gb_Library_add_linked_libs,merged,\
- objc \
- Cocoa \
-))
-endif
-
# vim: set noet sw=4 ts=4:
diff --git a/solenv/gbuild/Library.mk b/solenv/gbuild/Library.mk
index b9173ea..13258b8 100644
--- a/solenv/gbuild/Library.mk
+++ b/solenv/gbuild/Library.mk
@@ -106,7 +106,7 @@ endef
# gb_Library__get_final_target has been invented for that purpose...
define gb_Library_set_componentfile
$(call gb_ComponentTarget_ComponentTarget,$(2),$(call gb_Library__get_componentprefix,$(1)),\
- $(call gb_Library_get_runtime_filename,$(if $(MERGELIBS),$(if $(filter $(gb_MERGED_LIBS),$(1)),merged,$(1)),$(1
+ $(call gb_Library_get_runtime_filename,$(if $(filter $(1),$(gb_MERGEDLIBS)),merged,$(1
$(call gb_Library__get_final_target,$(1)) : \
$(call gb_ComponentTarget_get_outdir_target,$(2))
$(call gb_ComponentTarget_get_target,$(2)) :| $(call gb_Library_get_target,$(1))
diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk
index e4dbd46..e8f9bab 100644
--- a/solenv/gbuild/LinkTarget.mk
+++ b/solenv/gbuild/LinkTarget.mk
@@ -46,17 +46,6 @@ CXXFLAGS ?= $(gb_COMPILEROPTFLAGS)
OBJCXXFLAGS ?= $(gb_COMPILEROPTFLAGS)
endif
-# if enabled we link all of these libraries into one larger, merged library
-# for which we can do a lot more optimisation, and which is faster to read
-# from disk.
-ifeq ($(MERGELIBS),TRUE)
-# list of libraries which are always loaded, thus we can merge them into one
-# they have to be from tail_build, so we could link against merged library
-gb_CORE_LIBS := \
- uui \
-
-endif
-
# Overview of dependencies and tasks of LinkTarget
#
# target task depends on
@@ -357,8 +346,10 @@ mv $${TEMPFILE} $(call gb_LinkTarget_get_objects_list,$(2))
endef
+# If object files from this library are merged, create just empty file
$(call gb_LinkTarget_get_target,%) : $(call gb_LinkTarget_get_headers_target,%) $(gb_Helper_MISCDUMMY)
- $(call gb_LinkTarget__command,$@,$*)
+ $(if $(filter $*,$(foreach lib,$(gb_MERGEDLIBS),$(call gb_Library_get_linktargetname,$(lib, \
+ touch $@, $(call gb_LinkTarget__command,$@,$*))
$(call gb_LinkTarget__command_objectlist,$@,$*)
ifeq ($(gb_FULLDEPS),$(true))
@@ -639,11 +630,9 @@ $$(eval $$(call gb_Output_info,currently known libraries are: $(sort $(gb_Librar
$$(eval $$(call gb_Output_error,Cannot link against library/libraries $$(filter-out $(gb_Library_KNOWNLIBS),$(2)). Libraries must be registered in Repository.mk))
endif
-ifeq ($(MERGELIBS),TRUE)
-gb_LINKED_LIBS := $(if $(filter $(gb_CORE_LIBS),
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36843, which changed state. Bug 36843 Summary: Address Datasource wizard does nothing / doesn't function https://bugs.freedesktop.org/show_bug.cgi?id=36843 What|Old Value |New Value Resolution|WORKSFORME | Status|RESOLVED|REOPENED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 3.5.0 QA ... from BHS 1 to BHS 2
Hi all, So time to prepare bug hunt session two. http://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5 and http://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5#2nd_Bug-hunting_session Or is there something that should make us change our mind for that? As far as I've been able to notice, preparations for beta3 go fine, so that's OK! As may be read from the other thread (thread 'Evaluating first 3.5.0 Bug-Hunt Session' on the QA list) I'm far from sure about the impact on level of issues, but looking at the overall activity/awareness, I think it's worth. We could send a mail to the people that submitted their fist bug during the session, asking their feedback for possible improvement. Would that be OK, do you think? Other hits/remarks of course appreciated as well :-) Cheers, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] proposed fix for fdo#44533
Hello, I attached a patch for fdo#44533 (SLIDESHOW: CRASH when play particular presentation with sound). I attached in the bugtracker the backtrace (https://bugs.freedesktop.org/attachment.cgi?id=55314) and console logs (https://bugs.freedesktop.org/attachment.cgi?id=55315) Here is the code : VectorOfSprites::iterator aBegin( aUpdatableSprites.begin() ); VectorOfSprites::iterator aEnd ( aUpdatableSprites.end() ); ::std::sort( aBegin, aEnd, aSpriteComparator ); aEnd = ::std::unique( aBegin, aEnd ); ...comments ::std::for_each( aBegin, aEnd, SpriteUpdater( rUpdateAreas, maChangeRecords) ); ...comments VectorOfSprites aUnchangedSprites; ::std::set_difference( aSortedSpriteVector.begin(), aSortedSpriteVector.end(), aBegin, aEnd, ::std::back_insert_iterator< VectorOfSprites >(aUnchangedSprites) ); Because of the sort, I don't think that the iterators aBegin and aEnd can be reused just after a sort. So i try to declare these variables after the sort and I didn't have a crash. Perhaps, these variables could be declared more lately for safety or perhaps not at all (and so we should call each time .begin and .end each time), I'm not sure. Any idea ? Julien http://nabble.documentfoundation.org/file/n3643134/proposed_patch_44533.txt proposed_patch_44533.txt -- View this message in context: http://nabble.documentfoundation.org/PATCH-proposed-fix-for-fdo-44533-tp3643134p3643134.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Does help need update? was: text orientation, not text direction
Hello Andras, On Mon, Jan 9, 2012 at 01:59, Andras Timar wrote: > Thanks for raising the issue. I updated the help now. Thanks! But seems you've missed a verb 'use', so I just pushed a fix. :-) Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2
Hi Cor, On Sun, Jan 8, 2012 at 10:52 PM, Cor Nouws wrote: > > So time to prepare bug hunt session two. > http://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5 > and > > http://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5#2nd_Bug-hunting_session > > Or is there something that should make us change our mind for that? No, not really, It should be on Saturday/Sunday this time, as a few people complained that they cannot attend such an event during the week. But a disclaimer from my part: I won't be able to attend on Jan 21, as I'm invited on a birthday. > As may be read from the other thread (thread 'Evaluating first 3.5.0 > Bug-Hunt Session' on the QA list) I'm far from sure about the impact on > level of issues, Yeah, impact on 3.5issues is not that big, but I think it just needs time for people to get used to. > but looking at the overall activity/awareness, I think it's > worth. Exactly what I am thinking :-) > We could send a mail to the people that submitted their fist bug during the > session, asking their feedback for possible improvement. Would that be OK, > do you think? Sure, but then the Jan 20/21st might be too close. > Other hits/remarks of course appreciated as well :-) Find mentors "officially" and don't rely on people to show up for the second one. It did work out on the first session, but esp. for the follow-up event it should be sure that mentors are around. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] ScGlobal::GetAutoFormat not always required to create fresh instance
Hello Stephan, Kohei, 2012/1/7 Kohei Yoshida : > On Fri, 2012-01-06 at 19:03 +0100, Stephan Bergmann wrote: > >> So, I would appreciate it if some Calc aficionado could look at the >> patch, whether it actually makes any sense. > > First, I have to say all this auto format code is not something I'm > familiar with. So, my opinion is based on what I gathered in the past > ~10 minutes of reading how the global ScAutoFormat instance is used > throughout the calc code. I'm CC'ing Eike in case my answer is off the > mark. > > Anyway, it's my understanding that the main problem is that the global > ScAutoFormat instance unintentionally get instantiated in the destructor > of ScAutoFormatObj during the termination of the cppunit? In that case, > what I would do is to add ScGlobal::HasAutoFormat() which simply checks > whether the instance already exists, and if yes go on ahead and save if > the flag is set. When no such instance exists there is no need to save > stuff anyway (since there is no data to save). > > Another advantage of this is that we wouldn't have to modify all the > code that currently uses GetAutoFormat() expecting it to return a live > instance at all times, and we could only modify the code in > ~ScAutoFormatObj(). > > Would that solve the problem you are facing? > In my opinion we have two bugs here.. The ScGlobal::ppRscStrin is being deleted in the ScModule destructor which means that calc is no longer open. So the question is why do we delete ScAutoFormatObj after ScModule and the second one is that we are creating the object in the destructor. The problem is that I was only once able to reproduce this bug and have now in my testing branch some debug statements but I was never again able to reproduce the bug. IMHO it is a good idea to fix this bug here but I think it would be a good idea to understand why we have one object that is deleted later than it should be. I see here a place for some really nasty crashs that are not really reproducable. And then there might be a simple solution to both problems at the same time. If possible we could add a variable to ScAutoformatObj storing a sheet::SpreadsheetDocument (the uno interface behind ScModule and therefore force the right destruction order. I did not test this idea but I did something similar for ScDatabaseRangesObj and ScDatabaseRangeObj to prevent the destruction of the ScDatabaseRangesObj before the ScDatabaseRangeObj. Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
