[Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 Heiko Tietze changed: What|Removed |Added CC||hoss...@libreoffice.org --- Comment #14 from Heiko Tietze --- Hossein, what do you think about an easyhack? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 --- Comment #13 from symbioma.t...@gmail.com --- Apologies, heiko, I am not. Merely dropped a quick tip based on dry reading the code for someone who is more familiar with the project or has time to learn. A bit too much for me currently. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 --- Comment #12 from Heiko Tietze --- (In reply to symbioma.trix from comment #11) > I've pinpointed the part of the code... Looks promising. Please assign the bug to yourself and set the status to assigned so it would be visible for other volunteers that you are working on it. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185
--- Comment #11 from symbioma.t...@gmail.com ---
In case anyone's interested, I think I've pinpointed the part of the code where
function autoinput happens, with stephane's help.
In core/sc/source/ui/app/inputhdl.cxx , there's this segment under
ScInputHandler::KeyInput :
case KEY_RETURN:
// New line when in the input line and Shift/Ctrl-Enter is pressed,
// or when in a cell and Ctrl-Enter is pressed.
if ((pInputWin && bInputLine && bControl != bShift) || (!bInputLine
&& bControl && !bShift))
{
bDoEnter = true;
}
else if (nModi == 0 && nTipVisible && pFormulaData &&
miAutoPosFormula != pFormulaData->end())
{
PasteFunctionData();
bUsed = true;
}
else if ( nModi == 0 && nTipVisible && !aManualTip.isEmpty() )
{
PasteManualTip();
bUsed = true;
}
// And a few blocks down...
case KEY_TAB:
if (bControl && !bAlt)
{
if (pFormulaData && nTipVisible && miAutoPosFormula !=
pFormulaData->end())
{
// Iterate
NextFormulaEntry( bShift );
bUsed = true;
}
else if (pColumnData && bUseTab)
{
// Iterate through AutoInput entries
NextAutoEntry( bShift );
bUsed = true;
}
}
Move that PasteFunctionData block down to tab's handling and I think that
should make it the new function entry key. User setting based would be optimal
imo, but I haven't looked into how settings work. Would start from
SC_MOD()->GetAppOptions().GetAutoComplete() and try to make a replica of the
process.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 --- Comment #10 from QA Administrators --- Dear Mieszko, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 --- Comment #9 from Joshua Coppersmith --- Some alternatives: 1) Change auto entry to use tab, the default in almost every other system out there from Eclipse clear down to MS Hotmail. Obviously, my choice and Mieszko's but another idea is... 2) Don't kick in auto entry after backspace...per other suggestions already given. 3) Don't kick in auto entry until at least two (even three) letters have been typed. That would at least avoid the mess for simple column reference situations in the vast majority of cases. 4) Put "Tab to ignore" in bold at the end of the auto entry popup text tip while not changing the behavior at all. I think this is more than a preference question. If you, for example, have =($A:$A) in column C then go to change that to =($B:$B) you get into a morass of =($B:$B()), etc., when doing the obvious and pressing Enter. Here is the thing: Anyone wanting auto entry will be able to see clearly if that function has popped up, and will probably have to keep typing awhile before the drill down matches what they want, anyway. Meanwhile, the person expecting enter to do as it says and enter the edited value into the cell is left trapped, having to re-edit, and having to click into the end of the line or having to figure out to use tab to do what enter says right on the key, "Enter". The popup tip for the auto entry feature could have a bold "then Tab" at the end of it if switched to tab. MS Hotmail does something like this. Or...if the behavior isn't changed, what about putting "Tab to ingore" at the end of the tip? In any case, most intense users of LibreOffice Calc probably have the basic familiarity with tab for autocomplete, not enter. Tab for autocomplete is very mainstream. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 Xisco Faulí changed: What|Removed |Added Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 --- Comment #7 from QA Administrators --- Dear Mieszko, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 --- Comment #6 from Mieszko --- Hi, The looks of auto-input has been changed but disabling tools->auto-input still doesn't work on backspace press. Version: 6.0.4.1 Build ID: 00m0(Build:1) CPU threads: 4; OS: Linux 4.16; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions (or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions ( or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval |needsDevEval Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Severity|enhancement |normal --- Comment #4 from Heiko Tietze --- Typically the dropdown for autocomplete shows up and after selecting one the items it is inserted with enter. Having another option like (o) Enter, () Shift+Enter, () Ctrl+Enter sounds like an overkill. However, we could change the autocomplete behavior. As reported by Mieszko the functions is not shown when text is added and AutoInput (bad camel case) is disabled but pops up on backspace. And when this bug is solved we could introduce a manual autocomplete like the user enters =p and presses (use a good shortcut here) the function list is shown. But the selection of an entry would be done per Enter. unconfirmed -> new enhancement -> normal since autocomplete is buggy for backspace. -needsUXEval +needsDevEval -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions ( or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 Buovjaga changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions ( or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 --- Comment #3 from Mieszko --- **Solution** for people who don't want this feature -> uncheck tools/autoinput but this doesn't switch it off at all. If you type more letters and than delete them by backspace, autoinput still works. If don't want switch autoinput off or be sure that this will never happen accidentialy, teach your muscle memory to use TAB, ENTER instead of ENTER. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions ( or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 --- Comment #2 from Mieszko --- So just add possibility to change it in settings. You know better what is good as default, I've only mention what would be better for me (and I consider it as more logical), just as a feedback. BTW* this would not be so big change as when you break compatibility in macros for ver.4 vs ver.5. People can learn minor changes in gui/behavior, but cannot keep running their scripts. *Its 'btw'. I doesn't mean I want force my point of view. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104185] Better Autoinput for functions ( or different default than ENTER)
https://bugs.documentfoundation.org/show_bug.cgi?id=104185 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #1 from Buovjaga --- So what do we do after we change the default and millions of angry users attack? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
