[Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #15 from BogdanB --- warn:sal.file:51242:51242:sal/osl/unx/file_misc.cxx:659: Invalid file URL warn:sal.file:51242:51242:sal/osl/unx/file_misc.cxx:659: Invalid file URL warn:vcl.schedule.deinit:51242:51242:vcl/source/app/scheduler.cxx:176: DeInit task: Timer a: 1 p: 1 framework::AutoRecovery m_aTimer 60ms (0x360f5b0) warn:vcl.schedule.deinit:51242:51242:vcl/source/app/scheduler.cxx:176: DeInit task: Timer a: 1 p: 1 MemoryManager::MemoryManager maSwapOutTimer 1000ms (0x74ffecf21400) warn:vcl.schedule.deinit:51242:51242:vcl/source/app/scheduler.cxx:196: DeInit active tasks: 2 (ignored: 0) warn:unotools.config:51242:51242:unotools/source/config/configmgr.cxx:147: ConfigManager not empty Still repro in Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 --- Comment #14 from Eyal Rozenberg --- Bug still manifests with: Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 516f800f84b533db0082b1f39c19d1af40ab29c8 CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: he-IL (en_IL); UI: en-US The message may differ a little, e.g.: warn:unotools.config:29423:29423:unotools/source/config/configmgr.cxx:147: ConfigManager not empty -- You are receiving this mail because: You are the assignee for the bug.
[Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 --- Comment #13 from QA Administrators --- Dear Eyal Rozenberg, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 --- Comment #12 from Eyal Rozenberg --- (In reply to Chris Sherlock from comment #11) Which person has which nick and which function w.r.t. LO development? :-) Also... > [06:08:52] it would be a WONTFIX Already explained why that can't be right - whether one believes the config manager should be empty or not. And the IRC chat explained it too... > I respectfully disagree with the reviewer - a straight loop is fine for now. It's not _terrible_; it's just a question of style. I didn't say I reject the patch or anything. > Eyal, if you want to improve upon the patch, why not fix it after the patch > is committed. Well, possibly because I'm not really an LO developer. There's only a small chance I would dive into checking out, building and testing. > I can't see any reason why this is more or less readable than having to setup > several lambdas for a custom built for_each_if() function! Well, because it separates out the different semantic aspects of the code rather than weaving them together. It is idiomatic according to this paradigm: https://www.youtube.com/watch?v=W2tWOdzgXHA but obviously it is at least partially a matter of taste. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 --- Comment #11 from Chris Sherlock --- >From IRC: [06:02:55] noelgrandin you wrote in https://bugs.documentfoundation.org/show_bug.cgi?id=145175 that "LibreOffice generates tons of false positive warnings, it is just one of those things that happens, no need to worry." [06:02:57] bug 145175: LibreOffice-Writer normal/medium NEW ConfigManager is not empty when quitting LO Writer (and LO) [06:04:08] exactly [06:04:29] why would we worry? it's not causing a problem [06:06:23] so in that case, better to remove the warning? [06:06:44] if we don't care about the fact that it isn't removed, why muddy up the output with the warning? [06:06:44] they can be useful, if you are chasing another related bug [06:07:03] I'm confused, is it useful or not? [06:07:11] have we had problems with config mgr? [06:07:30] it's annoying to have it show output on the workben utilities we are creating [06:08:18] noelgrandin does this mean it should be a WONTFIX then? [06:08:52] it would be a WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 --- Comment #10 from Chris Sherlock --- Evan, seems to me that ConfigManager is never emptied. Doesn't seem like a false positive to me... Noel, why do you say it is a false positive? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 --- Comment #9 from Chris Sherlock --- Julien, I tested out your patch. It looks good. I respectfully disagree with the reviewer - a straight loop is fine for now. My only question is: why would "Office.Commands/Execute" be a problem? I have a utility that shows that "Setup/L10N" doesn't get cleared... Eval, if you want to improve upon the patch, why not fix it after the patch is committed. I can't see any reason why this is more or less readable than having to setup several lambdas for a custom built for_each_if() function! Which would be replaced with std::ranges in C++20. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 Julien Nabet changed: What|Removed |Added CC|serval2...@yahoo.fr | Status|ASSIGNED|NEW Assignee|serval2...@yahoo.fr |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #8 from Julien Nabet --- I gave a try with https://gerrit.libreoffice.org/c/core/+/123762 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 Eyal Rozenberg changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 Eyal Rozenberg changed: What|Removed |Added Ever confirmed|1 |0 Resolution|NOTABUG |--- Status|RESOLVED|UNCONFIRMED --- Comment #7 from Eyal Rozenberg --- (In reply to Noel Grandin from comment #5) > LibreOffice generates tons of false positive warnings, It actually generates very few false warnings. At least the daily master branch build, anyway. > it is just one of those things that happens, no need to worry. Either this is a false warning, in which case it should not be made; or it is a valid warning, in which case the config manager should be emptied. Which is it? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175
--- Comment #6 from Julien Nabet ---
Noel: so does it mean we may remove the SAL_WARN_IF in:
152 utl::ConfigManager::~ConfigManager() {
153 SAL_WARN_IF(!items_.empty(), "unotools.config", "ConfigManager not
empty");
154 }
to reduce console noise?
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 Noel Grandin changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW |RESOLVED --- Comment #5 from Noel Grandin --- LibreOffice generates tons of false positive warnings, it is just one of those things that happens, no need to worry. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 Julien Nabet changed: What|Removed |Added CC||noelgran...@gmail.com, ||sberg...@redhat.com --- Comment #4 from Julien Nabet --- Stephan/Noel: In framework/source/services/frame.cxx I tried to change m_aCommandOptions from SvtCommandOptions to std::unique_ptr but it failed with: #0 std::__shared_ptr::get() const (this=0x20) at /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/shared_ptr_base.h:1330 #1 0x7fbbb1490848 in std::__shared_ptr_access::_M_get() const (this=0x20) at /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/shared_ptr_base.h:1027 #2 0x7fbbb1485c35 in std::__shared_ptr_access::operator->() const (this=0x20) at /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/shared_ptr_base.h:1021 #3 0x7fbbb1484616 in SvtCommandOptions::EstablishFrameCallback(com::sun::star::uno::Reference const&) (this=0x0, xFrame= uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x2cbd490) at unotools/source/config/cmdoptions.cxx:340 #4 0x7fbbb61dc9b2 in (anonymous namespace)::XFrameImpl::initListeners() (this=0x2cbd420) at framework/source/services/frame.cxx:509 I noticed the use of weak reference and std::make_shared in unotools/source/config/cmdoptions.cxx. Any idea how to fix this part? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 --- Comment #3 from Julien Nabet --- Created attachment 175790 --> https://bugs.documentfoundation.org/attachment.cgi?id=175790=edit bt with debug symbols for "Office.Commands/Execute" After adding some trace at registerConfigItem and removeConfigItem and when comparing, the only remnant was "Office.Commands/Execute". So I retrieved a bt from where "Office.Commands/Execute" is registered. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145175] ConfigManager is not empty when quitting LO Writer (and LO)
https://bugs.documentfoundation.org/show_bug.cgi?id=145175 --- Comment #1 from Eyal Rozenberg --- Build info: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c998691e22ceda15c89d55cf7005201f0392dadb CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_IL); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-10-14_11:54:20 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
