[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-07-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

--- Comment #19 from László Németh  ---
Created attachment 195076
  --> https://bugs.documentfoundation.org/attachment.cgi?id=195076=edit
English unit test document

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-07-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

--- Comment #18 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/83733601124f611938c365426485d0001e1fe454

tdf#160170 sw: test for fix overshrank lines with hyphenation

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-06-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:25.2.0   |target:25.2.0
   |target:24.8.0.0.beta2   |target:24.8.0.0.beta2
   ||target:24.2.5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-06-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

László Németh  changed:

   What|Removed |Added

 CC||werner-ti...@arcor.de

--- Comment #16 from László Németh  ---
*** Bug 161451 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-06-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

--- Comment #15 from László Németh  ---
(In reply to Stéphane Guillou (stragu) from comment #14)
> Verified in:
> 
> Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 0e2409e5e3c73ec25c61aa4ea140d114869ea512
> CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
> Locale: en-AU (en_AU.UTF-8); UI: en-US
> Calc: CL threaded
> 
> Thank you László!

@Stéphane: thanks for the verification and feedback! Also thanks to Caolán
McNamara, whose work was likely an alternative solution before my commit!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-06-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-06-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

--- Comment #14 from Stéphane Guillou (stragu) 
 ---
Verified in:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0e2409e5e3c73ec25c61aa4ea140d114869ea512
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Thank you László!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-06-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

--- Comment #13 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/3fdbc6083336f84ed7fa55fb0ec3fd0288382967

tdf#160170 sw: fix overshrunk justified lines at hyphenation

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-06-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:25.2.0   |target:25.2.0
   ||target:24.8.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-06-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

László Németh  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
   Assignee|nem...@numbertext.org   |libreoffice-b...@lists.free
   ||desktop.org
 Resolution|--- |FIXED

--- Comment #12 from László Németh  ---
Fixed in the master (already likely by Caolán McNamara's commit, too, see
"stale hyphenation data after skipping blanks), and started to back-port to
24.2.

@Julian and all: thanks for your bug report and feedback!

Full commit description:

tdf#160170 sw: fix overshrunk justified lines at hyphenation

Smart justify uses 2 SwTextGuess::Guess() calls to break a
line, but using the same SwTextGuess object resulted overshrunk
lines, if the first call resulted hyphenation, because of the
bad state of the object for the second call. If we need a
second call, now instantiate a new object for it.

Regression from commit 36bfc86e27fa03ee16f87819549ab126c5a68cac
"tdf#119908 tdf#158776 sw smart justify: shrink only spaces".

Note: the reported test document was already fixed by
commit f050103c3324d878b310f37429ea3580a8230905
"stale hyphenation data after skipping blanks".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-06-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

László Németh  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

--- Comment #10 from Mike Kaganski  ---
(In reply to Stéphane Guillou (stragu) from comment #8)
> I have this extension installed to support German hyphenation:
> 
> https://extensions.libreoffice.org/en/extensions/show/german-de-de-frami-
> dictionaries

Reproducible with Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: default; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded

with only the *bundled* German (Austria, Germany, Switzerland) spelling
dictionaries, hyphenation rules, and thesaurus 2017.01.12.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 OS|Linux (All) |All

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
Same on Windows 11 with 24.2.1, same extension and attachment 193080.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160170] FILEOPEN .DOCX: words pulled together, characters overlap in some line of hyphenated paragraph

2024-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160170

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|24.2.1.2 release|24.2.0.2 rc
   Keywords||bibisected, bisected,
   ||regression
 CC||nem...@numbertext.org,
   ||stephane.guillou@libreoffic
   ||e.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||9908,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8776
 Blocks||120883
 Status|UNCONFIRMED |NEW
Summary|FILEOPEN .DOCX: words   |FILEOPEN .DOCX: words
   |pulled together |pulled together, characters
   ||overlap in some line of
   ||hyphenated paragraph
   Hardware|ARM |All
 Ever confirmed|0   |1
  Regression By||László Németh

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
Confirmed with:

Version: 24.2.2.1 (X86_64) / LibreOffice Community
Build ID: bf759d854b5ab45b6ef0bfd22e51c6dc4fb8b882
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2146e66d8df2b7b6a2dd868e886cae76aaf7f48b
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

... installed from deb, so unrelated to Flatpak.
I have this extension installed to support German hyphenation:

https://extensions.libreoffice.org/en/extensions/show/german-de-de-frami-dictionaries

Not reproduced with 7.6.5.2 -> regression.

Bibisected with linux-64-24.2 repo to first bad build
[817bca5601e09a41cad2cbcb897f95b33e61f673] which points to
8d247e3ad47e0b828437abb019e1573dbb1c05b1 which is a cherrypick of:

commit  36bfc86e27fa03ee16f87819549ab126c5a68cac
author  László Németh   Tue Dec 19 11:58:40 2023 +0100
committer   László Németh   Tue Dec 19 22:18:13 2023 +0100
tdf#119908 tdf#158776 sw smart justify: shrink only spaces
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160988

László, can you please have a look?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120883
[Bug 120883] [META] Hyphenation bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.