[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #23 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/74a8bda42d443c8fbcfab7619a929ccf53a00918

partial fix tdf100961 doc import: E_Locked field as plain text

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #22 from Justin L  ---
I'm not going to do the last step of importing into DOC. 
a.) It seems to require UNO garbage, and I can't stand working with that junk
unless I can just copy/paste - which I have no examples to find here.
b.) All the plumbing for turning a date-or-time-string into a DateTime is
mostly missing. Sure, there is convertStringToNumber from
https://cgit.freedesktop.org/libreoffice/core/commit/?id=8826934016d60d0a4a1e824e3f1cff814d915515,
but that is unfathomable UNO junk that returns only a float (why not return as
DateTime?) - and none of the date/time methods accept the float as an
initializer, so more plumbing is needed. Plus, none of that actually accepts
the format string that we already know from the field itself, which specifies
%YY.mm.dd, etc.
c.) I really don't want to write my own function to parse date/time based on
the field strings.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #21 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4ed7a2c8af03bc0f45df1f03fd160ccbf045ed4f

tdf#100961 rtf import: fldlock is FIXEDFLD

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #20 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dafdcb748a54a5e41bcb61f67355e06265bf98ff

tdf#100961 doc/rtf export: save FIXEDFLD as fldlock

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #19 from Mike Kaganski  ---
(In reply to Justin L from comment #18)
> BTW, what GOOD is a const date field?  Why shouldn't it just be turned into
> plain text on import?

It is absolutely necessary for *templates*, where it is calculated once upon
creation of a new document from such template.

Being a *field*, it also allows to adjust to locale dynamically (modifying
display string as reader expects), if its locale is not fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=59
   ||886
 CC||jl...@mail.com

--- Comment #18 from Justin L  ---
OK - there are a lot of different parts to this bug. Things act differently
depending on if the field was inserted via the UI/ODT, or imported from .doc.
Confirmed that the .doc imported date field round-trips always as a variable
field (since at least 3.5). [Ahh - of course, because the imported field is
variable, and the ODT one is fixed. Duh. Confirmed that if you CHANGE the .doc
imported time to FIXED, then 3.5-4.4 export as plain text.]

In 5.0 DOC/RTF start exporting as a field with bug 59886's
commit a072b3533f44730565f42b45cfd9f77f44f506a9
Author: Eilidh McAdam on Dec 19 16:56:58 2014 +
fdo#59886 export fixed date and time fields to docx.

Fixed date and time fields are supported in OOXML by adding the
attribute fldLock="true" to the fldChar element. This applies only
to the first instance of fldChar in a field (i.e. when fldCharType
is "begin").


Import WIP started at https://gerrit.libreoffice.org/c/core/+/113986.

BTW, what GOOD is a const date field?  Why shouldn't it just be turned into
plain text on import?
+  if (pF->nOpt & 0x10) // E_locked field option - do not recalculate
+  return eF_ResT::TEXT;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #17 from Justin L  ---
That grffldEnd is loaded into WW8FieldDesc.nOpt.

So I think we want to set our date and time fields to DATE_FIX
enum SwDateSubFormat
{
DATE_FIX,   #never used. Gets converted to FIXEDFLD(aka 1 - so confusing)
DATE_VAR#this is the one to search for. 
};
as well as setting the field's time to what was stored in the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #16 from Justin L  ---
Here is the relevant part from mso-dumper, the key here being grffldEnd bit
E_Locked



  #tyep of field


  #a Date field.





  #unused/ignored


 #ignored






  #grffldEnd


 #1001  E_Locked = this field does not recalculate,
H_fHasSep = set if this field has a separator.



-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

Buovjaga  changed:

   What|Removed |Added

   Keywords|bibisectRequest, regression |
Version|5.0.2.2 release |3.5.0 release

--- Comment #15 from Buovjaga  ---
(In reply to Mike Kaganski from comment #14)
> Created attachment 148057 [details]
> A DOC with const date and time fields saved with Word 2003

Removing regression-related keywords as file opening behaviour is the same in
older versions (oldest of 44max and 43all repos). It is opened with non-const
date and time, showing the current date and time instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #14 from Mike Kaganski  ---
Created attachment 148057
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148057=edit
A DOC with const date and time fields saved with Word 2003

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #13 from Mike Kaganski  ---
(In reply to Aron Budea from comment #12)
> I checked what's possible in Word, and it appears Word inserts fixed dates
> as a piece of text, and nothing else. Perhaps it's just an unsupported type
> in DOC formats. However, in that case possibly the old behavior was the
> correct one, which turned fixed dates into a piece of text - the fieldness
> is removed, but the date remains fixed.

Saving a test document to DOCX results in correct roundtrip (wrt this specific
issue that is about const-ness of fields); Word also opens the generated DOCX
with fields in it, having const values. Then, you can save the DOCX to DOC
using Word, and get a DOC with const fields - so the DOC format supports the
const date/time fields. But opening the resulting DOC (generated by Word) using
LO gives non-const date/time fields - so it's at least import filter issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #12 from Aron Budea  ---
I checked what's possible in Word, and it appears Word inserts fixed dates as a
piece of text, and nothing else. Perhaps it's just an unsupported type in DOC
formats. However, in that case possibly the old behavior was the correct one,
which turned fixed dates into a piece of text - the fieldness is removed, but
the date remains fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #11 from Buovjaga  ---
(In reply to Telesto from comment #10)
> but not with 
> Versie: 4.4.6.3 
> Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d
> Locale: nl_NL

With 4.4.7 and 4.3.0, the field turns into regular text when exporting to DOC,
so I would not call this a regression. Am I missing something? Can someone
share a DOC created with pre-5.0 that shows a working fixed date field?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 CC||tele...@surfxs.nl
Version|unspecified |5.0.2.2 release

--- Comment #10 from Telesto  ---
About fixed date is not fixed anymore when exported to DOC

Repro with
Version: 5.5.0.0.alpha0+
Build ID: 076ed447f694239d5c67adee528ea6e471d909ff
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-09_23:54:20
Locale: en-US (nl_NL); Calc: CL

and with
Version: 5.0.2.2
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe-GL
Locale: en-US (nl_NL)

but not with 
Versie: 4.4.6.3 
Build ID: e8938fd3328e95dcf59dd64e7facd2c7d67c704d
Locale: nl_NL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107739


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107739
[Bug 107739] [META] Field bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

--- Comment #9 from V Stuart Foote  ---
*** Bug 107533 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

Telesto  changed:

   What|Removed |Added

 Blocks||88173, 88171

--- Comment #8 from Telesto  ---
(In reply to Aron Budea from comment #7)
> Setting to NEW, as the issue has been reproduced.
> So there are two, closely related issues:
> -fixed date is not fixed anymore when exported to DOC,
> -fixed date can come back in different language when exported to DOCX.

Confirming with:
Version: 5.3.0.0.beta1
Build ID: 690f553ecb3efd19143acbf01f3af4e289e94536
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; Layout Engine:
new; 
Locale: nl-NL (nl_NL); Calc: C


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=88171
[Bug 88171] [Meta] Tracking bug for limitations of binary DOC format
https://bugs.documentfoundation.org/show_bug.cgi?id=88173
[Bug 88173] [Meta] Tracking bug for limitations of DOCX (OOXML) format
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100961] After inserting Fixed Date, and saving in DOC format, the date is not fixed anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100961

Aron Budea  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
   Hardware|x86-64 (AMD64)  |All
Summary|Insert Fixed Date Field |After inserting Fixed Date,
   |Inserts Current Date|and saving in DOC format,
   ||the date is not fixed
   ||anymore
 OS|Windows (All)   |All

--- Comment #7 from Aron Budea  ---
Setting to NEW, as the issue has been reproduced.
So there are two, closely related issues:
-fixed date is not fixed anymore when exported to DOC,
-fixed date can come back in different language when exported to DOCX.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs