[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #17 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6c2dae8259bf666d906b4d0c1ccd64aa14c6500c=libreoffice-5-2

tdf#102010 Never overwrite MM files via UNO

It will be available in 5.2.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0 target:5.3.0.1 |target:5.4.0 target:5.3.0.1
   ||target:5.2.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #16 from Alex Kempshall  ---
Downloaded daily build and tested successfully

Version: 5.3.0.0.beta1+
Build ID: c7e7a634cf5941fffd97102fe4252aee7445e36b

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #15 from Jan-Marek Glogowski  ---
There is now a libreoffice-5-3 build available @
http://dev-builds.libreoffice.org/daily/libreoffice-5-3/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #14 from Alex Kempshall  ---
I've done a git pull on master and tested got the expected results. So tick in
the box here.

Can't find a daily build for 5.3.0.1 so can't test this. Can someone advise?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #13 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5b4b60b2d81452c79ece99c51f63199b7dcf4b1d=libreoffice-5-3

tdf#102010 Never overwrite MM files via UNO

It will be available in 5.3.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0|target:5.4.0 target:5.3.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #12 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbf246e40c7814bfc4038d456d388d1f90048287

tdf#102010 Never overwrite MM files via UNO

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #11 from Alex Kempshall  ---
 Jan-Marek Glogowski has supplied a private patch which I've tested these tests
successfully -

1. Saving as multiple files with prefix - Success
2. Saving as multiple files with no prefix - Success
3. Saving as a single file with prefix - Success
4. Saving as a single file with no prefix - Success

Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||patch

--- Comment #10 from Xisco Faulí  ---
Hi Alex,
Thanks for submitting the patch. Could you please submit it to gerrit directly?
More info: https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #9 from Alex Kempshall  ---
I've attached a proposed patch for bug 102010. It works for me!

Though it does make a nonsense of the conditional statement as now both legs
are the same. 

   if( rMergeDescriptor.sPath.isEmpty() )
aTempFileURL.SetURL( aTempFile->GetURL() );
else
aTempFileURL.SetURL( aTempFile->GetURL() );


So clearly I need to clarify my understanding of what this condition statement
is supposed to achieve.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #8 from Alex Kempshall  ---
Created attachment 128544
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128544=edit
git diff patch for bug 102010

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #7 from Xisco Faulí  ---
Changing it to NEW as the problematic commit has been identified.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Alex Kempshall  changed:

   What|Removed |Added

 CC||mcmurchy1917-bugzilla@yahoo
   ||.co.uk

--- Comment #6 from Alex Kempshall  ---
Created attachment 128011
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128011=edit
bisect log for this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Alex Kempshall  changed:

   What|Removed |Added

   Keywords||bisected, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #5 from Alex Kempshall  ---
In the code above the lines 

DirectoryName = DirectoryNameoutofPath(ThisComponent.getURL(), "/") & "/"

If (Not GlobalScope.BasicLibraries.isLibraryLoaded("Tools")) Then
   GlobalScope.BasicLibraries.LoadLibrary("Tools")
End If



should be swapped to read


If (Not GlobalScope.BasicLibraries.isLibraryLoaded("Tools")) Then
   GlobalScope.BasicLibraries.LoadLibrary("Tools")
End If

DirectoryName = DirectoryNameoutofPath(ThisComponent.getURL(), "/") & "/"



Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #4 from Alex Kempshall  ---
I'm seeing this problem in 5.2.2.2 and in 5.3.0.0.alpha0+ Master, when running
a basic macro in Base which is expected to produce a merged file from a dataset
pulled from MariaDB. 

What I get is a file called CompanyMerged when I'm expecting a file called
CompanyMerged0.odt

This problem wasn't present in 5.1.5.2 when I get the expected file
CompanyMerged0.odt 

I've also replicated the problem using a macro in Writer using the following
code. In this code I've changed the FileNamePrefix so the file won't get
overwritten each time.


Dim oMailMerge as Object
Dim DirectoryName as String

DirectoryName = DirectoryNameoutofPath(ThisComponent.getURL(), "/") & "/"

If (Not GlobalScope.BasicLibraries.isLibraryLoaded("Tools")) Then
   GlobalScope.BasicLibraries.LoadLibrary("Tools")
End If

oMailMerge = CreateUnoService("com.sun.star.text.MailMerge")
oMailMerge.DataSourceName =  "CompanySeed"
oMailMerge.DocumentURL =  ConvertToUrl(DirectoryName &
"CompanySeed.odt")
oMailMerge.CommandType = 0
oMailMerge.Command = "CompanySeed"
oMailMerge.OutputType = com.sun.star.text.MailMergeType.FILE
oMailMerge.OutputUrl = ConvertToUrl(DirectoryName)
oMailMerge.FileNamePrefix = "Merged-" &  Format(Now, "mmddHHMMSS")
& "-"
oMailMerge.SaveAsSingleFile=True
oMailMerge.FileNameFromColumn=False
oMailMerge.Filter=""

oMailMerge.execute(Array())

oMailMerge.dispose()


The above code needs the data and the starting file setting up first. I'm
finding it easier to create these using the Mail Merge Wizard. 

Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Buovjaga  changed:

   What|Removed |Added

 Blocks||102998


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102998
[Bug 102998] [META] Mail merge bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

PAlex  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from PAlex  ---
(In reply to Jan-Marek Glogowski from comment #2)

Indeed, we use .NET on Windows.
Our parameters weren't changed :
We use a "DataSourceName", a "Command" as table name and a "CommandType" set on
a unoidl.com.sun.star.sdb.CommandType.TABLE (0).

For output, we're targeting a path :
"OutputType" as unoidl.com.sun.star.text.MailMergeType.FILE (2)
"OutputURL", for example "file:///D:/LO52/"
"SaveAsSingleFile" set as true.

Finally our ready-to-merge document :
"DocumentURL", for example "file:///D:/LO52/test.odt.updated.odt"

Under LO5.2.0.4, MM execute produces "D:\LO52\test.odt.updated"

Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||glo...@fbihome.de
 Ever confirmed|0   |1

--- Comment #2 from Jan-Marek Glogowski  ---
I did a lot of changes to MM in January, and I have the feeling, that

commit e637b6743a506ef74c93ccbe15ab6642f3baa34f
Author: Jan-Marek Glogowski 
Date:   Thu Mar 24 13:43:46 2016 +0100

MM: move email subject and address into descriptor

broke your setup.

>From the subject I guess you call MM via .NET on Windows, which I don't have,
but quite probably also don't need.

I have some ideas about your parameters, but since MM is quite complex with
many options and I don't want to test all variants, please provide the exact
UNO argument list you use in your call of the MM job execute function.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

--- Comment #1 from PAlex  ---
LO5.2.1.2 has the same behaviors as LO5.2.0.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs