[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com
 Blocks||94774


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=94774
[Bug 94774] [META] OOXML object fill bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

--- Comment #5 from Commit Notification 
 ---
lbenes committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=24998064599e3371208ad8ae4b149d754828d35b=libreoffice-5-2

tdf#102997 Fix Error in OOXML Transparency Conversion Math

It will be available in 5.2.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.2.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

Luke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

--- Comment #4 from Commit Notification 
 ---
lbenes committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ade43e6a86e4f864e771f4b3008a428bc10fa55f

tdf#102997 Fix Error in OOXML Transparency Conversion Math

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

--- Comment #3 from Miklos Vajna  ---
Best if you submit to gerrit, along with a matching testcase. Based on
testTdf100830 in sw/qa/extras/ooxmlimport/ooxmlimport.cxx, hopefully you can
add a new test easily.

If needed, of course I can help. :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

--- Comment #2 from Luke  ---
Miklos,

--- a/oox/source/drawingml/fillproperties.cxx
+++ b/oox/source/drawingml/fillproperties.cxx
@@ -655,7 +655,7 @@ void FillProperties::pushToPropMap( ShapePropertyMap&
rPropMap,
 }

 if (maBlipProps.moAlphaModFix.has())
-rPropMap.setProperty(ShapeProperty::FillTransparency,
static_cast(maBlipProps.moAlphaModFix.get() / PER_PERCENT));
+rPropMap.setProperty(ShapeProperty::FillTransparency,
static_cast(100 - (maBlipProps.moAlphaModFix.get() / PER_PERCENT)));
 }
 break;



Fixed the import conversion. 


Is the right place to do the conversion? Do you need to use const like
PER_PERCENT or is 100 OK here? Can you take care of applying this fix or do you
want me to submit a patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0830

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

--- Comment #1 from Luke  ---
Created attachment 127815
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127815=edit
Example of the Bug

The transparency calculation only works for .5 ( 1-.5=.5). Other values give
the complement. .7 -> .3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs