[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #56 from Regina Henschel --- No it is not fixed. When saving in ODF 1.3 extended (our current default) the attribute has to be written with "loext" prefix. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #55 from Dennis Roczek --- (In reply to Michael Stahl (allotropia) from comment #54) > thanks to Regina there is now ODF proposal: > https://issues.oasis-open.org/browse/OFFICE-4125 So this is accepted for ODF1.4. Is that bug now "fixed"? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Regina Henschel changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||1546 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #54 from Michael Stahl (allotropia) --- thanks to Regina there is now ODF proposal: https://issues.oasis-open.org/browse/OFFICE-4125 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #53 from Regina Henschel --- The current master writes draw:fill not only to where it belongs but in addition to . For ODF 1.3 strict the latter is suppressed. But in ODF 1.3 extended it should neither be there. That problem could be solved immediately. It is independent from header or footer fill. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #52 from Regina Henschel --- Next step besides using loext namespace: Write a proposal for ODF TC, to allow attribute draw:fill in header and footer. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #51 from Regina Henschel --- It is not solved. draw:fill attribute is still written in style:header-footer-properties in ODF 1.3 extended. Tested with Version: 7.1.1.2 (x64) / LibreOffice Community Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676 CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL and with Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 076da4cd9d61adf15942a7bfc350bd0d268f64f1 CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #50 from Justin L --- Is there anything in this bug report that is still outstanding or should the bug be closed now? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Commit Notification changed: What|Removed |Added Whiteboard|odf target:7.0.0|odf target:7.0.0 |target:6.4.5 target:7.1.0 |target:6.4.5 target:7.1.0 |target:7.0.0.1 |target:7.0.0.1 target:7.0.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #49 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/fb87c2ae2d28665f6d95df8ff5ac410db2dccb45 tdf#103602 xmloff: ODF export of page style: don't export draw:fill It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #48 from Michael Stahl (CIB) --- oops, i forgot to add the issue id to the commit: commit dd7caf3cfd3de636c8bf37c8347c1b72b3772aeb (logerrit/master) Author: Michael Stahl AuthorDate: Wed Aug 19 18:12:01 2020 +0200 Commit: Michael Stahl CommitDate: Thu Aug 20 10:56:02 2020 +0200 xmloff: ODF export of page style: don't export draw:fill ... attributes on header-style and footer-style in strict ODF. Change-Id: Ic1af26b6112a5afbb70a82b29dbacd3dcec14ec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101012 Tested-by: Jenkins Reviewed-by: Michael Stahl ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Michael Stahl (CIB) changed: What|Removed |Added CC||svante.schub...@gmail.com --- Comment #47 from Michael Stahl (CIB) --- there is still an open problem here in ODF 1.2 non-extended, with draw:fill on header/footer, as found by Svante yesterday. /tmp/70.odt/styles.xml[2,424511]: Error: unexpected attribute "draw:fill" fill="none" draw:fill-color="#4f81bd"/>___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #46 from Miklos Vajna --- We have this trade-off that we either conform to the spec fast or we care about existing documents, where users typically expect full backwards-compatibility. I believe we can't meet both requirements at the same time. My understanding is that we already write valid ODF in the non-extended case, and we can phase out the invalid ODF output over time in the extended case as well. So the status quo looks like a reasonable compromise to me. Next time perhaps we can detect & fix such problems earlier. I think this was introduced in commit 7d9bb549d498d6beed2c4050c402d09643febdfa (Related: #i124638# Second step of DrawingLayer FillAttributes..., 2014-06-02), and now, 6 years later, we can't just fix such things instantly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #45 from Michael Meeks --- Agreed with Thorsten (for what it is worth) - though it is not beautiful of course. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #44 from Thorsten Behrens (CIB) --- I agree with Michael - I believe erring on the side of pragmatism when it comes to interop is the right approach. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #43 from Michael Stahl (CIB) --- that is all true but we can't compel users to actually upgrade to the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #42 from Regina Henschel --- For older versions the document can be saved in "ODF 1.2 extended". I think, that users of LO 6.3 or older 6.4 versions cannot expect, that those versions can read "ODF 1.3 extended", a new feature of LO 7.0, although that will work in many cases. And we are already after "End of Lifetime" date for LO 6.3. and when LO 7.0 will be released, the version 6.4.5 is already available. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #41 from Michael Stahl (CIB) --- (In reply to Regina Henschel from comment #40) > Shouldn't LO70 produce valid ODF 1.3? The invalid draw:fill attributes are > still in style:page-layout-properties in ODF 1.3 extended. I thought it > would be enough to keep the invalid attributes in ODF1.2 extended. the problem with this is that the import commit is only in LO 6.4.5 or later, so a lot of users can't import the drawing-page style yet. i would wait some time, perhaps until the ODF 1.4 implementation, to remove the export of the invalid attributes in ODF 1.x Extended. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #40 from Regina Henschel --- Shouldn't LO70 produce valid ODF 1.3? The invalid draw:fill attributes are still in style:page-layout-properties in ODF 1.3 extended. I thought it would be enough to keep the invalid attributes in ODF1.2 extended. What does the other CCs think? ODF 1.3 strict, ODF 1.2 strict are OK. ODF 1.2 extended is as agreed. draw:background-size is OK. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #39 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/05dfd20fd42f57d681fb65d3fee6b5fe10f4ea1b tdf#103602 xmloff: ODF export of page style: don't export draw:fill It will be available in 7.0.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #38 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/4166cf43d2a56b0c2e9a3bf4c15d906be025ada6 tdf#103602 xmloff: ODF export: draw:background-size attribute It will be available in 7.0.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Commit Notification changed: What|Removed |Added Whiteboard|odf target:7.0.0|odf target:7.0.0 |target:6.4.5 target:7.1.0 |target:6.4.5 target:7.1.0 ||target:7.0.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #37 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ef2e609b9c3c4b568e1d04360f81b5f614fa6bd8 tdf#103602 xmloff: ODF export of page style: don't export draw:fill It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #36 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/415fac828c4bb45fa23f7d81e93992b711f37810 tdf#103602 xmloff: ODF export: draw:background-size attribute It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Commit Notification changed: What|Removed |Added Whiteboard|odf target:7.0.0|odf target:7.0.0 |target:6.4.5|target:6.4.5 target:7.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #35 from Regina Henschel --- (In reply to Regina Henschel from comment #34) With such restriction in save to "ODF 1.3 > strict" LibreOffice would still not render conform to the spec text (= > draw:fill in a style disables and > ), but at least the produced documents would contain > valid XML. I was wrong in this regard. The draw:fill attributes are used, and neither nor . That works in LO 6.4.5 with ODF 1.3 format too. But saving to "ODF 1.2 strict" writes the draw:fill attributes into too. That should not happen for the "strict" file formats. Only in "ODF 1.2 extended" and "ODF 1.2 compatible" the faulty attributes should be written. Not using loext for "ODF 1.2 extended" is already a concession to older LibreOffice versions, so "ODF 1.2 strict" should be correct. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #34 from Regina Henschel --- I think, that the attribute drawing:background-size should be written in addition to the element. So when reading this element is implemented, the documents would have already the correct settings. That attribute is optional but has no default. So it would be good, if the documents contain the correct setting. In Writer fill with gradient, color, pattern and hatch fills the entire page, so that would be drawing:background-size="full". Fill with bitmap still fills only inside border, so that would be drawing:background-size="border". And I think, in case of saving to "ODF 1.3 strict", the attribute draw:fill and connected attributes should not be written to the at all. Users who need the additional features which are possible with attribute draw:fill and the connected attributes, can save to "ODF 1.3 extended". With such restriction in save to "ODF 1.3 strict" LibreOffice would still not render conform to the spec text (= draw:fill in a style disables and ), but at least the produced documents would contain valid XML. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #33 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/ca9a719169fa444b5d82942ae1d5600fa0114002 tdf#103602 xmloff,sw: ODF 1.3 import: PageStyle with drawing-page style It will be available in 6.4.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Commit Notification changed: What|Removed |Added Whiteboard|odf target:7.0.0|odf target:7.0.0 ||target:6.4.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Michael Stahl (CIB) changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|michael.st...@cib.de|libreoffice-b...@lists.free ||desktop.org --- Comment #32 from Michael Stahl (CIB) --- the part that is possible to fix in ODF 1.3 via OFFICE-3937 is fixed on master now. what remains is the general case of draw:fill on things that aren't master-pages; that can't be fixed until we get new features in ODF 1.4. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Xisco Faulí changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |michael.st...@cib.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Michael Stahl (CIB) changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #29 from Michael Stahl (CIB) --- it looks like only Writer supports the draw:fill properties on page styles, while Calc only writes the old color/bitmap markup. i'm afraid we'll have to continue to export the draw:fill on the style:page-layout-properties for now (at least in extended) because there's no import yet for drawing-page-properties/draw-page style. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #28 from Regina Henschel --- The problem still exists in Version: 6.3.0.0.alpha0+ (x64) Build ID: 4c8349f138f1269120180c663d82b534d60c1f73 CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; Locale: de-DE (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #27 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Xisco Faulí changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|l...@deller.id.au |libreoffice-b...@lists.free ||desktop.org --- Comment #26 from Xisco Faulí --- Dear Luke Deller, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Luke Deller changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |l...@deller.id.au |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #10 from Regina Henschel --- All the draw:fill-* attributes are in a symbol in the schema. Unfortunately it has some attributes more than needed here. We could add a reference to the "style-graphic-fill-properties-attlist" symbol into the symbol in the schema. I'm not sure, whether we need to exclude some of the attributes in the spec description and how this has to be done. Perhaps we need to extract some attributes from the and use them instead. The fo:background-color attribute is wrapped in a symbol in the schema. I prefer to have the draw:fill-* attributes at the same level as the fo:* attributes. ODF1.2 has already a rule how to handle draw:fill and fo:background-color, if both attributes exist on the same style, in the section 20.175. So here it would mean to exchange the erroneous "draw:fill" with a "loext:fill", same for all other attributes on which the validator reports an error. All kind of fill styles have to be checked. I know, that for paragraph background the way with new was chosen. But the paragraph style has a different context. It is a element and the selection of the attributes is done by family, whereas the page background belongs to a element. Thorsten: Is it OK for you? Luke: Do you want to work on this issue? If yes, then assign it to you. And if you have finished work on the issue, please add the new use of "loext:" namespace to https://wiki.documentfoundation.org/Development/ODF_Implementer_Notes/List_of_LibreOffice_ODF_Extensions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #9 from Thorsten Behrens (CIB) --- (In reply to Regina Henschel from comment #8) > Thorsten, can you please have a look at it, how a solution should look in > principle? > No real better ideas - but loext:page-fill seems redundant to me, too. Perhaps we can restructure the schema a bit, so that fill attributes are grouped better, instead of repeatedly listed at various places? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Regina Henschel changed: What|Removed |Added CC||t...@libreoffice.org --- Comment #8 from Regina Henschel --- Thorsten, can you please have a look at it, how a solution should look in principle? (In reply to Luke Deller from comment #6) > I understand from these comments that ODF does not support page fill by > gradient/hatching for text documents, so we will need to move this > information into the "loext" extension namespace. > > To achieve this how about we make a child element of > named , and move all the > draw:fill-* attributes onto this child element? Or any better suggestions? I'm no sure about a solution. We need to keep in mind, how a final solution without namespace "loext:" can be realized in ODF 1.3. Do you have an idea about changing the schema and the specification? >From a technical point of view, you can put all the currently not allowed draw:fill-* attributes individually into the "loext:" namespace, without a new element. Please talk to Thorsten Behrens about a principle solution, perhaps via IRC. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #7 from Regina Henschel --- Please have look at the similar issue bug 94768. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #6 from Luke Deller --- I understand from these comments that ODF does not support page fill by gradient/hatching for text documents, so we will need to move this information into the "loext" extension namespace. To achieve this how about we make a child element of named , and move all the draw:fill-* attributes onto this child element? Or any better suggestions? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Regina Henschel changed: What|Removed |Added Blocks||108198 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108198 [Bug 108198] [META] ODF export is unsuitable or invalid -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||3224 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #5 from Xisco Faulí --- Adding Cc: to Rishabh Kumar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #4 from Regina Henschel --- (In reply to Katarina Behrens (CIB) from comment #3) > As far as I can see, Format > Page dialog in Writer (Libreoffice 5.1, so the > old one existing prior to GSoC code merge) offers *all* kinds of fills for a > page, not only colour and bitmap/image. Does this mean that the other fill > types have never been saved to ODF and now they are? The file format error slipped in from LO 4 to LO 5. Version 4.1 and 4.2 had the old background selection with color and image as still available in Calc. Version 4.3 and 4.4 had the item "gradient" added, but that was without any function. Version 4.5 had got fill kind "gradient" and "hatching" and the worked, but they were not written to file, and therefore any gradient or hatching was lost on save and replaced with a single color fill in LO 4.5. Writing invalid ODF slipped in after version 4.5 and it is not a problem of this year GSoC. The error itself was made in version 4, when adding a new kind of filling, without considering ODF file format. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 --- Comment #3 from Katarina Behrens (CIB) --- Can anyone please 'splain what exactly the issue here is, pretty please? For example, paste some ODF XML diff before vs. after > So currently exists no way to express other kind of fillings beside color or > image for a text document or for a spreadsheet in ODF. As far as I can see, Format > Page dialog in Writer (Libreoffice 5.1, so the old one existing prior to GSoC code merge) offers *all* kinds of fills for a page, not only colour and bitmap/image. Does this mean that the other fill types have never been saved to ODF and now they are? As for Calc (again in Libreoffice 5.1), I only see the option to set background to solid colour (Format > Cells > Background) and the tab page used for that is different than the tab page used for shape fill (Background vs. Area, they only look similar) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #2 from Regina Henschel --- It is a hard problem. The "draw:fill" attribute may not be used in the element . And the element has no other children or attributes that are suitable. For Draw and Impress, this is solved by an element of style family "drawing-page". But this family is only usable with draw and presentation documents. For Calc it is solved by restricting the background filling to color and image, because those do not need an attribute "draw:fill". Color is written by the attribute "fo:background-color" and an image by the child element of the element . Writer was restricted in the same way in older versions of LibreOffice. So currently exists no way to express other kind of fillings beside color or image for a text document or for a spreadsheet in ODF. There are suggestions required, how to solve this problem in ODF. Such considerations would have been necessary _before_ implementing the new feature. Another problem is, to get it into the namespace "loext", because only whole elements and attributes have a namespace, but not a single value. Where should this be discussed, so that it is really public? Here in the issue, or on the dev mailing list, or in a Wiki page or ...? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Aron Budea changed: What|Removed |Added Keywords||bisected Priority|medium |high Status|UNCONFIRMED |NEW CC||ba...@caesar.elte.hu Blocks||103223 Ever confirmed|0 |1 Severity|normal |major --- Comment #1 from Aron Budea --- It's the second candidate: https://cgit.freedesktop.org/libreoffice/core/commit/?id=686349476e03f951f4a9ff9755b9f71951b64ea5 "[GSoC] Move all fill style tabs inside area tab" Full bibisect log: # bad: [845539f0cf09355a7baa6d1cfbf6ad478a983da5] source sha:8dc495c93239739629683bb29e4110f5c57c94f0 # good: [33e60eae04c889baf52713a73dc9944015408914] source sha:5b168b3fa568e48e795234dc5fa454bf24c9805e git bisect start '845539f0cf09355a7baa6d1cfbf6ad478a983da5' '33e60eae04c889baf52713a73dc9944015408914' # good: [9e0af0bfb61955f2a7bcae3a25a403cfc01919f4] source sha:e8365711e817876ee45b282fc16977b55f4dbca8 git bisect good 9e0af0bfb61955f2a7bcae3a25a403cfc01919f4 # good: [45cf7c7435abbc97ae9773953e5f582784b91c1c] source sha:d5f1e7c5adac5f38379c56b536640f3aaf9ec7d5 git bisect good 45cf7c7435abbc97ae9773953e5f582784b91c1c # good: [be8f9784b28d086ec451f86ed968fe0364b26382] source sha:8413d6a91d5d03c0c47a8fbd2e41cd45cec95a1c git bisect good be8f9784b28d086ec451f86ed968fe0364b26382 # skip: [681fc5fe4f850e7885faf8fc43b1c7f377f6f902] source sha:613213240a84327a0a72bb5ee98cc88d50c1fd0e git bisect skip 681fc5fe4f850e7885faf8fc43b1c7f377f6f902 # bad: [6892f3a21a61c0aeb726e060576b291e08b052d6] source sha:398d641664baa6eaeb34789f0aebfd21e73edef3 git bisect bad 6892f3a21a61c0aeb726e060576b291e08b052d6 # bad: [c8e7036b5e5248aa5b20315767d55832fc7d0375] source sha:0f613adbfa44fb92e84e73a3fa7ea050c072944c git bisect bad c8e7036b5e5248aa5b20315767d55832fc7d0375 # good: [1c9e9a7ab9725516a6f9f20326439a6c025cd222] source sha:583ac140dcf6f11b21bc9c52516ba2bbcbd37a95 git bisect good 1c9e9a7ab9725516a6f9f20326439a6c025cd222 # bad: [3177d9338fb3d48f40a5a13b980d6e829f4bf76d] source sha:e6a05e9f3276e5d72adce24a8d2fee6b8b7b git bisect bad 3177d9338fb3d48f40a5a13b980d6e829f4bf76d # good: [459a28dbbb27faacb725b523cb2671b2debd] source sha:34698034dbfe59bf444709fcf54d01f8a6f03f83 git bisect good 459a28dbbb27faacb725b523cb2671b2debd # bad: [281ec4b684aeba7aaf527e64e6cb187b8a1e95d5] source sha:a77ff8446e7ed2255b11406b4ccce7ec742d7c67 git bisect bad 281ec4b684aeba7aaf527e64e6cb187b8a1e95d5 # bad: [cff3c3864a46cefde1b6e3145995b28ae6f9f008] source sha:0d93900801224b797741e9a1abf305109fa35665 git bisect bad cff3c3864a46cefde1b6e3145995b28ae6f9f008 # good: [9c0485b505f9dbb84accf1a902a234b234f5] source sha:ed3a4fcc878e8f3ce720520d60448bc962da0754 git bisect good 9c0485b505f9dbb84accf1a902a234b234f5 # bad: [b3691ee4f35b2dcea8bec7daecc981792844] source sha:686349476e03f951f4a9ff9755b9f71951b64ea5 git bisect bad b3691ee4f35b2dcea8bec7daecc981792844 # good: [2d0914fa553e754fe5942c037898e21102d93388] source sha:da01e9ec5dfb7787b4a3669486b3940590933850 git bisect good 2d0914fa553e754fe5942c037898e21102d93388 # first bad commit: [b3691ee4f35b2dcea8bec7daecc981792844] source sha:686349476e03f951f4a9ff9755b9f71951b64ea5 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103223 [Bug 103223] [META] Area fill tab bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103602] new documents fail ODF validation with Error: unexpected attribute "draw:fill"
https://bugs.documentfoundation.org/show_bug.cgi?id=103602 Justin L changed: What|Removed |Added Keywords||bibisected, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
