[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Khaled Hosny  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |khaledho...@eglug.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #19 from Commit Notification 
 ---
Khaled Hosny committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e63617ef934d3602bbc22f0f01c77b024347e60=libreoffice-5-3

tdf#103765: Round positions instead of truncating

It will be available in 5.3.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0 target:5.4.0   |target:5.3.0 target:5.4.0
   ||target:5.3.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #18 from Commit Notification 
 ---
Khaled Hosny committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9eb4b14ffa57cd7bbdf0fc43096f5f1e65c8e388

tdf#103765: Round positions instead of truncating

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Khaled Hosny  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #17 from Khaled Hosny  ---
*** Bug 104738 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #16 from Mike Kaganski  ---
Created attachment 129796
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129796=edit
Screenshot of menu with HarfBuzz and https://gerrit.libreoffice.org/32211
applied

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Mike Kaganski  changed:

   What|Removed |Added

 CC||mi...@filmsi.net

--- Comment #15 from Mike Kaganski  ---
*** Bug 104575 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #14 from Adolfo Jayme  ---
*** Bug 104223 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4223

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Mike Kaganski  changed:

   What|Removed |Added

   Priority|medium  |high
   Severity|normal  |major

--- Comment #13 from Mike Kaganski  ---
As the problem seems to impair usage of LO by users with poor eyesight, I raise
the importance of this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #12 from Khaled Hosny  ---
I guess so, though to be honest I’m not 100% sure it will fix this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #11 from Mike Kaganski  ---
(In reply to Khaled Hosny from comment #10)
> So I think this all comes down to the fact that we don’t do subpixel
> positioning and accumulate rounding error, i.e. bug 103322.

... in which case the abovementioned issue is no more an enhancement, and this
one depends on it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #10 from Khaled Hosny  ---
So I think this all comes down to the fact that we don’t do subpixel
positioning and accumulate rounding error, i.e. bug 103322.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Mike Kaganski  changed:

   What|Removed |Added

 Attachment #129023|Screenshot of menu with |Screenshot of menu with
description|HarfBuzz and|HarfBuzz
   |c49d5dea164b09b05a898495fa2 |
   |dd48b7ca4f0e4 applied   |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #9 from Mike Kaganski  ---
Created attachment 129025
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129025=edit
Screenshot of menu without HarfBuzz

Previous state. Please notice that this is *almost* identical to how HarfBuzz
works with d35b5c8db00afb0316b7ae4c43126a5dad194cbb reverted; but there are
still sometimes 1-pixel shifts.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #8 from Mike Kaganski  ---
Created attachment 129024
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129024=edit
Screenshot of menu with HarfBuzz and c49d5dea164b09b05a898495fa2dd48b7ca4f0e4
applied

This is with d35b5c8db00afb0316b7ae4c43126a5dad194cbb reverted. I mistakingly
named previous as "c49d5dea164b09b05a898495fa2dd48b7ca4f0e4 applied", but
actually this one is.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #7 from Mike Kaganski  ---
Created attachment 129023
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129023=edit
Screenshot of menu with HarfBuzz and c49d5dea164b09b05a898495fa2dd48b7ca4f0e4
applied

Yes, Bug 104173 is indeed a dupe for this.
Reverting commit d35b5c8db00afb0316b7ae4c43126a5dad194cbb (i.e. activating
commit c49d5dea164b09b05a898495fa2dd48b7ca4f0e4) makes things much better.

This screenshot made with screen resolution shows current state on Windows
(HarfBuzz enabled, commit c49d5dea164b09b05a898495fa2dd48b7ca4f0e4 partially
reversed).
The following two screenshots show the same area for reverted
d35b5c8db00afb0316b7ae4c43126a5dad194cbb, and previous state (with old layout
engine). It's better to switch between them in sequence when their position on
screen is the same, to see pixel differences.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Adolfo Jayme  changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #6 from Adolfo Jayme  ---
*** Bug 104173 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Khaled Hosny  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

--- Comment #5 from Khaled Hosny  ---
The fix for this caused bug 103891, so I’m going to revert it.

Thinking about this again, this big might related to the fact that we don’t use
FreeType to get glyph advance widths so if FreeType changed the width (e.g.
because of hinting), we might be using different glyph widths for layout. Not
sure how to fix this, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Khaled Hosny  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Khaled Hosny  ---
This should be fixed now. There is still some difference (the new text might be
slightly wider) but I believe the new rendering is the correct one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

--- Comment #3 from Commit Notification 
 ---
Khaled Hosny committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c49d5dea164b09b05a898495fa2dd48b7ca4f0e4

tdf#103765: Minimize the effect of rounding to int

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
  Component|Writer  |graphics stack
 Ever confirmed|0   |1

--- Comment #2 from Aron Budea  ---
Confirmed with the same 5.3 daily build / Ubuntu 16.04.

Also confirmed with alpha1.
To be clear, I used SAL_USE_COMMON_LAYOUT to enable common layout in alpha1,
and SAL_NO_COMMON_LAYOUT to disable common layout in the daily build, and in
both cases the rendering of menus looked cramped when common layout was
enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103765] Rendering of system font cramped with Harfbuzz

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103765

Khaled Hosny  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org

--- Comment #1 from Khaled Hosny  ---
On Linux, HarfBuzz is used in both old a new layout engines, and the code is
mostly based on the old Linux code, so I’m surprised there is a difference.

Can you test with the alpha release and see if you can see the difference there
as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs