[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

--- Comment #10 from Eike Rathke  ---
(Just collecting info and material here for a later README or such)
oxttools, Tools for creating language support oxt extensions for LibreOffice
https://github.com/silnrsi/oxttools

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

--- Comment #9 from Stephan Bergmann  ---
(In reply to Eike Rathke from comment #8)
> I'm not quite sure about the oor:op="fuse" vs oor:op="replace" attribute,
> i.e. what would actually happen if there are multiple entries for one name.

"replace" just puts the new node in place, completely ignoring any previously
existing one, if any, while "fuse" merges with the content of any previously
existing node, if any.  But since this node of type ExtraLanguage is a
non-extensible group with exactly two member props ("Name" and "ScriptType"),
both of which are explicitly set here, there's effectively no difference in
"replace" vs. "fuse" in this case.  (And if multiple extensions bring along an
"ExtraLanguages" set element named "nod-TH", a random one wins.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

--- Comment #8 from Eike Rathke  ---
The example has an error in that it adds the node under
 

which is wrong, instead it should be a separate item with a different path,
  


According to
https://lists.freedesktop.org/archives/libreoffice/2019-April/082441.html (see
full version of a dictionaries.xcu there) a working example is

  

  

  Northern Thai


  3

  

  

Adding the localization/translation capabilities that then might be

  

  

  Northern Thai
  Your favorite translation here...


  3

  

  

I'm not quite sure about the oor:op="fuse" vs oor:op="replace" attribute, i.e.
what would actually happen if there are multiple entries for one name.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

--- Comment #7 from Eike Rathke  ---
Presumably this is how it's supposed to work:

In dictionaries.xcu have

 
   
 ...
 
   nod-TH
 
   
   
 
   
 Default US English UI name
 Your favorite translation here...
   
   
 3
   
 
   
 

Where "nod-TH" is a BCP 47 language tag for the dictionary's
language/locale to be added to the Language list in dialogs, represented
in the UI by the "Name" defined.

ScriptType value 3 here means CTL. The values are explained in
officecfg/registry/schema/org/openoffice/VCL.xcs under

See
https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/VCL.xcs?r=33e80611#79

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

--- Comment #6 from Eike Rathke  ---
@Martin:
The download of the sample from scriptsource.org meanwhile appears to be
broken, could you please add documentation here how to actually use the new
ExtraLanguage Name and ScriptType properties in a dictionary? Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

martin_hos...@sil.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from martin_hos...@sil.org ---
This issue is fixed in libreoffice 5.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

Stephan Bergmann  changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #4 from Stephan Bergmann  ---
Martin, if the commit from comment 3 is all that was needed for this issue,
please mark as RESOLVED - FIXED.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

--- Comment #3 from Commit Notification 
 ---
Martin Hosken committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6b35e804198ac45386805e80a3d413ed3405c3b4

Fix tdf#103855 add language codes and names to language lists from extensions

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

--- Comment #2 from martin_hos...@sil.org ---
I've been asked why the changes to a core file like languagetag.hxx?

The way much of the core applications are set up for language is via the use of
LanguageTypes which are a 16-bit id after a MSLangId. The particular query I am
needing to address is the ScriptType of a given LanguageType. The ScriptType
tells us what category of script is used for the language. Primarily this is
for the western vs ctl vs asian split that controls font and language selection
based on characters in the text, but also for rtl and cjk querying in other
areas.

One option would be to query the language tag and ask for its script. The
problem here is that most language tags and their users do specify the script
in the tag. There is a big ambiguous hole in the language tag standard that
says: if you do not have a suppress script for your language then you may use a
script sub tag, but that you SHOULD not include the script if it adds no extra
distinguishing information to the tag. Therefore, for most languages in the
world, there is no need or desire to specify the script. But that means for
languages with no suppress script information, we do not know what the default
script is for the language. If we were to specify that in some way to the
language tag, the language tag would still not know whether or not to include
the script in the tag when it canonicalises it. And so I decided not to take
this particular implementation down that rather windy rabbit warren.

LanguageTag has a nice internal map of LanguageType to LanguageTagImpl, and we
can store the ScriptType in the LanguageTagImpl, which means it is more stable
than in a LanguageTag that can get remade many times. But the only way to get
to the LanguageTagImpl interface and the map is via the LanguageTag interface.
Hence the changes I have had to make to that interface. Unfortunately, this
interface is referenced pretty much everywhere and the result is a large build
churn. The hope is that we can minimise any re-changes to this interface, which
is considered mature and we don't want to demature it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

--- Comment #1 from martin_hos...@sil.org ---
An implementation patch is available for review
https://gerrit.libreoffice.org/#/c/30882/

There is no need to support sequence checking, since sequence checking has to
be built into code inside libreoffice and so will require a rebuild anyway. In
addition, sequence checking needs are very rare. Likewise, there is unlikely to
be many CJK type scripts, although a few.

An example .oxt that makes use of the new capability is available from:
http://scriptsource.org/cms/scripts/page.php?item_id=entry_detail=ccq6hrjrxc

Installing this will add a Shan entry in the language list for complex script
fonts in things like the character format dialog.

The public values for script type introduced could grow but would never need to
shrink. Notice how the RTL value implies another value (CTL) and any future
growth (not intended) would have numbers with similar implications of other
values.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103855] Add a language code via an extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103855

martin_hos...@sil.org changed:

   What|Removed |Added

 Blocks||103857


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103857
[Bug 103857] Allow addition of a new language via an extension
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs