[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #19 from pieter kristensen  ---
Created attachment 152468
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152468=edit
LO 6.4.0.0 with themed tabs in kde...

Thank you for the themed tabs. It looks great!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.4.0|target:6.4.0 target:6.3.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #18 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/466cc6c63c4020519d47ec442739f22d7779e901%5E%21

tdf#105884 Qt5 implement TabControl theming

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #17 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/430b406e5e8249983fc030aa0f867372f5da74d2%5E%21

tdf#105884 Qt5 implement TabControl theming

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #16 from Jan-Marek Glogowski  ---
Created attachment 150541
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150541=edit
Qt5 tab theming (broken)

Just FYI: the tabbing widget is currently not Qt themed at all and never has
been. It's completely drawn by LO itself. Nothing has changed since my comment
6. Actually the patch from back then is lost; or more probably I couldn't get
it working back then, just like I tried again a few days ago.

As for the current state: something is very broken with the way LO tries to
draw various frames. The attached patch can theme the tabs, but I couldn't get
it to draw the frame of the tab widget at all!

There is still the general frame painting problem. That's also the reason the
Calc input bar has no frame, same for the Writer "character" format dialog,
where the font preview at the end of the dialog has no frame.

I don't understand, why the edit lines are drawn correctly, as this code isn't
really correct, but somehow works. Any change I made to this code broke it or
crashed LO.

Same for the border of popup menus.
It looks even worse, if you start QT_STYLE_OVERRIDE=windows
SAL_USE_VCLPLUGIN=qt5.

I've tried to fix this code multiple times now. I've read the Qt code, but even
that didn't help me understand what's wrong.
All this may actually be a Qt bug - I don't know.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #15 from andreas_k  ---
Created attachment 150391
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150391=edit
screenshot of LibO and Dolphin with tab layout

It getting better and better.

Please remove the thick line on the right border to the tab and on bottom of
the notebookbar.

In black mode it's better visible than on light color scheme.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #14 from andreas_k  ---
The QT5 backend is far away from a final design. sorry to say this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||bu...@bubli.org

--- Comment #13 from Roman Kuznetsov <79045_79...@mail.ru> ---
bubli, may be you are interesting for this bug because now we have new KDE
back-end?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks|102062  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102062
[Bug 102062] [META] Notebookbar: bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107191


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107191
[Bug 107191] [META] Notebookbar theming issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #11 from pieter kristensen  ---
Created attachment 131763
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131763=edit
tabs on march 8th look better

for unknown reason it looks nicer now on my system (neon user edition plasma
5.9.3 LO 5.3.0). 
When I start a wayland session it looks identical.
Very nice. Not 100% plasma 5 but even nicer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #10 from Buovjaga  ---
*** Bug 106061 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #9 from Heiko Tietze  ---
Created attachment 131285
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131285=edit
Tabs on LibreOffice vs. Calligra/Qt5 vs. Qt4_Config

Themes are not respected today, and we are still on Qt4. My screenshot is made
on LXQt/Kwin with Breeze Dark theme.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #8 from Buovjaga  ---
(In reply to pieter kristensen from comment #7)
> KDE4 backend? That could be, but shouldn't that be "KDE 5" backend?

Could, should and would:
https://wiki.documentfoundation.org/Development/GSoC/Ideas#KDE5:_port_KDE4_plugin_to_KF5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #7 from pieter kristensen  ---
Thank you for your reply. You ask: "So I guess your real complain is about
missing theming of LOs tabs in the KDE4 backend".

KDE4 backend? That could be, but shouldn't that be "KDE 5" backend?

The whole UI doesn't feel native at all if you use KDE.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #6 from Jan-Marek Glogowski  ---
So I guess your real complain is about missing theming of LOs tabs in the KDE4
backend.

Yup - it's not (yet) implemented.

I have a preliminary patch for this, but Qt4 distinguishes between right, left
and middle tabs, so I think I'll simply go with "everything middle", and there
is some strange metric handling, which I have to figure out.

If you have a build, I can provide a branch for you to test, but generally
it'll need some more time, as I'm currently overwhelmed by RL events.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com
 Blocks||102495


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

--- Comment #5 from pieter kristensen  ---
Created attachment 131153
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131153=edit
LibreOffice with libreoffice-gtk installed. X and Wayland

The X one resembles Breeze the most. Especially the tabs. It doesn't look 100%
like breeze (no system colors etc) but it is nice

The Wayland version is a surprise. Stange, it has no tabs but it looks nice.
Not breeze-like

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105884

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 Blocks||102062
Summary|Tabs of the tabbed muffin   |Make the tabs of tabbed
   |layout look ugly in kde |Notebookbar follow KDE
   ||style
 Ever confirmed|0   |1
   Severity|normal  |minor


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102062
[Bug 102062] [META] Notebookbar: bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs