[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

Markus Mohrhard  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail.
   |desktop.org |com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

--- Comment #16 from Markus Mohrhard  ---
Actually there are two independent issues that cause the update problem. The
commit identified through bibisecting misses the updates to conditional format
position (as handled by aSrcPos) and a later commit missed that formula
listeners are updated independently after the conditional format update and
therefore updated twice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

Xisco Faulí  changed:

   What|Removed |Added

 CC|matteo.casalin@libreoffice. |kohei.yosh...@collabora.com
   |org |

--- Comment #15 from Xisco Faulí  ---
The bisection done in comment 13 seems incorrect, since the code changed in
that commit is in sw. I've bisected it again and it pointed me to this commit:

author  Kohei Yoshida  2013-07-30 19:27:02 (GMT)
committer   Kohei Yoshida  2013-07-31 03:50:02
(GMT)
commit  0277792d169d66ad24734504ff33d2ec7d52ebaf (patch)
tree1f1968f9c65ccfd8184f6855a60e887805a2786d
parent  441e70aee90e83a9f8782a3f84482db86b857b87 (diff)
Rework reference update in conditional formatting and cell validation.
No tests are written for this yet.

Adding Cc: to Kohei Yoshida

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

--- Comment #14 from Xisco Faulí  ---
Just for the record, inserting a new sheet and deleting it didn't make the bug
to appear for me, however, duplicating the sheet and deleting it does

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

raal  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
 CC||matteo.casalin@libreoffice.
   ||org, r...@post.cz

--- Comment #13 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Matteo Casalin ; Could you possibly take a look at this one?
Thanks

1ff95022f992314c309f9f683b0852bb77f215f9 is the first bad commit
commit 1ff95022f992314c309f9f683b0852bb77f215f9
Author: Matthew Francis 
Date:   Sat Sep 5 19:30:03 2015 +0800

source-hash-734295ee6081686b62a4521dacf4975240e1109e

commit 734295ee6081686b62a4521dacf4975240e1109e
Author: Matteo Casalin 
AuthorDate: Sat Jul 27 12:56:48 2013 +0200
Commit: Luboš Luňák 
CommitDate: Wed Jul 31 09:59:58 2013 +

String to OUString

Change-Id: I412801fbc1a692c02badd15ce03d4d7ff82aab5e
Reviewed-on: https://gerrit.libreoffice.org/5186
Reviewed-by: Luboš Luňák 
Tested-by: Luboš Luňák 

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

m.a.riosv  changed:

   What|Removed |Added

   Keywords||regression
Version|3.3.0 release   |4.2.0.4 release
 OS|Linux (All) |All

--- Comment #12 from m.a.riosv  ---
It's also in master.
Version: 5.4.0.0.alpha0+
Build ID: 100e00fd3273536ebff130cfddc5da2b1fe609b1
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-04-20_05:12:24
Locale: es-ES (es_ES); Calc: CL

First version with the issue.
Versión: 4.2.0.0.beta1
Id. de compilación: f4ca7b35f580827ad2c69ea6d29f7c9b48ebbac7

Last version without the issue.
Versión: 4.1.6.2
Id. de compilación: 40ff705089295be5be0aae9b15123f687c05b0a

It happens when the new sheet it's inserted to the left but not to the right.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #11 from m.a.riosv  ---
The issue I can see.
- Open the sample file.
- J13 and L14 has not background color.
- Insert a new sheet.
- Delete de new sheet.
- J13 and L14 has now background color.
Hard recalc and enable and disable autocalculta doesn't solve the issue.


Version: 5.3.2.2 (x64)
Build ID: 6cd4f1ef626f15116896b1d8e1398b56da0d0ee1
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine:
new; 
Locale: es-ES (es_ES); Calc: group
Version: 5.2.7.1
Build ID: bf0fa7b86c7c0592941ede29fca6fafff642a948
CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; 
Locale: es-ES (es_ES); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

--- Comment #10 from Erike Magegere  ---
I have done the testing defined on the page
https://wiki.documentfoundation.org/UserProfile
and the error still occurs

User Profile Reset: No ==> Yes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

Erike Magegere  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #9 from Erike Magegere  ---
Status changed to UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

--- Comment #8 from Erike Magegere  ---
I have reviewed the attachments and noticed and error in description on the
"result after delete" screen shot (comment 5). The red background is not
created by the conditionals, it is the normal background.  The conditionals
apply a style that has a white background. (ie balance x = balance y - clear
the red error notice)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

--- Comment #7 from Erike Magegere  ---
I have attached cut spreadsheet and screen shots showing to get to the error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

--- Comment #6 from Erike Magegere  ---
Created attachment 132738
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132738=edit
sample sheet used to produce screen shots

Spreadsheet with personal data and labels removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

--- Comment #5 from Erike Magegere  ---
Created attachment 132737
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132737=edit
result after delete

this shows the cells with a red background created by the conditional formats. 
These are to alert the user of a balance error on the sheet. note that cell L14
shows "Hold OK" rather than "Hold Error" generated by a balance mismatch thus
the data has not changed and the cells should not be red.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

--- Comment #4 from Erike Magegere  ---
Created attachment 132736
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132736=edit
sheet added

just showing added sheet. right mouse the new sheet to get the delete sheet
command

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

--- Comment #3 from Erike Magegere  ---
Created attachment 132735
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132735=edit
after double click

this dialog must be used to get the error

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

--- Comment #2 from Erike Magegere  ---
Created attachment 132734
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132734=edit
initial spread sheetwith cursor placed where double click

This is a chopped spreadsheet. the sheet-add dialog must be activated by double
click in the sheet tab area. the sheet-add icon does not produce the error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107289] Conditional formatting breaks on adding then deleting a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107289

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Please attach a minimal sample file where to reproduce the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs